[03/16] ARM: dts: rockchip: Add usb host0 ohci node for rk3288

Message ID 20200720185120.671064-4-jagan@amarulasolutions.com
State New
Headers show
Series
  • board: Add new features for ROCKPi N8/N10
Related show

Commit Message

Jagan Teki July 20, 2020, 6:51 p.m. UTC
rk3288 and rk3288w have a usb host0 ohci controller.

Although rk3288 ohci doesn't actually work on hardware, but
rk3288w ohci can work well.

So add usb host0 ohci node in rk3288 dtsi and the quirk in
ohci platform driver will disable ohci on rk3288.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 arch/arm/dts/rk3288.dtsi | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Comments

Kever Yang July 21, 2020, 3:17 a.m. UTC | #1
HI Jagan,

     Does patch 3~6 also from mainline kernel?

Thanks,

- Kever

On 2020/7/21 上午2:51, Jagan Teki wrote:
> rk3288 and rk3288w have a usb host0 ohci controller.
>
> Although rk3288 ohci doesn't actually work on hardware, but
> rk3288w ohci can work well.
>
> So add usb host0 ohci node in rk3288 dtsi and the quirk in
> ohci platform driver will disable ohci on rk3288.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>   arch/arm/dts/rk3288.dtsi | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/rk3288.dtsi b/arch/arm/dts/rk3288.dtsi
> index 18b372db3a..22bb06cec5 100644
> --- a/arch/arm/dts/rk3288.dtsi
> +++ b/arch/arm/dts/rk3288.dtsi
> @@ -431,7 +431,16 @@
>   		status = "disabled";
>   	};
>   
> -	/* NOTE: ohci@ff520000 doesn't actually work on hardware */
> +	/* NOTE: doesn't work on RK3288, but fixed on RK3288W */
> +	usb_host0_ohci: usb@ff520000 {
> +		compatible = "generic-ohci";
> +		reg = <0x0 0xff520000 0x0 0x100>;
> +		interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cru HCLK_USBHOST0>;
> +		phys = <&usbphy1>;
> +		phy-names = "usb";
> +		status = "disabled";
> +	};
>   
>   	usb_host1: usb@ff540000 {
>   		compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",
Jagan Teki July 21, 2020, 6:26 a.m. UTC | #2
Hi Kever,

On Tue, Jul 21, 2020 at 8:48 AM Kever Yang <kever.yang@rock-chips.com> wrote:
>
> HI Jagan,
>
>      Does patch 3~6 also from mainline kernel?

Yes, in mailing lists.


>
> Thanks,
>
> - Kever
>
> On 2020/7/21 上午2:51, Jagan Teki wrote:
> > rk3288 and rk3288w have a usb host0 ohci controller.
> >
> > Although rk3288 ohci doesn't actually work on hardware, but
> > rk3288w ohci can work well.
> >
> > So add usb host0 ohci node in rk3288 dtsi and the quirk in
> > ohci platform driver will disable ohci on rk3288.
> >
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> >   arch/arm/dts/rk3288.dtsi | 11 ++++++++++-
> >   1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/dts/rk3288.dtsi b/arch/arm/dts/rk3288.dtsi
> > index 18b372db3a..22bb06cec5 100644
> > --- a/arch/arm/dts/rk3288.dtsi
> > +++ b/arch/arm/dts/rk3288.dtsi
> > @@ -431,7 +431,16 @@
> >               status = "disabled";
> >       };
> >
> > -     /* NOTE: ohci@ff520000 doesn't actually work on hardware */
> > +     /* NOTE: doesn't work on RK3288, but fixed on RK3288W */
> > +     usb_host0_ohci: usb@ff520000 {
> > +             compatible = "generic-ohci";
> > +             reg = <0x0 0xff520000 0x0 0x100>;
> > +             interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
> > +             clocks = <&cru HCLK_USBHOST0>;
> > +             phys = <&usbphy1>;
> > +             phy-names = "usb";
> > +             status = "disabled";
> > +     };
> >
> >       usb_host1: usb@ff540000 {
> >               compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",
>
>


--
Jagan Teki,
Amarula Solutions India Pvt. Ltd.
Co-Founder & Embedded Linux Architect
405/E-Block, Sri Lakshmi Shubham Arcade, Chandanagar, Hyderabad - 500050, India
M. (+91) 910 009 0959
[`as] http://www.amarulasolutions.com

Patch

diff --git a/arch/arm/dts/rk3288.dtsi b/arch/arm/dts/rk3288.dtsi
index 18b372db3a..22bb06cec5 100644
--- a/arch/arm/dts/rk3288.dtsi
+++ b/arch/arm/dts/rk3288.dtsi
@@ -431,7 +431,16 @@ 
 		status = "disabled";
 	};
 
-	/* NOTE: ohci@ff520000 doesn't actually work on hardware */
+	/* NOTE: doesn't work on RK3288, but fixed on RK3288W */
+	usb_host0_ohci: usb@ff520000 {
+		compatible = "generic-ohci";
+		reg = <0x0 0xff520000 0x0 0x100>;
+		interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&cru HCLK_USBHOST0>;
+		phys = <&usbphy1>;
+		phy-names = "usb";
+		status = "disabled";
+	};
 
 	usb_host1: usb@ff540000 {
 		compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",