[v2,3/9] ARM: stm32: Imply SPL_SPI_LOAD

Message ID 20210315173256.103731-4-jagan@amarulasolutions.com
State New
Headers show
Series
  • stm32: Add Engicam STM32MP1 SoM
Related show

Commit Message

Jagan Teki March 15, 2021, 5:32 p.m. UTC
SPI Load isn't mandatory for STM32 builds.

Let's imply instead of select it to get rid of build
issues for non-SPI defconfigs.

Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- collect Patrice r-b

 arch/arm/mach-stm32mp/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Patrick DELAUNAY March 16, 2021, 1:28 p.m. UTC | #1
On 3/15/21 6:32 PM, Jagan Teki wrote:
> SPI Load isn't mandatory for STM32 builds.
>
> Let's imply instead of select it to get rid of build
> issues for non-SPI defconfigs.
>
> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - collect Patrice r-b
>
>   arch/arm/mach-stm32mp/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-stm32mp/Kconfig b/arch/arm/mach-stm32mp/Kconfig
> index f538d7cb83..79ffd5191d 100644
> --- a/arch/arm/mach-stm32mp/Kconfig
> +++ b/arch/arm/mach-stm32mp/Kconfig
> @@ -16,13 +16,13 @@ config SPL
>   	select SPL_REGMAP
>   	select SPL_DM_RESET
>   	select SPL_SERIAL_SUPPORT
> -	select SPL_SPI_LOAD
>   	select SPL_SYSCON
>   	select SPL_WATCHDOG_SUPPORT if WATCHDOG
>   	imply BOOTSTAGE_STASH if SPL_BOOTSTAGE
>   	imply SPL_BOOTSTAGE if BOOTSTAGE
>   	imply SPL_DISPLAY_PRINT
>   	imply SPL_LIBDISK_SUPPORT
> +	imply SPL_SPI_LOAD

cosmetic: you can add dependency ?

	imply SPL_SPI_LOAD if SPL_SPI_SUPPORT

>   
>   config SYS_SOC
>   	default "stm32mp"


Anyway



Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick

Patch

diff --git a/arch/arm/mach-stm32mp/Kconfig b/arch/arm/mach-stm32mp/Kconfig
index f538d7cb83..79ffd5191d 100644
--- a/arch/arm/mach-stm32mp/Kconfig
+++ b/arch/arm/mach-stm32mp/Kconfig
@@ -16,13 +16,13 @@  config SPL
 	select SPL_REGMAP
 	select SPL_DM_RESET
 	select SPL_SERIAL_SUPPORT
-	select SPL_SPI_LOAD
 	select SPL_SYSCON
 	select SPL_WATCHDOG_SUPPORT if WATCHDOG
 	imply BOOTSTAGE_STASH if SPL_BOOTSTAGE
 	imply SPL_BOOTSTAGE if BOOTSTAGE
 	imply SPL_DISPLAY_PRINT
 	imply SPL_LIBDISK_SUPPORT
+	imply SPL_SPI_LOAD
 
 config SYS_SOC
 	default "stm32mp"