drm/panel: panel-simple: Fix proper bpc for AM-1280800N3TZQW-T00H
diff mbox series

Message ID 20211111094103.494831-1-jagan@amarulasolutions.com
State New
Headers show
Series
  • drm/panel: panel-simple: Fix proper bpc for AM-1280800N3TZQW-T00H
Related show

Commit Message

Jagan Teki Nov. 11, 2021, 9:41 a.m. UTC 
AM-1280800N3TZQW-T00H panel support 8 bpc not 6 bpc as per
recent testing in i.MX8MM platform.

Fix it.

Fixes: bca684e69c4c ("drm/panel: simple: Add AM-1280800N3TZQW-T00H")
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jagan Teki Dec. 19, 2021, 4:40 p.m. UTC | #1 
Hi Sam,

On Thu, Nov 11, 2021 at 3:11 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> AM-1280800N3TZQW-T00H panel support 8 bpc not 6 bpc as per
> recent testing in i.MX8MM platform.
>
> Fix it.
>
> Fixes: bca684e69c4c ("drm/panel: simple: Add AM-1280800N3TZQW-T00H")
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index eb475a3a774b..cf3f21f649cb 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -719,7 +719,7 @@ static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = {
>  static const struct panel_desc ampire_am_1280800n3tzqw_t00h = {
>         .modes = &ampire_am_1280800n3tzqw_t00h_mode,
>         .num_modes = 1,
> -       .bpc = 6,
> +       .bpc = 8,

Any response on this?

Thanks,
Jagan.
Sam Ravnborg Dec. 20, 2021, 8:15 a.m. UTC | #2 
Hi Jagan,

On Sun, Dec 19, 2021 at 10:10:10PM +0530, Jagan Teki wrote:
> Hi Sam,
> 
> On Thu, Nov 11, 2021 at 3:11 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > AM-1280800N3TZQW-T00H panel support 8 bpc not 6 bpc as per
> > recent testing in i.MX8MM platform.
> >
> > Fix it.
> >
> > Fixes: bca684e69c4c ("drm/panel: simple: Add AM-1280800N3TZQW-T00H")
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> >  drivers/gpu/drm/panel/panel-simple.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index eb475a3a774b..cf3f21f649cb 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -719,7 +719,7 @@ static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = {
> >  static const struct panel_desc ampire_am_1280800n3tzqw_t00h = {
> >         .modes = &ampire_am_1280800n3tzqw_t00h_mode,
> >         .num_modes = 1,
> > -       .bpc = 6,
> > +       .bpc = 8,
> 
> Any response on this?

I am too busy with other stuff at the moment to spend time on Linux
stuff, but expect to re-surface sometime after xmas.

	Sam
Jagan Teki Feb. 7, 2022, 1:04 p.m. UTC | #3 
Hi Sam,

On Mon, Dec 20, 2021 at 1:45 PM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Jagan,
>
> On Sun, Dec 19, 2021 at 10:10:10PM +0530, Jagan Teki wrote:
> > Hi Sam,
> >
> > On Thu, Nov 11, 2021 at 3:11 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> > >
> > > AM-1280800N3TZQW-T00H panel support 8 bpc not 6 bpc as per
> > > recent testing in i.MX8MM platform.
> > >
> > > Fix it.
> > >
> > > Fixes: bca684e69c4c ("drm/panel: simple: Add AM-1280800N3TZQW-T00H")
> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > ---
> > >  drivers/gpu/drm/panel/panel-simple.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > > index eb475a3a774b..cf3f21f649cb 100644
> > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > @@ -719,7 +719,7 @@ static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = {
> > >  static const struct panel_desc ampire_am_1280800n3tzqw_t00h = {
> > >         .modes = &ampire_am_1280800n3tzqw_t00h_mode,
> > >         .num_modes = 1,
> > > -       .bpc = 6,
> > > +       .bpc = 8,
> >
> > Any response on this?
>
> I am too busy with other stuff at the moment to spend time on Linux
> stuff, but expect to re-surface sometime after xmas.

Any further comments?

Thanks,
Jagan.
Jagan Teki Feb. 22, 2022, 6:47 a.m. UTC | #4 
On Mon, Feb 7, 2022 at 6:34 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> Hi Sam,
>
> On Mon, Dec 20, 2021 at 1:45 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > Hi Jagan,
> >
> > On Sun, Dec 19, 2021 at 10:10:10PM +0530, Jagan Teki wrote:
> > > Hi Sam,
> > >
> > > On Thu, Nov 11, 2021 at 3:11 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> > > >
> > > > AM-1280800N3TZQW-T00H panel support 8 bpc not 6 bpc as per
> > > > recent testing in i.MX8MM platform.
> > > >
> > > > Fix it.
> > > >
> > > > Fixes: bca684e69c4c ("drm/panel: simple: Add AM-1280800N3TZQW-T00H")
> > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > ---
> > > >  drivers/gpu/drm/panel/panel-simple.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > > > index eb475a3a774b..cf3f21f649cb 100644
> > > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > > @@ -719,7 +719,7 @@ static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = {
> > > >  static const struct panel_desc ampire_am_1280800n3tzqw_t00h = {
> > > >         .modes = &ampire_am_1280800n3tzqw_t00h_mode,
> > > >         .num_modes = 1,
> > > > -       .bpc = 6,
> > > > +       .bpc = 8,
> > >
> > > Any response on this?
> >
> > I am too busy with other stuff at the moment to spend time on Linux
> > stuff, but expect to re-surface sometime after xmas.
>
> Any further comments?

Gentle Ping.
Jagan Teki March 31, 2022, 2:50 p.m. UTC | #5 
+ Robert

On Tue, Feb 22, 2022 at 12:17 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Mon, Feb 7, 2022 at 6:34 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > Hi Sam,
> >
> > On Mon, Dec 20, 2021 at 1:45 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> > >
> > > Hi Jagan,
> > >
> > > On Sun, Dec 19, 2021 at 10:10:10PM +0530, Jagan Teki wrote:
> > > > Hi Sam,
> > > >
> > > > On Thu, Nov 11, 2021 at 3:11 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> > > > >
> > > > > AM-1280800N3TZQW-T00H panel support 8 bpc not 6 bpc as per
> > > > > recent testing in i.MX8MM platform.
> > > > >
> > > > > Fix it.
> > > > >
> > > > > Fixes: bca684e69c4c ("drm/panel: simple: Add AM-1280800N3TZQW-T00H")
> > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > ---
> > > > >  drivers/gpu/drm/panel/panel-simple.c | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > > > > index eb475a3a774b..cf3f21f649cb 100644
> > > > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > > > @@ -719,7 +719,7 @@ static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = {
> > > > >  static const struct panel_desc ampire_am_1280800n3tzqw_t00h = {
> > > > >         .modes = &ampire_am_1280800n3tzqw_t00h_mode,
> > > > >         .num_modes = 1,
> > > > > -       .bpc = 6,
> > > > > +       .bpc = 8,
> > > >
> > > > Any response on this?
> > >
> > > I am too busy with other stuff at the moment to spend time on Linux
> > > stuff, but expect to re-surface sometime after xmas.
> >
> > Any further comments?
>
> Gentle Ping.
Robert Foss March 31, 2022, 2:52 p.m. UTC | #6 
On Thu, 31 Mar 2022 at 16:50, Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> + Robert
>
> On Tue, Feb 22, 2022 at 12:17 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > On Mon, Feb 7, 2022 at 6:34 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> > >
> > > Hi Sam,
> > >
> > > On Mon, Dec 20, 2021 at 1:45 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> > > >
> > > > Hi Jagan,
> > > >
> > > > On Sun, Dec 19, 2021 at 10:10:10PM +0530, Jagan Teki wrote:
> > > > > Hi Sam,
> > > > >
> > > > > On Thu, Nov 11, 2021 at 3:11 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> > > > > >
> > > > > > AM-1280800N3TZQW-T00H panel support 8 bpc not 6 bpc as per
> > > > > > recent testing in i.MX8MM platform.
> > > > > >
> > > > > > Fix it.
> > > > > >
> > > > > > Fixes: bca684e69c4c ("drm/panel: simple: Add AM-1280800N3TZQW-T00H")
> > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > ---
> > > > > >  drivers/gpu/drm/panel/panel-simple.c | 2 +-
> > > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > >
> > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > > > > > index eb475a3a774b..cf3f21f649cb 100644
> > > > > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > > > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > > > > @@ -719,7 +719,7 @@ static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = {
> > > > > >  static const struct panel_desc ampire_am_1280800n3tzqw_t00h = {
> > > > > >         .modes = &ampire_am_1280800n3tzqw_t00h_mode,
> > > > > >         .num_modes = 1,
> > > > > > -       .bpc = 6,
> > > > > > +       .bpc = 8,
> > > > >
> > > > > Any response on this?

Reviewed-by: Robert Foss <robert.foss@linaro.org>
Jagan Teki April 29, 2022, 9:49 a.m. UTC | #7 
Hi Robert,

Can you apply this?

On Thu, Mar 31, 2022 at 8:22 PM Robert Foss <robert.foss@linaro.org> wrote:
>
> On Thu, 31 Mar 2022 at 16:50, Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > + Robert
> >
> > On Tue, Feb 22, 2022 at 12:17 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> > >
> > > On Mon, Feb 7, 2022 at 6:34 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> > > >
> > > > Hi Sam,
> > > >
> > > > On Mon, Dec 20, 2021 at 1:45 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> > > > >
> > > > > Hi Jagan,
> > > > >
> > > > > On Sun, Dec 19, 2021 at 10:10:10PM +0530, Jagan Teki wrote:
> > > > > > Hi Sam,
> > > > > >
> > > > > > On Thu, Nov 11, 2021 at 3:11 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> > > > > > >
> > > > > > > AM-1280800N3TZQW-T00H panel support 8 bpc not 6 bpc as per
> > > > > > > recent testing in i.MX8MM platform.
> > > > > > >
> > > > > > > Fix it.
> > > > > > >
> > > > > > > Fixes: bca684e69c4c ("drm/panel: simple: Add AM-1280800N3TZQW-T00H")
> > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > > ---
> > > > > > >  drivers/gpu/drm/panel/panel-simple.c | 2 +-
> > > > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > > >
> > > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > > > > > > index eb475a3a774b..cf3f21f649cb 100644
> > > > > > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > > > > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > > > > > @@ -719,7 +719,7 @@ static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = {
> > > > > > >  static const struct panel_desc ampire_am_1280800n3tzqw_t00h = {
> > > > > > >         .modes = &ampire_am_1280800n3tzqw_t00h_mode,
> > > > > > >         .num_modes = 1,
> > > > > > > -       .bpc = 6,
> > > > > > > +       .bpc = 8,
> > > > > >
> > > > > > Any response on this?
>
> Reviewed-by: Robert Foss <robert.foss@linaro.org>
Robert Foss May 2, 2022, 2:30 p.m. UTC | #8 
On Fri, 29 Apr 2022 at 11:49, Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> Hi Robert,
>
> Can you apply this?
>

Thanks for the reminder.

Applied to drm-misc-next.

> On Thu, Mar 31, 2022 at 8:22 PM Robert Foss <robert.foss@linaro.org> wrote:
> >
> > On Thu, 31 Mar 2022 at 16:50, Jagan Teki <jagan@amarulasolutions.com> wrote:
> > >
> > > + Robert
> > >
> > > On Tue, Feb 22, 2022 at 12:17 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> > > >
> > > > On Mon, Feb 7, 2022 at 6:34 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> > > > >
> > > > > Hi Sam,
> > > > >
> > > > > On Mon, Dec 20, 2021 at 1:45 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> > > > > >
> > > > > > Hi Jagan,
> > > > > >
> > > > > > On Sun, Dec 19, 2021 at 10:10:10PM +0530, Jagan Teki wrote:
> > > > > > > Hi Sam,
> > > > > > >
> > > > > > > On Thu, Nov 11, 2021 at 3:11 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> > > > > > > >
> > > > > > > > AM-1280800N3TZQW-T00H panel support 8 bpc not 6 bpc as per
> > > > > > > > recent testing in i.MX8MM platform.
> > > > > > > >
> > > > > > > > Fix it.
> > > > > > > >
> > > > > > > > Fixes: bca684e69c4c ("drm/panel: simple: Add AM-1280800N3TZQW-T00H")
> > > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > > > ---
> > > > > > > >  drivers/gpu/drm/panel/panel-simple.c | 2 +-
> > > > > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > > > >
> > > > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > > > > > > > index eb475a3a774b..cf3f21f649cb 100644
> > > > > > > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > > > > > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > > > > > > @@ -719,7 +719,7 @@ static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = {
> > > > > > > >  static const struct panel_desc ampire_am_1280800n3tzqw_t00h = {
> > > > > > > >         .modes = &ampire_am_1280800n3tzqw_t00h_mode,
> > > > > > > >         .num_modes = 1,
> > > > > > > > -       .bpc = 6,
> > > > > > > > +       .bpc = 8,
> > > > > > >
> > > > > > > Any response on this?
> >
> > Reviewed-by: Robert Foss <robert.foss@linaro.org>
>
>
>
> --
> Jagan Teki,
> Amarula Solutions India Pvt. Ltd.
> Co-Founder & Embedded Linux Architect
> 405/E-Block, Sri Lakshmi Shubham Arcade, Chandanagar, Hyderabad - 500050, India
> M. (+91) 910 009 0959
> [`as] http://www.amarulasolutions.com

Patch
diff mbox series 

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index eb475a3a774b..cf3f21f649cb 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -719,7 +719,7 @@  static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = {
 static const struct panel_desc ampire_am_1280800n3tzqw_t00h = {
 	.modes = &ampire_am_1280800n3tzqw_t00h_mode,
 	.num_modes = 1,
-	.bpc = 6,
+	.bpc = 8,
 	.size = {
 		.width = 217,
 		.height = 136,