| Message ID | 20220418144907.327511-1-abbaraju.manojsai@amarulasolutions.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
On 18/04/2022 16:49, Manoj Sai wrote: > i.Core MX8M Plus is an EDIMM SoM based on NXP i.MX8M Plus from Engicam. > > EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive Evaluation > Board from Engicam. > > i.Core MX8M Plus needs to mount on top of this Evaluation board for > creating complete i.Core MX8M Plus EDIMM2.2 Starter Kit. > > Add bindings for it. > > Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com> > Reviewed-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Changes for v2 : > -added the device binding of imx8mp as per soc order. > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index b6cc34115362..3bdc490cfbe2 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -936,6 +936,13 @@ properties: > - const: toradex,verdin-imx8mp # Verdin iMX8M Plus Module > - const: fsl,imx8mp > > + - description: Engicam i.Core MX8M Plus SoM based boards Still not matching the existing convention in that file. :( This should be just before PHYTEC. Best regards, Krzysztof
Hi Krzysztof , Thanks for the review . Had u checked the Patch v2 2/3 , Patch v2 3/3 , is the changes made are fine ? . if there are any changes required , kindly please suggest . Thanks & Regards A.Manoj sai On Mon, Apr 18, 2022 at 8:23 PM Krzysztof Kozlowski < krzysztof.kozlowski@linaro.org> wrote: > On 18/04/2022 16:49, Manoj Sai wrote: > > i.Core MX8M Plus is an EDIMM SoM based on NXP i.MX8M Plus from Engicam. > > > > EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive Evaluation > > Board from Engicam. > > > > i.Core MX8M Plus needs to mount on top of this Evaluation board for > > creating complete i.Core MX8M Plus EDIMM2.2 Starter Kit. > > > > Add bindings for it. > > > > Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com> > > Reviewed-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > Changes for v2 : > > -added the device binding of imx8mp as per soc order. > > --- > > Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > b/Documentation/devicetree/bindings/arm/fsl.yaml > > index b6cc34115362..3bdc490cfbe2 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -936,6 +936,13 @@ properties: > > - const: toradex,verdin-imx8mp # Verdin iMX8M Plus > Module > > - const: fsl,imx8mp > > > > + - description: Engicam i.Core MX8M Plus SoM based boards > > Still not matching the existing convention in that file. :( > > This should be just before PHYTEC. > > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index b6cc34115362..3bdc490cfbe2 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -936,6 +936,13 @@ properties: - const: toradex,verdin-imx8mp # Verdin iMX8M Plus Module - const: fsl,imx8mp + - description: Engicam i.Core MX8M Plus SoM based boards + items: + - enum: + - engicam,icore-mx8mp-edimm2.2 # i.MX8MP Engicam i.Core MX8M Plus EDIMM2.2 Starter Kit + - const: engicam,icore-mx8mp # i.MX8MP Engicam i.Core MX8M Plus SoM + - const: fsl,imx8mp + - description: i.MX8MQ based Boards items: - enum: