[v2,1/4] rockchip: Add support to generate GZIP compressed U-boot binary
diff mbox series

Message ID 20230725035101.281325-2-abbaraju.manojsai@amarulasolutions.com
State New
Headers show
Series
  • support for booting the compressed U-boot binary on Rockchip based ARM64 SOC's
Related show

Commit Message

Manoj Sai July 25, 2023, 3:50 a.m. UTC 
Add support for generating a GZIP-compressed U-boot binary with the
help of binman, if CONFIG_SPL_GZIP is selected.

Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
---
 arch/arm/dts/rockchip-u-boot.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Simon Glass July 27, 2023, 12:53 a.m. UTC | #1 
On Mon, 24 Jul 2023 at 21:51, Manoj Sai
<abbaraju.manojsai@amarulasolutions.com> wrote:
>
> Add support for generating a GZIP-compressed U-boot binary with the
> help of binman, if CONFIG_SPL_GZIP is selected.
>
> Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
> ---
>  arch/arm/dts/rockchip-u-boot.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
Kever Yang July 28, 2023, 10:09 a.m. UTC | #2 
On 2023/7/25 11:50, Manoj Sai wrote:
> Add support for generating a GZIP-compressed U-boot binary with the
> help of binman, if CONFIG_SPL_GZIP is selected.
>
> Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/dts/rockchip-u-boot.dtsi | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/dts/rockchip-u-boot.dtsi b/arch/arm/dts/rockchip-u-boot.dtsi
> index 2878b80926..524d638e5b 100644
> --- a/arch/arm/dts/rockchip-u-boot.dtsi
> +++ b/arch/arm/dts/rockchip-u-boot.dtsi
> @@ -48,10 +48,17 @@
>   					type = "standalone";
>   					os = "U-Boot";
>   					arch = "arm64";
> +#if defined(CONFIG_SPL_GZIP)
> +					compression = "gzip";
> +#else
>   					compression = "none";
> +#endif
>   					load = <CONFIG_TEXT_BASE>;
>   					entry = <CONFIG_TEXT_BASE>;
>   					u-boot-nodtb {
> +#if defined(CONFIG_SPL_GZIP)
> +						compress = "gzip";
> +#endif
>   					};
>   #ifdef CONFIG_SPL_FIT_SIGNATURE
>   					hash {
Kever Yang Aug. 12, 2023, 3:03 a.m. UTC | #3 
Hi Manoj,

     This patch need rebase, and could you please address the comment 
from Jonas in new version is possible.


Thanks,

- Kever

On 2023/7/25 11:50, Manoj Sai wrote:
> Add support for generating a GZIP-compressed U-boot binary with the
> help of binman, if CONFIG_SPL_GZIP is selected.
>
> Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
> ---
>   arch/arm/dts/rockchip-u-boot.dtsi | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/dts/rockchip-u-boot.dtsi b/arch/arm/dts/rockchip-u-boot.dtsi
> index 2878b80926..524d638e5b 100644
> --- a/arch/arm/dts/rockchip-u-boot.dtsi
> +++ b/arch/arm/dts/rockchip-u-boot.dtsi
> @@ -48,10 +48,17 @@
>   					type = "standalone";
>   					os = "U-Boot";
>   					arch = "arm64";
> +#if defined(CONFIG_SPL_GZIP)
> +					compression = "gzip";
> +#else
>   					compression = "none";
> +#endif
>   					load = <CONFIG_TEXT_BASE>;
>   					entry = <CONFIG_TEXT_BASE>;
>   					u-boot-nodtb {
> +#if defined(CONFIG_SPL_GZIP)
> +						compress = "gzip";
> +#endif
>   					};
>   #ifdef CONFIG_SPL_FIT_SIGNATURE
>   					hash {

Patch
diff mbox series 

diff --git a/arch/arm/dts/rockchip-u-boot.dtsi b/arch/arm/dts/rockchip-u-boot.dtsi
index 2878b80926..524d638e5b 100644
--- a/arch/arm/dts/rockchip-u-boot.dtsi
+++ b/arch/arm/dts/rockchip-u-boot.dtsi
@@ -48,10 +48,17 @@ 
 					type = "standalone";
 					os = "U-Boot";
 					arch = "arm64";
+#if defined(CONFIG_SPL_GZIP)
+					compression = "gzip";
+#else
 					compression = "none";
+#endif
 					load = <CONFIG_TEXT_BASE>;
 					entry = <CONFIG_TEXT_BASE>;
 					u-boot-nodtb {
+#if defined(CONFIG_SPL_GZIP)
+						compress = "gzip";
+#endif
 					};
 #ifdef CONFIG_SPL_FIT_SIGNATURE
 					hash {