| Message ID | 20190428204801.9578-5-jagan@amarulasolutions.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
On 4/28/19 10:47 PM, Jagan Teki wrote: > Mark MXS_SPI has BROKEN, this so the resulting build shows > warning for broken configuration enabled and associated code > will remove in v2019.07 release. But the code is not broken, it works fine, right ? > Cc: Marek Vasut <marex@denx.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Michael Trimarchi <michael@amarulasolutions.com> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > drivers/spi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index e196f64e2f..393382fee2 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -377,6 +377,7 @@ config MXC_SPI > > config MXS_SPI > bool "MXS SPI Driver" > + select BROKEN > help > Enable the MXS SPI controller driver. This driver can be used > on the i.MX23 and i.MX28 SoCs. >
On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: > > On 4/28/19 10:47 PM, Jagan Teki wrote: > > Mark MXS_SPI has BROKEN, this so the resulting build shows > > warning for broken configuration enabled and associated code > > will remove in v2019.07 release. > > But the code is not broken, it works fine, right ? Yes the code work fine, but dm conversion not done yet. Now the CONFIG_BROKEN can mark the driver configs which doesn't convert dm yet, so the associated code will drop wrt MIGRATION deadline (similar like what we showed on the Makefile before). It is something like caution, before dropping it as suggested Tom.
On 4/29/19 12:40 PM, Jagan Teki wrote: > On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: >> >> On 4/28/19 10:47 PM, Jagan Teki wrote: >>> Mark MXS_SPI has BROKEN, this so the resulting build shows >>> warning for broken configuration enabled and associated code >>> will remove in v2019.07 release. >> >> But the code is not broken, it works fine, right ? > > Yes the code work fine, but dm conversion not done yet. Now the > CONFIG_BROKEN can mark the driver configs which doesn't convert dm That makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack. > yet, so the associated code will drop wrt MIGRATION deadline (similar > like what we showed on the Makefile before). > > It is something like caution, before dropping it as suggested Tom. >
On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex@denx.de> wrote: > > On 4/29/19 12:40 PM, Jagan Teki wrote: > > On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: > >> > >> On 4/28/19 10:47 PM, Jagan Teki wrote: > >>> Mark MXS_SPI has BROKEN, this so the resulting build shows > >>> warning for broken configuration enabled and associated code > >>> will remove in v2019.07 release. > >> > >> But the code is not broken, it works fine, right ? > > > > Yes the code work fine, but dm conversion not done yet. Now the > > CONFIG_BROKEN can mark the driver configs which doesn't convert dm > > That makes no sense, if the code works, it works and thus it is NOT > broken. Find some other way to flag it as non-DM-converted, not this hack. np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
On 4/29/19 1:02 PM, Jagan Teki wrote: > On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex@denx.de> wrote: >> >> On 4/29/19 12:40 PM, Jagan Teki wrote: >>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: >>>> >>>> On 4/28/19 10:47 PM, Jagan Teki wrote: >>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows >>>>> warning for broken configuration enabled and associated code >>>>> will remove in v2019.07 release. >>>> >>>> But the code is not broken, it works fine, right ? >>> >>> Yes the code work fine, but dm conversion not done yet. Now the >>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm >> >> That makes no sense, if the code works, it works and thus it is NOT >> broken. Find some other way to flag it as non-DM-converted, not this hack. > > np, It depends on whether we consider non-dm code(for legacy SPI > drivers) is broken or not, let Tom comment on this. Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload CONFIG_BROKEN for such things. The Makefile warning seems sufficient to me.
On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote: > On 4/29/19 1:02 PM, Jagan Teki wrote: > > On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex@denx.de> wrote: > >> > >> On 4/29/19 12:40 PM, Jagan Teki wrote: > >>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: > >>>> > >>>> On 4/28/19 10:47 PM, Jagan Teki wrote: > >>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows > >>>>> warning for broken configuration enabled and associated code > >>>>> will remove in v2019.07 release. > >>>> > >>>> But the code is not broken, it works fine, right ? > >>> > >>> Yes the code work fine, but dm conversion not done yet. Now the > >>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm > >> > >> That makes no sense, if the code works, it works and thus it is NOT > >> broken. Find some other way to flag it as non-DM-converted, not this hack. > > > > np, It depends on whether we consider non-dm code(for legacy SPI > > drivers) is broken or not, let Tom comment on this. > > Again, the code works, it's not broken. That's very clear. > DM conversion is a separate matter, so let's not overload CONFIG_BROKEN > for such things. The Makefile warning seems sufficient to me. The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN. The Makefile warnings tell people the code is going to be removed and I'm trying to have the window be: 1) LOUD warning about needing work 2) 1 release past those loud deadlines of the code there, but not built unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken) 3) Code removed. All that said, I continue to be open to delaying conversion / removal if we're having: - A discussion and proposed patches to do the conversion, but people need more time. The work is in progress, but people need time as it's not as easy to convert as hoped for various reasons. - A problem converting the driver to DM as it's highlighting some other problem within DM or hitting a size constraint or other problem. - Someone who is willing to do the DM work is just now seeing this. Yes, this is possible especially since our LOUD Makefile warnings are also easy enough to miss if you're just automating the build and not doing it manually. But I am not fine with: - Code that isn't converted AND - Code that no one seems to be converting AND - Code that no one says they are going to convert AND - The conversion deadline has past.
On 4/29/19 1:24 PM, Tom Rini wrote: > On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote: >> On 4/29/19 1:02 PM, Jagan Teki wrote: >>> On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex@denx.de> wrote: >>>> >>>> On 4/29/19 12:40 PM, Jagan Teki wrote: >>>>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: >>>>>> >>>>>> On 4/28/19 10:47 PM, Jagan Teki wrote: >>>>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows >>>>>>> warning for broken configuration enabled and associated code >>>>>>> will remove in v2019.07 release. >>>>>> >>>>>> But the code is not broken, it works fine, right ? >>>>> >>>>> Yes the code work fine, but dm conversion not done yet. Now the >>>>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm >>>> >>>> That makes no sense, if the code works, it works and thus it is NOT >>>> broken. Find some other way to flag it as non-DM-converted, not this hack. >>> >>> np, It depends on whether we consider non-dm code(for legacy SPI >>> drivers) is broken or not, let Tom comment on this. >> >> Again, the code works, it's not broken. That's very clear. >> DM conversion is a separate matter, so let's not overload CONFIG_BROKEN >> for such things. The Makefile warning seems sufficient to me. > > The code is broken because it doesn't work with DM and is going to be > removed due to lack of maintenance soon. My problem with this series, > but I need to check that we can do what I want to do and still keep > travis green, is have this (and the other non-converted and thus > non-maintained drivers) depend on, not select BROKEN. > > The Makefile warnings tell people the code is going to be removed and > I'm trying to have the window be: > 1) LOUD warning about needing work > 2) 1 release past those loud deadlines of the code there, but not built > unless you enable BROKEN (as yes, I see code that's not updated to use > DM as being broken) > 3) Code removed. > > All that said, I continue to be open to delaying conversion / removal if > we're having: > - A discussion and proposed patches to do the conversion, but people > need more time. The work is in progress, but people need time as it's > not as easy to convert as hoped for various reasons. > - A problem converting the driver to DM as it's highlighting some other > problem within DM or hitting a size constraint or other problem. > - Someone who is willing to do the DM work is just now seeing this. > Yes, this is possible especially since our LOUD Makefile warnings are > also easy enough to miss if you're just automating the build and not > doing it manually. > > But I am not fine with: > - Code that isn't converted AND > - Code that no one seems to be converting AND > - Code that no one says they are going to convert AND > - The conversion deadline has past. Seems there was some offer from Amarula to convert it , no ?
Hi Marek On Mon, Apr 29, 2019 at 1:27 PM Marek Vasut <marex@denx.de> wrote: > > On 4/29/19 1:24 PM, Tom Rini wrote: > > On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote: > >> On 4/29/19 1:02 PM, Jagan Teki wrote: > >>> On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex@denx.de> wrote: > >>>> > >>>> On 4/29/19 12:40 PM, Jagan Teki wrote: > >>>>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: > >>>>>> > >>>>>> On 4/28/19 10:47 PM, Jagan Teki wrote: > >>>>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows > >>>>>>> warning for broken configuration enabled and associated code > >>>>>>> will remove in v2019.07 release. > >>>>>> > >>>>>> But the code is not broken, it works fine, right ? > >>>>> > >>>>> Yes the code work fine, but dm conversion not done yet. Now the > >>>>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm > >>>> > >>>> That makes no sense, if the code works, it works and thus it is NOT > >>>> broken. Find some other way to flag it as non-DM-converted, not this hack. > >>> > >>> np, It depends on whether we consider non-dm code(for legacy SPI > >>> drivers) is broken or not, let Tom comment on this. > >> > >> Again, the code works, it's not broken. That's very clear. > >> DM conversion is a separate matter, so let's not overload CONFIG_BROKEN > >> for such things. The Makefile warning seems sufficient to me. > > > > The code is broken because it doesn't work with DM and is going to be > > removed due to lack of maintenance soon. My problem with this series, > > but I need to check that we can do what I want to do and still keep > > travis green, is have this (and the other non-converted and thus > > non-maintained drivers) depend on, not select BROKEN. > > > > The Makefile warnings tell people the code is going to be removed and > > I'm trying to have the window be: > > 1) LOUD warning about needing work > > 2) 1 release past those loud deadlines of the code there, but not built > > unless you enable BROKEN (as yes, I see code that's not updated to use > > DM as being broken) > > 3) Code removed. > > > > All that said, I continue to be open to delaying conversion / removal if > > we're having: > > - A discussion and proposed patches to do the conversion, but people > > need more time. The work is in progress, but people need time as it's > > not as easy to convert as hoped for various reasons. > > - A problem converting the driver to DM as it's highlighting some other > > problem within DM or hitting a size constraint or other problem. > > - Someone who is willing to do the DM work is just now seeing this. > > Yes, this is possible especially since our LOUD Makefile warnings are > > also easy enough to miss if you're just automating the build and not > > doing it manually. > > > > But I am not fine with: > > - Code that isn't converted AND > > - Code that no one seems to be converting AND > > - Code that no one says they are going to convert AND > > - The conversion deadline has past. > > Seems there was some offer from Amarula to convert it , no ? > we can do some job on imx28 because we have a board there. I have asked to mainline it Michael > -- > Best regards, > Marek Vasut
On Mon, Apr 29, 2019 at 02:34:32PM +0200, Michael Nazzareno Trimarchi wrote: > Hi Marek > > On Mon, Apr 29, 2019 at 1:27 PM Marek Vasut <marex@denx.de> wrote: > > > > On 4/29/19 1:24 PM, Tom Rini wrote: > > > On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote: > > >> On 4/29/19 1:02 PM, Jagan Teki wrote: > > >>> On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex@denx.de> wrote: > > >>>> > > >>>> On 4/29/19 12:40 PM, Jagan Teki wrote: > > >>>>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: > > >>>>>> > > >>>>>> On 4/28/19 10:47 PM, Jagan Teki wrote: > > >>>>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows > > >>>>>>> warning for broken configuration enabled and associated code > > >>>>>>> will remove in v2019.07 release. > > >>>>>> > > >>>>>> But the code is not broken, it works fine, right ? > > >>>>> > > >>>>> Yes the code work fine, but dm conversion not done yet. Now the > > >>>>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm > > >>>> > > >>>> That makes no sense, if the code works, it works and thus it is NOT > > >>>> broken. Find some other way to flag it as non-DM-converted, not this hack. > > >>> > > >>> np, It depends on whether we consider non-dm code(for legacy SPI > > >>> drivers) is broken or not, let Tom comment on this. > > >> > > >> Again, the code works, it's not broken. That's very clear. > > >> DM conversion is a separate matter, so let's not overload CONFIG_BROKEN > > >> for such things. The Makefile warning seems sufficient to me. > > > > > > The code is broken because it doesn't work with DM and is going to be > > > removed due to lack of maintenance soon. My problem with this series, > > > but I need to check that we can do what I want to do and still keep > > > travis green, is have this (and the other non-converted and thus > > > non-maintained drivers) depend on, not select BROKEN. > > > > > > The Makefile warnings tell people the code is going to be removed and > > > I'm trying to have the window be: > > > 1) LOUD warning about needing work > > > 2) 1 release past those loud deadlines of the code there, but not built > > > unless you enable BROKEN (as yes, I see code that's not updated to use > > > DM as being broken) > > > 3) Code removed. > > > > > > All that said, I continue to be open to delaying conversion / removal if > > > we're having: > > > - A discussion and proposed patches to do the conversion, but people > > > need more time. The work is in progress, but people need time as it's > > > not as easy to convert as hoped for various reasons. > > > - A problem converting the driver to DM as it's highlighting some other > > > problem within DM or hitting a size constraint or other problem. > > > - Someone who is willing to do the DM work is just now seeing this. > > > Yes, this is possible especially since our LOUD Makefile warnings are > > > also easy enough to miss if you're just automating the build and not > > > doing it manually. > > > > > > But I am not fine with: > > > - Code that isn't converted AND > > > - Code that no one seems to be converting AND > > > - Code that no one says they are going to convert AND > > > - The conversion deadline has past. > > > > Seems there was some offer from Amarula to convert it , no ? > > we can do some job on imx28 because we have a board there. I have asked > to mainline it OK, good. Can you and Marek please coordinate on: - Updating MAINTAINERS files - Dropping the boards that won't be supported moving forward (even if you can't mainline the custom board, there must be a ref platform you have/use, yes?). And Michael, can you please subscribe to the u-boot-maintainers list? Jagan, was there an old patch to try and convert this driver that may be of help to Michael? Thanks!
On 4/29/19 2:47 PM, Tom Rini wrote: > On Mon, Apr 29, 2019 at 02:34:32PM +0200, Michael Nazzareno Trimarchi wrote: >> Hi Marek >> >> On Mon, Apr 29, 2019 at 1:27 PM Marek Vasut <marex@denx.de> wrote: >>> >>> On 4/29/19 1:24 PM, Tom Rini wrote: >>>> On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote: >>>>> On 4/29/19 1:02 PM, Jagan Teki wrote: >>>>>> On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex@denx.de> wrote: >>>>>>> >>>>>>> On 4/29/19 12:40 PM, Jagan Teki wrote: >>>>>>>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: >>>>>>>>> >>>>>>>>> On 4/28/19 10:47 PM, Jagan Teki wrote: >>>>>>>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows >>>>>>>>>> warning for broken configuration enabled and associated code >>>>>>>>>> will remove in v2019.07 release. >>>>>>>>> >>>>>>>>> But the code is not broken, it works fine, right ? >>>>>>>> >>>>>>>> Yes the code work fine, but dm conversion not done yet. Now the >>>>>>>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm >>>>>>> >>>>>>> That makes no sense, if the code works, it works and thus it is NOT >>>>>>> broken. Find some other way to flag it as non-DM-converted, not this hack. >>>>>> >>>>>> np, It depends on whether we consider non-dm code(for legacy SPI >>>>>> drivers) is broken or not, let Tom comment on this. >>>>> >>>>> Again, the code works, it's not broken. That's very clear. >>>>> DM conversion is a separate matter, so let's not overload CONFIG_BROKEN >>>>> for such things. The Makefile warning seems sufficient to me. >>>> >>>> The code is broken because it doesn't work with DM and is going to be >>>> removed due to lack of maintenance soon. My problem with this series, >>>> but I need to check that we can do what I want to do and still keep >>>> travis green, is have this (and the other non-converted and thus >>>> non-maintained drivers) depend on, not select BROKEN. >>>> >>>> The Makefile warnings tell people the code is going to be removed and >>>> I'm trying to have the window be: >>>> 1) LOUD warning about needing work >>>> 2) 1 release past those loud deadlines of the code there, but not built >>>> unless you enable BROKEN (as yes, I see code that's not updated to use >>>> DM as being broken) >>>> 3) Code removed. >>>> >>>> All that said, I continue to be open to delaying conversion / removal if >>>> we're having: >>>> - A discussion and proposed patches to do the conversion, but people >>>> need more time. The work is in progress, but people need time as it's >>>> not as easy to convert as hoped for various reasons. >>>> - A problem converting the driver to DM as it's highlighting some other >>>> problem within DM or hitting a size constraint or other problem. >>>> - Someone who is willing to do the DM work is just now seeing this. >>>> Yes, this is possible especially since our LOUD Makefile warnings are >>>> also easy enough to miss if you're just automating the build and not >>>> doing it manually. >>>> >>>> But I am not fine with: >>>> - Code that isn't converted AND >>>> - Code that no one seems to be converting AND >>>> - Code that no one says they are going to convert AND >>>> - The conversion deadline has past. >>> >>> Seems there was some offer from Amarula to convert it , no ? >> >> we can do some job on imx28 because we have a board there. I have asked >> to mainline it > > OK, good. Can you and Marek please coordinate on: > - Updating MAINTAINERS files > - Dropping the boards that won't be supported moving forward (even if > you can't mainline the custom board, there must be a ref platform you > have/use, yes?). Might make sense to keep the MX28EVK, I'll ask about the other boards, but I think they could be dropped. > And Michael, can you please subscribe to the u-boot-maintainers list? > > Jagan, was there an old patch to try and convert this driver that may be > of help to Michael? Thanks! >
+ Akash On Mon, Apr 29, 2019 at 6:17 PM Tom Rini <trini@konsulko.com> wrote: > > On Mon, Apr 29, 2019 at 02:34:32PM +0200, Michael Nazzareno Trimarchi wrote: > > Hi Marek > > > > On Mon, Apr 29, 2019 at 1:27 PM Marek Vasut <marex@denx.de> wrote: > > > > > > On 4/29/19 1:24 PM, Tom Rini wrote: > > > > On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote: > > > >> On 4/29/19 1:02 PM, Jagan Teki wrote: > > > >>> On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex@denx.de> wrote: > > > >>>> > > > >>>> On 4/29/19 12:40 PM, Jagan Teki wrote: > > > >>>>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: > > > >>>>>> > > > >>>>>> On 4/28/19 10:47 PM, Jagan Teki wrote: > > > >>>>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows > > > >>>>>>> warning for broken configuration enabled and associated code > > > >>>>>>> will remove in v2019.07 release. > > > >>>>>> > > > >>>>>> But the code is not broken, it works fine, right ? > > > >>>>> > > > >>>>> Yes the code work fine, but dm conversion not done yet. Now the > > > >>>>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm > > > >>>> > > > >>>> That makes no sense, if the code works, it works and thus it is NOT > > > >>>> broken. Find some other way to flag it as non-DM-converted, not this hack. > > > >>> > > > >>> np, It depends on whether we consider non-dm code(for legacy SPI > > > >>> drivers) is broken or not, let Tom comment on this. > > > >> > > > >> Again, the code works, it's not broken. That's very clear. > > > >> DM conversion is a separate matter, so let's not overload CONFIG_BROKEN > > > >> for such things. The Makefile warning seems sufficient to me. > > > > > > > > The code is broken because it doesn't work with DM and is going to be > > > > removed due to lack of maintenance soon. My problem with this series, > > > > but I need to check that we can do what I want to do and still keep > > > > travis green, is have this (and the other non-converted and thus > > > > non-maintained drivers) depend on, not select BROKEN. > > > > > > > > The Makefile warnings tell people the code is going to be removed and > > > > I'm trying to have the window be: > > > > 1) LOUD warning about needing work > > > > 2) 1 release past those loud deadlines of the code there, but not built > > > > unless you enable BROKEN (as yes, I see code that's not updated to use > > > > DM as being broken) > > > > 3) Code removed. > > > > > > > > All that said, I continue to be open to delaying conversion / removal if > > > > we're having: > > > > - A discussion and proposed patches to do the conversion, but people > > > > need more time. The work is in progress, but people need time as it's > > > > not as easy to convert as hoped for various reasons. > > > > - A problem converting the driver to DM as it's highlighting some other > > > > problem within DM or hitting a size constraint or other problem. > > > > - Someone who is willing to do the DM work is just now seeing this. > > > > Yes, this is possible especially since our LOUD Makefile warnings are > > > > also easy enough to miss if you're just automating the build and not > > > > doing it manually. > > > > > > > > But I am not fine with: > > > > - Code that isn't converted AND > > > > - Code that no one seems to be converting AND > > > > - Code that no one says they are going to convert AND > > > > - The conversion deadline has past. > > > > > > Seems there was some offer from Amarula to convert it , no ? > > > > we can do some job on imx28 because we have a board there. I have asked > > to mainline it > > OK, good. Can you and Marek please coordinate on: > - Updating MAINTAINERS files > - Dropping the boards that won't be supported moving forward (even if > you can't mainline the custom board, there must be a ref platform you > have/use, yes?). > > And Michael, can you please subscribe to the u-boot-maintainers list? > > Jagan, was there an old patch to try and convert this driver that may be > of help to Michael? Thanks! I have asked previous version[1] author, Akash. He said he is going to send the next version. He don't have hardware to test, but Michael or someone can test his change, thanks. [1] https://patchwork.ozlabs.org/patch/911394/
On Mon, Apr 29, 2019 at 4:54 PM Tom Rini <trini@konsulko.com> wrote: > > On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote: > > On 4/29/19 1:02 PM, Jagan Teki wrote: > > > On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex@denx.de> wrote: > > >> > > >> On 4/29/19 12:40 PM, Jagan Teki wrote: > > >>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: > > >>>> > > >>>> On 4/28/19 10:47 PM, Jagan Teki wrote: > > >>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows > > >>>>> warning for broken configuration enabled and associated code > > >>>>> will remove in v2019.07 release. > > >>>> > > >>>> But the code is not broken, it works fine, right ? > > >>> > > >>> Yes the code work fine, but dm conversion not done yet. Now the > > >>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm > > >> > > >> That makes no sense, if the code works, it works and thus it is NOT > > >> broken. Find some other way to flag it as non-DM-converted, not this hack. > > > > > > np, It depends on whether we consider non-dm code(for legacy SPI > > > drivers) is broken or not, let Tom comment on this. > > > > Again, the code works, it's not broken. That's very clear. > > DM conversion is a separate matter, so let's not overload CONFIG_BROKEN > > for such things. The Makefile warning seems sufficient to me. > > The code is broken because it doesn't work with DM and is going to be > removed due to lack of maintenance soon. My problem with this series, > but I need to check that we can do what I want to do and still keep > travis green, is have this (and the other non-converted and thus > non-maintained drivers) depend on, not select BROKEN. Yes, the idea here is to build the broken one by selecting BROKEN so-that the travis-CI is green and have warning on the build, otherwise it is another rework of selecting BROKEN for those non-converted drivers if they depends. > > The Makefile warnings tell people the code is going to be removed and > I'm trying to have the window be: > 1) LOUD warning about needing work > 2) 1 release past those loud deadlines of the code there, but not built > unless you enable BROKEN (as yes, I see code that's not updated to use > DM as being broken) > 3) Code removed. ie what this series does. Driver (for example) will select BROKEN, that means it is still working bu would like to remove in next versions and so..
On Tue, May 14, 2019 at 07:46:06PM +0530, Jagan Teki wrote: > On Mon, Apr 29, 2019 at 4:54 PM Tom Rini <trini@konsulko.com> wrote: > > > > On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote: > > > On 4/29/19 1:02 PM, Jagan Teki wrote: > > > > On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex@denx.de> wrote: > > > >> > > > >> On 4/29/19 12:40 PM, Jagan Teki wrote: > > > >>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: > > > >>>> > > > >>>> On 4/28/19 10:47 PM, Jagan Teki wrote: > > > >>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows > > > >>>>> warning for broken configuration enabled and associated code > > > >>>>> will remove in v2019.07 release. > > > >>>> > > > >>>> But the code is not broken, it works fine, right ? > > > >>> > > > >>> Yes the code work fine, but dm conversion not done yet. Now the > > > >>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm > > > >> > > > >> That makes no sense, if the code works, it works and thus it is NOT > > > >> broken. Find some other way to flag it as non-DM-converted, not this hack. > > > > > > > > np, It depends on whether we consider non-dm code(for legacy SPI > > > > drivers) is broken or not, let Tom comment on this. > > > > > > Again, the code works, it's not broken. That's very clear. > > > DM conversion is a separate matter, so let's not overload CONFIG_BROKEN > > > for such things. The Makefile warning seems sufficient to me. > > > > The code is broken because it doesn't work with DM and is going to be > > removed due to lack of maintenance soon. My problem with this series, > > but I need to check that we can do what I want to do and still keep > > travis green, is have this (and the other non-converted and thus > > non-maintained drivers) depend on, not select BROKEN. > > Yes, the idea here is to build the broken one by selecting BROKEN > so-that the travis-CI is green and have warning on the build, > otherwise it is another rework of selecting BROKEN for those > non-converted drivers if they depends. > > > > > The Makefile warnings tell people the code is going to be removed and > > I'm trying to have the window be: > > 1) LOUD warning about needing work > > 2) 1 release past those loud deadlines of the code there, but not built > > unless you enable BROKEN (as yes, I see code that's not updated to use > > DM as being broken) > > 3) Code removed. > > ie what this series does. Driver (for example) will select BROKEN, > that means it is still working bu would like to remove in next > versions and so.. What I'm after is https://github.com/trini/u-boot/commits/WIP-BROKEN-test which is close, but not quite there. We no longer build the drivers marked as BROKEN by default, and the fallout from that has been: - Some missing dependencies (I'm trying to fix that now) leading to build problems. - Needing to yank CONFIG_SPI for example from configs that had been using a now-not-built driver as the subsystem fails to link if there's no controller. I don't think that's a problem however. - Needing to migrate a few more symbols to Kconfig in order to be able to properly express "You need to depend on BROKEN to use this option now".
On 5/14/19 4:45 PM, Tom Rini wrote: > On Tue, May 14, 2019 at 07:46:06PM +0530, Jagan Teki wrote: >> On Mon, Apr 29, 2019 at 4:54 PM Tom Rini <trini@konsulko.com> wrote: >>> >>> On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote: >>>> On 4/29/19 1:02 PM, Jagan Teki wrote: >>>>> On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex@denx.de> wrote: >>>>>> >>>>>> On 4/29/19 12:40 PM, Jagan Teki wrote: >>>>>>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: >>>>>>>> >>>>>>>> On 4/28/19 10:47 PM, Jagan Teki wrote: >>>>>>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows >>>>>>>>> warning for broken configuration enabled and associated code >>>>>>>>> will remove in v2019.07 release. >>>>>>>> >>>>>>>> But the code is not broken, it works fine, right ? >>>>>>> >>>>>>> Yes the code work fine, but dm conversion not done yet. Now the >>>>>>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm >>>>>> >>>>>> That makes no sense, if the code works, it works and thus it is NOT >>>>>> broken. Find some other way to flag it as non-DM-converted, not this hack. >>>>> >>>>> np, It depends on whether we consider non-dm code(for legacy SPI >>>>> drivers) is broken or not, let Tom comment on this. >>>> >>>> Again, the code works, it's not broken. That's very clear. >>>> DM conversion is a separate matter, so let's not overload CONFIG_BROKEN >>>> for such things. The Makefile warning seems sufficient to me. >>> >>> The code is broken because it doesn't work with DM and is going to be >>> removed due to lack of maintenance soon. My problem with this series, >>> but I need to check that we can do what I want to do and still keep >>> travis green, is have this (and the other non-converted and thus >>> non-maintained drivers) depend on, not select BROKEN. >> >> Yes, the idea here is to build the broken one by selecting BROKEN >> so-that the travis-CI is green and have warning on the build, >> otherwise it is another rework of selecting BROKEN for those >> non-converted drivers if they depends. >> >>> >>> The Makefile warnings tell people the code is going to be removed and >>> I'm trying to have the window be: >>> 1) LOUD warning about needing work >>> 2) 1 release past those loud deadlines of the code there, but not built >>> unless you enable BROKEN (as yes, I see code that's not updated to use >>> DM as being broken) >>> 3) Code removed. >> >> ie what this series does. Driver (for example) will select BROKEN, >> that means it is still working bu would like to remove in next >> versions and so.. > > What I'm after is > https://github.com/trini/u-boot/commits/WIP-BROKEN-test which is close, > but not quite there. We no longer build the drivers marked as BROKEN by > default, and the fallout from that has been: > - Some missing dependencies (I'm trying to fix that now) leading to > build problems. > - Needing to yank CONFIG_SPI for example from configs that had been > using a now-not-built driver as the subsystem fails to link if there's > no controller. I don't think that's a problem however. > - Needing to migrate a few more symbols to Kconfig in order to be able > to properly express "You need to depend on BROKEN to use this option > now". I still disagree with marking drivers that need DM conversion, but are otherwise working perfectly fine, as broken. That's just misleading and in fact incorrect. Invent some new, more descriptive Kconfig option please.
On Tue, May 14, 2019 at 07:33:17PM +0200, Marek Vasut wrote: > On 5/14/19 4:45 PM, Tom Rini wrote: > > On Tue, May 14, 2019 at 07:46:06PM +0530, Jagan Teki wrote: > >> On Mon, Apr 29, 2019 at 4:54 PM Tom Rini <trini@konsulko.com> wrote: > >>> > >>> On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote: > >>>> On 4/29/19 1:02 PM, Jagan Teki wrote: > >>>>> On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex@denx.de> wrote: > >>>>>> > >>>>>> On 4/29/19 12:40 PM, Jagan Teki wrote: > >>>>>>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: > >>>>>>>> > >>>>>>>> On 4/28/19 10:47 PM, Jagan Teki wrote: > >>>>>>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows > >>>>>>>>> warning for broken configuration enabled and associated code > >>>>>>>>> will remove in v2019.07 release. > >>>>>>>> > >>>>>>>> But the code is not broken, it works fine, right ? > >>>>>>> > >>>>>>> Yes the code work fine, but dm conversion not done yet. Now the > >>>>>>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm > >>>>>> > >>>>>> That makes no sense, if the code works, it works and thus it is NOT > >>>>>> broken. Find some other way to flag it as non-DM-converted, not this hack. > >>>>> > >>>>> np, It depends on whether we consider non-dm code(for legacy SPI > >>>>> drivers) is broken or not, let Tom comment on this. > >>>> > >>>> Again, the code works, it's not broken. That's very clear. > >>>> DM conversion is a separate matter, so let's not overload CONFIG_BROKEN > >>>> for such things. The Makefile warning seems sufficient to me. > >>> > >>> The code is broken because it doesn't work with DM and is going to be > >>> removed due to lack of maintenance soon. My problem with this series, > >>> but I need to check that we can do what I want to do and still keep > >>> travis green, is have this (and the other non-converted and thus > >>> non-maintained drivers) depend on, not select BROKEN. > >> > >> Yes, the idea here is to build the broken one by selecting BROKEN > >> so-that the travis-CI is green and have warning on the build, > >> otherwise it is another rework of selecting BROKEN for those > >> non-converted drivers if they depends. > >> > >>> > >>> The Makefile warnings tell people the code is going to be removed and > >>> I'm trying to have the window be: > >>> 1) LOUD warning about needing work > >>> 2) 1 release past those loud deadlines of the code there, but not built > >>> unless you enable BROKEN (as yes, I see code that's not updated to use > >>> DM as being broken) > >>> 3) Code removed. > >> > >> ie what this series does. Driver (for example) will select BROKEN, > >> that means it is still working bu would like to remove in next > >> versions and so.. > > > > What I'm after is > > https://github.com/trini/u-boot/commits/WIP-BROKEN-test which is close, > > but not quite there. We no longer build the drivers marked as BROKEN by > > default, and the fallout from that has been: > > - Some missing dependencies (I'm trying to fix that now) leading to > > build problems. > > - Needing to yank CONFIG_SPI for example from configs that had been > > using a now-not-built driver as the subsystem fails to link if there's > > no controller. I don't think that's a problem however. > > - Needing to migrate a few more symbols to Kconfig in order to be able > > to properly express "You need to depend on BROKEN to use this option > > now". > > I still disagree with marking drivers that need DM conversion, but are > otherwise working perfectly fine, as broken. That's just misleading and > in fact incorrect. Invent some new, more descriptive Kconfig option please. I also still disagree, but, fine, I'll add CONFIG_DEPRECATED.
On 5/14/19 7:37 PM, Tom Rini wrote: > On Tue, May 14, 2019 at 07:33:17PM +0200, Marek Vasut wrote: >> On 5/14/19 4:45 PM, Tom Rini wrote: >>> On Tue, May 14, 2019 at 07:46:06PM +0530, Jagan Teki wrote: >>>> On Mon, Apr 29, 2019 at 4:54 PM Tom Rini <trini@konsulko.com> wrote: >>>>> >>>>> On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote: >>>>>> On 4/29/19 1:02 PM, Jagan Teki wrote: >>>>>>> On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex@denx.de> wrote: >>>>>>>> >>>>>>>> On 4/29/19 12:40 PM, Jagan Teki wrote: >>>>>>>>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: >>>>>>>>>> >>>>>>>>>> On 4/28/19 10:47 PM, Jagan Teki wrote: >>>>>>>>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows >>>>>>>>>>> warning for broken configuration enabled and associated code >>>>>>>>>>> will remove in v2019.07 release. >>>>>>>>>> >>>>>>>>>> But the code is not broken, it works fine, right ? >>>>>>>>> >>>>>>>>> Yes the code work fine, but dm conversion not done yet. Now the >>>>>>>>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm >>>>>>>> >>>>>>>> That makes no sense, if the code works, it works and thus it is NOT >>>>>>>> broken. Find some other way to flag it as non-DM-converted, not this hack. >>>>>>> >>>>>>> np, It depends on whether we consider non-dm code(for legacy SPI >>>>>>> drivers) is broken or not, let Tom comment on this. >>>>>> >>>>>> Again, the code works, it's not broken. That's very clear. >>>>>> DM conversion is a separate matter, so let's not overload CONFIG_BROKEN >>>>>> for such things. The Makefile warning seems sufficient to me. >>>>> >>>>> The code is broken because it doesn't work with DM and is going to be >>>>> removed due to lack of maintenance soon. My problem with this series, >>>>> but I need to check that we can do what I want to do and still keep >>>>> travis green, is have this (and the other non-converted and thus >>>>> non-maintained drivers) depend on, not select BROKEN. >>>> >>>> Yes, the idea here is to build the broken one by selecting BROKEN >>>> so-that the travis-CI is green and have warning on the build, >>>> otherwise it is another rework of selecting BROKEN for those >>>> non-converted drivers if they depends. >>>> >>>>> >>>>> The Makefile warnings tell people the code is going to be removed and >>>>> I'm trying to have the window be: >>>>> 1) LOUD warning about needing work >>>>> 2) 1 release past those loud deadlines of the code there, but not built >>>>> unless you enable BROKEN (as yes, I see code that's not updated to use >>>>> DM as being broken) >>>>> 3) Code removed. >>>> >>>> ie what this series does. Driver (for example) will select BROKEN, >>>> that means it is still working bu would like to remove in next >>>> versions and so.. >>> >>> What I'm after is >>> https://github.com/trini/u-boot/commits/WIP-BROKEN-test which is close, >>> but not quite there. We no longer build the drivers marked as BROKEN by >>> default, and the fallout from that has been: >>> - Some missing dependencies (I'm trying to fix that now) leading to >>> build problems. >>> - Needing to yank CONFIG_SPI for example from configs that had been >>> using a now-not-built driver as the subsystem fails to link if there's >>> no controller. I don't think that's a problem however. >>> - Needing to migrate a few more symbols to Kconfig in order to be able >>> to properly express "You need to depend on BROKEN to use this option >>> now". >> >> I still disagree with marking drivers that need DM conversion, but are >> otherwise working perfectly fine, as broken. That's just misleading and >> in fact incorrect. Invent some new, more descriptive Kconfig option please. > > I also still disagree, but, fine, I'll add CONFIG_DEPRECATED. CONFIG_DM_NEED_MIGRATION or something ?
On Tue, May 14, 2019 at 07:41:07PM +0200, Marek Vasut wrote: > On 5/14/19 7:37 PM, Tom Rini wrote: > > On Tue, May 14, 2019 at 07:33:17PM +0200, Marek Vasut wrote: > >> On 5/14/19 4:45 PM, Tom Rini wrote: > >>> On Tue, May 14, 2019 at 07:46:06PM +0530, Jagan Teki wrote: > >>>> On Mon, Apr 29, 2019 at 4:54 PM Tom Rini <trini@konsulko.com> wrote: > >>>>> > >>>>> On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote: > >>>>>> On 4/29/19 1:02 PM, Jagan Teki wrote: > >>>>>>> On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex@denx.de> wrote: > >>>>>>>> > >>>>>>>> On 4/29/19 12:40 PM, Jagan Teki wrote: > >>>>>>>>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex@denx.de> wrote: > >>>>>>>>>> > >>>>>>>>>> On 4/28/19 10:47 PM, Jagan Teki wrote: > >>>>>>>>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows > >>>>>>>>>>> warning for broken configuration enabled and associated code > >>>>>>>>>>> will remove in v2019.07 release. > >>>>>>>>>> > >>>>>>>>>> But the code is not broken, it works fine, right ? > >>>>>>>>> > >>>>>>>>> Yes the code work fine, but dm conversion not done yet. Now the > >>>>>>>>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm > >>>>>>>> > >>>>>>>> That makes no sense, if the code works, it works and thus it is NOT > >>>>>>>> broken. Find some other way to flag it as non-DM-converted, not this hack. > >>>>>>> > >>>>>>> np, It depends on whether we consider non-dm code(for legacy SPI > >>>>>>> drivers) is broken or not, let Tom comment on this. > >>>>>> > >>>>>> Again, the code works, it's not broken. That's very clear. > >>>>>> DM conversion is a separate matter, so let's not overload CONFIG_BROKEN > >>>>>> for such things. The Makefile warning seems sufficient to me. > >>>>> > >>>>> The code is broken because it doesn't work with DM and is going to be > >>>>> removed due to lack of maintenance soon. My problem with this series, > >>>>> but I need to check that we can do what I want to do and still keep > >>>>> travis green, is have this (and the other non-converted and thus > >>>>> non-maintained drivers) depend on, not select BROKEN. > >>>> > >>>> Yes, the idea here is to build the broken one by selecting BROKEN > >>>> so-that the travis-CI is green and have warning on the build, > >>>> otherwise it is another rework of selecting BROKEN for those > >>>> non-converted drivers if they depends. > >>>> > >>>>> > >>>>> The Makefile warnings tell people the code is going to be removed and > >>>>> I'm trying to have the window be: > >>>>> 1) LOUD warning about needing work > >>>>> 2) 1 release past those loud deadlines of the code there, but not built > >>>>> unless you enable BROKEN (as yes, I see code that's not updated to use > >>>>> DM as being broken) > >>>>> 3) Code removed. > >>>> > >>>> ie what this series does. Driver (for example) will select BROKEN, > >>>> that means it is still working bu would like to remove in next > >>>> versions and so.. > >>> > >>> What I'm after is > >>> https://github.com/trini/u-boot/commits/WIP-BROKEN-test which is close, > >>> but not quite there. We no longer build the drivers marked as BROKEN by > >>> default, and the fallout from that has been: > >>> - Some missing dependencies (I'm trying to fix that now) leading to > >>> build problems. > >>> - Needing to yank CONFIG_SPI for example from configs that had been > >>> using a now-not-built driver as the subsystem fails to link if there's > >>> no controller. I don't think that's a problem however. > >>> - Needing to migrate a few more symbols to Kconfig in order to be able > >>> to properly express "You need to depend on BROKEN to use this option > >>> now". > >> > >> I still disagree with marking drivers that need DM conversion, but are > >> otherwise working perfectly fine, as broken. That's just misleading and > >> in fact incorrect. Invent some new, more descriptive Kconfig option please. > > > > I also still disagree, but, fine, I'll add CONFIG_DEPRECATED. > > CONFIG_DM_NEED_MIGRATION or something ? No, I think given the definition of deprecated: "to withdraw official support for or discourage the use of (something, such as a software product) in favor of a newer or better alternative" (from https://www.merriam-webster.com/dictionary/deprecated) this is good enough.
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index e196f64e2f..393382fee2 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -377,6 +377,7 @@ config MXC_SPI config MXS_SPI bool "MXS SPI Driver" + select BROKEN help Enable the MXS SPI controller driver. This driver can be used on the i.MX23 and i.MX28 SoCs.
Mark MXS_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release. Cc: Marek Vasut <marex@denx.de> Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Michael Trimarchi <michael@amarulasolutions.com> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)