| Message ID | 20181206132306.11843-3-jagan@amarulasolutions.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
On Thu, Dec 06, 2018 at 06:53:06PM +0530, Jagan Teki wrote: > Some camera modules have the SoC feeding a master clock to the sensor > instead of having a standalone crystal. This clock signal is generated > from the clock control unit and output from the CSI MCLK function of > pin PE1. > > Add a pinmux setting for it for camera sensors to reference. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Changes for v2: > - new patch > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index d7ab0006ebce..902b5238f1dd 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -538,6 +538,11 @@ > function = "csi0"; > }; > > + csi_mclk_pin: csi-mclk { > + pins = "PE1"; > + function = "csi0"; > + }; > + We're not merging nodes that have no users. Maxime
On Thu, Dec 6, 2018 at 9:05 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Thu, Dec 06, 2018 at 06:53:06PM +0530, Jagan Teki wrote: > > Some camera modules have the SoC feeding a master clock to the sensor > > instead of having a standalone crystal. This clock signal is generated > > from the clock control unit and output from the CSI MCLK function of > > pin PE1. > > > > Add a pinmux setting for it for camera sensors to reference. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > Changes for v2: > > - new patch > > > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > index d7ab0006ebce..902b5238f1dd 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > @@ -538,6 +538,11 @@ > > function = "csi0"; > > }; > > > > + csi_mclk_pin: csi-mclk { > > + pins = "PE1"; > > + function = "csi0"; > > + }; > > + > > We're not merging nodes that have no users. Yes, v1 [1] has a consumer for this. Since it's under discussion about PE group supply, opendrain I hold it. will send once the discussion done, I even tested on top-of your ov5640 changes. [1] https://patchwork.kernel.org/patch/10709077/
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index d7ab0006ebce..902b5238f1dd 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -538,6 +538,11 @@ function = "csi0"; }; + csi_mclk_pin: csi-mclk { + pins = "PE1"; + function = "csi0"; + }; + i2c0_pins: i2c0_pins { pins = "PH0", "PH1"; function = "i2c0";
Some camera modules have the SoC feeding a master clock to the sensor instead of having a standalone crystal. This clock signal is generated from the clock control unit and output from the CSI MCLK function of pin PE1. Add a pinmux setting for it for camera sensors to reference. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Changes for v2: - new patch arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++ 1 file changed, 5 insertions(+)