| Message ID | 20190929074239.11575-5-jagan@amarulasolutions.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi Jagan, On Sun, Sep 29, 2019 at 3:43 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > Add u-boot specific dts file for hifive-unleashed-a00, this > would help to add u-boot specific properties and other node > changes without touching the base dts(i) files which are easy > to sync from Linux. > > Added spi2 alias for qspi2 as an initial u-boot specific > property change. > > spi probing in current dm model is very much rely on aliases > numbering. even though the qspi2 can't comes under any associated > spi nor flash it would require to specify the same to make proper > binding happen for other spi slaves. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > create mode 100644 arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi > > diff --git a/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi > new file mode 100644 > index 0000000000..25ec8265a5 > --- /dev/null > +++ b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi > @@ -0,0 +1,10 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com> > + */ > + > +/ { > + aliases { > + spi2 = &qspi2; With the following 2 patches, this is no longer needed for SPI. http://patchwork.ozlabs.org/patch/1158960/ http://patchwork.ozlabs.org/patch/1158961/ > + }; > +}; > -- Regards, Bin
On Mon, Sep 30, 2019 at 3:35 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > Hi Jagan, > > On Sun, Sep 29, 2019 at 3:43 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > > > Add u-boot specific dts file for hifive-unleashed-a00, this > > would help to add u-boot specific properties and other node > > changes without touching the base dts(i) files which are easy > > to sync from Linux. > > > > Added spi2 alias for qspi2 as an initial u-boot specific > > property change. > > > > spi probing in current dm model is very much rely on aliases > > numbering. even though the qspi2 can't comes under any associated > > spi nor flash it would require to specify the same to make proper > > binding happen for other spi slaves. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > create mode 100644 arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi > > > > diff --git a/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi > > new file mode 100644 > > index 0000000000..25ec8265a5 > > --- /dev/null > > +++ b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi > > @@ -0,0 +1,10 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com> > > + */ > > + > > +/ { > > + aliases { > > + spi2 = &qspi2; > > With the following 2 patches, this is no longer needed for SPI. > > http://patchwork.ozlabs.org/patch/1158960/ > http://patchwork.ozlabs.org/patch/1158961/ Thanks, will check these.
On Mon, Sep 30, 2019 at 3:35 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > Hi Jagan, > > On Sun, Sep 29, 2019 at 3:43 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > > > Add u-boot specific dts file for hifive-unleashed-a00, this > > would help to add u-boot specific properties and other node > > changes without touching the base dts(i) files which are easy > > to sync from Linux. > > > > Added spi2 alias for qspi2 as an initial u-boot specific > > property change. > > > > spi probing in current dm model is very much rely on aliases > > numbering. even though the qspi2 can't comes under any associated > > spi nor flash it would require to specify the same to make proper > > binding happen for other spi slaves. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > create mode 100644 arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi > > > > diff --git a/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi > > new file mode 100644 > > index 0000000000..25ec8265a5 > > --- /dev/null > > +++ b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi > > @@ -0,0 +1,10 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com> > > + */ > > + > > +/ { > > + aliases { > > + spi2 = &qspi2; > > With the following 2 patches, this is no longer needed for SPI. > > http://patchwork.ozlabs.org/patch/1158960/ > http://patchwork.ozlabs.org/patch/1158961/ These changes doesn't related to this, checked the same. SPI MMC need to bringup like normal spi via alias to make proper graceful probing for next spi slaves.
diff --git a/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi new file mode 100644 index 0000000000..25ec8265a5 --- /dev/null +++ b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi @@ -0,0 +1,10 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com> + */ + +/ { + aliases { + spi2 = &qspi2; + }; +};
Add u-boot specific dts file for hifive-unleashed-a00, this would help to add u-boot specific properties and other node changes without touching the base dts(i) files which are easy to sync from Linux. Added spi2 alias for qspi2 as an initial u-boot specific property change. spi probing in current dm model is very much rely on aliases numbering. even though the qspi2 can't comes under any associated spi nor flash it would require to specify the same to make proper binding happen for other spi slaves. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi