| Message ID | 20191022175458.22604-8-jagan@amarulasolutions.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Jagan Teki <jagan@amarulasolutions.com> writes: > Add 0x330a for rk3399 gadget product number. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > drivers/usb/gadget/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig > index 2da8b40e05..b0e61f3fcd 100644 > --- a/drivers/usb/gadget/Kconfig > +++ b/drivers/usb/gadget/Kconfig > @@ -61,7 +61,7 @@ config USB_GADGET_PRODUCT_NUM > default 0x310a if ROCKCHIP_RK3036 > default 0x310c if ROCKCHIP_RK3128 > default 0x320a if ROCKCHIP_RK3229 || ROCKCHIP_RK3288 > - default 0x330a if ROCKCHIP_RK3328 > + default 0x330a if ROCKCHIP_RK3328 || ROCKCHIP_RK3399 > default 0x0 > help > Product ID of the USB device emulated, reported to the host device. With 0x330a, the device shown in `lsusb` is: Bus 002 Device 024: ID 2207:330a Fuzhou Rockchip Electronics Company RK3368 in Mask ROM mode While using 0x330c, the device shown in `lsusb` is: Bus 002 Device 025: ID 2207:330c Fuzhou Rockchip Electronics Company RK3399 in Mask ROM mode Therefore, this should be modified to use 0x330c: + default 0x330c if ROCKCHIP_RK3399 Thanks
On Tue, Oct 29, 2019 at 3:10 PM <djw@t-chip.com.cn> wrote: > > Jagan Teki <jagan@amarulasolutions.com> writes: > > > Add 0x330a for rk3399 gadget product number. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > drivers/usb/gadget/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig > > index 2da8b40e05..b0e61f3fcd 100644 > > --- a/drivers/usb/gadget/Kconfig > > +++ b/drivers/usb/gadget/Kconfig > > @@ -61,7 +61,7 @@ config USB_GADGET_PRODUCT_NUM > > default 0x310a if ROCKCHIP_RK3036 > > default 0x310c if ROCKCHIP_RK3128 > > default 0x320a if ROCKCHIP_RK3229 || ROCKCHIP_RK3288 > > - default 0x330a if ROCKCHIP_RK3328 > > + default 0x330a if ROCKCHIP_RK3328 || ROCKCHIP_RK3399 > > default 0x0 > > help > > Product ID of the USB device emulated, reported to the host device. > > With 0x330a, the device shown in `lsusb` is: > > Bus 002 Device 024: ID 2207:330a Fuzhou Rockchip Electronics Company RK3368 in Mask ROM mode > While using 0x330c, the device shown in `lsusb` is: > > Bus 002 Device 025: ID 2207:330c Fuzhou Rockchip Electronics Company RK3399 in Mask ROM mode > > Therefore, this should be modified to use 0x330c: > > + default 0x330c if ROCKCHIP_RK3399 Can you link the host driver for the rockchip gadget, I didn't see the name using lsusb. My output on ubuntu host is Bus 001 Device 009: ID 2207:330a
diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index 2da8b40e05..b0e61f3fcd 100644 --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig @@ -61,7 +61,7 @@ config USB_GADGET_PRODUCT_NUM default 0x310a if ROCKCHIP_RK3036 default 0x310c if ROCKCHIP_RK3128 default 0x320a if ROCKCHIP_RK3229 || ROCKCHIP_RK3288 - default 0x330a if ROCKCHIP_RK3328 + default 0x330a if ROCKCHIP_RK3328 || ROCKCHIP_RK3399 default 0x0 help Product ID of the USB device emulated, reported to the host device.
Add 0x330a for rk3399 gadget product number. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- drivers/usb/gadget/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)