From patchwork Thu Jul 28 07:02:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2272 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id A2F573F013 for ; Thu, 28 Jul 2022 09:03:04 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id w5-20020a05640234c500b0043be08bb082sf545134edc.9 for ; Thu, 28 Jul 2022 00:03:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1658991784; cv=pass; d=google.com; s=arc-20160816; b=lLx2OslK29SpmpSMnvFJprPrqLuE3qH8a4RkxCnHZy6a85LpcOmS3iOm2qCy8r2JmZ q6Z7zWqEHyjYpV0XXirWoA6bpt36pXrQ4tDqs+LHd9VThej2cgf98TTGU3Mm8qm2EDfa Wnxbv5GhR7xlNYN7a0MUYYHn5H+wRvKNF15dR6oGRgG49dc/kB3YnViJ6ynWZQw4ZdGB V7ItYMlZBcRxh045zxg/a9HlC6Boxj6jsCYd0dER6EDk80amEIbFbrFGxbC8PgQqfmqj 4Oc1m1ARs8HHJ41lRNxfTN3RjXrUJBZJuggJA/Vl960wHD1/b3FRhFkhwXcRL3iem4IY kZJQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=IwJ3NXPNj12mMxnOJKD5aOcxy3sMxZXycY7YfEcWklI=; b=G8xLef2QAl2MpC78VPpuLanBn9s7gUy3F7Xj78U38ON3ji3C/07d4m9p0z5+J8jM0W nb7aEjTrWGL1iCyeHmWxJYJoJ6XIf4D3dQRhyY1pJTHcAiVJiKNaoG36ATg7HzcuPDLK 2s/Y5r1Z+cMNJMEkIRbDRQArkpbTnIzySNVXVSRPF6qkny4VAZC4QIJ/r5qKFcTTm/nB Igd7rs66wMp+s9cpUa+yeuiRpXVvikcR1hY4C9KoziJ1zwV4ZKA7ejpU8g+bNJC8kfKo wag2D2K4/Fo6wuALMyTExoa+YoT08J1XrgW1m1RGbrWlWbE6XtbQw6QjdgnobjSdqFlC 6iWw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=f42OwsnT; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=IwJ3NXPNj12mMxnOJKD5aOcxy3sMxZXycY7YfEcWklI=; b=Agu6PDN9kfC+8uYs38Tb/8bV9GF4W9VfaM5bpYY/cIwBdtPl6W5ILu2HOhR+sznbj/ bP3FORn5oOBqrHuUblObQ2e4Ht/Lp6uvjiFrw5gtSPhdBX2a08BgBrjFJ5x6sfIiLSVZ XfxeUZf02kX4IDyCXXwcXZ6gvnYyuIpJ1Plig= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:x-spam-checked-in-group:list-post:list-help :list-archive:list-unsubscribe; bh=IwJ3NXPNj12mMxnOJKD5aOcxy3sMxZXycY7YfEcWklI=; b=aAnOFD2tdFZBUqCiwT6P1Zh8h07JxRUiOvHw0GkJcqnibQnwCll+h+Octqe1ERM++s 9G2hxZTer827kew1/GApk9I9W4bpLcGiKk2tk2uLdkdkZ6IQGSIUSd0EQw0Y1rDAvvRx /FDiMX2B25xoug+6l0HiD9h6O76nrIH0yAZ8Cq7r8Ag/RnDxb3FU/GEv9eTwcxslpXV5 TswGaFQdEDDoNsOy9TWMcCywD/oAZ2snq8ZqZMaZCZBLoqfS5GDl5de0+KgeFz2QdTKV Jd8M7ge3v6unRflXT53DeunOzlC2l0GoqlZY+GxSSqgVypyCq1W2NFUzJOvw3Apg28qM cLJQ== X-Gm-Message-State: AJIora/UpTAFDTEV845iHjd417dIGYiBxvMevsGVu+EkMDcUgWV77WQw VB+BD89Rc26UvuEd8PnoKkjauZr2 X-Google-Smtp-Source: AGRyM1tsJT3An5SePEKTD7b8ADCSvLxaq0dzp4u4KPqK7yNK/w1duJWqYIekrjQzJAP7OjbZmjwZ+A== X-Received: by 2002:a05:6402:1d51:b0:41f:cf6c:35a5 with SMTP id dz17-20020a0564021d5100b0041fcf6c35a5mr27091454edb.25.1658991784436; Thu, 28 Jul 2022 00:03:04 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:906:3b8a:b0:72f:b55a:8f8c with SMTP id u10-20020a1709063b8a00b0072fb55a8f8cls422588ejf.6.-pod-prod-gmail; Thu, 28 Jul 2022 00:03:03 -0700 (PDT) X-Received: by 2002:a17:907:3daa:b0:72b:7656:d4d2 with SMTP id he42-20020a1709073daa00b0072b7656d4d2mr20322500ejc.166.1658991783198; Thu, 28 Jul 2022 00:03:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658991783; cv=none; d=google.com; s=arc-20160816; b=Ry6L7m329iCJmxmbbo0yyHJHggMzja9dlVzEYOV1KjUmThZ5yvem/GU/YLgCfbYBUz Y7ywsksxFotnPIb0BXJNwaDaUEb5jrhN/xjeEIIUGQMQFfPHA2YxEBqC2suxmtqAYcn1 TaQisjV5WBwRLAWcB6qB/DXTKjfW7LkYHxO80QU20yHAxRIyE191VunCYV0HzGiBGr87 OA7RniOvst7iwaAbLO01GWwqPH0u9mzeUYahrgPptAoE/Ho5qBfSmJRAlE2qGkQzRI06 6UoYXFlAkXZ6gliq9VbicyW96oUqGmCBqXE8493IBDz29tarns4tqZYfGo09VwImKP5J uZ6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=nZj3FVBxKWQWzHTUYRIyjL/IBGzy/vAn7ewqW8rjIR8=; b=VHOTY089vwgKzKK/Edc/TrcRpRitJoDmk+kB/O/lKCKTpnejZiAlKeMyKkc9WvUqsa +OdUGgRFoie6qQ7OAA3xd1kkEEK5lDNdo69ws1MUNuZMw8SIfY4CieKJpyHNptuYn4nT WbJe7BDHO/l+JhLNe+jCxnkLSv+AOZlujpBWVaIK9N9md/MYnlI4iZQHwCZsDNRBqchy ZL0/GwZuawy86OelpiMHY4yu7pDQDMxcmuL7hv1wqCnoQwa/fbSDTaGA2FCVEScZdk26 nMvtpft2Lu6PQ01ZqQ62GgIHs9TJE31BDAgC4PNhXgk6h0QsNc46c9YRNMnaKQg2XG77 wMCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=f42OwsnT; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id m27-20020a50d7db000000b0043cd70052b0sor122227edj.10.2022.07.28.00.03.03 for (Google Transport Security); Thu, 28 Jul 2022 00:03:03 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6402:4016:b0:43a:f310:9522 with SMTP id d22-20020a056402401600b0043af3109522mr26262809eda.200.1658991782896; Thu, 28 Jul 2022 00:03:02 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-31-31-9.retail.telecomitalia.it. [79.31.31.9]) by smtp.gmail.com with ESMTPSA id r18-20020aa7d152000000b0042de3d661d2sm154742edo.1.2022.07.28.00.03.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 00:03:02 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-can@vger.kernel.org, Marc Kleine-Budde , Jeroen Hofstee , michael@amarulasolutions.com, Amarula patchwork , Oliver Hartkopp , Dario Binacchi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wolfgang Grandegger , netdev@vger.kernel.org Subject: [PATCH v4 0/7] can: slcan: extend supported features (step 2) Date: Thu, 28 Jul 2022 09:02:47 +0200 Message-Id: <20220728070254.267974-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=f42OwsnT; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , With this series I try to finish the task, started with the series [1], of completely removing the dependency of the slcan driver from the userspace slcand/slcan_attach applications. The series also contains patches that remove the legacy stuff (slcan_devs, SLCAN_MAGIC, ...) and do some module cleanup. The series has been created on top of the patches: can: slcan: convert comments to network style comments can: slcan: slcan_init() convert printk(LEVEL ...) to pr_level() can: slcan: fix whitespace issues can: slcan: convert comparison to NULL into !val can: slcan: clean up if/else can: slcan: use scnprintf() as a hardening measure can: slcan: do not report txerr and rxerr during bus-off can: slcan: do not sleep with a spin lock held applied to linux-next. [1] https://lore.kernel.org/all/20220628163137.413025-1-dario.binacchi@amarulasolutions.com/ Changes in v4: - Add Max Staudt's `Reviewed-by' tag. - Drop the patch "ethtool: add support to get/set CAN bit time register". - Drop the patch "can: slcan: add support to set bit time register (btr)". - Remove the RFC prefix from the series. Changes in v3: - Update the commit message. - Use 1 space in front of the =. - Put the series as RFC again. - Pick up the patch "can: slcan: use KBUILD_MODNAME and define pr_fmt to replace hardcoded names". - Add the patch "ethtool: add support to get/set CAN bit time register" to the series. - Add the patch "can: slcan: add support to set bit time register (btr)" to the series. - Replace the link https://marc.info/?l=linux-can&m=165806705927851&w=2 with https://lore.kernel.org/all/507b5973-d673-4755-3b64-b41cb9a13b6f@hartkopp.net. - Add the `Suggested-by' tag. Changes in v2: - Re-add headers that export at least one symbol used by the module. - Update the commit description. - Drop the old "slcan" name to use the standard canX interface naming. - Remove comment on listen-only command. - Update the commit subject and description. - Add the patch "MAINTAINERS: Add myself as maintainer of the SLCAN driver" to the series. Dario Binacchi (6): can: slcan: remove useless header inclusions can: slcan: remove legacy infrastructure can: slcan: change every `slc' occurrence in `slcan' can: slcan: use the generic can_change_mtu() can: slcan: add support for listen-only mode MAINTAINERS: Add maintainer for the slcan driver Vincent Mailhol (1): can: slcan: use KBUILD_MODNAME and define pr_fmt to replace hardcoded names MAINTAINERS | 6 + drivers/net/can/slcan/slcan-core.c | 459 +++++++++-------------------- 2 files changed, 144 insertions(+), 321 deletions(-)