From patchwork Mon Oct 17 16:42:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2433 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id DD2BF4147A for ; Mon, 17 Oct 2022 18:42:58 +0200 (CEST) Received: by mail-ej1-f69.google.com with SMTP id xc12-20020a170907074c00b007416699ea14sf4915361ejb.19 for ; Mon, 17 Oct 2022 09:42:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1666024978; cv=pass; d=google.com; s=arc-20160816; b=ZkPFwpgaJSTSnhUDnF7lX6QXV1X27kdZl4CuIDxNOS6cQN6jD3j2KAzBBAVcqsQHix Y2XSQsoadp7z80/lJAW4qbR6l++6ZbGljNG+LiPGIBx0F2CW175o76LUhJNu5PJmFEmp p84Z/QXu5n7hhiMVMZQBskrAoYGRdM24RM1SVTqOkvqm0XIsRkwYJ4hektiOQOgnnuzz 1SUHySjlWRgZ4O47f2hWyoNd0w6NLz7cTLg2v/JrUieoWXV18zy5JS//zWUXE+SOZVK3 Tpl2QMXknKgjGcnuM7oz8UQUUOmFHGPi/ykijBvzLaZjxxtzXe3BbYOc6XQgcWCN6fGE cQ2A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=abUiCE3Ig29sMAIqpHcYRuhlNjwGrfKdokoTa2wxqXw=; b=ZbQZhMW6ctYZHBUnPG4JTu5McdsATH8TqZV8e2tCVJF3VRDcViOmSmRTk3f5+ltAlc QbNDNvc8T56RaTcUBUnlpizfVaa5OwmkVSrYWbW/qu2lUIPmzUh7b+z6r//X7YVndrIx PuT9Lnb+2n4y99HLam5BpJE26WWYsQ8Ly6u2AVIE3JqL3GbWrxUa0pKvIbuX7HEIWqa9 DIlLqIF3W4bPEFO56V3kta7uzsqfZUfeDHF2M4oCyiINYm4WtbXwcyXTBoFSRs1V+laG 3/hGbthXqNMbl9qdNHA3O6+IMNLrR2BnHvuftK7tu8W0TFuDCYvc6fkUkF778Cfg+Ws0 ZMhw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ekoyXht2; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=abUiCE3Ig29sMAIqpHcYRuhlNjwGrfKdokoTa2wxqXw=; b=WrVtjFnNK34gwD19VDe66+enwGvzeSsBpkyfgst48xlZ3ZuXgxbhZi2phSKUAxXSFf cSgr2CVsDkw4tZpvDHs7pZPTOwYbJoVv0IYf7y70d/dSmASTvpTknv47by8JRiMJpMHA FtogeMbSITu8/wkupjiEhkQRVUS1O4CVtuFMw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=abUiCE3Ig29sMAIqpHcYRuhlNjwGrfKdokoTa2wxqXw=; b=rOMKIwfHuasmWysACTYLOWKpfylhY5iPG9uuo7YHkH03QtKQZ3Uwe4gPXLDMstyBtQ KfY254Suf8c5s9Vzd5JjUaAo+/5ND19bCNLSqiZGzsreVw0/pyH1VnwjlLOcYm+v3k9p E0sIqPTxoky259w+2NpRyjqJES2MvIAggfQTwgvMvEEx6K8e1E3UIyW8xM2t7jpp1Z+t UppoAS64nmma/F4P1BZMwt1Ue6G2dgAzInivhM2Hbhy3f/fsBj754R6JA/cuaNumwAnZ FO2LK/8JdLXWh5D0Y7bO8/aYwQb9WeAJuXaGbswuhJZMTAjWXin6YSqrPLworMIqPCgC 69hQ== X-Gm-Message-State: ACrzQf2kFNRIa5DKInYhVCpC2X2r48Fi5gzBIVO8M5UOnhH6WdEKRULZ hBW1s3qIN0pK1FISsibq97UfFLS6 X-Google-Smtp-Source: AMsMyM5e7sasXjsgE4/KRGOzfgtfdown2ykW0hibkGLgksvQkRFo6GxD61kc8IUDAJ0gkpF5ieLzQw== X-Received: by 2002:a05:6402:e9b:b0:454:351c:c222 with SMTP id h27-20020a0564020e9b00b00454351cc222mr11176556eda.216.1666024978616; Mon, 17 Oct 2022 09:42:58 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:906:544f:b0:78d:e7b8:d105 with SMTP id d15-20020a170906544f00b0078de7b8d105ls6043657ejp.8.-pod-prod-gmail; Mon, 17 Oct 2022 09:42:57 -0700 (PDT) X-Received: by 2002:a17:907:d26:b0:78e:20c6:9f77 with SMTP id gn38-20020a1709070d2600b0078e20c69f77mr9192239ejc.243.1666024977310; Mon, 17 Oct 2022 09:42:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666024977; cv=none; d=google.com; s=arc-20160816; b=IDCu/YtZzVDTPaiW8Jo3xW+ic2UWSko9XVC0XwV3FbPG1C7+aGY2RjGB1ETLgZHUw0 MZav/dfAgoSuq+OXt9adr3O/Ydyfhpj3UKbYvrJAZOwmbfz6ZMphmX8m7l3EzU1aiAA9 kVkR5rKkJYn+L12kMWtit7r2o0nrpVNQIz9Em742Tk1jRvfcPZQCYCRn4Zv6yyk7dDIo jHxzJHeagOHSu329ANfGwTfxooYOJHBLyty/cwYw7wBDaKLYSY6zyQiiDp96X1+PFEKd 38JHqkaZvRXYBOxoYoffB1NuHz/RoNffX1s6UnMH+J6FUIqOBHVYYlT68A8oIf9wV5tU JTQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=xDO3sMF/hJIpyc2siGnZVm8MMtmhdSexdGimiQU1euY=; b=Omkbpn02jLZWYjcURhimrPIkws2k92PnLA5P4DBZfCo3k3/2ezvUQou/1WqalV4Cz6 iega5E0e1DihWUsazT75xpZtwzkELZyf61a3ucpycbTJlAl6HQSsDvatc/ohZXEkqDlC HW65doBmO+iCGxlI4R0JuDgsvwHCDrIo4qQ7zhshXQkrPv3Img2pH7x2BtaTPUbidOYW SMna1oJOqoJUxS7j+X2Z5x6o/Bu7dMHqSr4ME6kGm+sB347HsZJrHYuVgygzKSt4XPmo aSQmeiPZjEZZ1Gz1v264nS2yDKksvsnuv8U8xTFY5r/itOPynog4yoxf2BtHtI7PJa4i tj4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ekoyXht2; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id o25-20020a170906359900b00781b891da6csor3946946ejb.62.2022.10.17.09.42.57 for (Google Transport Security); Mon, 17 Oct 2022 09:42:57 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:906:5dcc:b0:78d:fb98:6f85 with SMTP id p12-20020a1709065dcc00b0078dfb986f85mr9542851ejv.123.1666024976923; Mon, 17 Oct 2022 09:42:56 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-95-244-101-110.retail.telecomitalia.it. [95.244.101.110]) by smtp.gmail.com with ESMTPSA id a24-20020a1709063a5800b0078128c89439sm6437388ejf.6.2022.10.17.09.42.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 09:42:56 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: michael@amarulasolutions.com, Vincent Mailhol , Krzysztof Kozlowski , Rob Herring , Marc Kleine-Budde , Amarula patchwork , Alexandre Torgue , Dario Binacchi , Christophe Roullier , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Krzysztof Kozlowski , Mark Brown , Mathieu Poirier , Maxime Coquelin , Miquel Raynal , Paolo Abeni , Patrice Chotard , Rob Herring , Wolfgang Grandegger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Subject: [RFC PATCH v5 0/5] can: bxcan: add support for ST bxCAN controller Date: Mon, 17 Oct 2022 18:42:26 +0200 Message-Id: <20221017164231.4192699-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ekoyXht2; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The series adds support for the basic extended CAN controller (bxCAN) found in many low- to middle-end STM32 SoCs. The driver design (one core module and one driver module) was inspired by other ST drivers (e. g. drivers/iio/adc/stm32-adc.c, drivers/iio/adc/stm32-adc-core.c) where device instances share resources. The shared resources functions are implemented in the core module, the device driver in a separate module. The driver has been tested on the stm32f469i-discovery board with a kernel version 5.19.0-rc2 in loopback + silent mode: ip link set can0 type can bitrate 125000 loopback on listen-only on ip link set up can0 candump can0 -L & cansend can0 300#AC.AB.AD.AE.75.49.AD.D1 For uboot and kernel compilation, as well as for rootfs creation I used buildroot: make stm32f469_disco_sd_defconfig make but I had to patch can-utils and busybox as can-utils and iproute are not compiled for MMU-less microcotrollers. In the case of can-utils, replacing the calls to fork() with vfork(), I was able to compile the package with working candump and cansend applications, while in the case of iproute, I ran into more than one problem and finally I decided to extend busybox's ip link command for CAN-type devices. I'm still wondering if it was really necessary, but this way I was able to test the driver. Changes in v5: - Add Rob Herring's Acked-by tag. - Add Rob Herring's Reviewed-by tag. - Put static in front of bxcan_enable_filters() definition. Changes in v4: - Remove "st,stm32f4-bxcan-core" compatible. In this way the can nodes (compatible "st,stm32f4-bxcan") are no longer children of a parent node with compatible "st,stm32f4-bxcan-core". - Add the "st,gcan" property (global can memory) to can nodes which references a "syscon" node containing the shared clock and memory addresses. - Replace the node can@40006400 (compatible "st,stm32f4-bxcan-core") with the gcan@40006600 node ("sysnode" compatible). The gcan node contains clocks and memory addresses shared by the two can nodes of which it's no longer the parent. - Add to can nodes the "st,gcan" property (global can memory) which references the gcan@40006600 node ("sysnode compatibble). - Add "dt-bindings: arm: stm32: add compatible for syscon gcan node" patch. - Drop the core driver. Thus bxcan-drv.c has been renamed to bxcan.c and moved to the drivers/net/can folder. The drivers/net/can/bxcan directory has therefore been removed. - Use the regmap_*() functions to access the shared memory registers. - Use spinlock to protect bxcan_rmw(). - Use 1 space, instead of tabs, in the macros definition. - Drop clock ref-counting. - Drop unused code. - Drop the _SHIFT macros and use FIELD_GET()/FIELD_PREP() directly. - Add BXCAN_ prefix to lec error codes. - Add the macro BXCAN_RX_MB_NUM. - Enable time triggered mode and use can_rx_offload(). - Use readx_poll_timeout() in function with timeouts. - Loop from tail to head in bxcan_tx_isr(). - Check bits of tsr register instead of pkts variable in bxcan_tx_isr(). - Don't return from bxcan_handle_state_change() if skb/cf are NULL. - Enable/disable the generation of the bus error interrupt depending on can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING. - Don't return from bxcan_handle_bus_err() if skb is NULL. - Drop statistics updating from bxcan_handle_bus_err(). - Add an empty line in front of 'return IRQ_HANDLED;' - Rename bxcan_start() to bxcan_chip_start(). - Rename bxcan_stop() to bxcan_chip_stop(). - Disable all IRQs in bxcan_chip_stop(). - Rename bxcan_close() to bxcan_ndo_stop(). - Use writel instead of bxcan_rmw() to update the dlc register. Changes in v3: - Remove 'Dario Binacchi ' SOB. - Add description to the parent of the two child nodes. - Move "patterProperties:" after "properties: in top level before "required". - Add "clocks" to the "required:" list of the child nodes. - Remove 'Dario Binacchi ' SOB. - Add "clocks" to can@0 node. - Remove 'Dario Binacchi ' SOB. - Remove a blank line. - Remove 'Dario Binacchi ' SOB. - Fix the documentation file path in the MAINTAINERS entry. - Do not increment the "stats->rx_bytes" if the frame is remote. - Remove pr_debug() call from bxcan_rmw(). Changes in v2: - Change the file name into 'st,stm32-bxcan-core.yaml'. - Rename compatibles: - st,stm32-bxcan-core -> st,stm32f4-bxcan-core - st,stm32-bxcan -> st,stm32f4-bxcan - Rename master property to st,can-master. - Remove the status property from the example. - Put the node child properties as required. - Remove a blank line. - Fix sparse errors. - Create a MAINTAINERS entry. - Remove the print of the registers address. - Remove the volatile keyword from bxcan_rmw(). - Use tx ring algorithm to manage tx mailboxes. - Use can_{get|put}_echo_skb(). - Update DT properties. Dario Binacchi (5): dt-bindings: arm: stm32: add compatible for syscon gcan node dt-bindings: net: can: add STM32 bxcan DT bindings ARM: dts: stm32: add CAN support on stm32f429 ARM: dts: stm32: add pin map for CAN controller on stm32f4 can: bxcan: add support for ST bxCAN controller .../bindings/arm/stm32/st,stm32-syscon.yaml | 2 + .../bindings/net/can/st,stm32-bxcan.yaml | 83 ++ MAINTAINERS | 7 + arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 30 + arch/arm/boot/dts/stm32f429.dtsi | 29 + drivers/net/can/Kconfig | 12 + drivers/net/can/Makefile | 1 + drivers/net/can/bxcan.c | 1110 +++++++++++++++++ 8 files changed, 1274 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/can/st,stm32-bxcan.yaml create mode 100644 drivers/net/can/bxcan.c