From patchwork Sun Nov 13 18:13:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2490 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 75D9340F5A for ; Sun, 13 Nov 2022 19:13:32 +0100 (CET) Received: by mail-ed1-f70.google.com with SMTP id z15-20020a05640240cf00b00461b253c220sf6763705edb.3 for ; Sun, 13 Nov 2022 10:13:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668363212; cv=pass; d=google.com; s=arc-20160816; b=PO7PMmeo0nhrW5UA2cAKil05YjDiB2j65W7NU812hMLM2Y3oH8ZnOjDHT9NJq7JaOi jjYofZgJw3y6GSbGJ1tvxNEd9QWftZlNW0GgI/ANk04FVpdY2ioJ9R2ZsljqUa/rGUvN PrFtGwH2b7Ui7eBfdJMiau0sk4ik8PMaYFm25bTugUlAUXSHUoL5iVRQ7EDXyLaoKJda cXn2mvPEf5mvPpLuS8HBkt2KzTy3JOwKlvShyxVquqqIhxwRCI/WBsej1zNg7+SqdOMd WJm15am/NXlUqfWtYRNUkSLMbhIPnFKN32zo3MSRMPaAzesX51IyBxoDDOBleJJJsQal W9IA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=abUiCE3Ig29sMAIqpHcYRuhlNjwGrfKdokoTa2wxqXw=; b=zuxfFxZMaXNQlXRRxLgZkH7POrv5j4CGGuVvIoteZu9QzKZ9EeRFlTE2rnslUS/swU o9hhWlkedPpIXHuKrBQnGOkOyzWtJ8k4H25Auyp0gjMX7B8wZ1Unxafs6FJ8RiQxls8X Q0aNGxssAD6joMNOMFBahFRMiTWmrinxAJlXL/aaammzmbRqx4c+JJ2vf7tj1PBd+tXK HDbDC8ELX1Kax8p/Zl8F8TOq7EhIAItLFXmiIXRNsHDkaZxwJpvT5wjnUTPa3mRRwd9s GjZNzL5+WROMbIHmZciKWz775xP8Sii8iFUhV85Eh2ziX9QE599lWX8eZxkoEb5YA3yn M5Ew== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=rQYDlsQD; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=abUiCE3Ig29sMAIqpHcYRuhlNjwGrfKdokoTa2wxqXw=; b=fDtixT3k82N52le3/6waT51//oCQaeqquz9UxcUkrL2rmGA7DLaBbo/SXUr46vrgdI ooE+KHZVSECyI31uKfn3wVQaDzqHVVORlnCYYuGkvE8q9fhBcgRN4dvQyV1f3qrZbZ52 nzxYz1E/I13V5J20y0nEFo1c7lQ7OCZodF3PU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=abUiCE3Ig29sMAIqpHcYRuhlNjwGrfKdokoTa2wxqXw=; b=Xr8PZOBsb2IAPJwynhxMwTSja2j5DgcwRh4Lrr3ZFiESfOvnyZsNSqtvpF1cT9w44z euPjPJ2OaChCSg/hNwA1LWzlLDsDg/fJKGK8RxzV2dAefrFmDozpUytDBv1Ms9rMWaM8 ytDZhVPgOsOY5GYLh6g+NGmkF7GfxM6wBlbQgpF1WSwR+a15lnVkxjUjvntMvRhH9o51 8ajsbEIwmGFxln1rLAe2kbGgD4U9rTJStuPxaA2bufYoeeJrvBSRAZ0H99g/uIrSHu4I hpQzQZVsS61EWDoGhsWnN+TmQRegRvuogSxAcIeHhi9U5ZwcfW+CRZuFW3QBNLAC1SCr BUCQ== X-Gm-Message-State: ANoB5pnx7P0OcHGbXpieugTNhwB3Vy5AfQ59ouo9zZn60XiHk6u6sY0v CnrBR/QHGVfz+S5bHPVNkOdiG/tu X-Google-Smtp-Source: AA0mqf4JmpGfA9zrn5n2E33hL9RhExpxieEmrGgID+aNr4Od7SXRR1p88lIW2cYbm9YPFPB/BMLIMw== X-Received: by 2002:aa7:c2c4:0:b0:459:1788:5e49 with SMTP id m4-20020aa7c2c4000000b0045917885e49mr8632167edp.321.1668363212306; Sun, 13 Nov 2022 10:13:32 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:906:3fce:b0:7ae:83f4:3bed with SMTP id k14-20020a1709063fce00b007ae83f43bedls5017106ejj.2.-pod-prod-gmail; Sun, 13 Nov 2022 10:13:31 -0800 (PST) X-Received: by 2002:a17:907:8e92:b0:7ad:a34f:1efe with SMTP id tx18-20020a1709078e9200b007ada34f1efemr8043328ejc.350.1668363211169; Sun, 13 Nov 2022 10:13:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668363211; cv=none; d=google.com; s=arc-20160816; b=W02DqOKD2zTgtSY9CNCdTnLXPJtLCBIntgjh+taE8GQN0uz8QqsHrRGcSn36+MaDGY 331mINk0TTGRDsv1BtCrZqOO6hPLx6EWnj6YOukGeFQgQBaxSsVoDMpDlUn8PghiH4ic TwV8/GKEToUH33zih9q/fJe1HvAfnXILQyd309eSpNYxWjDvLS+UdoIEwJnYkkwlRDoR eFzV1QyWHZoMWI9xYUOGqm9HfYKwbKSS8sgi30tbE0YHRx4sLotCsIqA2mTP26Oeu5Dk iaVlAdJ+oaYcUwvLi1PGZTIopCHJhBOBE+PTO0nKnkBHooYV/TE5tGbNJMW/+rd8z066 m5dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=xDO3sMF/hJIpyc2siGnZVm8MMtmhdSexdGimiQU1euY=; b=b+WuBPZnL8B1Lk43I/NhderuxUu6Oz8YASZOgIlWSZ9YQL4b7lmX4z5s0Dw10XM0rs Jw9PyvU86JLhs2hx+IJbF1T1BPIzxf6dLZoZtHxF76MNkZBnpXfg4TDWehdV4sIMwI/D aHm39fKYF3cLbhoLDTQT03yK7ugObj40G3xMOICtaLsAXjhVJGuxnNlDSwLmdWAXgzbU ls3+0RofJVVSQgHrUHopfEPLMCPHNbYE5jOu39wSM7+wP9RQ26TT+jIxS2BbueJjEGPs Dq2pw5Ol47OGND4ku7fSHCLsCRywdSjyzlf3YQ/sU4UaNde3FlQj9rJHy6bnRQZGtbzc UI/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=rQYDlsQD; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id g12-20020a170906c18c00b007a8de84ce39sor2985687ejz.40.2022.11.13.10.13.31 for (Google Transport Security); Sun, 13 Nov 2022 10:13:31 -0800 (PST) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:906:3e43:b0:78d:a154:ae with SMTP id t3-20020a1709063e4300b0078da15400aemr7649346eji.259.1668363210865; Sun, 13 Nov 2022 10:13:30 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-40-103-33.business.telecomitalia.it. [79.40.103.33]) by smtp.gmail.com with ESMTPSA id iy6-20020a170907818600b0078de26f66b9sm3225487ejc.114.2022.11.13.10.13.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Nov 2022 10:13:30 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Marc Kleine-Budde , Rob Herring , Amarula patchwork , michael@amarulasolutions.com, Vincent Mailhol , Alexandre Torgue , Dario Binacchi , Christophe Roullier , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Krzysztof Kozlowski , Maxime Coquelin , Paolo Abeni , Rob Herring , Wolfgang Grandegger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Subject: [RESEND RFC PATCH v5 0/5] can: bxcan: add support for ST bxCAN controller Date: Sun, 13 Nov 2022 19:13:17 +0100 Message-Id: <20221113181322.1627084-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=rQYDlsQD; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The series adds support for the basic extended CAN controller (bxCAN) found in many low- to middle-end STM32 SoCs. The driver design (one core module and one driver module) was inspired by other ST drivers (e. g. drivers/iio/adc/stm32-adc.c, drivers/iio/adc/stm32-adc-core.c) where device instances share resources. The shared resources functions are implemented in the core module, the device driver in a separate module. The driver has been tested on the stm32f469i-discovery board with a kernel version 5.19.0-rc2 in loopback + silent mode: ip link set can0 type can bitrate 125000 loopback on listen-only on ip link set up can0 candump can0 -L & cansend can0 300#AC.AB.AD.AE.75.49.AD.D1 For uboot and kernel compilation, as well as for rootfs creation I used buildroot: make stm32f469_disco_sd_defconfig make but I had to patch can-utils and busybox as can-utils and iproute are not compiled for MMU-less microcotrollers. In the case of can-utils, replacing the calls to fork() with vfork(), I was able to compile the package with working candump and cansend applications, while in the case of iproute, I ran into more than one problem and finally I decided to extend busybox's ip link command for CAN-type devices. I'm still wondering if it was really necessary, but this way I was able to test the driver. Changes in v5: - Add Rob Herring's Acked-by tag. - Add Rob Herring's Reviewed-by tag. - Put static in front of bxcan_enable_filters() definition. Changes in v4: - Remove "st,stm32f4-bxcan-core" compatible. In this way the can nodes (compatible "st,stm32f4-bxcan") are no longer children of a parent node with compatible "st,stm32f4-bxcan-core". - Add the "st,gcan" property (global can memory) to can nodes which references a "syscon" node containing the shared clock and memory addresses. - Replace the node can@40006400 (compatible "st,stm32f4-bxcan-core") with the gcan@40006600 node ("sysnode" compatible). The gcan node contains clocks and memory addresses shared by the two can nodes of which it's no longer the parent. - Add to can nodes the "st,gcan" property (global can memory) which references the gcan@40006600 node ("sysnode compatibble). - Add "dt-bindings: arm: stm32: add compatible for syscon gcan node" patch. - Drop the core driver. Thus bxcan-drv.c has been renamed to bxcan.c and moved to the drivers/net/can folder. The drivers/net/can/bxcan directory has therefore been removed. - Use the regmap_*() functions to access the shared memory registers. - Use spinlock to protect bxcan_rmw(). - Use 1 space, instead of tabs, in the macros definition. - Drop clock ref-counting. - Drop unused code. - Drop the _SHIFT macros and use FIELD_GET()/FIELD_PREP() directly. - Add BXCAN_ prefix to lec error codes. - Add the macro BXCAN_RX_MB_NUM. - Enable time triggered mode and use can_rx_offload(). - Use readx_poll_timeout() in function with timeouts. - Loop from tail to head in bxcan_tx_isr(). - Check bits of tsr register instead of pkts variable in bxcan_tx_isr(). - Don't return from bxcan_handle_state_change() if skb/cf are NULL. - Enable/disable the generation of the bus error interrupt depending on can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING. - Don't return from bxcan_handle_bus_err() if skb is NULL. - Drop statistics updating from bxcan_handle_bus_err(). - Add an empty line in front of 'return IRQ_HANDLED;' - Rename bxcan_start() to bxcan_chip_start(). - Rename bxcan_stop() to bxcan_chip_stop(). - Disable all IRQs in bxcan_chip_stop(). - Rename bxcan_close() to bxcan_ndo_stop(). - Use writel instead of bxcan_rmw() to update the dlc register. Changes in v3: - Remove 'Dario Binacchi ' SOB. - Add description to the parent of the two child nodes. - Move "patterProperties:" after "properties: in top level before "required". - Add "clocks" to the "required:" list of the child nodes. - Remove 'Dario Binacchi ' SOB. - Add "clocks" to can@0 node. - Remove 'Dario Binacchi ' SOB. - Remove a blank line. - Remove 'Dario Binacchi ' SOB. - Fix the documentation file path in the MAINTAINERS entry. - Do not increment the "stats->rx_bytes" if the frame is remote. - Remove pr_debug() call from bxcan_rmw(). Changes in v2: - Change the file name into 'st,stm32-bxcan-core.yaml'. - Rename compatibles: - st,stm32-bxcan-core -> st,stm32f4-bxcan-core - st,stm32-bxcan -> st,stm32f4-bxcan - Rename master property to st,can-master. - Remove the status property from the example. - Put the node child properties as required. - Remove a blank line. - Fix sparse errors. - Create a MAINTAINERS entry. - Remove the print of the registers address. - Remove the volatile keyword from bxcan_rmw(). - Use tx ring algorithm to manage tx mailboxes. - Use can_{get|put}_echo_skb(). - Update DT properties. Dario Binacchi (5): dt-bindings: arm: stm32: add compatible for syscon gcan node dt-bindings: net: can: add STM32 bxcan DT bindings ARM: dts: stm32: add CAN support on stm32f429 ARM: dts: stm32: add pin map for CAN controller on stm32f4 can: bxcan: add support for ST bxCAN controller .../bindings/arm/stm32/st,stm32-syscon.yaml | 2 + .../bindings/net/can/st,stm32-bxcan.yaml | 83 ++ MAINTAINERS | 7 + arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 30 + arch/arm/boot/dts/stm32f429.dtsi | 29 + drivers/net/can/Kconfig | 12 + drivers/net/can/Makefile | 1 + drivers/net/can/bxcan.c | 1110 +++++++++++++++++ 8 files changed, 1274 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/can/st,stm32-bxcan.yaml create mode 100644 drivers/net/can/bxcan.c