From patchwork Sun Jan 8 16:25:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2614 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 8F4103F0CC for ; Sun, 8 Jan 2023 17:26:00 +0100 (CET) Received: by mail-ed1-f70.google.com with SMTP id c12-20020a05640227cc00b004853521ef55sf3917518ede.8 for ; Sun, 08 Jan 2023 08:26:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1673195160; cv=pass; d=google.com; s=arc-20160816; b=NwMvl6zCZ8nzs0STer5QEwWhAuAySfnlBcD3B/rwVz1FtNqV0ZEynVkXy8Jp/J03bL LZqxOTFb2MPXsmGFrHQ4ZyCFyeDmDuoSf5MrWNFxbW9+dqKdr44DIweXmKiRqKap0yZn qSkIoOOk3aHnbTiduuD+QUoGAAvZlt+dMoiOqMHHpN2Gdk9YlbgOOYa/gyEzurv6MMVt NbrAh+1LESL2IiJe4uqNtoW+fEbTZPDSUOxA/jRZgTiMFo751QIpvB9GYkokffH+ofhV 63HDbQ6oI+sYZyN8QGF9OglgINdAp2nPlw61IYlganYTwEhRpqJQC29PPRYttRdsipFy bqiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=abUiCE3Ig29sMAIqpHcYRuhlNjwGrfKdokoTa2wxqXw=; b=bPyxB3g0ys1Mg9HHLVRU0Ls8B2ohnWnr5QjLHKcDQFET/s8MJu5TC9G2kpFyVt/xvk PAY0PiX6BcJ26B+Fg2+NtjUewbHMbCMZwLqrYxpfAgNuTW1E/tiHQtRkrBFLyiijF+12 sqGX2TD0OurZxUNiY4JLI9aH4fWLNOeWasM8HqyndwXQ+GJ6EAIEYzRQPbQeChnGxGOo cHo0ZbMhU/CkMYnMoEXCiAwctOTqu8eEPDVRUnz11ZLymFXFH9IZGBOoKYuHfBgF/8HV cXfSyaXthjqT0+H/eb8cmpeQR/P4arimtBjKnO48fiNHzTx3c2f8S4VINId793YNmQer nVsw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Qm58Zj7W; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=abUiCE3Ig29sMAIqpHcYRuhlNjwGrfKdokoTa2wxqXw=; b=VRetgX4ag0JNcDMsrN4gALUM9QKvUn+5fbZOCy3Q4KJu8s2MjfjQ0UN2XDWof37c2L cfiBzEVR1M9jvugsJOM2YkJN1mIo/T/CED8OG943atRf026yRaHdYjzZsS5wdT/GjIAH O99JlZ49ezlV9HJrJe0ON0b/LC8kKhXd8sdpU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=abUiCE3Ig29sMAIqpHcYRuhlNjwGrfKdokoTa2wxqXw=; b=dAODyVesYHaiun8ZpIuZz1dRe45NpyqAx8Kkjho/930fxeZph30I4leWEsGDfrTF+n sscdd7bgmuUFWIAAw6ps51czWTQe7njrt+tmPFpH/Z3gnC5DuzYF9Qth4m8FNzH/9nef UaOOGApRE/9CHaR9lJoprilp1IrdRyDkglTC9x+lcIO3jl0mB8WwHFWbGkqGFymwvMDy WpVUI4YsLg0GfQO+YElSTOqn7RJBaN5iKM8Gat+s9SqdPbRL26eX9Dy2w31QS5p8Diai GoZD94m2++Xb9urPZ0jvtqPTHE26wmQAnkHmkBvVPnZ4JPlUEmki3P3xvR6mxhBQVaLi CqwQ== X-Gm-Message-State: AFqh2kpyp9rEX0jP6y37GbBU1LXAe+GfvOS15IMjItEIvYlHBup+zniG h1SpnNbBPwctB1T9F+zE2TfXSYRG X-Google-Smtp-Source: AMrXdXuKf7vftK225jCnCjRZTchMGqGcFZjgY+gKrXwjvjEUQug+XDBq4dEQAzdtWWzcZhfayMEs4w== X-Received: by 2002:aa7:de08:0:b0:468:4cd4:f133 with SMTP id h8-20020aa7de08000000b004684cd4f133mr7995091edv.18.1673195160334; Sun, 08 Jan 2023 08:26:00 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:6402:5213:b0:43d:b3c4:cd21 with SMTP id s19-20020a056402521300b0043db3c4cd21ls2237230edd.2.-pod-prod-gmail; Sun, 08 Jan 2023 08:25:59 -0800 (PST) X-Received: by 2002:a05:6402:d71:b0:498:5cfe:da81 with SMTP id ec49-20020a0564020d7100b004985cfeda81mr5069881edb.3.1673195159190; Sun, 08 Jan 2023 08:25:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673195159; cv=none; d=google.com; s=arc-20160816; b=Zx73C36CBS6heg/wi6yJzTJg2M89yZ7wQUkakWXid7MOLWt2JSm4U5719ftR0KxlXx KNhBHM3ClJOm281zUaAfMfBxuyp8kVk8CMAlkYgC9gPueUMEYcbCgnNUCzXqgBcav9u/ X+/arvQ3IP51Wt2HtYTB98pfKzwCI4G8Rc7PfpGjomas0wVryT7AoEuvpyRecYcAjvzl Z68/60TjXQBewSRZzk8OvR7MQVXtNmNNpki/IGLAG4vGuE5xLtOPjU305EetaJ2xKPlI 77E3ZQ1pJw3CVqU1dDZyFVxbJNWAqcuAczIFqGa0FeYktOeprjS21ZmQX5AX6rYgDD2Y n2sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=xDO3sMF/hJIpyc2siGnZVm8MMtmhdSexdGimiQU1euY=; b=TpRMhKLp1kHoYBPrNlxLtflUlYXmQzQc+ry4Pgpryj3GMVd+UqCc/sdugvbNEguqGw /UPDX6oYDDylalyqf16jSwYX8gaLn+yZBteVxCu+BadrB5XHggTgb0Y68dRGXXZKTqHC Wm5l2XiXPJGHqkli+5os5mMjPHO8C5A8PO3cHSj93ocfytiYhvxOtDeAnywXNfLPDoMS sz5J+MA7D/sTALC5q5h9HoE3Qe7TARbmo13APdVy09X1BliwpoPMjrTkdqvLV+YCBzr8 ZoZ27l4Qp2IvI0qom++AAN7YnXwxLa310xd6cBNvjfyI6EO5W3MgkyVm96szYhB8PKou hm2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Qm58Zj7W; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id h23-20020a1709063c1700b007c0b5ec206csor2466496ejg.90.2023.01.08.08.25.59 for (Google Transport Security); Sun, 08 Jan 2023 08:25:59 -0800 (PST) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:906:9f07:b0:7ec:27d7:1838 with SMTP id fy7-20020a1709069f0700b007ec27d71838mr66763832ejc.22.1673195158895; Sun, 08 Jan 2023 08:25:58 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-80-180-23-57.pool80180.interbusiness.it. [80.180.23.57]) by smtp.gmail.com with ESMTPSA id n3-20020aa7c443000000b00486074b4ce4sm2659614edr.68.2023.01.08.08.25.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Jan 2023 08:25:58 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Vincent Mailhol , Amarula patchwork , Alexandre Torgue , Marc Kleine-Budde , Krzysztof Kozlowski , Rob Herring , michael@amarulasolutions.com, Dario Binacchi , Christophe Roullier , "David S. Miller" , Dmitry Torokhov , Eric Dumazet , Jakub Kicinski , Krzysztof Kozlowski , Mark Brown , Maxime Coquelin , Paolo Abeni , Rob Herring , Stephen Boyd , Viresh Kumar , Wolfgang Grandegger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Subject: [RESEND RFC PATCH v5 0/5] can: bxcan: add support for ST bxCAN controller Date: Sun, 8 Jan 2023 17:25:49 +0100 Message-Id: <20230108162554.8375-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Qm58Zj7W; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The series adds support for the basic extended CAN controller (bxCAN) found in many low- to middle-end STM32 SoCs. The driver design (one core module and one driver module) was inspired by other ST drivers (e. g. drivers/iio/adc/stm32-adc.c, drivers/iio/adc/stm32-adc-core.c) where device instances share resources. The shared resources functions are implemented in the core module, the device driver in a separate module. The driver has been tested on the stm32f469i-discovery board with a kernel version 5.19.0-rc2 in loopback + silent mode: ip link set can0 type can bitrate 125000 loopback on listen-only on ip link set up can0 candump can0 -L & cansend can0 300#AC.AB.AD.AE.75.49.AD.D1 For uboot and kernel compilation, as well as for rootfs creation I used buildroot: make stm32f469_disco_sd_defconfig make but I had to patch can-utils and busybox as can-utils and iproute are not compiled for MMU-less microcotrollers. In the case of can-utils, replacing the calls to fork() with vfork(), I was able to compile the package with working candump and cansend applications, while in the case of iproute, I ran into more than one problem and finally I decided to extend busybox's ip link command for CAN-type devices. I'm still wondering if it was really necessary, but this way I was able to test the driver. Changes in v5: - Add Rob Herring's Acked-by tag. - Add Rob Herring's Reviewed-by tag. - Put static in front of bxcan_enable_filters() definition. Changes in v4: - Remove "st,stm32f4-bxcan-core" compatible. In this way the can nodes (compatible "st,stm32f4-bxcan") are no longer children of a parent node with compatible "st,stm32f4-bxcan-core". - Add the "st,gcan" property (global can memory) to can nodes which references a "syscon" node containing the shared clock and memory addresses. - Replace the node can@40006400 (compatible "st,stm32f4-bxcan-core") with the gcan@40006600 node ("sysnode" compatible). The gcan node contains clocks and memory addresses shared by the two can nodes of which it's no longer the parent. - Add to can nodes the "st,gcan" property (global can memory) which references the gcan@40006600 node ("sysnode compatibble). - Add "dt-bindings: arm: stm32: add compatible for syscon gcan node" patch. - Drop the core driver. Thus bxcan-drv.c has been renamed to bxcan.c and moved to the drivers/net/can folder. The drivers/net/can/bxcan directory has therefore been removed. - Use the regmap_*() functions to access the shared memory registers. - Use spinlock to protect bxcan_rmw(). - Use 1 space, instead of tabs, in the macros definition. - Drop clock ref-counting. - Drop unused code. - Drop the _SHIFT macros and use FIELD_GET()/FIELD_PREP() directly. - Add BXCAN_ prefix to lec error codes. - Add the macro BXCAN_RX_MB_NUM. - Enable time triggered mode and use can_rx_offload(). - Use readx_poll_timeout() in function with timeouts. - Loop from tail to head in bxcan_tx_isr(). - Check bits of tsr register instead of pkts variable in bxcan_tx_isr(). - Don't return from bxcan_handle_state_change() if skb/cf are NULL. - Enable/disable the generation of the bus error interrupt depending on can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING. - Don't return from bxcan_handle_bus_err() if skb is NULL. - Drop statistics updating from bxcan_handle_bus_err(). - Add an empty line in front of 'return IRQ_HANDLED;' - Rename bxcan_start() to bxcan_chip_start(). - Rename bxcan_stop() to bxcan_chip_stop(). - Disable all IRQs in bxcan_chip_stop(). - Rename bxcan_close() to bxcan_ndo_stop(). - Use writel instead of bxcan_rmw() to update the dlc register. Changes in v3: - Remove 'Dario Binacchi ' SOB. - Add description to the parent of the two child nodes. - Move "patterProperties:" after "properties: in top level before "required". - Add "clocks" to the "required:" list of the child nodes. - Remove 'Dario Binacchi ' SOB. - Add "clocks" to can@0 node. - Remove 'Dario Binacchi ' SOB. - Remove a blank line. - Remove 'Dario Binacchi ' SOB. - Fix the documentation file path in the MAINTAINERS entry. - Do not increment the "stats->rx_bytes" if the frame is remote. - Remove pr_debug() call from bxcan_rmw(). Changes in v2: - Change the file name into 'st,stm32-bxcan-core.yaml'. - Rename compatibles: - st,stm32-bxcan-core -> st,stm32f4-bxcan-core - st,stm32-bxcan -> st,stm32f4-bxcan - Rename master property to st,can-master. - Remove the status property from the example. - Put the node child properties as required. - Remove a blank line. - Fix sparse errors. - Create a MAINTAINERS entry. - Remove the print of the registers address. - Remove the volatile keyword from bxcan_rmw(). - Use tx ring algorithm to manage tx mailboxes. - Use can_{get|put}_echo_skb(). - Update DT properties. Dario Binacchi (5): dt-bindings: arm: stm32: add compatible for syscon gcan node dt-bindings: net: can: add STM32 bxcan DT bindings ARM: dts: stm32: add CAN support on stm32f429 ARM: dts: stm32: add pin map for CAN controller on stm32f4 can: bxcan: add support for ST bxCAN controller .../bindings/arm/stm32/st,stm32-syscon.yaml | 2 + .../bindings/net/can/st,stm32-bxcan.yaml | 83 ++ MAINTAINERS | 7 + arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 30 + arch/arm/boot/dts/stm32f429.dtsi | 29 + drivers/net/can/Kconfig | 12 + drivers/net/can/Makefile | 1 + drivers/net/can/bxcan.c | 1110 +++++++++++++++++ 8 files changed, 1274 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/can/st,stm32-bxcan.yaml create mode 100644 drivers/net/can/bxcan.c