From patchwork Mon Jan 9 18:23:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2620 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id E350C3F046 for ; Mon, 9 Jan 2023 19:24:02 +0100 (CET) Received: by mail-ed1-f70.google.com with SMTP id x13-20020a05640226cd00b0047ac11c9774sf5836445edd.17 for ; Mon, 09 Jan 2023 10:24:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1673288642; cv=pass; d=google.com; s=arc-20160816; b=FIssbyLBuLHYAev8ambdobL3w9mrfxjogFzdX/pg9XKqY4EDv6mhCOMyuDfccJgDws f7Z5D5W9iSZ7Ra0KuHLl03yRySHR95CLFP5vri4ViJkBFdEzroZTR7U4n2cuEh4ounjs XlNeR2Y9/JPHXlpbK7d5zCoUTNEEdGKDaDAjZswOdzsNHCqaOYLRJQtVkuDeS2C9qkpj ZJ+CLNpsHoeJkMo9FiEh/e2pZEbgKO+FEoc9hXPY0Jk6Z1EdYifOG7x24x+RspLhfsnz xM87nZ1+V4OHs+oNJlZRfFf2IYPVA1I1utD+FEHhXa0Oi5j2eRlMlGYd+maBhpQDllpX V9Mw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=3SxiJQnGG5jogsJwgPHmmNjWRcy3pJv34RHUWDpgJos=; b=oAYXv4d2XWRGw2V15olFI1V3Iw4wamt4FP4dmmhqygbpTNsXqYYZvXSoXuL+BF3l9K Vhi2sidVGm+rpdZoEA9M7LbiC1rIj+fGw25evbqgkRNITOwDxtC6NzVc29Z6X4Wd8vMB CXoSXXdo+UsXnCD+3ZZ4bOJUvXiS3SfkbC56xRb6FeNreRU/zK56yZjXI7gxeRaFan2m F6K5RJrpE8dlEFaDngtbe1sOqcdjCybSDKqKtB2IDcKNhaANFHlMF5bY51DB6Ug7xN1K tkR1lyavPBTaUUVzGIF7gQ1CqQLK+iGniwaA2zFai86Sjp/QlQMtZNcd3svEbagVC/V7 Rk9A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=MA6+LFdN; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=3SxiJQnGG5jogsJwgPHmmNjWRcy3pJv34RHUWDpgJos=; b=nDpkyDlX+jIFg7dt7CigJfvku14xrMpddEjPEvEKYUg6qQ091PFte0jMNvbtucay9S J28B+m9X3Iny70O8Z1L4JOFdNEjylUM6xWu+FZSbGAlv75oVBiWv2TGQWNFTqOJdV7bx NxJ6WYbl/4PMHGbh7SNl1tj+CXygGxfrhkJ4w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3SxiJQnGG5jogsJwgPHmmNjWRcy3pJv34RHUWDpgJos=; b=MfTWdqK38hQ/w7XO85SyvgQbfjG8JXqVQDmFwQFLRDSA695Snd9osSKwqMi+zrC35m sfgQJP+6KvjqoVre/g0E1cMWiPDyPeHT7heC+hJ9PEjNGGVzWCUrGuF8PM0GbPM811wh +AY9n1ESTZfjKi/Up95pQgRHW1JOU/9eZCI0nucbziicvkb5QjQOHQh4KdnwiXprCj2M kPcaA8zVTGPrgH0tNCD2MqBM+3Y6JzzmLcWTsJ0ZssCiz+hFL/+O7aQ9cC9qrIhgAmHR +in9kkvzsardDEXTXPGejpVQjj89RlWDx7sZdGJM5LhzqphpmLhtCnmZyJXlQyqvq4No wSrg== X-Gm-Message-State: AFqh2kqHkQe1NWpg9p4digwLjgmuNHSqeXMvwe+ch2uLWp12/p9HQAgW KKrA3zDvXEovasBhVrtnDn9Dpj7t X-Google-Smtp-Source: AMrXdXt0Vp1OvL5LLCO+URe3i+qmhSQvsm/xoP01UK8Ou5bkeyPtHoYAMO4FJUdG1TCH+BXb5ghLWQ== X-Received: by 2002:a17:906:3a85:b0:7c0:b56a:eadf with SMTP id y5-20020a1709063a8500b007c0b56aeadfmr6980066ejd.271.1673288642524; Mon, 09 Jan 2023 10:24:02 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:906:3582:b0:7c1:381b:406d with SMTP id o2-20020a170906358200b007c1381b406dls3426800ejb.11.-pod-prod-gmail; Mon, 09 Jan 2023 10:24:01 -0800 (PST) X-Received: by 2002:a17:906:309a:b0:819:7d8f:9684 with SMTP id 26-20020a170906309a00b008197d8f9684mr60154600ejv.72.1673288641354; Mon, 09 Jan 2023 10:24:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673288641; cv=none; d=google.com; s=arc-20160816; b=RlolFRVXM7SKS9bNEIojtegyyCa1YTsNiNfmV+T8rVnGsQ5svlZcW598ftPnWBsjIb axAt3XogGXMMGXPa2Xu39uFbKWayoYicKn9rmnpkHuHnbegt5BKvIEqOJKHoy5I0vNSH 9Bdt+mbKG0xO8aERJrNEYGrlwes6IVOC1XMbtRMAQEBTmoZKnEGrq+COEHTZMvJ0abaB 4e2QTM9OqXdkmbsTm8LOSl0UvYrv6ELAQ0TyqtpXP3x6VDChR/WocW5UHrAtJLYwtwwY QGDnt/6hIJe7zVgBAFjYmSXsJqg/YwnFXWtf6D2ox248XSp0e/FJPMijNRGC7bH9105I FuKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=XNqVIeX8ztDc7af6unR/+kFDfze2ld9osq5b677DCcw=; b=Rt2BB/xdMw8TTZEWjyq7cFrZLqHacTUmH08ot+mgtv0TcMzoqDHVKpZfy+CJgZifp7 ny1y2RVZ4XwpH/o0YizaBjvhpBNhoki1grsD3du64vgFjd47XPf7qg6LwoSPnCfIMhXO HxgPgEPBuJh59k8eM2VqxlPY+yJkntaqpjRm/l/8G5Ih/+9tnEYyuhtzQTqcKrMg/RiL NOkGRMsGkUP9uBlYit1Dw9ey0T7hfUOTLxFxIs2nFQ/QTsc7XTwpTN3OlqWwZQqJQe+q u+yjJBxSxKwOvLJwklDQbKNrZL6EjBNl+ZUIyrdTljyAuwzHfno9l+1TjmfFKi/u5WeB qMOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=MA6+LFdN; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id y11-20020a1709060a8b00b0078df295268esor3415197ejf.87.2023.01.09.10.24.01 for (Google Transport Security); Mon, 09 Jan 2023 10:24:01 -0800 (PST) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:907:c606:b0:84d:456f:91b7 with SMTP id ud6-20020a170907c60600b0084d456f91b7mr5002026ejc.43.1673288640952; Mon, 09 Jan 2023 10:24:00 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-80-180-23-57.retail.telecomitalia.it. [80.180.23.57]) by smtp.gmail.com with ESMTPSA id kz22-20020a17090777d600b007c1633cea13sm4093653ejc.12.2023.01.09.10.23.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 10:24:00 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Vincent Mailhol , Amarula patchwork , Marc Kleine-Budde , Alexandre Torgue , michael@amarulasolutions.com, Krzysztof Kozlowski , Rob Herring , Dario Binacchi , Alexandre Belloni , Christophe Roullier , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Krzysztof Kozlowski , Mark Brown , Matti Vaittinen , Maxime Coquelin , Paolo Abeni , Rob Herring , Viresh Kumar , Wolfgang Grandegger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Subject: [PATCH v6 0/5] can: bxcan: add support for ST bxCAN controller Date: Mon, 9 Jan 2023 19:23:50 +0100 Message-Id: <20230109182356.141849-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=MA6+LFdN; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The series adds support for the basic extended CAN controller (bxCAN) found in many low- to middle-end STM32 SoCs. The driver design (one core module and one driver module) was inspired by other ST drivers (e. g. drivers/iio/adc/stm32-adc.c, drivers/iio/adc/stm32-adc-core.c) where device instances share resources. The shared resources functions are implemented in the core module, the device driver in a separate module. The driver has been tested on the stm32f469i-discovery board with a kernel version 5.19.0-rc2 in loopback + silent mode: ip link set can0 type can bitrate 125000 loopback on listen-only on ip link set up can0 candump can0 -L & cansend can0 300#AC.AB.AD.AE.75.49.AD.D1 For uboot and kernel compilation, as well as for rootfs creation I used buildroot: make stm32f469_disco_sd_defconfig make but I had to patch can-utils and busybox as can-utils and iproute are not compiled for MMU-less microcotrollers. In the case of can-utils, replacing the calls to fork() with vfork(), I was able to compile the package with working candump and cansend applications, while in the case of iproute, I ran into more than one problem and finally I decided to extend busybox's ip link command for CAN-type devices. I'm still wondering if it was really necessary, but this way I was able to test the driver. Changes in v6: - move can1 node before gcan to keep ordering by address. Changes in v5: - Add Rob Herring's Acked-by tag. - Add Rob Herring's Reviewed-by tag. - Put static in front of bxcan_enable_filters() definition. Changes in v4: - Remove "st,stm32f4-bxcan-core" compatible. In this way the can nodes (compatible "st,stm32f4-bxcan") are no longer children of a parent node with compatible "st,stm32f4-bxcan-core". - Add the "st,gcan" property (global can memory) to can nodes which references a "syscon" node containing the shared clock and memory addresses. - Replace the node can@40006400 (compatible "st,stm32f4-bxcan-core") with the gcan@40006600 node ("sysnode" compatible). The gcan node contains clocks and memory addresses shared by the two can nodes of which it's no longer the parent. - Add to can nodes the "st,gcan" property (global can memory) which references the gcan@40006600 node ("sysnode compatibble). - Add "dt-bindings: arm: stm32: add compatible for syscon gcan node" patch. - Drop the core driver. Thus bxcan-drv.c has been renamed to bxcan.c and moved to the drivers/net/can folder. The drivers/net/can/bxcan directory has therefore been removed. - Use the regmap_*() functions to access the shared memory registers. - Use spinlock to protect bxcan_rmw(). - Use 1 space, instead of tabs, in the macros definition. - Drop clock ref-counting. - Drop unused code. - Drop the _SHIFT macros and use FIELD_GET()/FIELD_PREP() directly. - Add BXCAN_ prefix to lec error codes. - Add the macro BXCAN_RX_MB_NUM. - Enable time triggered mode and use can_rx_offload(). - Use readx_poll_timeout() in function with timeouts. - Loop from tail to head in bxcan_tx_isr(). - Check bits of tsr register instead of pkts variable in bxcan_tx_isr(). - Don't return from bxcan_handle_state_change() if skb/cf are NULL. - Enable/disable the generation of the bus error interrupt depending on can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING. - Don't return from bxcan_handle_bus_err() if skb is NULL. - Drop statistics updating from bxcan_handle_bus_err(). - Add an empty line in front of 'return IRQ_HANDLED;' - Rename bxcan_start() to bxcan_chip_start(). - Rename bxcan_stop() to bxcan_chip_stop(). - Disable all IRQs in bxcan_chip_stop(). - Rename bxcan_close() to bxcan_ndo_stop(). - Use writel instead of bxcan_rmw() to update the dlc register. Changes in v3: - Remove 'Dario Binacchi ' SOB. - Add description to the parent of the two child nodes. - Move "patterProperties:" after "properties: in top level before "required". - Add "clocks" to the "required:" list of the child nodes. - Remove 'Dario Binacchi ' SOB. - Add "clocks" to can@0 node. - Remove 'Dario Binacchi ' SOB. - Remove a blank line. - Remove 'Dario Binacchi ' SOB. - Fix the documentation file path in the MAINTAINERS entry. - Do not increment the "stats->rx_bytes" if the frame is remote. - Remove pr_debug() call from bxcan_rmw(). Changes in v2: - Change the file name into 'st,stm32-bxcan-core.yaml'. - Rename compatibles: - st,stm32-bxcan-core -> st,stm32f4-bxcan-core - st,stm32-bxcan -> st,stm32f4-bxcan - Rename master property to st,can-master. - Remove the status property from the example. - Put the node child properties as required. - Remove a blank line. - Fix sparse errors. - Create a MAINTAINERS entry. - Remove the print of the registers address. - Remove the volatile keyword from bxcan_rmw(). - Use tx ring algorithm to manage tx mailboxes. - Use can_{get|put}_echo_skb(). - Update DT properties. Dario Binacchi (5): dt-bindings: arm: stm32: add compatible for syscon gcan node dt-bindings: net: can: add STM32 bxcan DT bindings ARM: dts: stm32: add CAN support on stm32f429 ARM: dts: stm32: add pin map for CAN controller on stm32f4 can: bxcan: add support for ST bxCAN controller .../bindings/arm/stm32/st,stm32-syscon.yaml | 2 + .../bindings/net/can/st,stm32-bxcan.yaml | 83 ++ MAINTAINERS | 7 + arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 30 + arch/arm/boot/dts/stm32f429.dtsi | 29 + drivers/net/can/Kconfig | 12 + drivers/net/can/Makefile | 1 + drivers/net/can/bxcan.c | 1110 +++++++++++++++++ 8 files changed, 1274 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/can/st,stm32-bxcan.yaml create mode 100644 drivers/net/can/bxcan.c