From patchwork Mon Jan 16 17:51:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2626 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 5D87D3F1F4 for ; Mon, 16 Jan 2023 18:52:06 +0100 (CET) Received: by mail-ej1-f72.google.com with SMTP id hs18-20020a1709073e9200b007c0f9ac75f9sf19926252ejc.9 for ; Mon, 16 Jan 2023 09:52:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1673891526; cv=pass; d=google.com; s=arc-20160816; b=zqbscdQpZIZLPJ8rQjsLw92Mtj1gKAcuOAS7enrsjSyWmOMFD6KLKka39DzV/gOZcn 4FHH+G16KxX3i/o4IKyErPl6Y3JNtXeuYRA27keHc8/YiciAA4q7v2Yk3LbL2sMG4Q/t +y3cejbYsa+CXfvhV7OHOZ1iqV/g7fgY2Sh0/dhTDNTGExUNWtVt93c7cfo22uPaBR0r Bq+2zThzy0YZW8mM2+Z1g/OwP2FI1n/gtQZOUrU1wJsRw7bQgleyKPdJzJFB+cJOavL4 Na1WOBTJpYq/46nYmZXEWvFo3TOsVldjjDcqOSyU+ybz0eLM24fkcyXKsNFeGK89AHx8 p3eg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=7g3fhpSvzMpbGbm1YBpq1qtmT41ncRGKBEpmv2LEGp4=; b=IvLSwaBnyaE8ZtT77YPR2HnudXkqnCbpIOKg6+RsCFx9/S537DD2qnRlrIALtoyOMe dbmurdfobW5uELe/4DbS68vzR7qHr7wZKqgFBOBQ5+c20eXPUYsDe9LfY86y5SUnqQ72 EWnueFcVaGCZasR2DQvXYWDzxmryI8e9IKV3nww0WFFbLOUxcOs5VMaaZlsoVG2ZUkQB iy3FY++4OOTkvbxIe4ejnyOk31TJSFLmVdf2RJFXGRmm1AmSSzCdXuCBMDl6bwmABl8c 6w+OlsyVS24Cstmbz7xkrgIGjvEJU5TJWZDc39qiU7b13beSiAHnRXBpOT4yXXodoH/A xaQw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Bg4RLtsI; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=7g3fhpSvzMpbGbm1YBpq1qtmT41ncRGKBEpmv2LEGp4=; b=hloEmCp2VTrmJjozCXTfC8Jw9V2TpX5oXcB+dxiInCsZQN+GZBNFwz3oIlGXz7FvN2 0rnsuSxkfxxgKdRQguaL3PUJgRUoLyjFO3A3PgSVMYKh/nWzmbQ3V6kqHQHfNNfflce1 agVE/FmXF1IUgb/HU8XnGHi/s/Zh+BpgI8TnI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7g3fhpSvzMpbGbm1YBpq1qtmT41ncRGKBEpmv2LEGp4=; b=sMP87oLgNUWB8brqfIv9Eb+4skM0xRxXQIq3AJiA0nM5FGXaTz888jPOidxyqKTR0o gimvoGbF7KXxocfj03QYYcEmIYhHS/e855eYWyXAcDIHvntRDkICmTanJvaFO9MbO0KP HZkEIfBaDqAOKr+dBHtLXQFpfH5KXTzVcHJOUXuT2rrlj1T3X5d/ouJ6xbZO5Y3qqdJt MAeMXwaQGpbS4MOc6BZ/af83jOpxQOrpbmt47YEIt+4V4NgNU3RVu/zYZYvn0CBY+wrL 2YKBo7Xz+11OQs499OlyL6UlrOs9TehyaOYLPrEgddguYP6t7Hswr1LcAkyNhDTpD40b VXPg== X-Gm-Message-State: AFqh2kp5YRPTrIxnk3Vrr8F+WFHs2mfUGbg8Geds+bD8eDeyiGzyqU7e bFBtJ/G+1ui0JUP8ZqCPjTmZvuqE X-Google-Smtp-Source: AMrXdXt77A+JVzRr7T98aHSpOSqGx9VOseAFdQ4yBB6ory+xdHvgRChpoCup/8ofZXI7tyy+VKFFMw== X-Received: by 2002:a17:907:9d05:b0:83f:1f64:e7e with SMTP id kt5-20020a1709079d0500b0083f1f640e7emr8785997ejc.292.1673891525998; Mon, 16 Jan 2023 09:52:05 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:906:37cd:b0:7c1:381b:406d with SMTP id o13-20020a17090637cd00b007c1381b406dls7578917ejc.11.-pod-prod-gmail; Mon, 16 Jan 2023 09:52:05 -0800 (PST) X-Received: by 2002:a17:906:63d2:b0:871:818e:6e9 with SMTP id u18-20020a17090663d200b00871818e06e9mr2388546ejk.64.1673891524785; Mon, 16 Jan 2023 09:52:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673891524; cv=none; d=google.com; s=arc-20160816; b=G8+KuahtPBeOBi0WXUy6vLzPVpp9VrjM2tBS76H8ZPi1oRq8WE/9opgElc57ctgopu mbx3MosFWMgybqsKssCXRabEEevuCkv3O9qTCRDH7yxxtMOpRpI+kkm51qK9iBwqi1vX 5NSpgzT+LcKLkwGyeCoTZotDWH1hnkI8L+OdMktocXZIh3Lq7cuPuEXh2niLg6fqqXbB wcRajyT8mhv4SFTQXcKh0f5robR+l6liTkhDrM5SUfZEugonnH5HvefmhhdumYPq/AQK diLhPMFKPof8LRtVch2f9QXap1n8nhan9UOatcWBucQy29yc1UKHVjh9LFoGbtI40M14 Obog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=nmKHBHnPdxu/HZFwVcQ6tfAQn/CQ7f4jjd7l14TU8o8=; b=Eui8G2auW43ZMjEXJdS2P3X4JoTteyIjMypgLFWCblJ9Vz8c16o5c5u2Jk4RE1tRyq pkCyd5xV5ps9TJwSoqaJM6I+5f1hIYXNPJxXQX/aE0E+hJx5Msn/UCC6O6Le/fispkGh lO8cWPyduN+U/0SHfba3w9VhczF1BzFbfdci/SMWiLeuRnKS7v9Ll3ezjGxT71ECnmkq N2cc1QM5rXUR9ax78D3eA+jOrnF4ia/X6Mx/MQbMpdy7+1D1TcGFOgnusuhT9Di4DgYn hqjMqkZdZG8BWqxUzJquO4s+QqbSXhKH8L0gVqtBFaeASzyw2ffuQ6QmtUU8AsxgEfp5 Aqow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Bg4RLtsI; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id l1-20020a50cbc1000000b00469514c691dsor15374070edi.38.2023.01.16.09.52.04 for (Google Transport Security); Mon, 16 Jan 2023 09:52:04 -0800 (PST) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:aa7:cb07:0:b0:45c:b772:5f41 with SMTP id s7-20020aa7cb07000000b0045cb7725f41mr132092edt.6.1673891524533; Mon, 16 Jan 2023 09:52:04 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.. (mob-5-90-75-145.net.vodafone.it. [5.90.75.145]) by smtp.gmail.com with ESMTPSA id fd7-20020a056402388700b00483dd234ac6sm11490723edb.96.2023.01.16.09.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 09:52:04 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Vincent Mailhol , Amarula patchwork , Krzysztof Kozlowski , michael@amarulasolutions.com, Rob Herring , Alexandre Torgue , Marc Kleine-Budde , Dario Binacchi , Alexandre Belloni , Christophe Roullier , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Krzysztof Kozlowski , Maxime Coquelin , Paolo Abeni , Rob Herring , Sebastian Reichel , Stephen Boyd , Wolfgang Grandegger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Subject: [PATCH v7 0/5] can: bxcan: add support for ST bxCAN controller Date: Mon, 16 Jan 2023 18:51:47 +0100 Message-Id: <20230116175152.2839455-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Bg4RLtsI; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The series adds support for the basic extended CAN controller (bxCAN) found in many low- to middle-end STM32 SoCs. The driver design (one core module and one driver module) was inspired by other ST drivers (e. g. drivers/iio/adc/stm32-adc.c, drivers/iio/adc/stm32-adc-core.c) where device instances share resources. The shared resources functions are implemented in the core module, the device driver in a separate module. The driver has been tested on the stm32f469i-discovery board with a kernel version 5.19.0-rc2 in loopback + silent mode: ip link set can0 type can bitrate 125000 loopback on listen-only on ip link set up can0 candump can0 -L & cansend can0 300#AC.AB.AD.AE.75.49.AD.D1 For uboot and kernel compilation, as well as for rootfs creation I used buildroot: make stm32f469_disco_sd_defconfig make but I had to patch can-utils and busybox as can-utils and iproute are not compiled for MMU-less microcotrollers. In the case of can-utils, replacing the calls to fork() with vfork(), I was able to compile the package with working candump and cansend applications, while in the case of iproute, I ran into more than one problem and finally I decided to extend busybox's ip link command for CAN-type devices. I'm still wondering if it was really necessary, but this way I was able to test the driver. Changes in v7: - Add Vincent Mailhol's Reviewed-by tag. - Remove all unused macros for reading/writing the controller registers. - Add CAN_ERR_CNT flag to notify availability of error counter. - Move the "break" before the newline in the switch/case statements. - Print the mnemotechnic instead of the error value in each netdev_err(). - Remove the debug print for timings parameter. - Do not copy the data if CAN_RTR_FLAG is set in bxcan_start_xmit(). - Populate ndev->ethtool_ops with the default timestamp info. Changes in v6: - move can1 node before gcan to keep ordering by address. Changes in v5: - Add Rob Herring's Acked-by tag. - Add Rob Herring's Reviewed-by tag. - Put static in front of bxcan_enable_filters() definition. Changes in v4: - Remove "st,stm32f4-bxcan-core" compatible. In this way the can nodes (compatible "st,stm32f4-bxcan") are no longer children of a parent node with compatible "st,stm32f4-bxcan-core". - Add the "st,gcan" property (global can memory) to can nodes which references a "syscon" node containing the shared clock and memory addresses. - Replace the node can@40006400 (compatible "st,stm32f4-bxcan-core") with the gcan@40006600 node ("sysnode" compatible). The gcan node contains clocks and memory addresses shared by the two can nodes of which it's no longer the parent. - Add to can nodes the "st,gcan" property (global can memory) which references the gcan@40006600 node ("sysnode compatibble). - Add "dt-bindings: arm: stm32: add compatible for syscon gcan node" patch. - Drop the core driver. Thus bxcan-drv.c has been renamed to bxcan.c and moved to the drivers/net/can folder. The drivers/net/can/bxcan directory has therefore been removed. - Use the regmap_*() functions to access the shared memory registers. - Use spinlock to protect bxcan_rmw(). - Use 1 space, instead of tabs, in the macros definition. - Drop clock ref-counting. - Drop unused code. - Drop the _SHIFT macros and use FIELD_GET()/FIELD_PREP() directly. - Add BXCAN_ prefix to lec error codes. - Add the macro BXCAN_RX_MB_NUM. - Enable time triggered mode and use can_rx_offload(). - Use readx_poll_timeout() in function with timeouts. - Loop from tail to head in bxcan_tx_isr(). - Check bits of tsr register instead of pkts variable in bxcan_tx_isr(). - Don't return from bxcan_handle_state_change() if skb/cf are NULL. - Enable/disable the generation of the bus error interrupt depending on can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING. - Don't return from bxcan_handle_bus_err() if skb is NULL. - Drop statistics updating from bxcan_handle_bus_err(). - Add an empty line in front of 'return IRQ_HANDLED;' - Rename bxcan_start() to bxcan_chip_start(). - Rename bxcan_stop() to bxcan_chip_stop(). - Disable all IRQs in bxcan_chip_stop(). - Rename bxcan_close() to bxcan_ndo_stop(). - Use writel instead of bxcan_rmw() to update the dlc register. Changes in v3: - Remove 'Dario Binacchi ' SOB. - Add description to the parent of the two child nodes. - Move "patterProperties:" after "properties: in top level before "required". - Add "clocks" to the "required:" list of the child nodes. - Remove 'Dario Binacchi ' SOB. - Add "clocks" to can@0 node. - Remove 'Dario Binacchi ' SOB. - Remove a blank line. - Remove 'Dario Binacchi ' SOB. - Fix the documentation file path in the MAINTAINERS entry. - Do not increment the "stats->rx_bytes" if the frame is remote. - Remove pr_debug() call from bxcan_rmw(). Changes in v2: - Change the file name into 'st,stm32-bxcan-core.yaml'. - Rename compatibles: - st,stm32-bxcan-core -> st,stm32f4-bxcan-core - st,stm32-bxcan -> st,stm32f4-bxcan - Rename master property to st,can-master. - Remove the status property from the example. - Put the node child properties as required. - Remove a blank line. - Fix sparse errors. - Create a MAINTAINERS entry. - Remove the print of the registers address. - Remove the volatile keyword from bxcan_rmw(). - Use tx ring algorithm to manage tx mailboxes. - Use can_{get|put}_echo_skb(). - Update DT properties. Dario Binacchi (5): dt-bindings: arm: stm32: add compatible for syscon gcan node dt-bindings: net: can: add STM32 bxcan DT bindings ARM: dts: stm32: add CAN support on stm32f429 ARM: dts: stm32: add pin map for CAN controller on stm32f4 can: bxcan: add support for ST bxCAN controller .../bindings/arm/stm32/st,stm32-syscon.yaml | 2 + .../bindings/net/can/st,stm32-bxcan.yaml | 83 ++ MAINTAINERS | 7 + arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 30 + arch/arm/boot/dts/stm32f429.dtsi | 29 + drivers/net/can/Kconfig | 12 + drivers/net/can/Makefile | 1 + drivers/net/can/bxcan.c | 1088 +++++++++++++++++ 8 files changed, 1252 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/can/st,stm32-bxcan.yaml create mode 100644 drivers/net/can/bxcan.c