From patchwork Sun Mar 26 16:03:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2803 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 7BAC83F25A for ; Sun, 26 Mar 2023 18:03:33 +0200 (CEST) Received: by mail-ed1-f69.google.com with SMTP id k30-20020a50ce5e000000b00500544ebfb1sf9039781edj.7 for ; Sun, 26 Mar 2023 09:03:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1679846613; cv=pass; d=google.com; s=arc-20160816; b=ahegg0V4q6BEpzYfsJWZOQI9+BQbShiXAJRDbx2lDxfCRcxMtLuW1o+2cmibUnPPcF FuzH++72QVCCcCffmYFEBkwi5kE2SRsZ9pQSI/eA2WwCOhFumOWzgUZjz3cNuRyC9/cz bFW2WXSHhA9Y8nZdvJRyz/1Jb5APRPwm+NrU55RNjh4HpIEyvRXLKawRF63uFz1wdDrK 741UYdQ6x5ko9M0FxTuoVxtAB0vCPoMKxkuFIlaXOaQ8SGBc5VKWTkL5mvvqeRI48Te5 N0VUctCsAF6PSaLD2cNVblK8gXAGQS6nNwWEXMgJRkO0tJdx/rwVEDxiKPLYbRtwgosp fvDA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=zH0XCbz75T0ViyBvqooq2aqe8ElRlg+XJCYmTa1Wkoc=; b=UeXjJccLPfN4jPYqhbTI2iBunEmk0F3nzbkYDDcCs95rsmGypHB9IA5CVMuJmzkliM NIBoyNeQvfQmfPOZzI4rVdo22KqfvoBQgGmQZcqYEJIZArbyR0Z89RulH4bTHF0ffTQy MyFVPtmPjOQ/o/Zb8yY1kTq3k8su94XRW+KV+3/3r1EKUj8OEL37q/btYF2A37sxobcP oCoUkd0xuX1ahwY7GGdiBy6Mi/k6xWtDxkUyw6q1Sfxf62GMtiUHqCnAX/bo2NlMwtVp kNWFU/Hxzh1aMhMb+2DtqKnOmtyOyM8iDmTgZUyyEoX6E2wR7824CoHIW664EuPF99Q5 Y38g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=TDDalfqi; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1679846613; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=zH0XCbz75T0ViyBvqooq2aqe8ElRlg+XJCYmTa1Wkoc=; b=ANUFApcHKUfk9xIsQEVblUamJTnPwhcL1J4LnyCJ/y99ZqNxs19MDJxZvW8Vmi5fJ2 J6wbTcpD6jTruXaEdHunM7FA1D1RK5ubSd97Wrj/qVB1ExpZMp3Xym/tskzJuBRnKv0F sF/PzppwKWAADLHcxQlBrIbmJfnuKjny3wUCU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679846613; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zH0XCbz75T0ViyBvqooq2aqe8ElRlg+XJCYmTa1Wkoc=; b=HBi8HzGl/xqTJwjRKXSAzWMHgOjhLENT+8GOBtIHY1v1D/FU6sAoeQKUPrEm0ZFXvY xlHRG3bTiDxL/GMGuRcL97eR2ZYI5NF0JbgJ4s6iNKj3jbKdEP1WFWvhYwfrpcIFqCi5 DRtyHuiMRDSDCJk2M/52IXDMyCtCLDZWJHv6IXQS+nLT6kkvAbAXF+hSnEJNWxEcs9kz bNVXeKu6LscvcCLqdVcUfyB1bgf89AZVWRzu+LTlcDwHjhV/KEIrpJA5qkhqOq74PQLz nIyKnWFColdfWzBZI+l2Arf1llSjntxAlxOkSDej8z67MFEKvuNyHFQyDIzdwgw8TsYh bEow== X-Gm-Message-State: AAQBX9eMQjHI7EWJfEaj6V0WP2FT85/oO8uTq5puJnkC3xvq8OimUcgc 9yeAfc5kMn3TyPtLG1DcoUsomGLRfLzZpA7t X-Google-Smtp-Source: AKy350bJcZxHkeTkVmB+4N3atfbVblKDuL/K3ibtRnGceqDzbs3dCf4Flc5sWKHuqPYc/DYdgRQ6cA== X-Received: by 2002:a17:906:c003:b0:932:777a:d34b with SMTP id e3-20020a170906c00300b00932777ad34bmr4111323ejz.14.1679846613019; Sun, 26 Mar 2023 09:03:33 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:6402:5214:b0:4ac:b59b:6e28 with SMTP id s20-20020a056402521400b004acb59b6e28ls2566462edd.2.-pod-prod-gmail; Sun, 26 Mar 2023 09:03:31 -0700 (PDT) X-Received: by 2002:a05:6402:45:b0:4ea:a9b0:a511 with SMTP id f5-20020a056402004500b004eaa9b0a511mr9352608edu.37.1679846611096; Sun, 26 Mar 2023 09:03:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679846611; cv=none; d=google.com; s=arc-20160816; b=dLbyB9fSRv2pvIFrnfAzIUl+PNCbz9s2o/hE6/4wkyHwxRU9v7JV5suRhUmQNSH+Gg HSeiOEpwarSVWmCFAOiO4saa9+klgbcdGFE5ID/vP0NKUbGcybwzKzkFr0pSmXOekIXw ZAtY14Jc4obTUlD9fbQBrXkHVug1/Nb0pZUElGtvn2WFExMW9CXsy7LJ86NQ7AWye1gK AX85maWETOjJx5ZslsjBBNxGgi4ku7e147nnkMETPXLqdYRRs0fyDeQknDe2ijnzxD5H LNwzgP/80nPJI44xyV8Zb6XE4qJun6z8kQN3MWAsVsSlASZYafaUkUMhNfVwVxfQqE5N hv9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=nHoE3dkQq12ELlvJCUdn1VIaqEl2rbzuk1PVgI3tnqM=; b=sBvBA16np70zrP00YyO1fjiW8/k+6Q+oKWjqzhwma11XqqDCxNF+Gj4sh7/OTRFpr0 Vdjf2vjGg5V/AwlKLcbbTascEay32BGg3tcUnKJ79GYybwkUcwmNldnHrCAHoWKpMXbJ b/lhQHPyHYgthHsmrpAt7b2deA5qEv9yYFZggDa4Vg030PPxyfVPqzXB5KHhTfNlmYNk WBM3n6U+oRqLtzGPZh8K7R+VxtXEup/Qis25PBPai9f1ZpQYz4t4U7VcRehL1xlJlIdM BaD7BZmP9VTCeZrZhA6sEKAi46G+FdXyq5rAb7F33yPFh34puBCz7tZblxYgWkNa553W bNgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=TDDalfqi; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id w6-20020a50c446000000b004c25b12b7d2sor14219459edf.2.2023.03.26.09.03.31 for (Google Transport Security); Sun, 26 Mar 2023 09:03:31 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:aa7:c90d:0:b0:4fb:2060:4c20 with SMTP id b13-20020aa7c90d000000b004fb20604c20mr9112651edt.31.1679846610692; Sun, 26 Mar 2023 09:03:30 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-87-0-102-254.retail.telecomitalia.it. [87.0.102.254]) by smtp.gmail.com with ESMTPSA id m2-20020a50d7c2000000b00501fc87352fsm6869333edj.13.2023.03.26.09.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Mar 2023 09:03:30 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , Rob Herring , Krzysztof Kozlowski , Marc Kleine-Budde , michael@amarulasolutions.com, Vincent Mailhol , Alexandre Torgue , Dario Binacchi , Alexandre Belloni , Christophe Roullier , "David S. Miller" , Eric Dumazet , Hans Verkuil , Jakub Kicinski , Krzysztof Kozlowski , Matti Vaittinen , Maxime Coquelin , Paolo Abeni , Rob Herring , Stephen Boyd , Wolfgang Grandegger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Subject: [PATCH v8 0/5] can: bxcan: add support for ST bxCAN controller Date: Sun, 26 Mar 2023 18:03:20 +0200 Message-Id: <20230326160325.3771891-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=TDDalfqi; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The series adds support for the basic extended CAN controller (bxCAN) found in many low- to middle-end STM32 SoCs. The driver design (one core module and one driver module) was inspired by other ST drivers (e. g. drivers/iio/adc/stm32-adc.c, drivers/iio/adc/stm32-adc-core.c) where device instances share resources. The shared resources functions are implemented in the core module, the device driver in a separate module. The driver has been tested on the stm32f469i-discovery board with a kernel version 5.19.0-rc2 in loopback + silent mode: ip link set can0 type can bitrate 125000 loopback on listen-only on ip link set up can0 candump can0 -L & cansend can0 300#AC.AB.AD.AE.75.49.AD.D1 For uboot and kernel compilation, as well as for rootfs creation I used buildroot: make stm32f469_disco_sd_defconfig make but I had to patch can-utils and busybox as can-utils and iproute are not compiled for MMU-less microcotrollers. In the case of can-utils, replacing the calls to fork() with vfork(), I was able to compile the package with working candump and cansend applications, while in the case of iproute, I ran into more than one problem and finally I decided to extend busybox's ip link command for CAN-type devices. I'm still wondering if it was really necessary, but this way I was able to test the driver. Changes in v8: - Do not enable the clock in probe and enable/disable it in open/close. - Return IRQ_NONE if no IRQ is active. Changes in v7: - Add Vincent Mailhol's Reviewed-by tag. - Remove all unused macros for reading/writing the controller registers. - Add CAN_ERR_CNT flag to notify availability of error counter. - Move the "break" before the newline in the switch/case statements. - Print the mnemotechnic instead of the error value in each netdev_err(). - Remove the debug print for timings parameter. - Do not copy the data if CAN_RTR_FLAG is set in bxcan_start_xmit(). - Populate ndev->ethtool_ops with the default timestamp info. Changes in v6: - move can1 node before gcan to keep ordering by address. Changes in v5: - Add Rob Herring's Acked-by tag. - Add Rob Herring's Reviewed-by tag. - Put static in front of bxcan_enable_filters() definition. Changes in v4: - Remove "st,stm32f4-bxcan-core" compatible. In this way the can nodes (compatible "st,stm32f4-bxcan") are no longer children of a parent node with compatible "st,stm32f4-bxcan-core". - Add the "st,gcan" property (global can memory) to can nodes which references a "syscon" node containing the shared clock and memory addresses. - Replace the node can@40006400 (compatible "st,stm32f4-bxcan-core") with the gcan@40006600 node ("sysnode" compatible). The gcan node contains clocks and memory addresses shared by the two can nodes of which it's no longer the parent. - Add to can nodes the "st,gcan" property (global can memory) which references the gcan@40006600 node ("sysnode compatibble). - Add "dt-bindings: arm: stm32: add compatible for syscon gcan node" patch. - Drop the core driver. Thus bxcan-drv.c has been renamed to bxcan.c and moved to the drivers/net/can folder. The drivers/net/can/bxcan directory has therefore been removed. - Use the regmap_*() functions to access the shared memory registers. - Use spinlock to protect bxcan_rmw(). - Use 1 space, instead of tabs, in the macros definition. - Drop clock ref-counting. - Drop unused code. - Drop the _SHIFT macros and use FIELD_GET()/FIELD_PREP() directly. - Add BXCAN_ prefix to lec error codes. - Add the macro BXCAN_RX_MB_NUM. - Enable time triggered mode and use can_rx_offload(). - Use readx_poll_timeout() in function with timeouts. - Loop from tail to head in bxcan_tx_isr(). - Check bits of tsr register instead of pkts variable in bxcan_tx_isr(). - Don't return from bxcan_handle_state_change() if skb/cf are NULL. - Enable/disable the generation of the bus error interrupt depending on can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING. - Don't return from bxcan_handle_bus_err() if skb is NULL. - Drop statistics updating from bxcan_handle_bus_err(). - Add an empty line in front of 'return IRQ_HANDLED;' - Rename bxcan_start() to bxcan_chip_start(). - Rename bxcan_stop() to bxcan_chip_stop(). - Disable all IRQs in bxcan_chip_stop(). - Rename bxcan_close() to bxcan_ndo_stop(). - Use writel instead of bxcan_rmw() to update the dlc register. Changes in v3: - Remove 'Dario Binacchi ' SOB. - Add description to the parent of the two child nodes. - Move "patterProperties:" after "properties: in top level before "required". - Add "clocks" to the "required:" list of the child nodes. - Remove 'Dario Binacchi ' SOB. - Add "clocks" to can@0 node. - Remove 'Dario Binacchi ' SOB. - Remove a blank line. - Remove 'Dario Binacchi ' SOB. - Fix the documentation file path in the MAINTAINERS entry. - Do not increment the "stats->rx_bytes" if the frame is remote. - Remove pr_debug() call from bxcan_rmw(). Changes in v2: - Change the file name into 'st,stm32-bxcan-core.yaml'. - Rename compatibles: - st,stm32-bxcan-core -> st,stm32f4-bxcan-core - st,stm32-bxcan -> st,stm32f4-bxcan - Rename master property to st,can-master. - Remove the status property from the example. - Put the node child properties as required. - Remove a blank line. - Fix sparse errors. - Create a MAINTAINERS entry. - Remove the print of the registers address. - Remove the volatile keyword from bxcan_rmw(). - Use tx ring algorithm to manage tx mailboxes. - Use can_{get|put}_echo_skb(). - Update DT properties. Dario Binacchi (5): dt-bindings: arm: stm32: add compatible for syscon gcan node dt-bindings: net: can: add STM32 bxcan DT bindings ARM: dts: stm32: add CAN support on stm32f429 ARM: dts: stm32: add pin map for CAN controller on stm32f4 can: bxcan: add support for ST bxCAN controller .../bindings/arm/stm32/st,stm32-syscon.yaml | 2 + .../bindings/net/can/st,stm32-bxcan.yaml | 83 ++ MAINTAINERS | 7 + arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 30 + arch/arm/boot/dts/stm32f429.dtsi | 29 + drivers/net/can/Kconfig | 12 + drivers/net/can/Makefile | 1 + drivers/net/can/bxcan.c | 1096 +++++++++++++++++ 8 files changed, 1260 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/can/st,stm32-bxcan.yaml create mode 100644 drivers/net/can/bxcan.c