From patchwork Mon Mar 27 20:16:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2809 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 705BB4147B for ; Mon, 27 Mar 2023 22:16:44 +0200 (CEST) Received: by mail-il1-f197.google.com with SMTP id l10-20020a056e0205ca00b00322fdda7261sf6565579ils.6 for ; Mon, 27 Mar 2023 13:16:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1679948203; cv=pass; d=google.com; s=arc-20160816; b=DdS7eLo6uFGy4h0c0swwNQrqHV7V8WewBUQv6nzyl4HTrdG6A4/ZV1z2QO8Qs2oFde xYee/4aXqw7pcniTwr9//HRV1WsvAtn1BWF2mPAgFNUj2hygnwT5rothoKBKWf9qnG5q rZMoQzCe6JBVoPJ1To/uin6tjzpoI+ZfXRkMwWbE6PkLp6iqMGuLXd27KOdWgTjSipdn tNUAO4wZsnZcbs/xHqQXEkcrPUeU08b8rDaVd8BrerHSIVNSNyr8ynGD63KFXSykbjRB pDotaG3MzQfpsePFCI/7SC9BhBDGO7hrww2iAcq2mM+7EWtOpIItuLSfU/ra+3Purk7h r0zw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=1kDIoX1wSaug4ELsTIQpYxpAc/N7ySQz+IOUXvIy8xs=; b=GYqHeggJUxHEtfgNJokC+zawyB/nQgS36Mc9Igt69qZLXYtH6jmcXf9hP1ucIrm8JN E3LLJtkTPgttGYtzug8qCbNDD+5wpwPmDQwzr3k7+gt54y+9SP7XqMRMZn/iV6/5v/lP H3NP8Wh+oGhU6IEYGpcDStQMSXeDDNbsrBCowhXaqMqJQzuclKLZKYTDZOIq1MUCkHci 7kzJd4JMsk2SJaB/mwAPRw1X1AFv2YsZeM5DhRpeiC50pGjhXQZLRE2BN1SL6wXwkBH2 Z/Z/ThGWw3nsFHLN1OBgP7Pq1y9o/xbwF4+2dfYUc9AIksQ4x7t5EKGZd2QVSyhewKPK jopw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=WUEt6Ubb; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1679948203; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=1kDIoX1wSaug4ELsTIQpYxpAc/N7ySQz+IOUXvIy8xs=; b=HsIlUSq9CQJ2ZVYlEjm8O5xpGj7Xrhy3IdqfRD9bs/quFkfeXvcbGuyBt04ubb1fl0 S6qTbUOogwk3IyVK3s9NoiO2/GTmI91VS49Ev/XAFxh1ZsI43PU9IYd9nLLNs+aSnuHN 7vKSRcj7niCdIUmX2NrxHu+mfxFVV0Q8uxTFk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679948203; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1kDIoX1wSaug4ELsTIQpYxpAc/N7ySQz+IOUXvIy8xs=; b=6pIjPE0QpA46WFfBi5KxICIT8yTf3s+FmiMw3pWMXPtugmgw0R1MuJRS2fxVleH0Od j+TGQ9sgfP7pMATGFNmq0OKQYk0mCDWuzY5HlG9HkivyUSo+YW3NSLYYQNpWWWDQ6yQU Ir6Js8+cwUbuxzLJd0jU7Is6BEr8BESijBkSYao6hgARxN0xpJrzB6Az+BLG/rNY4LaV huy1jP3aVyqAT0DGwPD1h0DhMttIe/AxWn9J9Pf18NqbZVD3ISe5kTZ5+7Gm4REAPcnT InKXVNNXdGxOJQBnbZEHAfb1y8MRwhmqi192e3yiiuNTdtdtwsdnq+b8Dsn/FfZNfg+3 jvdg== X-Gm-Message-State: AO0yUKXTFF7HAMJLuGeIt7iTgeGQ/nBHXBZoHduxjWqOZa5HkwgTa1d+ IRViLmySJohL3ewtGLMvNYrSsX3G X-Google-Smtp-Source: AK7set+uXTvodLM7vWNR7LET6u9xtm2jlMgB6SUwCdNKiQPJSjlU4FCSwxrGXzGIb7Qv+/uhkWa4aQ== X-Received: by 2002:a02:944a:0:b0:3c4:dda2:da6e with SMTP id a68-20020a02944a000000b003c4dda2da6emr4833938jai.4.1679948203298; Mon, 27 Mar 2023 13:16:43 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:6e02:144d:b0:325:d4ba:8214 with SMTP id p13-20020a056e02144d00b00325d4ba8214ls2829372ilo.3.-pod-prod-gmail; Mon, 27 Mar 2023 13:16:42 -0700 (PDT) X-Received: by 2002:a92:ce06:0:b0:316:aa64:cc03 with SMTP id b6-20020a92ce06000000b00316aa64cc03mr10863570ilo.18.1679948202602; Mon, 27 Mar 2023 13:16:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679948202; cv=none; d=google.com; s=arc-20160816; b=tfi2VL3M5vWH/x2a4t/M6Ib3uZjQpvZZ4ARn2hYzzoh8/ukZ77V3CNLRaHtA625Yl8 Jykchn2qPr/ZA+yt294lQOCS68rp4AOUwDmhcexaWLDGIJ0KQjNWhzmmlXeiS3uUalMs P1f366nRwNO9cRD9pzUuv+RW+oVzFzavDGaye3z149t1d5Iq3K4DxXEkhu2Ni6pu3VX1 Eve5tMRMpjvfUVnLCw8hgTfJm86zBgzV97t7/1pwVcesbWpAOpITnqr42MF04ZXplG9h 8tbI86pTeN3mFsYW7/XktSDma2Lu1ZzUtHwOTHvcTs1XWPngpsjJdL9cmYOYkA0bOKwc TlQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=tMOeOXowWeI0yAjk1FgwcJXxbz5tHlDssxq2QI5IVBY=; b=TONRuYMHr7hE/FXlLaA/nYIQ3eIeDXxAvd1G/S/06IQ6hGqeo1Bhsqn3ncS6NLSpxI KJzUZotYEd6aQ974dNh0HKuUP9srDfDcV47nLeqmlRryRLwYCsJxsMg5yV3kzM0lQyw8 4DhmWmoZnu7HEw+9FGo52Uxz1KB0LE2+WBE4CMqxWdX5jUuRwjSi7Y1HYH9XUZBVLEjq ZgDe27Z9a1xySpTilpXkdYRpSUfwPbVA3QRX2rHVqnQvgLs+2nSLCCP1Y4k7+K+VXSOb h3vdPtRua95pRilULvJzGzB/kyar35s4uOnM9AA8kpf/n4bbveu9Wq7FJhIGXiR05lhS JRvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=WUEt6Ubb; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id i14-20020a056e020d8e00b00317988ccde7sor8185187ilj.73.2023.03.27.13.16.42 for (Google Transport Security); Mon, 27 Mar 2023 13:16:42 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a92:dc91:0:b0:325:c1ef:5943 with SMTP id c17-20020a92dc91000000b00325c1ef5943mr10352033iln.14.1679948202158; Mon, 27 Mar 2023 13:16:42 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-87-0-102-254.retail.telecomitalia.it. [87.0.102.254]) by smtp.gmail.com with ESMTPSA id u26-20020a02b1da000000b003a958f51423sm5594759jah.167.2023.03.27.13.16.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 13:16:41 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Marc Kleine-Budde , Alexandre Torgue , Rob Herring , Amarula patchwork , Vincent Mailhol , michael@amarulasolutions.com, Krzysztof Kozlowski , Dario Binacchi , Christophe Roullier , "David S. Miller" , Dmitry Torokhov , Eric Dumazet , Jakub Kicinski , Krzysztof Kozlowski , Maxime Coquelin , Paolo Abeni , Rob Herring , Sebastian Reichel , Ulf Hansson , Wolfgang Grandegger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Subject: [PATCH v9 0/5] can: bxcan: add support for ST bxCAN controller Date: Mon, 27 Mar 2023 22:16:25 +0200 Message-Id: <20230327201630.3874028-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=WUEt6Ubb; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The series adds support for the basic extended CAN controller (bxCAN) found in many low- to middle-end STM32 SoCs. The driver has been tested on the stm32f469i-discovery board with a kernel version 5.19.0-rc2 in loopback + silent mode: ip link set can0 type can bitrate 125000 loopback on listen-only on ip link set up can0 candump can0 -L & cansend can0 300#AC.AB.AD.AE.75.49.AD.D1 For uboot and kernel compilation, as well as for rootfs creation I used buildroot: make stm32f469_disco_sd_defconfig make but I had to patch can-utils and busybox as can-utils and iproute are not compiled for MMU-less microcotrollers. In the case of can-utils, replacing the calls to fork() with vfork(), I was able to compile the package with working candump and cansend applications, while in the case of iproute, I ran into more than one problem and finally I decided to extend busybox's ip link command for CAN-type devices. I'm still wondering if it was really necessary, but this way I was able to test the driver. Changes in v9: - Fix commit description formatting. No semantic changes have been made. - Replace master/slave terms with primary/secondary. - Replace master/slave terms with primary/secondary. - Replace master/slave terms with primary/secondary. Changes in v8: - Do not enable the clock in probe and enable/disable it in open/close. - Return IRQ_NONE if no IRQ is active. Changes in v7: - Add Vincent Mailhol's Reviewed-by tag. - Remove all unused macros for reading/writing the controller registers. - Add CAN_ERR_CNT flag to notify availability of error counter. - Move the "break" before the newline in the switch/case statements. - Print the mnemotechnic instead of the error value in each netdev_err(). - Remove the debug print for timings parameter. - Do not copy the data if CAN_RTR_FLAG is set in bxcan_start_xmit(). - Populate ndev->ethtool_ops with the default timestamp info. Changes in v6: - move can1 node before gcan to keep ordering by address. Changes in v5: - Add Rob Herring's Acked-by tag. - Add Rob Herring's Reviewed-by tag. - Put static in front of bxcan_enable_filters() definition. Changes in v4: - Remove "st,stm32f4-bxcan-core" compatible. In this way the can nodes (compatible "st,stm32f4-bxcan") are no longer children of a parent node with compatible "st,stm32f4-bxcan-core". - Add the "st,gcan" property (global can memory) to can nodes which references a "syscon" node containing the shared clock and memory addresses. - Replace the node can@40006400 (compatible "st,stm32f4-bxcan-core") with the gcan@40006600 node ("sysnode" compatible). The gcan node contains clocks and memory addresses shared by the two can nodes of which it's no longer the parent. - Add to can nodes the "st,gcan" property (global can memory) which references the gcan@40006600 node ("sysnode compatibble). - Add "dt-bindings: arm: stm32: add compatible for syscon gcan node" patch. - Drop the core driver. Thus bxcan-drv.c has been renamed to bxcan.c and moved to the drivers/net/can folder. The drivers/net/can/bxcan directory has therefore been removed. - Use the regmap_*() functions to access the shared memory registers. - Use spinlock to protect bxcan_rmw(). - Use 1 space, instead of tabs, in the macros definition. - Drop clock ref-counting. - Drop unused code. - Drop the _SHIFT macros and use FIELD_GET()/FIELD_PREP() directly. - Add BXCAN_ prefix to lec error codes. - Add the macro BXCAN_RX_MB_NUM. - Enable time triggered mode and use can_rx_offload(). - Use readx_poll_timeout() in function with timeouts. - Loop from tail to head in bxcan_tx_isr(). - Check bits of tsr register instead of pkts variable in bxcan_tx_isr(). - Don't return from bxcan_handle_state_change() if skb/cf are NULL. - Enable/disable the generation of the bus error interrupt depending on can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING. - Don't return from bxcan_handle_bus_err() if skb is NULL. - Drop statistics updating from bxcan_handle_bus_err(). - Add an empty line in front of 'return IRQ_HANDLED;' - Rename bxcan_start() to bxcan_chip_start(). - Rename bxcan_stop() to bxcan_chip_stop(). - Disable all IRQs in bxcan_chip_stop(). - Rename bxcan_close() to bxcan_ndo_stop(). - Use writel instead of bxcan_rmw() to update the dlc register. Changes in v3: - Remove 'Dario Binacchi ' SOB. - Add description to the parent of the two child nodes. - Move "patterProperties:" after "properties: in top level before "required". - Add "clocks" to the "required:" list of the child nodes. - Remove 'Dario Binacchi ' SOB. - Add "clocks" to can@0 node. - Remove 'Dario Binacchi ' SOB. - Remove a blank line. - Remove 'Dario Binacchi ' SOB. - Fix the documentation file path in the MAINTAINERS entry. - Do not increment the "stats->rx_bytes" if the frame is remote. - Remove pr_debug() call from bxcan_rmw(). Changes in v2: - Change the file name into 'st,stm32-bxcan-core.yaml'. - Rename compatibles: - st,stm32-bxcan-core -> st,stm32f4-bxcan-core - st,stm32-bxcan -> st,stm32f4-bxcan - Rename master property to st,can-master. - Remove the status property from the example. - Put the node child properties as required. - Remove a blank line. - Fix sparse errors. - Create a MAINTAINERS entry. - Remove the print of the registers address. - Remove the volatile keyword from bxcan_rmw(). - Use tx ring algorithm to manage tx mailboxes. - Use can_{get|put}_echo_skb(). - Update DT properties. Dario Binacchi (5): dt-bindings: arm: stm32: add compatible for syscon gcan node dt-bindings: net: can: add STM32 bxcan DT bindings ARM: dts: stm32: add CAN support on stm32f429 ARM: dts: stm32: add pin map for CAN controller on stm32f4 can: bxcan: add support for ST bxCAN controller .../bindings/arm/stm32/st,stm32-syscon.yaml | 2 + .../bindings/net/can/st,stm32-bxcan.yaml | 85 ++ MAINTAINERS | 7 + arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 30 + arch/arm/boot/dts/stm32f429.dtsi | 29 + drivers/net/can/Kconfig | 12 + drivers/net/can/Makefile | 1 + drivers/net/can/bxcan.c | 1098 +++++++++++++++++ 8 files changed, 1264 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/can/st,stm32-bxcan.yaml create mode 100644 drivers/net/can/bxcan.c