[0/2] drm: sun4i/dsi: allow modeset helpers to manage display
mbox series

Message ID 20230410084750.164016-1-fusibrandon13@gmail.com
Headers show
Series
  • drm: sun4i/dsi: allow modeset helpers to manage display
Related show

Message

Brandon Cheo Fusi April 10, 2023, 8:47 a.m. UTC 
This change moves DSI PHY poweron/off from the encoder to the TCON. 

As a consequence enabling or disabling the DSI sink can be left to the modeset
helpers, and bridge support easily introduced without touching the 
drm_encoder.bridge_chain or converting the encoder to a drm_bridge.

Brandon Cheo Fusi (2):
  drm: sun4i/dsi: factor out DSI PHY poweron and poweroff
  drm: sun4i: tie DSI PHY Poweron/off to crtc enable/disable

 drivers/gpu/drm/sun4i/sun4i_tcon.c     | 10 +++-
 drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 64 ++++++++++++--------------
 drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h |  4 ++
 3 files changed, 43 insertions(+), 35 deletions(-)

Comments

Maxime Ripard April 11, 2023, 3:24 p.m. UTC | #1 
Hi,

On Mon, Apr 10, 2023 at 09:47:48AM +0100, Brandon Cheo Fusi wrote:
> This change moves DSI PHY poweron/off from the encoder to the TCON. 
> 
> As a consequence enabling or disabling the DSI sink can be left to the
> modeset helpers, and bridge support easily introduced without touching
> the drm_encoder.bridge_chain or converting the encoder to a
> drm_bridge.

I guess this is related to the discussion we had a couple of weeks ago
about being able to send DCS commands while in HS mode.

This just seems to workaround the issue entirely, breaking KMS
abstractions in the process. We had some leads on how to fix it
properly, so please follow them instead.

Maxime