[v2,3/3] doc: sifive: fu540: Document Boot from MMC

Message ID 20200420133735.23599-3-jagan@amarulasolutions.com
State New
Headers show
Series
  • [v2,1/3] sifive: fu540: Add sample SD gpt partition layout
Related show

Commit Message

Jagan Teki April 20, 2020, 1:37 p.m. UTC
Document the Booting from MMC steps.

Detailed information about partitioning, flashing and etc.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- new patch

 doc/board/sifive/fu540.rst | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

Comments

Bin Meng April 29, 2020, 1:56 p.m. UTC | #1
On Mon, Apr 20, 2020 at 9:37 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> Document the Booting from MMC steps.
>
> Detailed information about partitioning, flashing and etc.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - new patch
>
>  doc/board/sifive/fu540.rst | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Pragnesh Patel April 29, 2020, 3:47 p.m. UTC | #2
Hi Jagan,

>-----Original Message-----
>From: Jagan Teki <jagan@amarulasolutions.com>
>Sent: 20 April 2020 19:08
>To: Pragnesh Patel <pragnesh.patel@sifive.com>; rick@andestech.com; u-
>boot@lists.denx.de
>Cc: bmeng.cn@gmail.com; Sagar Kadam <sagar.kadam@sifive.com>; Paul
>Walmsley <paul.walmsley@sifive.com>; Troy Benjegerdes
><troy.benjegerdes@sifive.com>; palmerdabbelt@google.com;
>anup.patel@wdc.com; atish.patra@wdc.com; linux-
>amarula@amarulasolutions.com; Jagan Teki <jagan@amarulasolutions.com>
>Subject: [PATCH v2 3/3] doc: sifive: fu540: Document Boot from MMC
>
>[External Email] Do not click links or attachments unless you recognize the
>sender and know the content is safe
>
>Document the Booting from MMC steps.
>
>Detailed information about partitioning, flashing and etc.
>
>Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>---
>Changes for v2:
>- new patch
>
> doc/board/sifive/fu540.rst | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>

This changes is not on top of https://patchwork.ozlabs.org/project/uboot/patch/20200329170538.25449-18-pragnesh.patel@sifive.com/
this.

If you don't mind, I will incorporate your changes in my v7 series which has a complete description for FSBL and SPL.

>diff --git a/doc/board/sifive/fu540.rst b/doc/board/sifive/fu540.rst index
>3937222c6c..691ef232e2 100644
>--- a/doc/board/sifive/fu540.rst
>+++ b/doc/board/sifive/fu540.rst
>@@ -363,3 +363,31 @@ load uImage.
>
>    Please press Enter to activate this console.
>    / #
>+
>+Booting from MMC
>+----------------
>+
>+Use steps from "Building" section for building the U-Boot
>+
>+Format the SD card (make sure the disk has GPT, otherwise use gdisk to
>+switch)
>+
>+.. code-block:: none
>+
>+   # sudo sgdisk --clear \
>+   > --set-alignment=2 \
>+   > --new=1:34:2081 --change-name=1:loader1 --typecode=1:5B193300-FC78-
>40CD-8002-E86C45580B47 \
>+   > --new=2:2082:10273 --change-name=2:loader2 --typecode=2:2E54B353-
>1271-4842-806F-E436D6AF6985 \
>+   > --new=3:10274: --change-name=3:rootfs --typecode=3:0FC63DAF-8483-
>4772-8E79-3D69D8477DE4 \
>+   > /dev/sda
>+
>+Program the SD card
>+
>+.. code-block:: none
>+
>+   sudo dd if=spl/u-boot-spl.bin of=/dev/sda seek=34
>+   sudo dd if=u-boot.itb of=/dev/sda seek=2082
>+   sync
>+
>+Change DIP switches MSEL[3:0] are set to 1011
>+
>+Insert the SD card and power up the board.
>--
>2.17.1
Jagan Teki April 29, 2020, 3:56 p.m. UTC | #3
On Wed, Apr 29, 2020 at 9:17 PM Pragnesh Patel
<pragnesh.patel@sifive.com> wrote:
>
> Hi Jagan,
>
> >-----Original Message-----
> >From: Jagan Teki <jagan@amarulasolutions.com>
> >Sent: 20 April 2020 19:08
> >To: Pragnesh Patel <pragnesh.patel@sifive.com>; rick@andestech.com; u-
> >boot@lists.denx.de
> >Cc: bmeng.cn@gmail.com; Sagar Kadam <sagar.kadam@sifive.com>; Paul
> >Walmsley <paul.walmsley@sifive.com>; Troy Benjegerdes
> ><troy.benjegerdes@sifive.com>; palmerdabbelt@google.com;
> >anup.patel@wdc.com; atish.patra@wdc.com; linux-
> >amarula@amarulasolutions.com; Jagan Teki <jagan@amarulasolutions.com>
> >Subject: [PATCH v2 3/3] doc: sifive: fu540: Document Boot from MMC
> >
> >[External Email] Do not click links or attachments unless you recognize the
> >sender and know the content is safe
> >
> >Document the Booting from MMC steps.
> >
> >Detailed information about partitioning, flashing and etc.
> >
> >Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> >---
> >Changes for v2:
> >- new patch
> >
> > doc/board/sifive/fu540.rst | 28 ++++++++++++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> >
>
> This changes is not on top of https://patchwork.ozlabs.org/project/uboot/patch/20200329170538.25449-18-pragnesh.patel@sifive.com/
> this.
>
> If you don't mind, I will incorporate your changes in my v7 series which has a complete description for FSBL and SPL.

Better take it in a patch where you enable SPL MMC. and have another
patch before that with existing FSBL availability. This way changes
look easy to understand.

Jagan.
Pragnesh Patel April 29, 2020, 4:02 p.m. UTC | #4
Hi Jagan,

>-----Original Message-----
>From: Jagan Teki <jagan@amarulasolutions.com>
>Sent: 29 April 2020 21:26
>To: Pragnesh Patel <pragnesh.patel@sifive.com>
>Cc: rick@andestech.com; u-boot@lists.denx.de; bmeng.cn@gmail.com; Sagar
>Kadam <sagar.kadam@sifive.com>; Paul Walmsley
><paul.walmsley@sifive.com>; Troy Benjegerdes
><troy.benjegerdes@sifive.com>; palmerdabbelt@google.com;
>anup.patel@wdc.com; atish.patra@wdc.com; linux-
>amarula@amarulasolutions.com
>Subject: Re: [PATCH v2 3/3] doc: sifive: fu540: Document Boot from MMC
>
>[External Email] Do not click links or attachments unless you recognize the
>sender and know the content is safe
>
>On Wed, Apr 29, 2020 at 9:17 PM Pragnesh Patel
><pragnesh.patel@sifive.com> wrote:
>>
>> Hi Jagan,
>>
>> >-----Original Message-----
>> >From: Jagan Teki <jagan@amarulasolutions.com>
>> >Sent: 20 April 2020 19:08
>> >To: Pragnesh Patel <pragnesh.patel@sifive.com>; rick@andestech.com;
>> >u- boot@lists.denx.de
>> >Cc: bmeng.cn@gmail.com; Sagar Kadam <sagar.kadam@sifive.com>; Paul
>> >Walmsley <paul.walmsley@sifive.com>; Troy Benjegerdes
>> ><troy.benjegerdes@sifive.com>; palmerdabbelt@google.com;
>> >anup.patel@wdc.com; atish.patra@wdc.com; linux-
>> >amarula@amarulasolutions.com; Jagan Teki
><jagan@amarulasolutions.com>
>> >Subject: [PATCH v2 3/3] doc: sifive: fu540: Document Boot from MMC
>> >
>> >[External Email] Do not click links or attachments unless you
>> >recognize the sender and know the content is safe
>> >
>> >Document the Booting from MMC steps.
>> >
>> >Detailed information about partitioning, flashing and etc.
>> >
>> >Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> >---
>> >Changes for v2:
>> >- new patch
>> >
>> > doc/board/sifive/fu540.rst | 28 ++++++++++++++++++++++++++++
>> > 1 file changed, 28 insertions(+)
>> >
>>
>> This changes is not on top of
>> https://patchwork.ozlabs.org/project/uboot/patch/20200329170538.25449-
>> 18-pragnesh.patel@sifive.com/
>> this.
>>
>> If you don't mind, I will incorporate your changes in my v7 series which has a
>complete description for FSBL and SPL.
>
>Better take it in a patch where you enable SPL MMC. and have another patch
>before that with existing FSBL availability. This way changes look easy to
>understand.

Nice suggestion, I will incorporate this changes in my v7 series and also add your
Signed-off-by.

Can you please drop this patch in v3.

>
>Jagan.

Patch

diff --git a/doc/board/sifive/fu540.rst b/doc/board/sifive/fu540.rst
index 3937222c6c..691ef232e2 100644
--- a/doc/board/sifive/fu540.rst
+++ b/doc/board/sifive/fu540.rst
@@ -363,3 +363,31 @@  load uImage.
 
    Please press Enter to activate this console.
    / #
+
+Booting from MMC
+----------------
+
+Use steps from "Building" section for building the U-Boot
+
+Format the SD card (make sure the disk has GPT, otherwise use gdisk to switch)
+
+.. code-block:: none
+
+   # sudo sgdisk --clear \
+   > --set-alignment=2 \
+   > --new=1:34:2081 --change-name=1:loader1 --typecode=1:5B193300-FC78-40CD-8002-E86C45580B47 \
+   > --new=2:2082:10273 --change-name=2:loader2 --typecode=2:2E54B353-1271-4842-806F-E436D6AF6985 \
+   > --new=3:10274: --change-name=3:rootfs --typecode=3:0FC63DAF-8483-4772-8E79-3D69D8477DE4 \
+   > /dev/sda
+
+Program the SD card
+
+.. code-block:: none
+
+   sudo dd if=spl/u-boot-spl.bin of=/dev/sda seek=34
+   sudo dd if=u-boot.itb of=/dev/sda seek=2082
+   sync
+
+Change DIP switches MSEL[3:0] are set to 1011
+
+Insert the SD card and power up the board.