[v2,3/6] clk: rk3399: Set empty for HCLK_SD assigned-clocks

Message ID 20200428100019.19155-4-jagan@amarulasolutions.com
State New
Headers show
Series
  • rk3399: Sync linux v5.7-rc1 dts(i)
Related show

Commit Message

Jagan Teki April 28, 2020, 10 a.m. UTC
Due to v5.7-rc1 sync the SD controller nodes in rk3399.dtsi
have HCLK_SD assigned-clocks which are usually required for
Linux and don't require to handle them in U-Boot.

 assigned-clocks = <&cru HCLK_SD>;

So, mark them as empty in clock otherwise device probe on
those SD controllers would fail.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- none

 drivers/clk/rockchip/clk_rk3399.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kever Yang April 28, 2020, 2:13 p.m. UTC | #1
On 2020/4/28 下午6:00, Jagan Teki wrote:
> Due to v5.7-rc1 sync the SD controller nodes in rk3399.dtsi
> have HCLK_SD assigned-clocks which are usually required for
> Linux and don't require to handle them in U-Boot.
>
>   assigned-clocks = <&cru HCLK_SD>;
>
> So, mark them as empty in clock otherwise device probe on
> those SD controllers would fail.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>


Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
> Changes for v2:
> - none
>
>   drivers/clk/rockchip/clk_rk3399.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/rockchip/clk_rk3399.c b/drivers/clk/rockchip/clk_rk3399.c
> index 1f62376595..d822acace1 100644
> --- a/drivers/clk/rockchip/clk_rk3399.c
> +++ b/drivers/clk/rockchip/clk_rk3399.c
> @@ -996,6 +996,7 @@ static ulong rk3399_clk_set_rate(struct clk *clk, ulong rate)
>   		break;
>   	case ACLK_VOP1:
>   	case HCLK_VOP1:
> +	case HCLK_SD:
>   		/**
>   		 * assigned-clocks handling won't require for vopl, so
>   		 * return 0 to satisfy clk_set_defaults during device probe.

Patch

diff --git a/drivers/clk/rockchip/clk_rk3399.c b/drivers/clk/rockchip/clk_rk3399.c
index 1f62376595..d822acace1 100644
--- a/drivers/clk/rockchip/clk_rk3399.c
+++ b/drivers/clk/rockchip/clk_rk3399.c
@@ -996,6 +996,7 @@  static ulong rk3399_clk_set_rate(struct clk *clk, ulong rate)
 		break;
 	case ACLK_VOP1:
 	case HCLK_VOP1:
+	case HCLK_SD:
 		/**
 		 * assigned-clocks handling won't require for vopl, so
 		 * return 0 to satisfy clk_set_defaults during device probe.