From patchwork Mon Jun 8 18:31:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 1347 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 463403F06D for ; Mon, 8 Jun 2020 20:32:07 +0200 (CEST) Received: by mail-pl1-f198.google.com with SMTP id d9sf12804887pll.12 for ; Mon, 08 Jun 2020 11:32:07 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1591641125; cv=pass; d=google.com; s=arc-20160816; b=No656bvu8O9DDvjQZA9gsJL8eQHoIUiPFE9eV5qmK4/LP5m9U62Poelg9e8sx4IrJt uwXwTQW6QH+82bey+UQVsfQJ4dsf8FRNJ/N5Os3dRBf4bwq2mF4uw/hZalYXvF+Bky+I 9ACxksXuxAh7qzK2EcVR9o530nv2rx9Kr5Zq6Vl9fNzxU/QiizvT0kQaT8jFfU3+Sco7 TtSK5JIzHv3usykaUoij+FGKmAcCNNLbaQLT0klrstqNdQsJdM1sm+8JG+6d+nK8Q/8L 1yJaqKkCSjnxqo4knF8l3l1i3xUxQqZ2GO6TxY/xkFueHKMf9KoI9qK9sku1w5/yTCCW OGGw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=W1XW5xp5UP5XBG/Gw0YvK3qJJgksI4vqH5Yz+a8r0Vk=; b=ggr/8+uBm/KCk1U+uY9GqwuLz+8+odcmFeiDF8HxrU1LjxFtMGUSNI/urghHvHuldD fICYlKtHSjl1rOiLDUA2KIZnZSFksX6tIQsYBjaZA6n4Q/S1X67GvujEF8qjjDF53lxu nKWSmN0Z5oKRVUy8CDRJJZlCr7XYNrJhcHnvqNfdpqQr9hIU4igmbL4XR2radQGhGOKF 1w5BWki84TWZZ+5rrwiKJ/7yfzO5Be+qyMJmVFkTI8821iMa8YCyWKNFvtR+90iUPDdW Mjwa2CTY+BloB5GX4WUnFSu7jpnckC7eGUPZHh1Gg+xlGID+LvqLsewnfld7ZyKuLUt4 L1lA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=o4vOcHSl; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=W1XW5xp5UP5XBG/Gw0YvK3qJJgksI4vqH5Yz+a8r0Vk=; b=RRwhLJdVH8SbmIJd6PN8fqDqfyLjHEIlVvjBXQx4wdtroHfKCXxmKV0bytkAvebe8/ a1gT4WzoHHF6YeNPOWjVoi9hr+e4JSvQs3xBAJ6yZTx7PsguvD2zG/JgbKR/8TU/NdCk nJI4/bob4d/Ln/E+Fvj2lKFNkRiWAc01KuJcs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=W1XW5xp5UP5XBG/Gw0YvK3qJJgksI4vqH5Yz+a8r0Vk=; b=KAMp8bvdute6rWrkonmv2Q0A9SDg+5AesUCH3mEQaoPPhoCX0eqA9NLzfZkspo7nKJ 6Z4XIkIbQfNaRbyH8WJcC/IbGBb/y3gR7EEURMuJxg07mjHAya+5EtHr7v8yrB5DL1XP v09DOYLBGgtTsbZfsxl8OO7xJFRSBl3h6kuR5M82Htx0p0ErjJQMDEPQ/d7y1wqeNVjS Q40mZV3hJSlrH0oMK8m0x2WQFzMGSeuv2P8e11f9tGc9PNMwqwKTNl79ybM+HlYxa5+g Dj0k70l8zpUWumO8MSd3pl0+txfSQxDpHw3YOmCD8aX2+f0lASHEjfNUrLkgB9cghQXR MDMw== X-Gm-Message-State: AOAM531j1V+xU52IIWEEH++lap3dQad8dMPccNEfASj5CoRJKCbONO0d ieXmxXq/oPB+Eji15sCdZ/BYxA8c X-Google-Smtp-Source: ABdhPJxEDEa6XJs0dd9kCJluPwbj0N4MsJ2hnUaeDc9wROaJUjUWxJQ2HoYktt00j1lg61ZJtR8Czg== X-Received: by 2002:a63:ca4a:: with SMTP id o10mr420823pgi.182.1591641125361; Mon, 08 Jun 2020 11:32:05 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:aa7:9a84:: with SMTP id w4ls5506818pfi.7.gmail; Mon, 08 Jun 2020 11:32:05 -0700 (PDT) X-Received: by 2002:a63:1f42:: with SMTP id q2mr20735604pgm.357.1591641124822; Mon, 08 Jun 2020 11:32:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591641124; cv=none; d=google.com; s=arc-20160816; b=FEG5Xn/ogtuOZpGr5YiNyi8pmc1IvWbb0T49ch2KgzWMwKrGZv1orLyWLX5MSoCnT1 wXJeRkwo6d0AVvY9S2g8eX1G9+YgFvcWAOvA7GxqtcVBc4YKOY7dARwOwgVDzrMJCger BlbiUzHuQAkbR7AH3es20xo9uRW2SIcQIazRPudwdnQdPvNyKpxBWl1+GNqzHDeR9GyI 5G7/dQu3sJU2o+rCwvjfVS+MEZQXgv+tSyAuLAKhCpiJbNmQ4Hri77iJS4b5i+5QXLRf HioR1hVTMQT1HhgmRSZNb57Obj+n4vIIvNutXwudME4z85Xc1oVu0RjYGMsAQtpdk4Nf WMkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=whusgV3SuU4OYdnISZ0eE6+udK0GNJd8qRyaT+j/kBs=; b=YFu+6GDRLPur4RfSlIFCufOdJPZeFkazqlkL5Cpz1Di4fn7vVa40btQO6pzwySt8yZ XIJMREA249LsoqO4BEBo4KIYAyoUhOaiU0NSL9gyMzKHEHcnnhK/n8J4HxgTkIG1q/Ap PFhbZPI5kBKSxpmrzgLHPA/Y1CwEAkyP0Lech8/7uZYWfY56jRZjIFnEFwHR7va6m1Pb yNXGeNJLLVvCpu2nJPPQq3oYuf7lxkUzXDx0OPZ7pgHeow9pLtJCER9PQtwBjod+Q1q1 erYUY3UPIPfkglRP2dWsNqbj0ibjotlWXQRk7qIo3KPaBdv7GBIXzNefMkt+4/APCKpz q1Vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=o4vOcHSl; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id n22sor549411pjn.13.2020.06.08.11.32.04 for (Google Transport Security); Mon, 08 Jun 2020 11:32:04 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:a17:90b:110f:: with SMTP id gi15mr622869pjb.87.1591641124486; Mon, 08 Jun 2020 11:32:04 -0700 (PDT) Received: from localhost.localdomain ([2405:201:c809:c7d5:9043:af95:b7b4:3ade]) by smtp.gmail.com with ESMTPSA id k29sm6680961pgf.77.2020.06.08.11.32.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 11:32:03 -0700 (PDT) From: Jagan Teki To: Kever Yang , Philipp Tomsich , Simon Glass Cc: Suniel Mahesh , U-Boot-Denx , linux-rockchip@lists.infradead.org, linux-amarula , Jagan Teki Subject: [PATCH v3 2/5] rk3399: spl: Print SPL banner after relocation Date: Mon, 8 Jun 2020 14:31:41 -0400 Message-Id: <20200608183144.26809-3-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200608183144.26809-1-jagan@amarulasolutions.com> References: <20200608183144.26809-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=o4vOcHSl; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Usually printing the SPL banner varies between architecture or board codes. - Some would print before relocation at the end board_init_f   for making sure all initialization prior to this would happen   properly. if at all there is a requirement for serial init,   that happens properly since it prints all after that. - Some would print after relocation at the spl_board_init for   making sure all initialization prior to relocation would happen properly. Also debug uart on these cases would be available before relocation. So debug support is available in before and after relocation. Rockchip SPL is following formar step to print the banner at the end of board_init_f. To support various custom use cases in SPL like leds, environment, board detections later options like printing the banner after relocation would be a better option. Printing banner would also help to support debugging availability between relocation codes, like debug uart available before relocation and banner availability after relation. By demonstrating all the above use cases, this patch is trying to print the SPL banner after relocation. Signed-off-by: Jagan Teki Tested-by: Suniel Mahesh --- Changes for v3: - new patch arch/arm/mach-rockchip/rk3399/rk3399.c | 2 ++ arch/arm/mach-rockchip/spl.c | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c b/arch/arm/mach-rockchip/rk3399/rk3399.c index 681f80f339..af4b0e271b 100644 --- a/arch/arm/mach-rockchip/rk3399/rk3399.c +++ b/arch/arm/mach-rockchip/rk3399/rk3399.c @@ -279,6 +279,8 @@ void spl_board_init(void) { /* board specific spl init */ rk_spl_board_init(); + + preloader_console_init(); } #endif diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c index cddf4fd3d5..1c2dca8a72 100644 --- a/arch/arm/mach-rockchip/spl.c +++ b/arch/arm/mach-rockchip/spl.c @@ -147,7 +147,6 @@ void board_init_f(ulong dummy) gd->ram_top = gd->ram_base + get_effective_memsize(); gd->ram_top = board_get_usable_ram_top(gd->ram_size); #endif - preloader_console_init(); } #ifdef CONFIG_SPL_LOAD_FIT