Message ID | 20190311082005.18550-2-jagan@amarulasolutions.com |
---|---|
State | New |
Headers | show |
Series |
|
Related | show |
> u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and > which is U-Boot specific devicetrees binding. > > Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot > bindings will move it future based on the requirement. > > This would help to sync the devicetrees from Linux whenever required > instead of adding specific nodes. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > arch/arm/dts/rk3399-evb.dts | 1 - > arch/arm/dts/rk3399-firefly.dts | 1 - > arch/arm/dts/rk3399-puma.dtsi | 1 - > arch/arm/dts/rk3399-u-boot.dtsi | 8 ++++++++ > 4 files changed, 8 insertions(+), 3 deletions(-) > create mode 100644 arch/arm/dts/rk3399-u-boot.dtsi > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Hi Philipp, On Mon, Apr 22, 2019 at 12:11 AM Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote: > > > u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and > > which is U-Boot specific devicetrees binding. > > > > Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot > > bindings will move it future based on the requirement. > > > > This would help to sync the devicetrees from Linux whenever required > > instead of adding specific nodes. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > arch/arm/dts/rk3399-evb.dts | 1 - > > arch/arm/dts/rk3399-firefly.dts | 1 - > > arch/arm/dts/rk3399-puma.dtsi | 1 - > > arch/arm/dts/rk3399-u-boot.dtsi | 8 ++++++++ > > 4 files changed, 8 insertions(+), 3 deletions(-) > > create mode 100644 arch/arm/dts/rk3399-u-boot.dtsi > > > > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> I have v2 version for these changes, [1] please have a look, thanks! [1] https://patchwork.ozlabs.org/cover/1086213/
diff --git a/arch/arm/dts/rk3399-evb.dts b/arch/arm/dts/rk3399-evb.dts index ce004d0d18..9162f3dd50 100644 --- a/arch/arm/dts/rk3399-evb.dts +++ b/arch/arm/dts/rk3399-evb.dts @@ -155,7 +155,6 @@ }; &sdmmc { - u-boot,dm-pre-reloc; bus-width = <4>; status = "okay"; }; diff --git a/arch/arm/dts/rk3399-firefly.dts b/arch/arm/dts/rk3399-firefly.dts index f90e7e88db..46f2ffaf8d 100644 --- a/arch/arm/dts/rk3399-firefly.dts +++ b/arch/arm/dts/rk3399-firefly.dts @@ -592,7 +592,6 @@ }; &sdmmc { - u-boot,dm-pre-reloc; bus-width = <4>; status = "okay"; }; diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi index 8304f67192..9049694243 100644 --- a/arch/arm/dts/rk3399-puma.dtsi +++ b/arch/arm/dts/rk3399-puma.dtsi @@ -492,7 +492,6 @@ }; &sdmmc { - u-boot,dm-pre-reloc; clock-frequency = <150000000>; max-frequency = <40000000>; supports-sd; diff --git a/arch/arm/dts/rk3399-u-boot.dtsi b/arch/arm/dts/rk3399-u-boot.dtsi new file mode 100644 index 0000000000..f533ed95eb --- /dev/null +++ b/arch/arm/dts/rk3399-u-boot.dtsi @@ -0,0 +1,8 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com> + */ + +&sdmmc { + u-boot,dm-pre-reloc; +};
u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and which is U-Boot specific devicetrees binding. Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot bindings will move it future based on the requirement. This would help to sync the devicetrees from Linux whenever required instead of adding specific nodes. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- arch/arm/dts/rk3399-evb.dts | 1 - arch/arm/dts/rk3399-firefly.dts | 1 - arch/arm/dts/rk3399-puma.dtsi | 1 - arch/arm/dts/rk3399-u-boot.dtsi | 8 ++++++++ 4 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 arch/arm/dts/rk3399-u-boot.dtsi