[1/3] ram: rk3399: Drop debug stride in driver
diff mbox series

Message ID 20200713200635.651032-1-jagan@amarulasolutions.com
State New
Headers show
Series
  • [1/3] ram: rk3399: Drop debug stride in driver
Related show

Commit Message

Jagan Teki July 13, 2020, 8:06 p.m. UTC 
stride debug is already present in sdram_common.c via
RAM_ROCKCHIP_DEBUG.

So, drop the redundant debug stride code in rk3399 driver.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/ram/rockchip/sdram_rk3399.c | 25 -------------------------
 1 file changed, 25 deletions(-)

Comments

Kever Yang July 18, 2020, 12:14 p.m. UTC | #1 
On 2020/7/14 上午4:06, Jagan Teki wrote:
> stride debug is already present in sdram_common.c via
> RAM_ROCKCHIP_DEBUG.
>
> So, drop the redundant debug stride code in rk3399 driver.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Reviewed-by: Kever Yang<kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   drivers/ram/rockchip/sdram_rk3399.c | 25 -------------------------
>   1 file changed, 25 deletions(-)
>
> diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
> index 60a1ab8b51..d2f3fde236 100644
> --- a/drivers/ram/rockchip/sdram_rk3399.c
> +++ b/drivers/ram/rockchip/sdram_rk3399.c
> @@ -2875,31 +2875,6 @@ static unsigned char calculate_stride(struct rk3399_sdram_params *params)
>   		if (stride == (-1))
>   			goto error;
>   	}
> -	switch (stride) {
> -	case 0xc:
> -		printf("128B stride\n");
> -		break;
> -	case 5:
> -	case 9:
> -	case 0xd:
> -	case 0x11:
> -	case 0x19:
> -		printf("256B stride\n");
> -		break;
> -	case 0xa:
> -	case 0xe:
> -	case 0x12:
> -		printf("512B stride\n");
> -		break;
> -	case 0xf:
> -		printf("4K stride\n");
> -		break;
> -	case 0x1f:
> -		printf("32MB + 256B stride\n");
> -		break;
> -	default:
> -		printf("no stride\n");
> -	}
>   
>   	sdram_print_stride(stride);
>

Patch
diff mbox series 

diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
index 60a1ab8b51..d2f3fde236 100644
--- a/drivers/ram/rockchip/sdram_rk3399.c
+++ b/drivers/ram/rockchip/sdram_rk3399.c
@@ -2875,31 +2875,6 @@  static unsigned char calculate_stride(struct rk3399_sdram_params *params)
 		if (stride == (-1))
 			goto error;
 	}
-	switch (stride) {
-	case 0xc:
-		printf("128B stride\n");
-		break;
-	case 5:
-	case 9:
-	case 0xd:
-	case 0x11:
-	case 0x19:
-		printf("256B stride\n");
-		break;
-	case 0xa:
-	case 0xe:
-	case 0x12:
-		printf("512B stride\n");
-		break;
-	case 0xf:
-		printf("4K stride\n");
-		break;
-	case 0x1f:
-		printf("32MB + 256B stride\n");
-		break;
-	default:
-		printf("no stride\n");
-	}
 
 	sdram_print_stride(stride);