[v2,08/12] rockchip: evb_rk3288: Add console settings
diff mbox series

Message ID 20200721152443.37602-9-jagan@amarulasolutions.com
State New
Headers show
Series
  • rockchip: ROCKPi N8/N10 hardware enablement
Related show

Commit Message

Jagan Teki July 21, 2020, 3:24 p.m. UTC 
From: Suniel Mahesh <sunil@amarulasolutions.com>

Add console settings like stdin, stdout and stderr as
usbkbd and vidconsole respectively for evb-rk3288 targets.

This would certainly help to detect the attached video
devices (like HDMI) and print the console messages on display.

Signed-off-by: Suniel Mahesh <sunil@amarulasolutions.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- update commit messaage

 include/configs/evb_rk3288.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Kever Yang July 22, 2020, 12:30 p.m. UTC | #1 
On 2020/7/21 下午11:24, Jagan Teki wrote:
> From: Suniel Mahesh <sunil@amarulasolutions.com>
>
> Add console settings like stdin, stdout and stderr as
> usbkbd and vidconsole respectively for evb-rk3288 targets.
>
> This would certainly help to detect the attached video
> devices (like HDMI) and print the console messages on display.
>
> Signed-off-by: Suniel Mahesh <sunil@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
> Changes for v2:
> - update commit messaage
>
>   include/configs/evb_rk3288.h | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/configs/evb_rk3288.h b/include/configs/evb_rk3288.h
> index ddd7012c8f..e19fa90212 100644
> --- a/include/configs/evb_rk3288.h
> +++ b/include/configs/evb_rk3288.h
> @@ -6,7 +6,11 @@
>   #ifndef __CONFIG_H
>   #define __CONFIG_H
>   
> -#define ROCKCHIP_DEVICE_SETTINGS
> +#define ROCKCHIP_DEVICE_SETTINGS \
> +		"stdin=serial,usbkbd\0" \
> +		"stdout=serial,vidconsole\0" \
> +		"stderr=serial,vidconsole\0"
> +
>   #include <configs/rk3288_common.h>
>   
>   #define CONFIG_SYS_MMC_ENV_DEV 0

Patch
diff mbox series 

diff --git a/include/configs/evb_rk3288.h b/include/configs/evb_rk3288.h
index ddd7012c8f..e19fa90212 100644
--- a/include/configs/evb_rk3288.h
+++ b/include/configs/evb_rk3288.h
@@ -6,7 +6,11 @@ 
 #ifndef __CONFIG_H
 #define __CONFIG_H
 
-#define ROCKCHIP_DEVICE_SETTINGS
+#define ROCKCHIP_DEVICE_SETTINGS \
+		"stdin=serial,usbkbd\0" \
+		"stdout=serial,vidconsole\0" \
+		"stderr=serial,vidconsole\0"
+
 #include <configs/rk3288_common.h>
 
 #define CONFIG_SYS_MMC_ENV_DEV 0