From patchwork Thu Nov 11 15:22:53 2021
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Michael Nazzareno Trimarchi
 <michael@amarulasolutions.com>
X-Patchwork-Id: 1746
Return-Path: 
 <linux-amarula+bncBCXK73FY3AFRBXXKWSGAMGQEKCDZZEI@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com
	[209.85.128.69])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 72A193F07B
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Thu, 11 Nov 2021 16:23:10 +0100 (CET)
Received: by mail-wm1-f69.google.com with SMTP id
	l6-20020a05600c4f0600b0033321934a39sf2834826wmq.9
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Thu, 11 Nov 2021 07:23:10 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1636644190; cv=pass;
	d=google.com; s=arc-20160816;
	b=Iyocn67eCAh04pFjgp+yt0SnIraK9dGdnwTXcVy8lEmtOTLgxUK++5BNxguzThQYqr
	/1gT97xZPXLv0WqyQ808g+tpke/S24ituFS4/LK7jTX2b3GQgkLvSLKCBJpFn3bGUgv/
	3DCZe+ldUsJyBytGy4L65lOSS6r1w/Re44p++rpZuS1PuxvAk+wsm/Kvb6ZRnJ1wLkbi
	rfcMQQ0LZUyqcwVg72HaC7E4zfuMsHAIZNiI7j/3G8PufZPTtwkTP93CQ5NYMIEKIAFH
	08AZxkJOct/Ywi3pmhtnxXNUrVlL3PmNK8ZJdTWvK7aN6lbZhRlS4PLv3MxVdR1Zw6lx
	0dkw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=XnJ56nyr+2yTx+X5T9+0mm57uiqTbkl7TAJmfSyBigs=;
	b=nyV6I4diClzRFCXgqWxWl17MsCqbbHf1APpnJEVEkUeb0c8aVlr5c8t2jr36vv0KUS
	z3FKT/S4rs1pOntXnZWsr2QwHN6qxfzOf1kkOJjSJ7fTPsO4VRJ0kMZo6sPrMW9uytSC
	JVf+SdB+/AHYrQwo3MI0RrKDcPguFe/vOAnYxDvJorDVmSK4e0M7/T8avLBvwnWQCpvR
	sPH+C/FXXuI/QBbdZWpjtDDN2pkpvr7prJmx4wSlS7Sti9Ad5zy7nsFnMDptujBzIVnG
	R3Udpcr996kUf6yfthCTDo/Mm+jot01d/ClFEnUcAVXraPjB4bidt4VtZW2L3UBb2IqR
	sNTw==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=SEiqDmSK;
	spf=pass (google.com: domain of michael@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=michael@amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google;
	h=from:to:cc:subject:date:message-id:in-reply-to:references
	:mime-version:x-original-sender:x-original-authentication-results
	:precedence:mailing-list:list-id:list-post:list-help:list-archive
	:list-unsubscribe;
	bh=XnJ56nyr+2yTx+X5T9+0mm57uiqTbkl7TAJmfSyBigs=;
	b=avPv6FKF3kkXViaWUjP2vmHknc2gzDptI6q5W+vPo9t1coYDgtUSXO1NOBLAaAUDEH
	nSk/bvvANj7cnSt8yEkhanPxtpN99vH11sZqN3MT7K0yYGGV1jWEBVzU7rBDmllpjFE0
	/L3OoRkVrdLl2p/1uCwLBBSBQqE55IClG3c68=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20210112;
	h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
	:references:mime-version:x-original-sender
	:x-original-authentication-results:precedence:mailing-list:list-id
	:x-spam-checked-in-group:list-post:list-help:list-archive
	:list-unsubscribe;
	bh=XnJ56nyr+2yTx+X5T9+0mm57uiqTbkl7TAJmfSyBigs=;
	b=Z2Hfokt9YzipG0PaCJQRlJsCt8KG3gSqlwHadHOgeKg8wrp3Op79x8+IDZneDnP88m
	+BxIO+QedSHRtQ9XgZFLTE/n2smxuRIE3h82y/FQNy6OyMcroGySgLMN/8IjOxHDGI27
	Cl6DNnpzb/xB0CohqNY3swx5Wxtif1dBYd+j29H9ae893A2HNypAMTzP/GevwOLbazyB
	r+E8wXgUepTzDgGIAoEwwfCmkBWlja8z0YPo0zOTxN3L9t4B9jRvdP4E9TC1V9JZS0Rl
	xdDrhVr+4CihWWDxQYekihJF/JqwztJYDYM2eTsq9oHPk6ddj957YEu+lTgzgzLQpoAE
	6f7Q==
X-Gm-Message-State: AOAM533QFzIEyVel5h2agitcMHOmjAGAgTq/C3GCYJ03E4bSUH3wwFLn
	MCSo02xztgm4F3K2AnUBR/M4Xs7p
X-Google-Smtp-Source: 
 ABdhPJwRuIVmG0XjnTnvq2KB5wmiyqSMP+ie0ms+NRTuT8qJ72+XfXCwxSAB+1eyWH3asCD2vksG6Q==
X-Received: by 2002:adf:d1e2:: with SMTP id g2mr7560325wrd.362.1636644190234;
	Thu, 11 Nov 2021 07:23:10 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a05:600c:ad6:: with SMTP id c22ls5124357wmr.1.canary-gmail;
	Thu, 11 Nov 2021 07:23:09 -0800 (PST)
X-Received: by 2002:a05:600c:22cb:: with SMTP id
	11mr9000301wmg.181.1636644189162;
	Thu, 11 Nov 2021 07:23:09 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1636644189; cv=none;
	d=google.com; s=arc-20160816;
	b=mwsYy6ubtvPTb55UTtu0ADXd26Pn+hKhFG2Y9EVc51fiOrfFhJjmDSAMdsoPiSDglH
	MsalfHUhOlmZ7hXE4/YtiOQf12tpt42Qk2i3+FZGSlc9GTQ4GF4JM6zv0ajZlAz3bxnD
	Se4ebzRi8df156ZWe3vw0XC6Hdg1WTQjS4S22qDRec3MJUEQZcLUu670TUSimZKS/P8E
	74t3iCzlYV+kIGDE/T9U6ww3+QvaWWO7S6oZbGVwhroXQ+4+GpnA0bs+Yq7N/KRjvC3n
	fdaIVaX/ZG3ntDX8NqifUySCNBipf7sbmDmJH+CwZDBneGuPlPwXL4GD9aIPbRTmcqOV
	iT2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=1LE+XNBolkTsWIvH8Ut6LTTHH4UL3wj1a74HRrrRWGs=;
	b=YUZjjJXwsrnQ8N6wlbcPcUpqTfPpXGrror28Tjthz7Y7jhu34Cx5elLII4Df4OlJQ2
	c56Ezd2i05OwiRpLz1oNMK91p4lmaOBnatOcuVBBn4Kj1D0YP9E0RsjrtaW4aq4jP3cM
	+W1IRPMF7OXttdJRT3L2lo2uFyHgNZCSIa5ui4j7NY9O0zBIF5c6PZaxhFJwjkG52ZQu
	SSWVIa6kGdnJ+ClP2I2bCHGECIsbJfTyrr9mLRAq9XIDYZPCu85Aqg6MddMqg9hbilWT
	Fr+yRBv+P68QptpCo98AVCRe4rJ/OFBh2yY3QFsjDFTMn6rMbE8AeLJOezpvNOTbaf24
	Of4A==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=SEiqDmSK;
	spf=pass (google.com: domain of michael@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=michael@amarulasolutions.com
Received: from mail-sor-f41.google.com (mail-sor-f41.google.com.
	[209.85.220.41])
	by mx.google.com with SMTPS id c4sor2322021wrb.6.2021.11.11.07.23.09
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Thu, 11 Nov 2021 07:23:09 -0800 (PST)
Received-SPF: pass (google.com: domain of michael@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	client-ip=209.85.220.41;
X-Received: by 2002:a5d:6ac7:: with SMTP id u7mr9547761wrw.57.1636644188792;
	Thu, 11 Nov 2021 07:23:08 -0800 (PST)
Received: from panicking.pdxnet.pdxeng.ch ([5.171.215.77])
	by smtp.gmail.com with ESMTPSA id
	f3sm8973683wmb.12.2021.11.11.07.23.07
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Thu, 11 Nov 2021 07:23:08 -0800 (PST)
From: Michael Trimarchi <michael@amarulasolutions.com>
To: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
Cc: linux-amarula@amarulasolutions.com,
	Anthony Brandon <anthony@amarulasolutions.com>
Subject: [PATCH 06/11] drm/panel: Add Synaptics R63353 panel driver
Date: Thu, 11 Nov 2021 16:22:53 +0100
Message-Id: <20211111152258.26131-6-michael@amarulasolutions.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211111152258.26131-1-michael@amarulasolutions.com>
References: <20211111152258.26131-1-michael@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: michael@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b=SEiqDmSK;
	spf=pass (google.com: domain of michael@amarulasolutions.com
	designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=michael@amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

The LS068B3SX02 panel is based on the Synaptics R63353 Controller.
Add a driver for it.

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
 drivers/gpu/drm/panel/Kconfig                 |   8 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../gpu/drm/panel/panel-synaptics-r63353.c    | 362 ++++++++++++++++++
 3 files changed, 371 insertions(+)
 create mode 100644 drivers/gpu/drm/panel/panel-synaptics-r63353.c

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 2cb8eba76af8..ee135b178235 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -551,6 +551,14 @@ config DRM_PANEL_SITRONIX_ST7789V
 	  Say Y here if you want to enable support for the Sitronix
 	  ST7789V controller for 240x320 LCD panels
 
+config DRM_PANEL_SYNAPTICS_R63353
+	tristate "Synaptics R63353-based panels"
+	depends on OF
+	depends on DRM_MIPI_DSI
+	help
+	  Say Y if you want to enable support for panels based on the
+	  Synaptics R63353 controller.
+
 config DRM_PANEL_SONY_ACX424AKP
 	tristate "Sony ACX424AKP DSI command mode panel"
 	depends on OF
diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
index 6e30640b9099..9e80106f69dc 100644
--- a/drivers/gpu/drm/panel/Makefile
+++ b/drivers/gpu/drm/panel/Makefile
@@ -56,6 +56,7 @@ obj-$(CONFIG_DRM_PANEL_SHARP_LS043T1LE01) += panel-sharp-ls043t1le01.o
 obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7701) += panel-sitronix-st7701.o
 obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o
 obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o
+obj-$(CONFIG_DRM_PANEL_SYNAPTICS_R63353) += panel-synaptics-r63353.o
 obj-$(CONFIG_DRM_PANEL_SONY_ACX424AKP) += panel-sony-acx424akp.o
 obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o
 obj-$(CONFIG_DRM_PANEL_TDO_TL070WSH30) += panel-tdo-tl070wsh30.o
diff --git a/drivers/gpu/drm/panel/panel-synaptics-r63353.c b/drivers/gpu/drm/panel/panel-synaptics-r63353.c
new file mode 100644
index 000000000000..da3886c8a4dc
--- /dev/null
+++ b/drivers/gpu/drm/panel/panel-synaptics-r63353.c
@@ -0,0 +1,362 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Synaptics R63353 Controller driver
+ *
+ * Copyright (C) 2020 BSH Hausgerate GmbH
+ */
+
+#include <linux/delay.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/errno.h>
+#include <linux/fb.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/of_device.h>
+#include <linux/media-bus-format.h>
+
+#include <linux/gpio/consumer.h>
+#include <linux/regulator/consumer.h>
+
+#include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modes.h>
+#include <drm/drm_panel.h>
+
+#include <video/mipi_display.h>
+
+#define R63353_INSTR(...) { \
+		.len = ARRAY_SIZE(((u8[]) {__VA_ARGS__} )), \
+		.data = (const u8 *)&(const u8 []){__VA_ARGS__} \
+	}
+
+struct r63353_instr {
+	size_t len;
+	const u8 * const data;
+};
+
+static const struct r63353_instr sharp_ls068b3sx02_init[] = {
+	R63353_INSTR(0x51, 0xff),
+	R63353_INSTR(0x53, 0x0c),
+	R63353_INSTR(0x55, 0x00),
+	R63353_INSTR(0x84, 0x00),
+};
+
+struct r63353_desc {
+	const char *name;
+	const struct r63353_instr *init;
+	const size_t init_length;
+	const struct drm_display_mode *mode;
+	u32 width_mm;
+	u32 height_mm;
+};
+
+struct r63353_panel {
+	struct drm_panel base;
+	struct mipi_dsi_device *dsi;
+
+	struct gpio_desc *reset_gpio;
+	struct regulator *dvdd;
+	struct regulator *avdd;
+
+	bool prepared;
+	bool enabled;
+	struct r63353_desc *pdata;
+};
+
+static inline struct r63353_panel *to_r63353_panel(struct drm_panel *panel)
+{
+	return container_of(panel, struct r63353_panel, base);
+}
+
+static int r63353_panel_prepare(struct drm_panel *panel)
+{
+	struct r63353_panel *rpanel = to_r63353_panel(panel);
+	int ret;
+
+	if (rpanel->prepared)
+		return 0;
+
+	ret = regulator_enable(rpanel->avdd);
+	if (ret)
+		return ret;
+
+	usleep_range(1000, 2000);
+
+	ret = regulator_enable(rpanel->dvdd);
+	if (ret) {
+		regulator_disable(rpanel->avdd);
+		return ret;
+	}
+
+	if (rpanel->reset_gpio != NULL) {
+		gpiod_set_value(rpanel->reset_gpio, 0);
+		usleep_range(5000, 10000);
+		gpiod_set_value(rpanel->reset_gpio, 1);
+		msleep(120);
+	}
+
+	rpanel->prepared = true;
+
+	return 0;
+}
+
+static int r63353_panel_unprepare(struct drm_panel *panel)
+{
+	struct r63353_panel *rpanel = to_r63353_panel(panel);
+	struct device *dev = &rpanel->dsi->dev;
+
+	if (!rpanel->prepared)
+		return 0;
+
+	if (rpanel->enabled) {
+		dev_err(dev, "Panel still enabled!\n");
+		return -EPERM;
+	}
+
+	gpiod_set_value(rpanel->reset_gpio, 0);
+
+	regulator_disable(rpanel->dvdd);
+	regulator_disable(rpanel->avdd);
+
+	rpanel->prepared = false;
+
+	return 0;
+}
+
+static int r63353_panel_enable(struct drm_panel *panel)
+{
+	struct r63353_panel *rpanel = to_r63353_panel(panel);
+	struct mipi_dsi_device *dsi = rpanel->dsi;
+	struct device *dev = &dsi->dev;
+	int i;
+	int ret;
+
+	if (rpanel->enabled)
+		return 0;
+
+	if (!rpanel->prepared) {
+		dev_err(dev, "Panel not prepared!\n");
+		return -EPERM;
+	}
+
+	ret = mipi_dsi_dcs_soft_reset(dsi);
+	if (ret < 0) {
+		dev_err(dev, "Failed to do Software Reset (%d)\n", ret);
+		goto fail;
+	}
+
+	usleep_range(15000, 17000);
+
+	ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
+	if (ret < 0) {
+		dev_err(dev, "Failed to enter sleep mode (%d)\n", ret);
+		goto fail;
+	}
+
+	for (i = 0; i < rpanel->pdata->init_length; i++) {
+		const struct r63353_instr *instr = &rpanel->pdata->init[i];
+
+		ret = mipi_dsi_dcs_write_buffer(dsi, instr->data, instr->len);
+		if (ret)
+			return ret;
+	}
+
+	msleep(120);
+
+	ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
+	if (ret < 0) {
+		dev_err(dev, "Failed to exit sleep mode (%d)\n", ret);
+		goto fail;
+	}
+
+	usleep_range(5000, 10000);
+
+	/*This call starts sending the data on the display (LINUX LOGO) */
+	ret = mipi_dsi_dcs_set_display_on(dsi);
+	if (ret < 0) {
+		dev_err(dev, "Failed to set display ON (%d)\n", ret);
+		goto fail;
+	}
+
+	rpanel->enabled = true;
+
+	return 0;
+
+fail:
+	gpiod_set_value(rpanel->reset_gpio, 0);
+
+	return ret;
+}
+
+static int r63353_panel_disable(struct drm_panel *panel)
+{
+	struct r63353_panel *rpanel = to_r63353_panel(panel);
+	struct mipi_dsi_device *dsi = rpanel->dsi;
+	struct device *dev = &dsi->dev;
+	int ret;
+
+	if (!rpanel->enabled)
+		return 0;
+
+	ret = mipi_dsi_dcs_set_display_off(dsi);
+	if (ret < 0) {
+		dev_err(dev, "Failed to set display OFF (%d)\n", ret);
+		return ret;
+	}
+
+	usleep_range(5000, 10000);
+
+	ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
+	if (ret < 0) {
+		dev_err(dev, "Failed to enter sleep mode (%d)\n", ret);
+		return ret;
+	}
+
+	rpanel->enabled = false;
+
+	return 0;
+}
+
+static const struct drm_display_mode sharp_ls068b3sx02_timing = {
+	.clock = 70000,
+	.hdisplay = 720,
+	.hsync_start = 720 + 35,
+	.hsync_end = 720 + 35 + 2,
+	.htotal = 720 + 35 + 2 + 150,
+	.vdisplay = 1280,
+	.vsync_start = 1280 + 2,
+	.vsync_end = 1280 + 2 + 4,
+	.vtotal = 1280 + 2 + 4 + 0,
+};
+
+static int r63353_panel_get_modes(struct drm_panel *panel,
+				  struct drm_connector *connector)
+{
+	struct r63353_panel *rpanel = to_r63353_panel(panel);
+	struct drm_display_mode *mode;
+	static const u32 bus_format = MEDIA_BUS_FMT_RGB888_1X24;
+
+	mode = drm_mode_duplicate(connector->dev, rpanel->pdata->mode);
+	if (!mode)
+		return -ENOMEM;
+
+	drm_mode_set_name(mode);
+	drm_mode_probed_add(connector, mode);
+
+	mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
+	connector->display_info.width_mm = rpanel->pdata->width_mm;
+	connector->display_info.height_mm = rpanel->pdata->height_mm;
+
+	drm_display_info_set_bus_formats(&connector->display_info,
+					 &bus_format, 1);
+
+	return 1;
+}
+
+static const struct drm_panel_funcs r63353_panel_funcs = {
+	.prepare = r63353_panel_prepare,
+	.unprepare = r63353_panel_unprepare,
+	.enable = r63353_panel_enable,
+	.disable = r63353_panel_disable,
+	.get_modes = r63353_panel_get_modes,
+};
+
+static int r63353_panel_probe(struct mipi_dsi_device *dsi)
+{
+	struct device *dev = &dsi->dev;
+	struct r63353_panel *panel;
+
+	panel = devm_kzalloc(&dsi->dev, sizeof(*panel), GFP_KERNEL);
+	if (!panel)
+		return -ENOMEM;
+
+	mipi_dsi_set_drvdata(dsi, panel);
+	panel->dsi = dsi;
+	panel->pdata = (struct r63353_desc *)of_device_get_match_data(dev);
+
+	dev_info(dev, "Panel %s\n", panel->pdata->name);
+
+	dsi->lanes = 2;
+	dsi->format = MIPI_DSI_FMT_RGB888;
+	dsi->mode_flags = MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO |
+			  MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM |
+			  MIPI_DSI_MODE_VIDEO_SYNC_PULSE;
+
+	panel->dvdd = devm_regulator_get(dev, "dvdd");
+	if (IS_ERR(panel->dvdd))
+		return PTR_ERR(panel->dvdd);
+	panel->avdd = devm_regulator_get(dev, "avdd");
+	if (IS_ERR(panel->avdd))
+		return PTR_ERR(panel->avdd);
+
+	panel->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
+	if (IS_ERR(panel->reset_gpio)) {
+		dev_err(dev, "failed to get RESET GPIO\n");
+		return PTR_ERR(panel->reset_gpio);
+	}
+	gpiod_set_value(panel->reset_gpio, 0);
+
+	drm_panel_init(&panel->base, dev, &r63353_panel_funcs,
+		       DRM_MODE_CONNECTOR_DSI);
+
+	drm_panel_add(&panel->base);
+
+	return mipi_dsi_attach(dsi);
+}
+
+static int r63353_panel_remove(struct mipi_dsi_device *dsi)
+{
+	struct r63353_panel *rpanel = mipi_dsi_get_drvdata(dsi);
+	struct device *dev = &dsi->dev;
+	int ret;
+
+	ret = mipi_dsi_detach(dsi);
+	if (ret < 0) {
+		dev_err(dev, "Failed to detach from host (%d)\n", ret);
+		return ret;
+	}
+
+	drm_panel_remove(&rpanel->base);
+
+	return 0;
+}
+
+static void r63353_panel_shutdown(struct mipi_dsi_device *dsi)
+{
+	struct r63353_panel *rpanel = mipi_dsi_get_drvdata(dsi);
+
+	r63353_panel_disable(&rpanel->base);
+	r63353_panel_unprepare(&rpanel->base);
+}
+
+static const struct r63353_desc sharp_ls068b3sx02_data = {
+	.name = "Sharp LS068B3SX02",
+	.mode = &sharp_ls068b3sx02_timing,
+	.init = sharp_ls068b3sx02_init,
+	.width_mm = 68,
+	.height_mm = 159,
+};
+
+static const struct of_device_id r63353_of_match[] = {
+	{ .compatible = "sharp,ls068b3sx02", .data = &sharp_ls068b3sx02_data },
+	{ }
+};
+
+MODULE_DEVICE_TABLE(of, r63353_of_match);
+
+static struct mipi_dsi_driver r63353_panel_driver = {
+	.driver = {
+		   .name = "r63353-dsi",
+		   .of_match_table = r63353_of_match,
+	},
+	.probe = r63353_panel_probe,
+	.remove = r63353_panel_remove,
+	.shutdown = r63353_panel_shutdown,
+};
+
+module_mipi_dsi_driver(r63353_panel_driver);
+
+MODULE_AUTHOR("Matthias Proske <Matthias.Proske@bshg.com>");
+MODULE_AUTHOR("Michael Trimarchi <michael@amarulasolutions.com>");
+MODULE_DESCRIPTION("Synaptics R63353 Controller Driver");
+MODULE_LICENSE("GPL v2");