[v3,2/3] arm64: dts: imx8mp: Add Engicam i.Core MX8M Plus SoM
diff mbox series

Message ID 20220321103924.21468-2-abbaraju.manojsai@amarulasolutions.com
State New
Headers show
Series
  • [v3,1/3] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Plus EDIMM2.2 Starter Kit
Related show

Commit Message

Manoj Sai March 21, 2022, 10:39 a.m. UTC 
i.Core MX8M Plus is an EDIMM SoM based on NXP i.MX8M Plus
from Engicam.

General features:
- NXP i.MX8M Plus
- Up to 4GB LDDR4
- 8 eMMC
- Gigabit Ethernet
- USB 3.0, 2.0 Host/OTG
- PCIe 3.0 interface
- I2S
- LVDS
- rest of i.MX8M Plus features

i.Core MX8M Plus needs to mount on top of Engicam baseboards
for creating complete platform solutions.

Add support for it.

Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
---
 changes for v2
     -removed commented properties,
     -removed unsupported driver property,
     -added pin control name for pmic,
     -changed matching naming convention for pmic 9540c node,
     -added node in ascending order.
---
changes for v3
     - updated the nodes as per review comments .
---
---
 .../dts/freescale/imx8mp-icore-mx8mp.dtsi     | 200 ++++++++++++++++++
 1 file changed, 200 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp.dtsi

Comments

Jagan Teki March 21, 2022, 12:36 p.m. UTC | #1 
On Mon, Mar 21, 2022 at 4:09 PM Manoj Sai
<abbaraju.manojsai@amarulasolutions.com> wrote:
>
> i.Core MX8M Plus is an EDIMM SoM based on NXP i.MX8M Plus
> from Engicam.
>
> General features:
> - NXP i.MX8M Plus
> - Up to 4GB LDDR4
> - 8 eMMC
> - Gigabit Ethernet
> - USB 3.0, 2.0 Host/OTG
> - PCIe 3.0 interface
> - I2S
> - LVDS
> - rest of i.MX8M Plus features
>
> i.Core MX8M Plus needs to mount on top of Engicam baseboards
> for creating complete platform solutions.
>
> Add support for it.
>
> Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
> ---
>  changes for v2
>      -removed commented properties,
>      -removed unsupported driver property,
>      -added pin control name for pmic,
>      -changed matching naming convention for pmic 9540c node,
>      -added node in ascending order.
> ---
> changes for v3
>      - updated the nodes as per review comments .
> ---
> ---
>  .../dts/freescale/imx8mp-icore-mx8mp.dtsi     | 200 ++++++++++++++++++
>  1 file changed, 200 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp.dtsi
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp.dtsi
> new file mode 100644
> index 000000000000..cb9a5f4e03e3
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp.dtsi
> @@ -0,0 +1,200 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2018 NXP
> + * Copyright (c) 2019 Engicam srl
> + * Copyright (c) 2020 Amarula Solutons(India)
> + */
> +
> +/ {
> +       compatible = "engicam,icore-mx8mp", "fsl,imx8mp";
> +};
> +
> +&A53_0 {
> +       cpu-supply = <&buck2>;
> +};
> +
> +&A53_1 {
> +       cpu-supply = <&buck2>;
> +};
> +
> +&A53_2 {
> +       cpu-supply = <&buck2>;
> +};
> +
> +&A53_3 {
> +       cpu-supply = <&buck2>;
> +};
> +
> +/* EMMC */
> +&usdhc3 {
> +       pinctrl-names = "default", "state_100mhz", "state_200mhz";
> +       pinctrl-0 = <&pinctrl_usdhc3>;
> +       pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
> +       pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
> +       bus-width = <8>;
> +       non-removable;
> +       status = "okay";
> +};

This is not in ascending order list.

> +
> +&i2c1 {
> +       clock-frequency = <100000>;
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_i2c1>;
> +       status = "okay";
> +
> +       pmic: pca9450@25 {
> +               reg = <0x25>;
> +               compatible = "nxp,pca9450c";
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&pinctrl_pmic>;
> +               interrupt-parent = <&gpio1>;

gpio3

> +               interrupts = <3 GPIO_ACTIVE_LOW>;

1

s/GPIO_ACTIVE_LOW/IRQ_TYPE_LEVEL_LOW

> +
> +               regulators {
> +                       buck1: BUCK1 {
> +                               regulator-name = "BUCK1";
> +                               regulator-min-microvolt = <600000>;
> +                               regulator-max-microvolt = <2187500>;
> +                               regulator-boot-on;
> +                               regulator-always-on;
> +                               regulator-ramp-delay = <3125>;
> +                       };
> +
> +                       buck2: BUCK2 {
> +                               regulator-name = "BUCK2";
> +                               regulator-min-microvolt = <600000>;
> +                               regulator-max-microvolt = <2187500>;
> +                               regulator-boot-on;
> +                               regulator-always-on;
> +                               regulator-ramp-delay = <3125>;
> +                               nxp,dvs-run-voltage = <950000>;
> +                               nxp,dvs-standby-voltage = <850000>;
> +                       };
> +
> +                       buck4: BUCK4{
> +                               regulator-name = "BUCK4";
> +                               regulator-min-microvolt = <600000>;
> +                               regulator-max-microvolt = <3400000>;
> +                               regulator-boot-on;
> +                               regulator-always-on;
> +                       };
> +
> +                       buck5: BUCK5{
> +                               regulator-name = "BUCK5";
> +                               regulator-min-microvolt = <600000>;
> +                               regulator-max-microvolt = <3400000>;
> +                               regulator-boot-on;
> +                               regulator-always-on;
> +                       };
> +
> +                       buck6: BUCK6 {
> +                               regulator-name = "BUCK6";
> +                               regulator-min-microvolt = <600000>;
> +                               regulator-max-microvolt = <3400000>;
> +                               regulator-boot-on;
> +                               regulator-always-on;
> +                       };
> +
> +                       ldo1: LDO1 {
> +                               regulator-name = "LDO1";
> +                               regulator-min-microvolt = <1600000>;
> +                               regulator-max-microvolt = <3300000>;
> +                               regulator-boot-on;
> +                               regulator-always-on;
> +                       };
> +
> +                       ldo2: LDO2 {
> +                               regulator-name = "LDO2";
> +                               regulator-min-microvolt = <800000>;
> +                               regulator-max-microvolt = <1150000>;
> +                               regulator-boot-on;
> +                               regulator-always-on;
> +                       };
> +
> +                       ldo3: LDO3 {
> +                               regulator-name = "LDO3";
> +                               regulator-min-microvolt = <800000>;
> +                               regulator-max-microvolt = <3300000>;
> +                               regulator-boot-on;
> +                               regulator-always-on;
> +                       };
> +
> +                       ldo4: LDO4 {
> +                               regulator-name = "LDO4";
> +                               regulator-min-microvolt = <800000>;
> +                               regulator-max-microvolt = <3300000>;
> +                               regulator-boot-on;
> +                               regulator-always-on;
> +                       };
> +
> +                       ldo5: LDO5 {
> +                               regulator-name = "LDO5";
> +                               regulator-min-microvolt = <1800000>;
> +                               regulator-max-microvolt = <3300000>;
> +                               regulator-boot-on;
> +                               regulator-always-on;
> +                       };
> +               };
> +       };
> +};
> +
> +&iomuxc {
> +       pinctrl_i2c1: i2c1grp {
> +               fsl,pins = <
> +                       MX8MP_IOMUXC_I2C1_SCL__I2C1_SCL         0x400001c3
> +                       MX8MP_IOMUXC_I2C1_SDA__I2C1_SDA         0x400001c3
> +               >;
> +       };
> +
> +       pinctrl_pmic: pmicirq {

pmicgrp

> +               fsl,pins = <
> +                       MX8MP_IOMUXC_NAND_CE0_B__GPIO3_IO01     0x41
> +               >;
> +       };
> +       pinctrl_usdhc3: usdhc3grp {
> +               fsl,pins = <
> +                       MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK      0x190
> +                       MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD      0x1d0
> +                       MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0  0x1d0
> +                       MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1  0x1d0
> +                       MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2  0x1d0
> +                       MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3  0x1d0
> +                       MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4    0x1d0
> +                       MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5   0x1d0
> +                       MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6   0x1d0
> +                       MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7     0x1d0
> +                       MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE  0x190
> +               >;
> +       };
> +
> +       pinctrl_usdhc3_100mhz: usdhc3grp-100mhz {

same comment as v1.  usdhc3-100mhzgrp

> +               fsl,pins = <
> +                       MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK      0x194
> +                       MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD      0x1d4
> +                       MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0  0x1d4
> +                       MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1  0x1d4
> +                       MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2  0x1d4
> +                       MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3  0x1d4
> +                       MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4    0x1d4
> +                       MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5   0x1d4
> +                       MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6   0x1d4
> +                       MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7     0x1d4
> +                       MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE  0x194
> +               >;
> +       };
> +       pinctrl_usdhc3_200mhz: usdhc3grp-200mhz {
> +               fsl,pins = <
> +                       MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK      0x196
> +                       MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD      0x1d6
> +                       MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0  0x1d6
> +                       MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1  0x1d6
> +                       MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2  0x1d6
> +                       MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3  0x1d6
> +                       MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4    0x1d6
> +                       MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5   0x1d6
> +                       MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6   0x1d6
> +                       MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7     0x1d6
> +                       MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE  0x196
> +               >;

ditto.

Jagan.

Patch
diff mbox series 

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp.dtsi
new file mode 100644
index 000000000000..cb9a5f4e03e3
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp.dtsi
@@ -0,0 +1,200 @@ 
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2018 NXP
+ * Copyright (c) 2019 Engicam srl
+ * Copyright (c) 2020 Amarula Solutons(India)
+ */
+
+/ {
+	compatible = "engicam,icore-mx8mp", "fsl,imx8mp";
+};
+
+&A53_0 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_1 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_2 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_3 {
+	cpu-supply = <&buck2>;
+};
+
+/* EMMC */
+&usdhc3 {
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc3>;
+	pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
+	bus-width = <8>;
+	non-removable;
+	status = "okay";
+};
+
+&i2c1 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c1>;
+	status = "okay";
+
+	pmic: pca9450@25 {
+		reg = <0x25>;
+		compatible = "nxp,pca9450c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_pmic>;
+		interrupt-parent = <&gpio1>;
+		interrupts = <3 GPIO_ACTIVE_LOW>;
+
+		regulators {
+			buck1: BUCK1 {
+				regulator-name = "BUCK1";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <2187500>;
+				regulator-boot-on;
+				regulator-always-on;
+				regulator-ramp-delay = <3125>;
+			};
+
+			buck2: BUCK2 {
+				regulator-name = "BUCK2";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <2187500>;
+				regulator-boot-on;
+				regulator-always-on;
+				regulator-ramp-delay = <3125>;
+				nxp,dvs-run-voltage = <950000>;
+				nxp,dvs-standby-voltage = <850000>;
+			};
+
+			buck4: BUCK4{
+				regulator-name = "BUCK4";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			buck5: BUCK5{
+				regulator-name = "BUCK5";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			buck6: BUCK6 {
+				regulator-name = "BUCK6";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo1: LDO1 {
+				regulator-name = "LDO1";
+				regulator-min-microvolt = <1600000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo2: LDO2 {
+				regulator-name = "LDO2";
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <1150000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo3: LDO3 {
+				regulator-name = "LDO3";
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo4: LDO4 {
+				regulator-name = "LDO4";
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo5: LDO5 {
+				regulator-name = "LDO5";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+		};
+	};
+};
+
+&iomuxc {
+	pinctrl_i2c1: i2c1grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_I2C1_SCL__I2C1_SCL		0x400001c3
+			MX8MP_IOMUXC_I2C1_SDA__I2C1_SDA		0x400001c3
+		>;
+	};
+
+	pinctrl_pmic: pmicirq {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_CE0_B__GPIO3_IO01	0x41
+		>;
+	};
+	pinctrl_usdhc3: usdhc3grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK	0x190
+			MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD	0x1d0
+			MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0	0x1d0
+			MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1	0x1d0
+			MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2	0x1d0
+			MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3	0x1d0
+			MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4	0x1d0
+			MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5	0x1d0
+			MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6	0x1d0
+			MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7	0x1d0
+			MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE	0x190
+		>;
+	};
+
+	pinctrl_usdhc3_100mhz: usdhc3grp-100mhz {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK	0x194
+			MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD	0x1d4
+			MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0	0x1d4
+			MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1	0x1d4
+			MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2	0x1d4
+			MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3	0x1d4
+			MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4	0x1d4
+			MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5	0x1d4
+			MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6	0x1d4
+			MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7	0x1d4
+			MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE	0x194
+		>;
+	};
+	pinctrl_usdhc3_200mhz: usdhc3grp-200mhz {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK	0x196
+			MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD	0x1d6
+			MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0	0x1d6
+			MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1	0x1d6
+			MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2	0x1d6
+			MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3	0x1d6
+			MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4	0x1d6
+			MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5	0x1d6
+			MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6	0x1d6
+			MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7	0x1d6
+			MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE	0x196
+		>;
+	};
+};