From patchwork Fri May 20 23:58:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 1976 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id D555F3F03D for ; Sat, 21 May 2022 01:58:51 +0200 (CEST) Received: by mail-wm1-f70.google.com with SMTP id e9-20020a05600c4e4900b00394779649b1sf6838048wmq.3 for ; Fri, 20 May 2022 16:58:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1653091131; cv=pass; d=google.com; s=arc-20160816; b=Jip1iVGrGeI7Dp1A9SwKALfTaWHtORT8IYHZ63EYt3M67IMPZOCa0E0IVxOOt61TMO hIPJBVVZPluBUeVH7ahuj9Kj3XIkoradpXpbL9+YDJeNlq+hHzEAFpUPFdVIU2IOKtnO kUlqQV3ULh7imjB8p3x04CFpZTYaXLCVuLzJUouzYd98mssu4tljeWFHFVkeYbQlkRMe N5hJT2uknRFPB5tSpQVE90vaWrqPGU+LpxIaVj0BgwDM4/Hza6zn9PX2obDjZZUYUOww SQmc6RsPUGaqgYW3gucXgVrLEkeguAwTd3qKcKFRN0L8o7LcICtk9dITa0bUGaebla2F hUJw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=dw3HcrfpjefV9VX/2SzWivLSRqwxl0H2J58IyDR06io=; b=nQpxCCFYpIFrC5wPSGN/s+SxmGFnNb/9ATw/PjmrRK8/nq/soazx3qlypyEq2JqfuP fozgou8NHaTJ1O/qRN+qXWw5G64dk4/rXPTL1PWF9hR96dNh+u0q99k7Si/GF8fm6emA oI0iFoYeuDCAq9V0Snl8iK0wmyoUJMwU5yqtQPqykOZRiBMNapq8JdlRB0S6XToIp+qm vMK4weIn1Scs2YvE+lfhFkkiTA3PvAHkBTYXLIAqETfp6BSUkxU1K3iEmzhmqovQVwU4 XxRjRTyI+7tM65o1oG39swLvSNbjHu13oZGk8dwZbp78J82m1Qq8vGUR/pV2J6U320bx EiuA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=n8YxOwsV; spf=pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=tommaso.merciai@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=dw3HcrfpjefV9VX/2SzWivLSRqwxl0H2J58IyDR06io=; b=AgXCd0tPEgBmFJdOJmisWwTW82BjVvHkacDeV88WK3qtkRDgAseNDLOicTvfusrOGF QIuXTG9TCyq7W5fcogyX7qHO+itqrDnPoadN9KiFJy6HAusz0wvURS+jeo8E1botpjek 46kdpR7UaIYV8IRAWI0gzUDfsp38NEUlMB5tA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:x-spam-checked-in-group:list-post:list-help :list-archive:list-unsubscribe; bh=dw3HcrfpjefV9VX/2SzWivLSRqwxl0H2J58IyDR06io=; b=rnyCnhlJ3ZsOvqRpEFKKUqkAmaTmpy9ayEyrR6l+lbiTscWq4bFDCMTgLJlAomexmn S5MZzxJbuD7ZXd5vamk9b4DWiIO23fyTy0Wy1xoJrtlZu9AMoxKh01WBnIywaJzgSjca dY8SYbIhylGGVcxWpIFYyS7MyUkKzpabPk8k1tjGg8wCLw3IVhusJ6sHHbwRKoUMnt9Q /0zxUsr2fAhylQNGjriFbZeny+1gGyReSXG7LA9GsOfvnEf2kWDcPeALyb7FFL0bwpdz pi8RH60w3w26H7L2ADvDqfyOmvKfg5tos2UDDxxIWM97oHG5C6mR3+SK9kGbiWIZBEaU a+ew== X-Gm-Message-State: AOAM531Zw1YQ0q5vgc53+rpcOhSKvsQJiyPoh49E3gutxDTHXLoCRW2X Hy1LOotPn64H5WDMvg/FR8WTiwQe X-Google-Smtp-Source: ABdhPJx8UOj/z39KX/e4ejQLEVBsbuXqHcMQuxxayHZ/Sm4EEo2ah8TpXl/xs6uRC93iBYNJGuSNvg== X-Received: by 2002:a05:600c:4313:b0:397:26c9:dda1 with SMTP id p19-20020a05600c431300b0039726c9dda1mr10516713wme.184.1653091131428; Fri, 20 May 2022 16:58:51 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:600c:ad8:b0:394:2fc9:9c19 with SMTP id c24-20020a05600c0ad800b003942fc99c19ls6152666wmr.3.canary-gmail; Fri, 20 May 2022 16:58:50 -0700 (PDT) X-Received: by 2002:a05:600c:3482:b0:397:caa:9e68 with SMTP id a2-20020a05600c348200b003970caa9e68mr10680653wmq.118.1653091130322; Fri, 20 May 2022 16:58:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653091130; cv=none; d=google.com; s=arc-20160816; b=FkzaAf5BLSI2Kub46+u/Ib6RzK6WHp0W61TmoqUVZ5naWjQWOyj0l8pphvC03khTic w338JbVk+q1z53i06dAtjZCdwm9Q5jxKZ3xnp8qS40yxiWxoyE3oundoMJ23f+ZhTOiC tSRJQzK94Fvk58tu7aqXB+gKfevTQVZOr3z7HSpoai8aD8D5+ier/fFLQ0l5MGld+OWj oSCegtp16OvxjboiYFbw6/5CwaSwDi0NUQUFc0LTMdYKpu7Aj/wM8i+higGKoIPR1iKX 2sZDAVAjKul+VZP91iKIF6J05EsfTAzZ4rR6YxE2+h4z9Ku5L8JlSHepQ/64GxZY5ODy ccuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=CZudmt8QjK7Ob0wwst9Iisd3ub5uSgdUrqhdvCAPlJY=; b=vdr4PWPIj++cyrvzr9twSJm4DgP9xZLn0Do3lvu6wO1AHDNpSF3/a4AKh1fsLSbbmS w0u/1QiIiT8/9tNDAcStIM2EaDNuewI314SbLPFnMy3XR1wW8+P9kA7NLSWW3CHCvY9m Hg/TQ1uK9gQMHm6LcIaErVGogsHsfYOI2Y+b/aptr0cZ5/1Ug+Q984xrwGJjc9bE066e MuRymeDlVBKDBcVX2ROs+aTnc9I9n3F3JBTiH3C+DVCYyP72fLScRkGW9KJ+iELX/UAL +mVjTOHFa5GltXyHV8pXzk6/PL8ndRjf5YKTcxMlyJUlbk2ysJEmX/RauuW8JvafBUpI 86dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=n8YxOwsV; spf=pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=tommaso.merciai@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id n64-20020a1ca443000000b0039732b3233fsor1214773wme.1.2022.05.20.16.58.50 for (Google Transport Security); Fri, 20 May 2022 16:58:50 -0700 (PDT) Received-SPF: pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:600c:3c8b:b0:397:2db3:97a8 with SMTP id bg11-20020a05600c3c8b00b003972db397a8mr9203193wmb.132.1653091130092; Fri, 20 May 2022 16:58:50 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-53-154.cust.vodafonedsl.it. [188.217.53.154]) by smtp.gmail.com with ESMTPSA id l41-20020a05600c1d2900b003973343c014sm3216306wms.33.2022.05.20.16.58.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 16:58:49 -0700 (PDT) From: Tommaso Merciai To: Cc: tommaso.merciai@amarulasolutions.com, michael@amarulasolutions.com, alberto.bianchi@amarulasolutions.com, linux-amarula@amarulasolutions.com, linuxfancy@googlegroups.com, Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] net: phy: DP83822: enable rgmii mode if phy_interface_is_rgmii Date: Sat, 21 May 2022 01:58:46 +0200 Message-Id: <20220520235846.1919954-1-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Original-Sender: tommaso.merciai@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=n8YxOwsV; spf=pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=tommaso.merciai@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , RGMII mode can be enable from dp83822 straps, and also writing bit 9 of register 0x17 - RMII and Status Register (RCSR). When phy_interface_is_rgmii rgmii mode must be enabled, same for contrary, this prevents malconfigurations of hw straps References: - https://www.ti.com/lit/gpn/dp83822i p66 Signed-off-by: Tommaso Merciai Co-developed-by: Michael Trimarchi Suggested-by: Alberto Bianchi Tested-by: Tommaso Merciai Reviewed-by: Andrew Lunn --- Changes since v2: - Fix comment of register name RSCR -> RCSR - Fix define DP83822_RGMII_MODE_EN location Changes since v1: - Improve commit msg - Add definition of bit 9 reg rcsr (rgmii mode en) - Handle case: phy_interface_is_rgmii is false drivers/net/phy/dp83822.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c index ce17b2af3218..e6ad3a494d32 100644 --- a/drivers/net/phy/dp83822.c +++ b/drivers/net/phy/dp83822.c @@ -94,7 +94,8 @@ #define DP83822_WOL_INDICATION_SEL BIT(8) #define DP83822_WOL_CLR_INDICATION BIT(11) -/* RSCR bits */ +/* RCSR bits */ +#define DP83822_RGMII_MODE_EN BIT(9) #define DP83822_RX_CLK_SHIFT BIT(12) #define DP83822_TX_CLK_SHIFT BIT(11) @@ -408,6 +409,12 @@ static int dp83822_config_init(struct phy_device *phydev) if (err) return err; } + + phy_set_bits_mmd(phydev, DP83822_DEVADDR, + MII_DP83822_RCSR, DP83822_RGMII_MODE_EN); + } else { + phy_clear_bits_mmd(phydev, DP83822_DEVADDR, + MII_DP83822_RCSR, DP83822_RGMII_MODE_EN); } if (dp83822->fx_enabled) {