From patchwork Sun May 22 13:41:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Trimarchi X-Patchwork-Id: 1983 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 0DE2A3F05D for ; Sun, 22 May 2022 15:41:52 +0200 (CEST) Received: by mail-ej1-f69.google.com with SMTP id gh15-20020a170906e08f00b006fea2a22319sf2531494ejb.20 for ; Sun, 22 May 2022 06:41:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1653226911; cv=pass; d=google.com; s=arc-20160816; b=w6lqFM2yYm+o4YdbNaY/O/899yv2+PLhgYdrr+5zCTANvRchNqYTvizm6DKt5laBgl jP0UlIsVrQH8ss7Y2aDdTFVhYb78ByQELNoYX7jI9NazR4uHPnbRUF/0JVpXYc4q7wbi 9YUyYHdY53vMho9DFGq1C8FMNsEVTO0nVINIqqVUa20sMQXL2V8h+mRbJusaVjgDkk3a gF8c0f9OES4CUObL5VoU825zPhGHVbasFtpURwYPiDx1X6gkDPONAYw/qVo0V2/eYjhu oj3T4C2mWtWTT5uOjOQ8IAe1Js1cso/b6CXR1axX5YHVGdV2T1p8VdZcSre222fNtDjZ Q5cQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=eLwlmmADiyjXQavaxCgs9hHzrz6hzJFkRaGiqqpJxJ0=; b=0kmgm4kqLlKoqNZ9Mw305MHGzOtBVXdhnVeVEaJgi7+XQYr9whF3zBxu/Ivlg9+dqt mjMjWsHcNVKBuTPrWDC5rHn/4oXowlWKGrSfNn5HZHADz57/N4oVtVYU+YmXSGSz9rWL 6t4A9iSCNN6BsO5ZbPnuy4nLF1H4XmeJVBEQISpi4QwLsKtG2Qxqtx7e8azPjqq3ULtM wC9Ugkfv6Xzu3hIQrY7AuRWAv0nMgfhFPKt+CCG6biNexvvQNLnBWs3wfV3O2w6oRkXE 2ViO67N+cdZs3vTqXUf6K8YvnKKM5Cx9GthRGQHaiStpvbcuE5+6qjc9aIx+SUdz4ICl Vong== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="U/DCGPp0"; spf=pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=michael@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=eLwlmmADiyjXQavaxCgs9hHzrz6hzJFkRaGiqqpJxJ0=; b=kQmxg4IjrAEKCbRdmh0gSbql3wFBJq0kVgNjSIMCAsRQmyBCN0bYIp51DLIt0TaC/s ek17ZyY+8Mnve/u29vB4qN1z1ljQSR1KTIwNqnfFBCPuuZeEdO9sW3FpC6T7IvnlC6Qg kM2EGr4Pm8W4mCii1Y7/q6IB9x5wOCl1sPBC4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=eLwlmmADiyjXQavaxCgs9hHzrz6hzJFkRaGiqqpJxJ0=; b=VQ1LYILjLIsYildHJYlKovhR6v31JYB+z2NtZ2G0Ozg6tVUxqsoZo/o/wNq2j4OGTF tguHl4EX3d0NS+jawU9sbtLG6Y4I0PrrDicA+PUykS/mELSHz28cMkKq8sGEcEfrhnFl v3U26hwIhAm84XPHnTcTqIcsJFhVlbMMcm83sK7LKT1n03R9HuSF4nH2wX6KA00C2WWx 7/x8dI+gCFU0rcPRH2II2vJJ7vvR6aFSo5dDmdU0KoAPSnj4CclHeU4iO+sKsX8NeUGA ykPPrUmh5mn7O9UXUOreHwwiJxHrWLCpsTKrLJcj12y5WT4EmpIeB5L18Mo/nqjTXpu2 iQAg== X-Gm-Message-State: AOAM531z/etCNWKOFQ6ojt3UGKenBc5v46P3onvqSM2r5QlboJwbpWVV qIvtHAXN/B2V+QsL3EAojnN+FkxP X-Google-Smtp-Source: ABdhPJwO1FG6nVUEZ9rb0rUSMY0KZhc20+LXGF2HexH5y/gI5hC2JgrMdhzWX1xrqV8T6EzoP6dyUg== X-Received: by 2002:a17:907:3e92:b0:6f4:7ab4:20a5 with SMTP id hs18-20020a1709073e9200b006f47ab420a5mr16565110ejc.620.1653226911863; Sun, 22 May 2022 06:41:51 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:6402:5415:b0:42b:305b:5501 with SMTP id ev21-20020a056402541500b0042b305b5501ls871444edb.0.gmail; Sun, 22 May 2022 06:41:50 -0700 (PDT) X-Received: by 2002:aa7:df86:0:b0:42a:ba05:3ee7 with SMTP id b6-20020aa7df86000000b0042aba053ee7mr19521849edy.141.1653226910507; Sun, 22 May 2022 06:41:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653226910; cv=none; d=google.com; s=arc-20160816; b=Kbz4EoQWyEjlE+TmZo2nxPmgrxMUrbIYQu06vp7/J5FwniXeytNgvOVQ7r1clvBE5W Gk167wXiVxN6cWJch+05tSMf/mmMBhjaNuqq7ZRDCa1LAvqHu8eQr11xi9clYJPCe2gg M0BAJzLkSufN8jeikVdDwRyXm0IJiN901AWvPIWQ5l8PDKm5djbcB1OEZCxHXhYsaFRB fV5PjaTj6cWCWXa8rtNdMrouCUS+9V/sUQM5joYBWrsuOIjHL50Ll6obmoy3QmVO4r0O dbV2WgqJJDCLuf4wqFbHx2RKJbU0FnYqo/ZHKbPawuHff98fHth50jsWtaLZDe9qjP5k RYyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=wwCzHLqAYP1e3pWxNFSfQy0wYVL2yigOJdfonllZrJs=; b=YDr22v+/nNqTGDVa9lRetsN4gcERjM5EAEZ+iQQb76D7w2VugaD6KNSdZRHeJlKOpi uCO6xHPUds01EHB/BFCwBd4Rj8WOu1hU6qy3iIBVqc/0V8GyOEd/g8VB1nZWrzk4jV0D 8ARx+kynbOOLnY0PypQ0xyJwuD6/onC7T3FR76yB1yMB3bNV63ofOaIAdwFUaRzhqntX 8HxwSUbqEwPberbuBFzT4bHpVXNZZnpaGk4vMjbzgw/f3FIZtkA+2YLTcTyCLY3oM2+S d1oI76MqEYIPmYzWfWXIaa5Mi8rm3Dkne+echTR/0iciTRJBJlca8DZ/LWZXCZBiwovZ uxKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="U/DCGPp0"; spf=pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=michael@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id j3-20020a170906534300b006fe88301d74sor5370649ejo.110.2022.05.22.06.41.50 for (Google Transport Security); Sun, 22 May 2022 06:41:50 -0700 (PDT) Received-SPF: pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:907:9615:b0:6f4:92ab:4fce with SMTP id gb21-20020a170907961500b006f492ab4fcemr16188565ejc.95.1653226910196; Sun, 22 May 2022 06:41:50 -0700 (PDT) Received: from panicking.amarulasolutions.com (host-80-21-24-253.business.telecomitalia.it. [80.21.24.253]) by smtp.gmail.com with ESMTPSA id h22-20020aa7cdd6000000b0042abb914d6asm6772383edw.69.2022.05.22.06.41.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 May 2022 06:41:49 -0700 (PDT) From: Michael Trimarchi To: Tommaso Merciai Cc: linux-amarula@amarulasolutions.com Subject: [PATCH V2 3/3] net: phy: DP83822: check for supported interface modes in config_init Date: Sun, 22 May 2022 15:41:46 +0200 Message-Id: <20220522134146.120312-3-michael@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220522134146.120312-1-michael@amarulasolutions.com> References: <20220522134146.120312-1-michael@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: michael@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="U/DCGPp0"; spf=pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=michael@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Let config_init check for unsupported interface modes Signed-off-by: Michael Trimarchi --- drivers/net/phy/dp83822.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c index 0b35f6d1a08e..beb3203aaf9f 100644 --- a/drivers/net/phy/dp83822.c +++ b/drivers/net/phy/dp83822.c @@ -387,6 +387,11 @@ static int dp83822_config_init(struct phy_device *phydev) int err = 0; int bmcr; + if (!phy_interface_is_rgmii(phydev) && + phy->interface != PHY_INTERFACE_MODE_RMII && + phy->interface != PHY_INTERFACE_MODE_MII) + return -ENODEV; + if (phy_interface_is_rgmii(phydev)) { trx_int_delay = phy_get_internal_delay(phydev, dev, NULL, 0, true);