From patchwork Mon May 23 13:22:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 1984 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 7DB9C3F0D5 for ; Mon, 23 May 2022 15:22:53 +0200 (CEST) Received: by mail-ed1-f69.google.com with SMTP id s9-20020aa7c549000000b0042ab6ab62f0sf10614495edr.14 for ; Mon, 23 May 2022 06:22:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1653312173; cv=pass; d=google.com; s=arc-20160816; b=ancBOW5qvmGGfsYQnFiYQoKPatq64NBakGsRMkXFVo/2hgBNS53bvN5Px4vEIwQEdf 1J+ne+LfnHt1JQxDXQbjvDDAj/yHWH80GQ0r0wq61xl5+jHQ1eEw46OHkrCqavJ95rZY dLfiQmhvsBHAvC5zzcrZYemM7z3XhE8neu9/3bYMIRs2e/l0+KmyEBDjf/9mxErLwAcS Ncb0UX9uz691tAyuLRkhGGWOkJH8OY7yH/haoTAIFOL8n+sn+BiN4Wv6eDD7+fDigngB bnI/eGP9Ns5iOS5yr2sesBwpj6L+m07dRM1h/n9qMeKtDuqhoEZTqy3ZE2hG3bMXuell gIEA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=br6yLSqkjxiooBvz18M48yePWfVrS4zxVPqtRjfTIew=; b=Ac/hUWnFVdhW35fF/WjNEYnq5Rxkg8EhnyXfPwXbKEHN1TYcsY+Navu+uFRxKLnDd2 w5PUfoL5+9+MvFIUTM0FvDxKwLj9SCURy3sp6yxOXZi6Pld+nMaibZcw1zS9FkhiZxCc tHOKKgvV9qE0vFhG8DrmrtuTC4Ph8rC2y6NyMFr5qgEwfjbeBHEFwbzzt57oEoCO0m18 n6nqUpsjfjDkjbqlwjVy7RWpJ4seuvTHCFBRkQlfOF+Fk2icKP+9qKje1tq5PnZD5/Vn mHGOQMSjjmje+4S2k9cgTQFpcBZBsxhwyH8Qm91X0ByX0nJ0liR54OzGHzgSXZ2DSDwl JC8Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=W4OGyqHL; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=br6yLSqkjxiooBvz18M48yePWfVrS4zxVPqtRjfTIew=; b=ByeRTkij/sH0SCotGfbUa5ZzEBr/zENHkfsqhJUCWP77Y2yjonR9+Mgo8jeKHmirIM Jlxyp+vU68fJzvvqu4eglC3k9WNjRayErp9Tk9ieV6bECOsaslOZBb6MMHJodDbN/Af3 VnXrZaQApxJuGAYbSSfosf8o9O/MFi81lJusc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:x-spam-checked-in-group:list-post:list-help :list-archive:list-unsubscribe; bh=br6yLSqkjxiooBvz18M48yePWfVrS4zxVPqtRjfTIew=; b=ve4Su2iM7yJ7op6lugqBj+2vgc+Ah4A4EUv3yrrEZeBEWugnoa9YBOsmp8KSM07E57 2d9HTUDVYzidYL87AA+p+/ad6psNbXCm4jFTJr07+s+CfWHZKWSxfKiJeqLeCQqxeIRu TruN89vPuJ6y2znznibiPzXDkuW5pQutE51XmqNq7Ha6mjjifUv6rovV7esUP8LD3/L7 Xkvt+L2Lg2onENKQoxkOgsnC2FJaePEl8WGQY2waJjQrxXl7rlz5ajmxnZlWlhWOvtdh JkIp3BwKQKC2q/UOXrYShH9r6DCiB016P0iTVHJGZI9D8UkSQ1AazCed93a+BXYkpUIN zubg== X-Gm-Message-State: AOAM533nA/no7MnT3oo75XN8bOql5PQSoE/rPxvZj9XsVqeBhvCMYDAh 8vkQp5oztxR7M4gH4MVKy7RQaVn9 X-Google-Smtp-Source: ABdhPJy/KMt41aO+2B7oXYH4EQxBR11Jjfru6wNYSPXfUZwoS5o9AOH63LUcrZ7r4VpLcASq++UumA== X-Received: by 2002:a05:6402:424d:b0:42b:6da1:bd25 with SMTP id g13-20020a056402424d00b0042b6da1bd25mr4269321edb.107.1653312173153; Mon, 23 May 2022 06:22:53 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:6402:5415:b0:42b:305b:5501 with SMTP id ev21-20020a056402541500b0042b305b5501ls3332094edb.0.gmail; Mon, 23 May 2022 06:22:52 -0700 (PDT) X-Received: by 2002:a05:6402:d05:b0:425:b5c8:faeb with SMTP id eb5-20020a0564020d0500b00425b5c8faebmr23524831edb.273.1653312172052; Mon, 23 May 2022 06:22:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653312172; cv=none; d=google.com; s=arc-20160816; b=Gk+uGM3E82x0WGULOszGihPKvSf3H+fTMaXqoKMR3al7RPI42Iex58trmZvvbeoehT 5KBnGa8cyKpHkJtY7FpeOAs0xJnK8XW+KN0Op6ceQskK1q7JiM9kH4hJpwX1T0Zr6aGP oW2qnwd1tg+t6A8fD1bInT6JjozJWLs7FVQhlIlRwQ6P4RoCRNCOBbaVIwSymBTk39R7 QfD+9Zv2WYtziEEm1SPeZuKXlKGVv/VjDu3HFiSQC44D8OR8RLNF/fs+6LwnKFPRG/VH 6Y5OiWRaJLreIBfV7H5rbixhkBSbb75ms5VxNEAom1EPKeUa55+9+dViqf3MZmuteUGl nMfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=r8WAmC01JdwEuRA91bKXEDq+9uWVDhRFE7DDNgirVT8=; b=hs4s5SUxoDek7qtOGZncVww8KhKubsE1T4uGywET8ySgQvi3bi1rPi9b0BGm6B9oOU Sd7tCUdiI8U4dtxkr0JNodmiGx5kI0PVKR67POubhhc2I2PE77RJbEJsvASSVZhEK9NT zXosaFdh+UHDE0z2EcLQ38KKhs1KUUL4Ll0MTNsvEFSVoTPabviv4NmpmjgXkMFcHli+ CtffB3VIULEKHGzxr+qqDHQdM3R8ACrG8p6degD0E6gavbaRX9HRntEArDYDsQRY1hsi GsNYqOo7jS7KTEose3NDVz60iN27z0/0qqRreKaMOKQxKmrl0w+/6S0wowj4OwG8mKzL 9t6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=W4OGyqHL; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id m18-20020aa7c2d2000000b0042a628e699fsor8138594edp.58.2022.05.23.06.22.52 for (Google Transport Security); Mon, 23 May 2022 06:22:52 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6402:368b:b0:42b:42c7:f63f with SMTP id ej11-20020a056402368b00b0042b42c7f63fmr11364450edb.409.1653312171880; Mon, 23 May 2022 06:22:51 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-80-116-90-174.retail.telecomitalia.it. [80.116.90.174]) by smtp.gmail.com with ESMTPSA id cw12-20020a170906c78c00b006fec3b388edsm2249351ejb.95.2022.05.23.06.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 06:22:51 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Michael Trimarchi , stable@vger.kernel.org, Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Vinod Koul , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] dmaengine: mxs: fix driver registering Date: Mon, 23 May 2022 15:22:47 +0200 Message-Id: <20220523132247.1429321-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=W4OGyqHL; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Driver registration fails on SOC imx8mn as its supplier, the clock control module, is not ready. Since platform_driver_probe(), as reported by its description, is incompatible with deferred probing, we have to use platform_driver_register(). Fixes: a580b8c5429a ("dmaengine: mxs-dma: add dma support for i.MX23/28") Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Cc: stable@vger.kernel.org --- Changes in v2: - Add the tag "Cc: stable@vger.kernel.org" in the sign-off area. drivers/dma/mxs-dma.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c index 994fc4d2aca4..b8a3e692330d 100644 --- a/drivers/dma/mxs-dma.c +++ b/drivers/dma/mxs-dma.c @@ -670,7 +670,7 @@ static enum dma_status mxs_dma_tx_status(struct dma_chan *chan, return mxs_chan->status; } -static int __init mxs_dma_init(struct mxs_dma_engine *mxs_dma) +static int mxs_dma_init(struct mxs_dma_engine *mxs_dma) { int ret; @@ -741,7 +741,7 @@ static struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec, ofdma->of_node); } -static int __init mxs_dma_probe(struct platform_device *pdev) +static int mxs_dma_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; const struct mxs_dma_type *dma_type; @@ -839,10 +839,7 @@ static struct platform_driver mxs_dma_driver = { .name = "mxs-dma", .of_match_table = mxs_dma_dt_ids, }, + .probe = mxs_dma_probe, }; -static int __init mxs_dma_module_init(void) -{ - return platform_driver_probe(&mxs_dma_driver, mxs_dma_probe); -} -subsys_initcall(mxs_dma_module_init); +module_platform_driver(mxs_dma_driver);