From patchwork Thu Jun 2 16:04:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 1988 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 6597E3F1D5 for ; Thu, 2 Jun 2022 18:04:43 +0200 (CEST) Received: by mail-ed1-f71.google.com with SMTP id k21-20020aa7d2d5000000b0042dcac48313sf3787553edr.8 for ; Thu, 02 Jun 2022 09:04:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1654185883; cv=pass; d=google.com; s=arc-20160816; b=jC13kLdg3X/DLtpse31eyvrgc/fPxOB5oR/a4pz5fFEXqbe8+1mxlrdpHlh2z+xmSs XSibs6dnUHneB6pACpuFbcI9A9AJ/w0PTvlgdlezYC7GffAI9ChjardW1x+mxgGsRQC3 JdAP5KfRfS4ig3csecOxIHrENER97eRVEQmf/8RLaDThtg5Ysr39hwrF2YByLWHG8yRs 3N5bJmUfQmZMv60Y79vq0mdXArHZTajXqSV6SIv3NPfFfkEdEP51sVRFjnbiyMnFxhJE vO08LP7Jjn+3HOrBlpd8Ve8qUio8X2f9gZAB3RcG5qdEySmCPOqAh2b5dSQ7GMh7NIiJ jCCA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=SrWu90v7RwVVGIyj3J1NJ4lNaOE9C3PTcBPEpqAGb3Y=; b=fRVKsxTnP0H9H2iG1cizPTVDFKtqlDZ/+qkq2l4UjmvBDzXNSUK4UGdIDDPDq4qXLO K7KIqx/xKvjLco21cD4MQfwhuiZJtzxu53Mdq9JfqtU2zGnmwVCxBUeng47mTHCXUM4Y QScyi7LlyjsJG1OYwEkDr76gzcQTBBxTM4AMdsDdvFrUgnl8zftsR6A5VHwIyLLxDUu7 Vd6km6/JypE8Vyk1IdSw/tsfWGGeQOByzzqTSduVCOxQSr3GzOrIauxFSX+buBxe74PD wWfgCBifDQLyaX/JUuhXJ44umRXvL1kRbG6cfPAOBFDTU/Xq9VGPN32xmOsxGribb0F9 MlTw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="B1gL++/H"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=SrWu90v7RwVVGIyj3J1NJ4lNaOE9C3PTcBPEpqAGb3Y=; b=rqpN+amPLvm9srT03VzphWGA5tbA9c+Bl9IsYtltIgMU+V3KwCL/pZt2uC+v/KBzrP jtbyQwWjiEZBYBiJwRrJLHmF4fGGd3+pD1UJYGS88Hmzr5t0g/seD+LkXYGx4dlDQrs0 rGICT5kHhhsmo6nbz4hV1HDA9V2Fzjd9bdHMo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=SrWu90v7RwVVGIyj3J1NJ4lNaOE9C3PTcBPEpqAGb3Y=; b=2mrXH+cgMIrWoL7kSi7PNcLZqhk7eLnTtykvT40M9QI6B+1qr5i7iQiPBf51xm/62w As7VucAbw5P/OxrZbdzAHab7dzFQNzlodsGeBSUH3EBy4Z6H3rQge3Jah3wgsyaZlywt jJm4WLDG9kHCkLqoWsxXi/4EEcK6QhNHthMBR2P9ns1EWZcYDY1c3sQywiWvpaGM2a3j ul7/mf3+3IUTJjmwc0oBVmDIlQl/pjiufmaGV240REmlT16DkgYu3HQVPou8FkarSWWw v/d60QSrg0zcWfIylfbOXft+2by6ZGzHXSXx28TGN5TYVSDzy+lXr5iHULh7k5IMvn1s 0SZw== X-Gm-Message-State: AOAM530NxbMhlQHIAHWWkVFt83+Z1mNoCCsI7BktVYy9268BGxZt3mAE vBc9k3MeXPYBW1kPIpWEf0W3/Jlx X-Google-Smtp-Source: ABdhPJzJPXFH3RePm+qSNnpUWRggql0pb8QsRFc5TMsKgzAwddgvz232C3DH+jZFXDVQyX10wrzPOA== X-Received: by 2002:a17:907:7ba9:b0:6fe:5636:1636 with SMTP id ne41-20020a1709077ba900b006fe56361636mr5103528ejc.463.1654185883174; Thu, 02 Jun 2022 09:04:43 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:906:6a26:b0:70a:1088:57d1 with SMTP id qw38-20020a1709066a2600b0070a108857d1ls1684058ejc.3.gmail; Thu, 02 Jun 2022 09:04:42 -0700 (PDT) X-Received: by 2002:a17:907:72d5:b0:6fe:c343:1ace with SMTP id du21-20020a17090772d500b006fec3431acemr4932545ejc.563.1654185881122; Thu, 02 Jun 2022 09:04:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654185880; cv=none; d=google.com; s=arc-20160816; b=gQgU0LktSx4JGJcjJTfzMPjgr4HzsRqOUH7jvoitwpjHN+IrF3lj6OgrsfTpeqgGES uj4fUNjPwbzTMggGUjSBjYQxMEniXuFhazZJBybO+6oAN5mUjU0RO+Xc5CH54dHu5gbr G5Bd67fbuoOxRVdplfPo9/GfouUDk1cANhHavxNWaaD2gS98K81+OBC7NzhmOIptiwMN NOBCrJSM2qnkSivCDGwh5X2NvG5bZXAiEUNwPIPhCfv2D6/kjhIlqO8HD2HVjsgusK2q 01kn09e4hkClTQl+8KVctDcO+RKFAqcNxcA8EwZUG4ZSrnumeuZzxKAAoZz/7PVPk9Ia 7MnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=El3W9x0OB1VE70B0Lt3SBVyO+pC/HDeoL5aPqYtLRdg=; b=aLiBQK63nF/OJFM9D5l9f9hZllgJ8KEyq3iOZBXA/jFE+/b3mieG5zfcYcu61JpS/8 zTLIx0y+Jks5W4zCimNHypFr6bEUhSqTB8EHILiNwHcN5qPaBxg4LeuNfQhkLVrtTW0E VnMH/8XMkGrLqOyZnRn9KTAV4icxppuLbo+o0I8OKG5NRHC5+3PHIYN4s+JCZFDbjyCE fyZkq63Mi1BcLT7lLChd1AmGCwbb/2WXOLTToc2MG5Ea7y2QSM4WsFlGKNVvIVLu5dYP Dy0kxlEETIgwVON4DBQDFQU/X1g15YvQDBJwwzF4nXFvR5BEvDdZ8TQUceVqTWm6jzE/ NoWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="B1gL++/H"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id m17-20020a50ef11000000b0042ab8bf3faesor3173902eds.52.2022.06.02.09.04.40 for (Google Transport Security); Thu, 02 Jun 2022 09:04:40 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6402:5409:b0:42a:a643:4eb8 with SMTP id ev9-20020a056402540900b0042aa6434eb8mr6412687edb.71.1654185880529; Thu, 02 Jun 2022 09:04:40 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-80-116-90-174.pool80116.interbusiness.it. [80.116.90.174]) by smtp.gmail.com with ESMTPSA id f3-20020a056402150300b0042dd3bf1403sm2637095edw.54.2022.06.02.09.04.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jun 2022 09:04:40 -0700 (PDT) From: Dario Binacchi To: linux-amarula@amarulasolutions.com Cc: dario.binacchi@amarulasolutions.com, michael@amarulasolutions.com, tommaso.merciai@amarulasolutions.com Subject: [RFC PATCH v2 02/13] can: slcan: use netdev helpers to print out messages Date: Thu, 2 Jun 2022 18:04:23 +0200 Message-Id: <20220602160434.225417-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220602160434.225417-1-dario.binacchi@amarulasolutions.com> References: <20220602160434.225417-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="B1gL++/H"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Replace printk() calls with corresponding netdev helpers. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/slcan.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/slcan.c b/drivers/net/can/slcan.c index b37d35c2a23a..6162a9c21672 100644 --- a/drivers/net/can/slcan.c +++ b/drivers/net/can/slcan.c @@ -365,7 +365,7 @@ static netdev_tx_t slc_xmit(struct sk_buff *skb, struct net_device *dev) spin_lock(&sl->lock); if (!netif_running(dev)) { spin_unlock(&sl->lock); - printk(KERN_WARNING "%s: xmit: iface is down\n", dev->name); + netdev_warn(dev, "xmit: iface is down\n"); goto out; } if (sl->tty == NULL) { @@ -776,8 +776,7 @@ static void __exit slcan_exit(void) sl = netdev_priv(dev); if (sl->tty) { - printk(KERN_ERR "%s: tty discipline still running\n", - dev->name); + netdev_err(dev, "tty discipline still running\n"); } unregister_netdev(dev);