From patchwork Wed Jun 8 16:51:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2030 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 377703F1F7 for ; Wed, 8 Jun 2022 18:51:28 +0200 (CEST) Received: by mail-ed1-f69.google.com with SMTP id o17-20020a50fd91000000b0042dbded81desf15233463edt.0 for ; Wed, 08 Jun 2022 09:51:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1654707088; cv=pass; d=google.com; s=arc-20160816; b=Epadek6o2noE1Y85pFa3jzBz1gZFmzhoAm/gHOHjN/Klix79ZuzQ5dHQo4wrVbrvn0 zrcXG0zGMT2uJjbOmpK9wBmUNWFstzeTsFmaIFKF8eIPMC6MZaZ3mQ8Y7uHY8fo64Z7/ CqPNZXrnw8Yo4K8f+q/hiaDcd9v6TNHrPYoxj6pOkt2PySIwgohGTz7ffvner1RfvHPn HwfZV5852kG7Clj2WUh28sX2+vkCgkvOqCvBxHPVxcGyU0ODGAF6AS+0O9wAy5jpmgx/ sLPB02kFRxHT+zWFbmF6lcAbDPm7gP2/2jaQMFyUVpEW89JExKMItcJOQ30jqye1VdoC +mLg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=SrWu90v7RwVVGIyj3J1NJ4lNaOE9C3PTcBPEpqAGb3Y=; b=VTKN34xZUKDbYp5cHZVHsw36NbrcErrFV1/T4/ZMeXrhVDHxTj9zodKuC4VIXSUQhF l7juAXwWImHl4RmJSANSe0qyO3gZqzjAVCRZPtY58+LEzC4HKOdDZ2Ipfw84dxuvqV5a wezj9Z8Hl9TTB4gCcPIPXmzYrs+W0hedI2mz20VnOgXQQzccuWxipTCydwGHXbdzUPbo QCDBdHpTaec3GcjmPHoRTZDPboZsKDY7/l6OPFQQH5yNQv+K+QnAVk1Qk09/K8mZ608V fzESa0xMSRwxzUcV9ppCusr7x4uf7K65k0KFUcxuCkuaPqBhg1ZI4Ycsanjq1LuQw0Gk xVJQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ofPeQ4nO; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=SrWu90v7RwVVGIyj3J1NJ4lNaOE9C3PTcBPEpqAGb3Y=; b=J9ZMWR7zZLWfJbcs+rcBS5EsL4RzhcatoCyu1LA62qKDw/Acw/K7cQcyrALi2AB75q p7MUQTlF6ljoi9tBrucU/6Fdv99ywr/oV1B1Myx3ZeqbaGLWjawIRD+7Lvm486gAsb/l LepxQhCcHUkGP4iz7FuLjGAeNIti9aa5vjqGU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=SrWu90v7RwVVGIyj3J1NJ4lNaOE9C3PTcBPEpqAGb3Y=; b=MPoiFXUXoni7UDIVRHSzJHG318/UJh6QUBs0KsdqsU7ZEt66Rx6TALq+euhdRTcaVb WvY+eCGBddAKNpDuOx2KYzSERRGSswY/yibRQH/cfoza4MyeYYP9/2DiK+HFifChelUn Js1iuaP80s0/6rJ9/iW1pgON45w5P1R3Kftx91G6W3Z3EBybsYYLBlMalXpoZ0f09RWm uIRy16DtCVrhMDNTT0hnjVFXLQu9CLMQgwum/fnxoPDZjbJ5VS+Yo09yl1UEi8nTUdat dsEE47rC+7rYj2kUoadXMpNHWCYZUDe2mibf+zhWEuqwzdV50lo2eZvRLzWudV5HWhNh ELBw== X-Gm-Message-State: AOAM533eivln45L+PORwO2fDyRYJPB41FooMGC/eJoRzP43b0sEWTCaM Cyr7dy5iXxSdaaWG3gGKxA6PhwYW X-Google-Smtp-Source: ABdhPJxz3+HMXCWOhtsjpZ8Jr+r7Q6CY48Pz046yR1EW4VnUqK3FmPtezHEUvEVQwNb33ZqWC2Ajdg== X-Received: by 2002:a17:907:6e01:b0:704:8c0e:872f with SMTP id sd1-20020a1709076e0100b007048c0e872fmr32568625ejc.387.1654707087766; Wed, 08 Jun 2022 09:51:27 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:907:7f91:b0:704:cf38:c76b with SMTP id qk17-20020a1709077f9100b00704cf38c76bls1238946ejc.11.gmail; Wed, 08 Jun 2022 09:51:26 -0700 (PDT) X-Received: by 2002:a17:906:4fc9:b0:70f:8970:dda2 with SMTP id i9-20020a1709064fc900b0070f8970dda2mr24260353ejw.324.1654707086634; Wed, 08 Jun 2022 09:51:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654707086; cv=none; d=google.com; s=arc-20160816; b=IqzA2zZzV+Mf1iHR4kGYObQBbCvI0P7+OpZVRnomGANIY3lTqaJ5dh3cL5XkW8MHbT Z0AWHoM61gwYSKlhnbykpQNk1Cd+Yu9E0ojJTJImjt7rvulZmvqcSLuMCkICY/thZViG 07espZtWYRmoryObHXG0F21nFDYO6TErcH+YUkhRcJvOfwYzPSPOENBrYLTI+wz+tDoS F92aqFV/CvUN8a1C9iMJxAZ8D2Y5mGcvdKpGuVc8tqZTlJB/RXd2ryuYQc+WqBaJuuP4 Gebp15aS93Sj7lU7usLOhu9tGaBjLrqe+atfFeygt+tGM01XQM1udU+GFBJAlsxLvB2d Dhjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=El3W9x0OB1VE70B0Lt3SBVyO+pC/HDeoL5aPqYtLRdg=; b=XwmkbsNqtkItMYxHYYHIm6uF+r70qm6mnxFwN+s1+8ErZjot7oKLD+Dy4ulalKbzxj bpOqnlqEekfb2e7tW66aICbmmJijSZ81FKlDy+z2ZaFmNYuFul5nSSKg62mnZFfMmkQv 9L0KooNON+SIHATdRsaHhW372X57CYd0QBGNBixr2wLKb77+zpdrakzjO6QekTQj/oti vg8RRTqwnEzLF4roFQU1f92mz+OymbeD2J95OT6vjWOn9ZejFRpLn4DVHt5J8ooVEqPy NCBxorWi7RIJMkWr2y3iWpE1Lb7ADzkN91iv/KurnKOQFDLsCdaiEejYODK8FXye4lWk XL+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ofPeQ4nO; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id m19-20020a056402511300b0042de1ae31a6sor12170807edd.65.2022.06.08.09.51.26 for (Google Transport Security); Wed, 08 Jun 2022 09:51:26 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6402:1cb5:b0:42d:ddda:7459 with SMTP id cz21-20020a0564021cb500b0042dddda7459mr41312011edb.16.1654707086472; Wed, 08 Jun 2022 09:51:26 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-80-116-90-174.pool80116.interbusiness.it. [80.116.90.174]) by smtp.gmail.com with ESMTPSA id c22-20020a17090654d600b0070587f81bcfsm9569071ejp.19.2022.06.08.09.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 09:51:26 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Marc Kleine-Budde , Paolo Abeni , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2 02/13] can: slcan: use netdev helpers to print out messages Date: Wed, 8 Jun 2022 18:51:05 +0200 Message-Id: <20220608165116.1575390-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220608165116.1575390-1-dario.binacchi@amarulasolutions.com> References: <20220608165116.1575390-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ofPeQ4nO; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Replace printk() calls with corresponding netdev helpers. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/slcan.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/slcan.c b/drivers/net/can/slcan.c index b37d35c2a23a..6162a9c21672 100644 --- a/drivers/net/can/slcan.c +++ b/drivers/net/can/slcan.c @@ -365,7 +365,7 @@ static netdev_tx_t slc_xmit(struct sk_buff *skb, struct net_device *dev) spin_lock(&sl->lock); if (!netif_running(dev)) { spin_unlock(&sl->lock); - printk(KERN_WARNING "%s: xmit: iface is down\n", dev->name); + netdev_warn(dev, "xmit: iface is down\n"); goto out; } if (sl->tty == NULL) { @@ -776,8 +776,7 @@ static void __exit slcan_exit(void) sl = netdev_priv(dev); if (sl->tty) { - printk(KERN_ERR "%s: tty discipline still running\n", - dev->name); + netdev_err(dev, "tty discipline still running\n"); } unregister_netdev(dev);