From patchwork Sun Jun 12 21:39:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2049 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 6E2C53F1DD for ; Sun, 12 Jun 2022 23:39:47 +0200 (CEST) Received: by mail-ed1-f70.google.com with SMTP id o2-20020a056402438200b00434ec3efc03sf920736edc.9 for ; Sun, 12 Jun 2022 14:39:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1655069987; cv=pass; d=google.com; s=arc-20160816; b=makY5qnQH3jG3atrSVp6hS5r+TPfpVsgN9lZUg9IhPWE3yCyZAXy8/bpp5YNpwnVt0 6NQ0l28yvoVtzBAUH1hX76n4nhJwHFEWjoauIn64XqrP2grwbltfzEW7J//JY0mKas5a GQ74i0i/B7xbD2RTBaAxWqNB5w/siKv3SJ0+o4IwJ2x+cfSI4YWthhUQKgtMyJFdcpYV AXSmbhHbEjCBZjItUQ5maugIkdlKYCTlrL1WGXHEmptrzI6hI8+8lWWMQEv0hUnJ6KMA giLtqgpd6uH0ooC37WW/1wfBKopIqIzKyk24d/pT5GNQWlmYwdCbB8Ir2mR3FVIgmTzC kEiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=SrWu90v7RwVVGIyj3J1NJ4lNaOE9C3PTcBPEpqAGb3Y=; b=lFtcINy08wnAmo5n1zyxYw1mJrOf9fXAVGI6vmWBZH/N0VfIRsJ58YQXfdzUp40NyR KfvZZz/hx1ZrfhNMW11P7/hv+5YXIanYDgQDYYvdBGfHCKzaJIc6+xHuuFnv7CyFFoHz TR9DVgWGaTVMKQidNdwQzPbgU4H7aOJV6j2RLo22PD9WDxDWFfs1Or/VYtJCknomc/hG r+Lf1RkF4j6DPrX+d6gfa8agQq/PtY0vgSM1aW92BZFle7W3aruzCSgvX+Uv80iFIlOT 49Tah6XNhpyPEN7LxpxGC4xVGEe1DW/G+4WqzHZMq1xD1twZ09N42xSWleDXCOp+wOG2 wvdA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=FIZh5UTr; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=SrWu90v7RwVVGIyj3J1NJ4lNaOE9C3PTcBPEpqAGb3Y=; b=H7boND/ciLNfpIzWXXEy1SJ5dwzseUuDhCQN2Oye1RAFYgh9mZHzLPFXSBbrctjGf7 gwR8Ih04HWgCgvwa0DkovjCXXSIBBFvaV+27Ihy4+pXKEApSC5RA2QCeeyTPswAG/50c PzwXC7XPkbaCDYqTOo5USiNv2yyUrt/V4pmIg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=SrWu90v7RwVVGIyj3J1NJ4lNaOE9C3PTcBPEpqAGb3Y=; b=40va4tRlT/rsxQufh8CRwlW9XmYwZ2kkFlKo6MtZRcQrkTcJdZ/fDhq6BlLCtZFOoa MbeGB3KjXJeObjlqvVp9F902radT72g+XB2l/ABkn1IqwuwSmjGE6Fe/lDdr7LcDTCkm V/q9noRcBN94unBjtjoDAIqddN1cTsN4vOrGzEpV8mlnvUCN/SFF0xmNPP2iHOO1JDJW yeGGmUUIq4RNuZ2GqG7Grg1Ulq4ES2RdKfp069I+2E6LmjPQtVuMC7OPW8rVDdhddawH izbmsZbwXhSPoD5Vj+fhmCcq3j9rUZ1KJppK6WrHGgqk71MLAoqG8lnj6fx7NjNaq0ep scog== X-Gm-Message-State: AOAM533uoNetJS5hMhNVhHZW8Ip1bzAoSJIFpyvcZTvZcBS1CFSErDET iC5B+nUPsaEBE5rztvvEmuqPl75s X-Google-Smtp-Source: ABdhPJwX+CU/6ayGyLW/y5LFzYQ3RNiCiRMKcdmGqjUNh8ZFn03dOxLwwOthzBM18ix4f7BhTvQMkg== X-Received: by 2002:a17:907:8c1a:b0:715:73d2:df36 with SMTP id ta26-20020a1709078c1a00b0071573d2df36mr2957596ejc.256.1655069987246; Sun, 12 Jun 2022 14:39:47 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:906:6a26:b0:70a:1088:57d1 with SMTP id qw38-20020a1709066a2600b0070a108857d1ls1009638ejc.3.gmail; Sun, 12 Jun 2022 14:39:46 -0700 (PDT) X-Received: by 2002:a17:906:891:b0:70b:c30e:c1f1 with SMTP id n17-20020a170906089100b0070bc30ec1f1mr46761819eje.733.1655069986187; Sun, 12 Jun 2022 14:39:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655069986; cv=none; d=google.com; s=arc-20160816; b=d1BjNgCtIOgXTveMsQoKcQJK4t/GuPPyZl18g0cJz030r43SBGqYFCyufgkvCRL3A7 qqWV2WdTnhLKa6FUo7rRcbTkFAK+KApiASZpFp7aZNc4U2GsifAv0HrO4x2em/ijqRwM U97+Q/fUJui0jOqnvkDI2ju/7gBwugGb9bYn6aBJAh+UhhleGLC8Qhj+Yg3fM1Apu2ex K4lh3jIQ+txJDbqdxK2ji22Kl3iqcTu26h2XpNiqxVIl1kg8SJXvUSojW0yoTDGYmzeC ga6itWlc2xslGCX5BPk5GR9L+toTItS1DyMKuff0K7fm6gE+vZYILgaBp0+SfPPH4xFr V36A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=El3W9x0OB1VE70B0Lt3SBVyO+pC/HDeoL5aPqYtLRdg=; b=NJl5AqJjvNvObiOMiGbbVhhZm4kJ2ggLzZdgZ82RI7BeVPws30YJkdLa7AHV74qkEu Z2RpYiVXWSI/p5irF9TueMqsRm87BYsg9wFhatSpy4/s6UTKH0w/U6GbI+mlYcX7yTg7 oWFnaIv8EaLNANfEkZeth7l4Gdcw3DkxkO3nYLeTAmyjR19JZpVOeNe8Cqv82/ZOxYIN Z4dXCLCaNIrTptsGEc4wX6voRh2d2UdrpY00Mv1hsmHR/wKty0P2sz+1MfXhKVD6HtFH qocePWY9DDiULKsXdkYywvpxGLvycJ0eIQGpQ5sNMc7BAuI5Ug6bFIIJkFvgI+s+3Ynq A+0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=FIZh5UTr; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ee4-20020a056402290400b0042dcafc4527sor1584698edb.50.2022.06.12.14.39.46 for (Google Transport Security); Sun, 12 Jun 2022 14:39:46 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:aa7:c306:0:b0:42d:d4cc:c606 with SMTP id l6-20020aa7c306000000b0042dd4ccc606mr62413182edq.341.1655069986039; Sun, 12 Jun 2022 14:39:46 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-80-116-90-174.pool80116.interbusiness.it. [80.116.90.174]) by smtp.gmail.com with ESMTPSA id u10-20020a1709061daa00b00711d546f8a8sm2909398ejh.139.2022.06.12.14.39.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jun 2022 14:39:45 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: michael@amarulasolutions.com, Amarula patchwork , Oliver Hartkopp , Dario Binacchi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Marc Kleine-Budde , Paolo Abeni , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 02/13] can: slcan: use netdev helpers to print out messages Date: Sun, 12 Jun 2022 23:39:16 +0200 Message-Id: <20220612213927.3004444-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220612213927.3004444-1-dario.binacchi@amarulasolutions.com> References: <20220612213927.3004444-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=FIZh5UTr; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Replace printk() calls with corresponding netdev helpers. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/slcan.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/slcan.c b/drivers/net/can/slcan.c index b37d35c2a23a..6162a9c21672 100644 --- a/drivers/net/can/slcan.c +++ b/drivers/net/can/slcan.c @@ -365,7 +365,7 @@ static netdev_tx_t slc_xmit(struct sk_buff *skb, struct net_device *dev) spin_lock(&sl->lock); if (!netif_running(dev)) { spin_unlock(&sl->lock); - printk(KERN_WARNING "%s: xmit: iface is down\n", dev->name); + netdev_warn(dev, "xmit: iface is down\n"); goto out; } if (sl->tty == NULL) { @@ -776,8 +776,7 @@ static void __exit slcan_exit(void) sl = netdev_priv(dev); if (sl->tty) { - printk(KERN_ERR "%s: tty discipline still running\n", - dev->name); + netdev_err(dev, "tty discipline still running\n"); } unregister_netdev(dev);