From patchwork Tue Jun 14 12:28:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2067 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 5C9F83F03E for ; Tue, 14 Jun 2022 14:28:30 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id y13-20020a056402358d00b0042dfb820070sf6075154edc.6 for ; Tue, 14 Jun 2022 05:28:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1655209710; cv=pass; d=google.com; s=arc-20160816; b=nxtwBwi8ukMey56ibou8QT5Lk+/WVBvY0evIgaQBHSJyk7/4U3Nc/Evn0Tie2ZcGT3 4z5DHqD3QpJIXB4eOIrry5v+o7indv1rJFsZf4CFUO9hhwsG3YosJSloJ6V5oQcv5XWw G+AjnnHgmtK4Uit3j3v30e+PE+Bx0JZC+7BZkbswmfZqPeqYl2yyaIuIjQqtKUd9M8Th PD0asH6TQWmdI9JjVRDQCzkthtLQN3s/7yNRgYHIvXYc8h8Rx7mM0GOBwfayhpkvfz6y hVGuIaggavUiRTcz3ql1VbAeuOEf7JgzHZr/fcAjCDzxIXva9Mh3Pm6v0gB4ylObQza6 /QYQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=SrWu90v7RwVVGIyj3J1NJ4lNaOE9C3PTcBPEpqAGb3Y=; b=gB9I0tDTSM6eNBjUaEXtPTvkVfqAf14xGEeLnDLQujQY9ffDdn7QmbC5DcsSF1FtO+ vSI7KqyYGHSMAyItIhmXeKsHiSDirFnqtw9t9+hNOU1JT23l0f02TlafhsQkO2g3TS6M DW4pZrYEJG+UTW78i2OHWt3wAQjw7gjhbUIVNfM02JcwpGARkh0tlgT0pxGMOeQitQYv D/BBr2NYvzwITtEM7DaekNb2qPdjItN+Q+xn5cPF2PBX3Fuj9p7q1cRlDlqeRI/TyyDa oVacqB4NE8WgeDI3cngHMYzguvmU6TA9eVyji4n4ViHY79HagVJrD60toUss6BAk2dUS JkRg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="BiAOyZ/X"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=SrWu90v7RwVVGIyj3J1NJ4lNaOE9C3PTcBPEpqAGb3Y=; b=GIooCdkJOkSiwjLX9XO4u+iCNMhqMdEAOn+ZI7mlikRoRopOnsLJospjF72AN4h4uU DkvnyEVhavVKUGUUlo94zjLsVdHPEyG0/PMBRZDf+56B8syqfNa5wRI6ZfuNpsPXV7vi nNTJVmh8U5QAl3AbvvEnNyW8l+OxOeN8BtrsE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=SrWu90v7RwVVGIyj3J1NJ4lNaOE9C3PTcBPEpqAGb3Y=; b=SlytFMBLu0TE4vn54CP//aRiMlhkTePnGMP3v0S8I8jX1zCw2K6wVcUwny/gGMDkVY iozfS6inIAihEqgROxL99xjPtvT3H/MEto7bO8GhfL2C1nrDgDX0ApBDiFMZcOsB8yc4 zQAgdfBBK1H1wB7Kzvn7iLHIpAonHkYM+n0VheS2A1rxMXYmCDqNyqaj78kLH6pXDGrN qfd7T/luhXb9uH+qoF9t4bCXlav7YR/pOY3qLuaW9bi1HgdWFoqNGle6Mlj+A0hAPO6v 6wzX47klOOJ+KLZO4S27kaWf4aBvqc+rr/8ZMp7xG1yslrH4TufJGrdlSNRvV052VQiE uzcA== X-Gm-Message-State: AJIora+HWVo7QwsxiOfxK76v6bxJOlRKn4g1busQInH7pqF7jdMZfkgm 6ygb8DXzdtUdVcBSaMwq8fCcqYuO X-Google-Smtp-Source: ABdhPJw2BTr3czZyNZ+NNRRvsBQai8EAWALzYY45u9bmAxuuIf8g9cUKvlx6iftnPKS7cQ/4Zhdl3g== X-Received: by 2002:a17:907:2da6:b0:711:d86d:ccab with SMTP id gt38-20020a1709072da600b00711d86dccabmr4087720ejc.356.1655209710159; Tue, 14 Jun 2022 05:28:30 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:907:9705:b0:70d:ff46:7086 with SMTP id jg5-20020a170907970500b0070dff467086ls991852ejc.4.gmail; Tue, 14 Jun 2022 05:28:29 -0700 (PDT) X-Received: by 2002:a17:906:1501:b0:715:76d0:862a with SMTP id b1-20020a170906150100b0071576d0862amr4046052ejd.681.1655209709184; Tue, 14 Jun 2022 05:28:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655209709; cv=none; d=google.com; s=arc-20160816; b=VHXMwnpaArs4LVOj9zuDBU1NUACwg6nWKOymAYxljWyOLciFyTDgJ9cnijPq+hIK5w McPuZ70WmCHZX0pU8XPPP8QGN/15UKaWhb2guxjmz3VqnHfZyFbBd+av7n6mCiqVQfTq kJymi1SchPdUpR+r9KNOLhOCYapaMj2t/yGNowpABnaz4sqDLcOKcLNcPVYOHc0D+8tI H44AG55Xr0yfCEfP4W/mfhsLHmG2TzKhWnF4dvo6WsYa/fICsh0iMqwmR81BhVQcWa71 CIlyH/tYGdzJvzI5DA2wggz7oJtNzsayEnbLnX7gkTBYFe7lT1I71dbdrPyCKqwi+MIQ pbhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=El3W9x0OB1VE70B0Lt3SBVyO+pC/HDeoL5aPqYtLRdg=; b=XQs67j0S9JB22pYA+kqSYhy8Bk7BMoptfaJaG5ngEuOZpdSWWdJanLsa7plfUW6VAw kxJomYGY+GW9NdTlODJCFQJ+FbbnfFQGmQpUJWCIaTt3+Xf6V2bFRMNPqVooZoUirltH tgu1juIpxIfiKSlucsImNlhzk+EzxFhSJwwSnpEgSvRjs0kBwdqhbo98CPyLdVyYEXlC yPdVKvUJ/nEIRveefAtjXbdNg3JGNuh35ybeHyaWYDKqRLPEpwLceuEZqAyvga0NdGa+ UW9Nuz1qAhqasez0JXSMxX/GNzE17okOKeiO6Zz3zNtTMU6UVwNCmPY++p9m+fGpkjX3 XZ/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="BiAOyZ/X"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ev13-20020a056402540d00b00434f082ea97sor2944953edb.36.2022.06.14.05.28.29 for (Google Transport Security); Tue, 14 Jun 2022 05:28:29 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6402:100c:b0:42d:f407:b050 with SMTP id c12-20020a056402100c00b0042df407b050mr5652088edu.39.1655209708968; Tue, 14 Jun 2022 05:28:28 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.amarulasolutions.com (host-80-116-90-174.pool80116.interbusiness.it. [80.116.90.174]) by smtp.gmail.com with ESMTPSA id z22-20020a17090655d600b006f3ef214e2csm5087043ejp.146.2022.06.14.05.28.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 05:28:28 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , Oliver Hartkopp , michael@amarulasolutions.com, Dario Binacchi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Marc Kleine-Budde , Paolo Abeni , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v4 02/12] can: slcan: use netdev helpers to print out messages Date: Tue, 14 Jun 2022 14:28:11 +0200 Message-Id: <20220614122821.3646071-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220614122821.3646071-1-dario.binacchi@amarulasolutions.com> References: <20220614122821.3646071-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="BiAOyZ/X"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Replace printk() calls with corresponding netdev helpers. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/slcan.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/slcan.c b/drivers/net/can/slcan.c index b37d35c2a23a..6162a9c21672 100644 --- a/drivers/net/can/slcan.c +++ b/drivers/net/can/slcan.c @@ -365,7 +365,7 @@ static netdev_tx_t slc_xmit(struct sk_buff *skb, struct net_device *dev) spin_lock(&sl->lock); if (!netif_running(dev)) { spin_unlock(&sl->lock); - printk(KERN_WARNING "%s: xmit: iface is down\n", dev->name); + netdev_warn(dev, "xmit: iface is down\n"); goto out; } if (sl->tty == NULL) { @@ -776,8 +776,7 @@ static void __exit slcan_exit(void) sl = netdev_priv(dev); if (sl->tty) { - printk(KERN_ERR "%s: tty discipline still running\n", - dev->name); + netdev_err(dev, "tty discipline still running\n"); } unregister_netdev(dev);