From patchwork Tue Jul 12 16:33:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 2111 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 5BEDF3F081 for ; Tue, 12 Jul 2022 18:34:13 +0200 (CEST) Received: by mail-wr1-f70.google.com with SMTP id l5-20020adfa385000000b0021db73f5818sf355954wrb.20 for ; Tue, 12 Jul 2022 09:34:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1657643653; cv=pass; d=google.com; s=arc-20160816; b=yIMMGDocSBPb/ANL7nWzWQOCr0u2KstIsCrzj0wQq1rkdx4rWEyGGCWdmRrFsv0T0V 8gvu0vD2VKm8dJ4EgUW7Yx3zlkvmC1vgI73poKhcnab2L87gPPBauwcseLFnmwNvgkTA doaYTXOPYoof/hCEfUj+CHGqs47+S/ofIjRKaLT+Lt6lGnWbvz2pm8wvtMOtHGNDnBDZ UVhsel8FVhC3jSxqRwRF8sedexvHpD1RzpIgKudUnC/KW6nQ6mtQoBzPsI30JWUCw6uG 12e1K/imUem2/meatbIdhAcXD1VP3D7NWM0N4lbXB7pOoDdK97GMlfMx4rELADdFT2V3 vzGw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=oqWkW2LxfD6S4ORUzeRpTsgvc5j2dAwD84ZMnuqbXNk=; b=rY1+ch+7ug+BbwJPpbCFE/GwRHjCgS9Yg4PTE5zoHEkFcrZGVfWC73Q4+h5/THAnPi qzolQx23BkMXgHn377UnKGkKmVHbSocKX5hb+SsFseiL20k85d+TdMuGlW2bNIQRdjTs Hqog00whW1lqB29+xVxUJWlq1yR0AHqubcerQCGgDtLEs6WWndqWd2L0XPqZf4HldKx0 sj3xIH3B3xvUL9R/VpCr64bybvgs2/1exstCForMMxxkPmejmSmAKvX+D0D74kGHUDeI aJ26x+knLY3vNm8yzTfeSdhWjzuAO9fkGLVbVlr+P7Hws6ZpaoFKT4nY7FA+HODcBZKP GrXw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=CylXyQDI; spf=pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=tommaso.merciai@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=oqWkW2LxfD6S4ORUzeRpTsgvc5j2dAwD84ZMnuqbXNk=; b=Qd1Dpg6bkMWMM6rlpGBg2zx7+I1YA6GaPQs3vUQudr5hm8NHH9dG2Qu+928Aob5+LI DDJSrNnHH+fzTSrMc+m37CIrWewkqYl5wpbzhOI5t2xtBhLAJwTXPh3UEy16b2gQPhtv fVWkWvFbehaZn9MSNBh9VNUEUGT70hbmq8fro= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=oqWkW2LxfD6S4ORUzeRpTsgvc5j2dAwD84ZMnuqbXNk=; b=IH4TM0rWo5TPoUy19dH8o+ajWsi+8Yn2lHicachey896ZiTCBQJWxpVzwr51agNrPk BxPTFe4BshZColA5M/v8//O9eFydtPDSUcav2wiyJtSu9ex3vNo8NYglcQ9tRjlw30bY ozOx63JXNZz07NO77z9jm0VFGYpBeoWNHj/VX8gJo3/4cOGO5jf33yByyKr+LoRzPeej G8tEbojyMUTRv+ohR2ZcP0XSycTXhkFXYZsN0V+nAsKC3S9oqinuaHHDgtgFPgoApZnz V8DyyQCvfhIkJOW2JI67XC2KSaMwf/Dp0B47n1wT7WSUOmdsadmch7nFF47c7gvBUIVi x6kQ== X-Gm-Message-State: AJIora8zxaPDMDRTBCp5RPwaXu2N3s70JAAfmDt4mCCgSafcroB9Z2EU pnHlMoqEUs1BJPHkwrRdSSoths24 X-Google-Smtp-Source: AGRyM1torFS6zxT48qpr+9efv9KwOmqpRWcWaNK9nm/FCCJQB4wmvqG0c7yp/7/nLUB8C8uRz0KiGw== X-Received: by 2002:a05:6000:15ca:b0:21d:a72d:beb8 with SMTP id y10-20020a05600015ca00b0021da72dbeb8mr9885142wry.624.1657643653130; Tue, 12 Jul 2022 09:34:13 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:6000:1ac7:b0:21d:ab25:25ba with SMTP id i7-20020a0560001ac700b0021dab2525bals4967348wry.2.gmail; Tue, 12 Jul 2022 09:34:12 -0700 (PDT) X-Received: by 2002:a05:6000:250:b0:21d:b3b5:3438 with SMTP id m16-20020a056000025000b0021db3b53438mr3392702wrz.203.1657643652086; Tue, 12 Jul 2022 09:34:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657643652; cv=none; d=google.com; s=arc-20160816; b=ALWvdzyd94woOdeUDQCRG29hbu+mW73Oqm31T6KQSOnI55IIBD7BQr8nBWVwpwNoaH +5u33WiUFV6wlBuUdnywhj5wSD61IeDI5Yi1Ud9CaKX6f7wk9BOVPi+gX0+Ri9ZNjaMM yrc1nhIKsmwAGk72KOwhFPd/9hMqJWXocCKSkwDzKfQGGjbDXWH3jTQA/nl+jBXPjiLD wn4yER1XTot1Gtqd5iscpkeaK70roj+W3LIcxcmlgcjpfCTOKyRbUoyvFweWRllR7Y6U xsSusfx/gLo3Zxt1akAW95NRowZkW/FOAUdD0ieNci76LcR5o+vNfQ3TT3NYeLSp7N+A VwaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ctpa/T2vVk1WErHGmcuqVVZ1P5/ZM5PQkEWqW8vXr7A=; b=NBbCBNmJm6XYTAN6CzbQlbWownoiiIV15OvEi5A+pXsT4NAllSoKz6vwPTT8wR8gP+ SKT1u/uHpzUE32ZPHtEVxNn7TTFcAyHp0fgPvHBna+u4iJpVcri5fdwWt6e4qobA1yFh ZJ76QdN5gVwwQitj4xvbjpbiS4Dnt8+Mnr4w+qC9ixujk8kNw8PQPJZ5XICNpiTf5eIJ RSYq/ax7r1HH/oHjYCoA8b3kBCdVLn2W2fY9daiYt2CP9zSHZCMZ2qLRyq9IOquw2DLW cYNwKZIK2tW5y2Kpdc0GLOC/3KREUmno7U5olvY13GfhyCCX8xRbQAqP2vDgmwvevI08 tzQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=CylXyQDI; spf=pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=tommaso.merciai@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id b14-20020adfd1ce000000b0021d745963bdsor4120574wrd.49.2022.07.12.09.34.12 for (Google Transport Security); Tue, 12 Jul 2022 09:34:12 -0700 (PDT) Received-SPF: pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a5d:584e:0:b0:21c:ea0c:3734 with SMTP id i14-20020a5d584e000000b0021cea0c3734mr22283780wrf.420.1657643651827; Tue, 12 Jul 2022 09:34:11 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-53-214.cust.vodafonedsl.it. [188.217.53.214]) by smtp.gmail.com with ESMTPSA id j16-20020a5d6050000000b0021db2dcd0aasm2321052wrt.108.2022.07.12.09.34.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 09:34:11 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Jacopo Mondi , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 3/6] media: ov5693: rename clk into xvclk Date: Tue, 12 Jul 2022 18:33:46 +0200 Message-Id: <20220712163349.1308540-4-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com> References: <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: tommaso.merciai@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=CylXyQDI; spf=pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=tommaso.merciai@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Rename clk pdata pointer into xvclk (system clock input). Same for clk_rate into xvclk_rate. This is more explicit Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi --- Changes since v3: - Add reviewed-by tag, suggested by Jacopo, Krzysztof drivers/media/i2c/ov5693.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index 9e84468d920e..d2adc5513a21 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -157,7 +157,7 @@ struct ov5693_device { struct gpio_desc *reset; struct gpio_desc *powerdown; struct regulator_bulk_data supplies[OV5693_NUM_SUPPLIES]; - struct clk *clk; + struct clk *xvclk; struct ov5693_mode { struct v4l2_rect crop; @@ -794,7 +794,7 @@ static void ov5693_sensor_powerdown(struct ov5693_device *ov5693) regulator_bulk_disable(OV5693_NUM_SUPPLIES, ov5693->supplies); - clk_disable_unprepare(ov5693->clk); + clk_disable_unprepare(ov5693->xvclk); } static int ov5693_sensor_powerup(struct ov5693_device *ov5693) @@ -804,7 +804,7 @@ static int ov5693_sensor_powerup(struct ov5693_device *ov5693) gpiod_set_value_cansleep(ov5693->reset, 1); gpiod_set_value_cansleep(ov5693->powerdown, 1); - ret = clk_prepare_enable(ov5693->clk); + ret = clk_prepare_enable(ov5693->xvclk); if (ret) { dev_err(ov5693->dev, "Failed to enable clk\n"); goto fail_power; @@ -1390,7 +1390,7 @@ static int ov5693_check_hwcfg(struct ov5693_device *ov5693) static int ov5693_probe(struct i2c_client *client) { struct ov5693_device *ov5693; - u32 clk_rate; + u32 xvclk_rate; int ret = 0; ov5693 = devm_kzalloc(&client->dev, sizeof(*ov5693), GFP_KERNEL); @@ -1408,16 +1408,16 @@ static int ov5693_probe(struct i2c_client *client) v4l2_i2c_subdev_init(&ov5693->sd, client, &ov5693_ops); - ov5693->clk = devm_clk_get(&client->dev, "xvclk"); - if (IS_ERR(ov5693->clk)) { + ov5693->xvclk = devm_clk_get(&client->dev, "xvclk"); + if (IS_ERR(ov5693->xvclk)) { dev_err(&client->dev, "Error getting clock\n"); - return PTR_ERR(ov5693->clk); + return PTR_ERR(ov5693->xvclk); } - clk_rate = clk_get_rate(ov5693->clk); - if (clk_rate != OV5693_XVCLK_FREQ) + xvclk_rate = clk_get_rate(ov5693->xvclk); + if (xvclk_rate != OV5693_XVCLK_FREQ) dev_warn(&client->dev, "Found clk freq %u, expected %u\n", - clk_rate, OV5693_XVCLK_FREQ); + xvclk_rate, OV5693_XVCLK_FREQ); ret = ov5693_configure_gpios(ov5693); if (ret)