From patchwork Wed Jul 13 06:54:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Trimarchi X-Patchwork-Id: 2118 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 6132F3F1F7 for ; Wed, 13 Jul 2022 08:54:12 +0200 (CEST) Received: by mail-ej1-f69.google.com with SMTP id jg29-20020a170907971d00b0072b5acf30e7sf2631350ejc.8 for ; Tue, 12 Jul 2022 23:54:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1657695252; cv=pass; d=google.com; s=arc-20160816; b=RoCd1orzcL1vF4sGkGGQ86S2J7CaJJxcx9bPusD+O4ybfDR8NtZubrxq0avQk7VXVw TrAZuu0CFWihRblTZzFWH3JS5s2KRLpWdG6A+LTu5UcQtqCAnmKYjCJw/4q8wJGHub2L p1JhX9MMAlNnUjgfFrFWm2uJsQWoRb/TwBQS3YrPZRUgM1yCxVcJr1BrFdRBRLpyPEN0 p6lIPZZTn/Sw48NYh9pr7abGSL0DRQIcAd90oD0BAedPdShOYUITxKTZqADnqCej0Mbn PztUsIybtKS50MyjqMr06fbG05SIBUHlYJJ/yVwkqdX4MP3NSWdAt8Dz46vPMPTlOAil IIZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:to :from:dkim-signature; bh=w6jeEffYbyh5yW4irRptvwg51uM2EHfMcnY/JdAF/24=; b=S2jeSnr92zxFXL5pga9jjLNyWU/DHrGcpXLfT8q7e2WFHYCVZ6UgD0FBhkE8AS8OBn PoBVn3OgI6CAVgisxsupBb/p00a87Fema8cvr+c/Xcl5iQ45+oCJXzL1j1i/eKcfGL6e KYpTaJeC52P+Z49nXu4vGMeHaENq4sZ45qb5jWjlyx0bt9SqcEBnFs9ctLvho4bVILhm p9UctPMgvjUSkFVMzoEj0WGEk4W+znyUQMp6QCNnJL8hGKUI1Ua9yBsbM4xCOGd+ryR3 notd+LcdIV17ZBevK1/henpUfTGmu0pTh5nHaaYAulNLzhmBNhKmbmf3PcaN3EFEnc5M JB3w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=d4MfGWv0; spf=pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=michael@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:subject:date:message-id:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=w6jeEffYbyh5yW4irRptvwg51uM2EHfMcnY/JdAF/24=; b=kQiJFiRPuBTJ14vxex1O5SyCLPfzKiomNJLSRia6k+xIJ4mtkB3Wk0TA5RRExvfQ2P 2FBVRYBMflvERwYdv99tGBBd4JAv3BcTtE57rGTTR2RRaTIBzMoVgAnCvYmqTWQ9c0x2 MGtqIb1WB/oqKTaXl15NZ6TVH7LUHLOHYS0GA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:x-spam-checked-in-group:list-post:list-help :list-archive:list-unsubscribe; bh=w6jeEffYbyh5yW4irRptvwg51uM2EHfMcnY/JdAF/24=; b=mps02xWDVQ5vkL9Z2QchXQAP4jcMKs2WYWp/MASlcJrLASlqLXlHhG6K8wnAMSPH9N ajIxhABhcBfwCGhZt4RtNBCa2RRJgIcYSVfIFznlPD3F6+CqzitzzE3aS65fuZz0foJl DPC6VnmZVnUTWxHTNDIRhPjwXvSqey0UFhEvnzbBKp3X76hhhoX1CfpuLYQwQZNFyh9V ci7zHP+tg66T5+vDVS30w0vmB7WZ6v7zavSFqWy58aOIR9SlbsYhGrMHcrW7hQtu0hFF Y5Nw/VrovOsn5yJEeNb5fR84qAG1KUSfI9yqFQFac17uGHw/LxA2E4fSlKyUmgfjrpv+ vaQA== X-Gm-Message-State: AJIora+AAeTaEyY5s+PVaioWAHyzHcY0M8tSi68j70gYxQ/IgPDK807Y 8mAdnDjQuvfWfEubRMEu3ec+q+lN X-Google-Smtp-Source: AGRyM1vphsQ+S3qH9SFj6PpD/37d9ei9UvM8QkaK7muA7i1o9BKfn5mes/dxP2QuimUoRHGSRBPjCg== X-Received: by 2002:a05:6402:540c:b0:434:d965:f8a with SMTP id ev12-20020a056402540c00b00434d9650f8amr2821372edb.30.1657695252213; Tue, 12 Jul 2022 23:54:12 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:907:9728:b0:72b:4fab:1c58 with SMTP id jg40-20020a170907972800b0072b4fab1c58ls69587ejc.3.gmail; Tue, 12 Jul 2022 23:54:11 -0700 (PDT) X-Received: by 2002:a17:907:b08:b0:72b:1bc8:19e4 with SMTP id h8-20020a1709070b0800b0072b1bc819e4mr1960258ejl.106.1657695250798; Tue, 12 Jul 2022 23:54:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657695250; cv=none; d=google.com; s=arc-20160816; b=LlQ5YCfHOdsphrOBYMDvuYMoUzI5mu6o1X76SLfSE3ByDXQMcF9JO+u0NS8G++3LRg f6Q7zBcvmNEAzMm6Qy4qp/TruKSdfvUptOK7bdGYQeHiJfu7QW41jlEN5uEyoX0rO5qi wahSczTRRY55ugCjuaVBCJibyZWUtH69bhAb9xDYNdnEbILP0PbxsJ5WFYb6RwwJeL/y S+dX0LtQcirhPfNM6sTKIQGLCxB/LDZ7A8gIxL8QvQF2aoBCbWHuHYZ0FW/kxsy/rfgD BH4U2lDe09F97CYpYXIfU4BPYiwitVoGpqR5q1X7wjfXc62Z4foYpsi05wVyYofa7Wps /rrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:dkim-signature; bh=lIuIWLqqz2ogXeLR2OiG+YgBNXzZxQ2P6FCSJQWqai8=; b=SV+esMmvefPZwH0t5DOTL31qE2EdnZJ4/WxkHHW6QLBYYgn4QgZi8kZBN/wd54j0OT WpU1nEHDZveL/PjVwG2rRTRb/EfFPM0jOsn5IZpcHEgNQ6hGfVe7YfXs6bcf3EtSefxH 8G0/uOkNn2fECAfSZGCEIV2h2JJLYVAqctAOoxsN5/f7t5ULcdJXcTv1ejLKu97lwsYD ClfkHrVDk79wiu4J9/UeiF6dQcgArp0e/qSUGZ07BWiXhpdHJeFSU3G1nlRBqrwUwuYt lC227CvQk3cxFu3sYXGGSap5Wg0rX8pNx13TF1di7/MkfvhZEviiGuO8XUy+9jO04SUL 0Scw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=d4MfGWv0; spf=pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=michael@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id s10-20020a508dca000000b004372b52e011sor4799906edh.28.2022.07.12.23.54.10 for (Google Transport Security); Tue, 12 Jul 2022 23:54:10 -0700 (PDT) Received-SPF: pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:aa7:dd4b:0:b0:43a:d508:7cb9 with SMTP id o11-20020aa7dd4b000000b0043ad5087cb9mr2799088edw.218.1657695250372; Tue, 12 Jul 2022 23:54:10 -0700 (PDT) Received: from panicking.amarulasolutions.com ([2.198.242.86]) by smtp.gmail.com with ESMTPSA id j5-20020a056402238500b004358f6e0570sm7389026eda.17.2022.07.12.23.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 23:54:09 -0700 (PDT) From: Michael Trimarchi To: Dario Binacchi , linux-amarula@amarulasolutions.com Subject: [PATCH 1/4] mtd: nand: Drop busw variable and use chip->options field Date: Wed, 13 Jul 2022 08:54:03 +0200 Message-Id: <20220713065406.272114-1-michael@amarulasolutions.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Original-Sender: michael@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=d4MfGWv0; spf=pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=michael@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , No functional change. Reduce the function parameters in preparation of support specific nand manufacture Signed-off-by: Michael Trimarchi --- drivers/mtd/nand/raw/nand_base.c | 58 ++++++++++++++++++-------------- 1 file changed, 32 insertions(+), 26 deletions(-) diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index 6f81257cf1..cb22e0ec13 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -3890,8 +3890,7 @@ static void nand_onfi_detect_micron(struct nand_chip *chip, /* * Check if the NAND chip is ONFI compliant, returns 1 if it is, 0 otherwise. */ -static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip, - int *busw) +static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip) { struct nand_onfi_params *p = &chip->onfi_params; char id[4]; @@ -3963,9 +3962,7 @@ static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip, chip->bits_per_cell = p->bits_per_cell; if (onfi_feature(chip) & ONFI_FEATURE_16_BIT_BUS) - *busw = NAND_BUSWIDTH_16; - else - *busw = 0; + chip->options |= NAND_BUSWIDTH_16; if (p->ecc_bits != 0xff) { chip->ecc_strength_ds = p->ecc_bits; @@ -3995,8 +3992,7 @@ static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip, return 1; } #else -static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip, - int *busw) +static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip) { return 0; } @@ -4005,8 +4001,7 @@ static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip, /* * Check if the NAND chip is JEDEC compliant, returns 1 if it is, 0 otherwise. */ -static int nand_flash_detect_jedec(struct mtd_info *mtd, struct nand_chip *chip, - int *busw) +static int nand_flash_detect_jedec(struct mtd_info *mtd, struct nand_chip *chip) { struct nand_jedec_params *p = &chip->jedec_params; struct jedec_ecc_info *ecc; @@ -4068,9 +4063,7 @@ static int nand_flash_detect_jedec(struct mtd_info *mtd, struct nand_chip *chip, chip->bits_per_cell = p->bits_per_cell; if (jedec_feature(chip) & JEDEC_FEATURE_16_BIT_BUS) - *busw = NAND_BUSWIDTH_16; - else - *busw = 0; + chip->options |= NAND_BUSWIDTH_16; /* ECC info */ ecc = &p->ecc_info[0]; @@ -4160,7 +4153,7 @@ static int nand_get_bits_per_cell(u8 cellinfo) * manufacturer-specific "extended ID" decoding patterns. */ static void nand_decode_ext_id(struct mtd_info *mtd, struct nand_chip *chip, - u8 id_data[8], int *busw) + u8 id_data[8]) { int extid, id_len; /* The 3rd id byte holds MLC / multichip data */ @@ -4213,7 +4206,6 @@ static void nand_decode_ext_id(struct mtd_info *mtd, struct nand_chip *chip, /* Calc blocksize */ mtd->erasesize = (128 * 1024) << (((extid >> 1) & 0x04) | (extid & 0x03)); - *busw = 0; } else if (id_len == 6 && id_data[0] == NAND_MFR_HYNIX && !nand_is_slc(chip)) { unsigned int tmp; @@ -4254,7 +4246,6 @@ static void nand_decode_ext_id(struct mtd_info *mtd, struct nand_chip *chip, mtd->erasesize = 768 * 1024; else mtd->erasesize = (64 * 1024) << tmp; - *busw = 0; } else { /* Calc pagesize */ mtd->writesize = 1024 << (extid & 0x03); @@ -4267,7 +4258,7 @@ static void nand_decode_ext_id(struct mtd_info *mtd, struct nand_chip *chip, mtd->erasesize = (64 * 1024) << (extid & 0x03); extid >>= 2; /* Get buswidth information */ - *busw = (extid & 0x01) ? NAND_BUSWIDTH_16 : 0; + chip->options |= (extid & 0x01) ? NAND_BUSWIDTH_16 : 0; /* * Toshiba 24nm raw SLC (i.e., not BENAND) have 32B OOB per @@ -4293,15 +4284,14 @@ static void nand_decode_ext_id(struct mtd_info *mtd, struct nand_chip *chip, * the chip. */ static void nand_decode_id(struct mtd_info *mtd, struct nand_chip *chip, - struct nand_flash_dev *type, u8 id_data[8], - int *busw) + struct nand_flash_dev *type, u8 id_data[8]) { int maf_id = id_data[0]; mtd->erasesize = type->erasesize; mtd->writesize = type->pagesize; mtd->oobsize = mtd->writesize / 32; - *busw = type->options & NAND_BUSWIDTH_16; + chip->options |= (type->options & NAND_BUSWIDTH_16) ? NAND_BUSWIDTH_16 : 0; /* All legacy ID NAND are small-page, SLC */ chip->bits_per_cell = 1; @@ -4363,7 +4353,7 @@ static inline bool is_full_id_nand(struct nand_flash_dev *type) } static bool find_full_id_nand(struct mtd_info *mtd, struct nand_chip *chip, - struct nand_flash_dev *type, u8 *id_data, int *busw) + struct nand_flash_dev *type, u8 *id_data) { if (!strncmp((char *)type->id, (char *)id_data, type->id_len)) { mtd->writesize = type->pagesize; @@ -4378,7 +4368,7 @@ static bool find_full_id_nand(struct mtd_info *mtd, struct nand_chip *chip, chip->onfi_timing_mode_default = type->onfi_timing_mode_default; - *busw = type->options & NAND_BUSWIDTH_16; + chip->options |= (type->options & NAND_BUSWIDTH_16) ? NAND_BUSWIDTH_16 : 0; if (!mtd->name) mtd->name = type->name; @@ -4441,9 +4431,24 @@ struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd, if (!type) type = nand_flash_ids; + /* + * Save the NAND_BUSWIDTH_16 flag before letting auto-detection logic + * override it. + * This is required to make sure initial NAND bus width set by the + * NAND controller driver is coherent with the real NAND bus width + * (extracted by auto-detection code). + */ + busw = chip->options & NAND_BUSWIDTH_16; + + /* + * The flag is only set (never cleared), reset it to its default value + * before starting auto-detection. + */ + chip->options &= ~NAND_BUSWIDTH_16; + for (; type->name != NULL; type++) { if (is_full_id_nand(type)) { - if (find_full_id_nand(mtd, chip, type, id_data, &busw)) + if (find_full_id_nand(mtd, chip, type, id_data)) goto ident_done; } else if (*dev_id == type->dev_id) { break; @@ -4453,11 +4458,11 @@ struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd, chip->onfi_version = 0; if (!type->name || !type->pagesize) { /* Check if the chip is ONFI compliant */ - if (nand_flash_detect_onfi(mtd, chip, &busw)) + if (nand_flash_detect_onfi(mtd, chip)) goto ident_done; /* Check if the chip is JEDEC compliant */ - if (nand_flash_detect_jedec(mtd, chip, &busw)) + if (nand_flash_detect_jedec(mtd, chip)) goto ident_done; } @@ -4471,10 +4476,11 @@ struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd, if (!type->pagesize) { /* Decode parameters from extended ID */ - nand_decode_ext_id(mtd, chip, id_data, &busw); + nand_decode_ext_id(mtd, chip, id_data); } else { - nand_decode_id(mtd, chip, type, id_data, &busw); + nand_decode_id(mtd, chip, type, id_data); } + /* Get chip options */ chip->options |= type->options;