From patchwork Wed Jul 13 15:05:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 2133 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 0723B3F1F7 for ; Wed, 13 Jul 2022 17:05:13 +0200 (CEST) Received: by mail-wr1-f72.google.com with SMTP id t13-20020adfe10d000000b0021bae3def1esf2225933wrz.3 for ; Wed, 13 Jul 2022 08:05:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1657724712; cv=pass; d=google.com; s=arc-20160816; b=dd8CzCSjn6DsyREiQhQQVqcmFEyhd6LNu7HEpzAXXx0oP4Y8Yn0vKjbhySzaZHvJQB ba/TrSim+q42f8XIvJZRlJMQY/RSWpHKO4F9nUw64J95YyERBz4cNmWHXJy+EKB/fxZ4 ocef4DB0xN/PYmgyk3N1FHvXDoYMTc9pMfZmoMYT8LBPUEpiZv/8oIx0ruccJ4GvwdSr N1fb1TX9Y9UsSIZ8x+KUS2laztKckIhpKClvKUIYLZ+//6ocrnGrqqrsQNAkHoTaMjdm x8fBaDdANpTV5HUx/D/vOAh3/jwf84MHTbgHgsdn3DpFHL9g6Ik47+wP9Kg6YVQHDd0s Z+ig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=GJGtdhRH8kSjpKIGACFev1ZeFEfzoao3nqEaHO6Fl0Y=; b=U79VvJPcN1/nUmXdI0us1HrL0iw0jBRn9rPy/9T/ubhysptGs+LtefsVkLLPAL0Z6A rs6/rLED5w2C+bzM0PpeS5eJAltrpDo5i4BR8Mnyii15R9fL8cYs5TnumTYIh8g9Nmxx JHiOazhUZznaunxeVY6eCYpBrh5O0AuK8nKBHA65Kbp9zFaIZJHItqc2pnA0KHPrfiuR 8ScYd5FQ0rvEIsQPPKVXPP98pm3DGVURECqp55M4GNcWhympFaxPP1PxEVlBxmNCRCj9 pK4lU/sfBjWhJ8Blvk05ifQXh7NS858BfVUtHQRXQCdFa5B+/XikePzpNnfsixzVq0Lj ANuQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=gUbx5q33; spf=pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=tommaso.merciai@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=GJGtdhRH8kSjpKIGACFev1ZeFEfzoao3nqEaHO6Fl0Y=; b=Da8N3tc7MLhXyE0qmbDbBu839vUoevZ/zXDcJfu8G8PrgrDpVsLhGMhkTgEd/Td5/a FROeqN7TPF+Y04rKwbKCyYMChFCei/oPzynqz/+SmuXyCpTQH8NA/VYUF3N+mV2NI0FN gHJ5qUcJkD/3GC/SWoewXiZs0jQsnk0CaWVv8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=GJGtdhRH8kSjpKIGACFev1ZeFEfzoao3nqEaHO6Fl0Y=; b=fjAqkKI7V08t5VlfwS/+WQuNg8xGkfEV6CAf7uU/cALgCvnaNj6VHDORw/WkbjxPhU SiklO+jPW0XbdU4j0SmaZFQ/91epHz/IrUXSdjODlyXTFOIod5cW2kFRLQ2q2+spzTQg PGYJCMRotinGj8ryMZK8ZOD8N3VDOiEX/c15rLmZ7zHyboBbqfQW6cNFeM4P8ZBhNf/N ktDxNCkCoiRgDLlVXtz1i7Tl2OHUSXkzlzVUNYPcXHKXIz2dZAaq4hi8zd9HjTamJof6 Z5ejjAdqLIQyzcW7ndCtQcrvhkA5zKiJZVSrnqlBjqD7aU0X5sG1f1HuGKF61cSsOfkl 2q2Q== X-Gm-Message-State: AJIora8XIFzIpcZjZJypZ3xaCKy/v9zLn/omJJWa6FxowysWryx476eH eXCO97YKu46zfEpoQAZpPGjd2PLu X-Google-Smtp-Source: AGRyM1vuHfDAxGK1U+/PXk4Icoto9Oz8yMtlICzcFpJTz6UVV0V92bg1CZWd2+f8MhRsqe7u0gxvnA== X-Received: by 2002:a5d:4345:0:b0:21a:3b82:ad57 with SMTP id u5-20020a5d4345000000b0021a3b82ad57mr3874492wrr.176.1657724712735; Wed, 13 Jul 2022 08:05:12 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:600c:1e88:b0:3a2:f0cc:bc47 with SMTP id be8-20020a05600c1e8800b003a2f0ccbc47ls2323972wmb.2.canary-gmail; Wed, 13 Jul 2022 08:05:11 -0700 (PDT) X-Received: by 2002:a05:600c:1e8a:b0:3a2:ee8a:bbc9 with SMTP id be10-20020a05600c1e8a00b003a2ee8abbc9mr9303121wmb.6.1657724711577; Wed, 13 Jul 2022 08:05:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657724711; cv=none; d=google.com; s=arc-20160816; b=DrlvSMuRFqb1etxSMV3F70HgfA+sT/Tw5b2iQphbD0o+nCZqsCKu1cul60Mnd0wgSw UlDN1boaXmf8N7mZEtJekkxnq8wUgfjfmqg3sm95CHRfBovcGFYoRJ2YispWDbKyW8jx zpkF8P+E+N4Rd+knuhicpyfYINvl877t9T9Sm0lc9LygCda5ab+7hsd52O5/3ZhR8dAk tsGWxX0wIO9BoJxwAMEAUoIjhQrjEN1hXMlDTAnKWTRX4T6SAYM3nNuMsKJtZ79a5W0N 2N4NByzkEzbL/Qu8wjrMYeiTCrkjXIyFUFgp8ii3iPviImBEo+Db9jbCfTqBky+V/Ykl JVGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=jE26kz8uLkTSQmG0BFSrQuTDJo25o/aqMTxY60BA87o=; b=P3u7Q9AkAPbAy7WNCxz5Lx1pIx7QsG2FpI1e30l7kSItk/4zoNjkAb/Czc3WAVhSsY Y6V8TuPhn8mz7i6B7m8fakTjLzruKOgVX4dlYF7XLsnHoLu2hG63cj6M6JU8NPognLUn /zrLqe+98M/vE9aAM+deZMEsHf2GvDUcmN28/aA5pwLE/HRWbR9FN4LI0XJQs+7RzQSS sAHu6oDQIZpZMVWpKiRwAFybYgou+FWy2uadXAnnm/REZ1jebwiEf5luzikdzuRi7QJL gLjD91LvbjoYO2oiYigZHVDzLWZZ/YV9axUFT6vQdDulkazRkurUy+T+nQLQMFOhGY+v 9KEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=gUbx5q33; spf=pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=tommaso.merciai@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id j40-20020a05600c1c2800b003a2e6339a2dsor580193wms.39.2022.07.13.08.05.11 for (Google Transport Security); Wed, 13 Jul 2022 08:05:11 -0700 (PDT) Received-SPF: pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:600c:25ce:b0:3a2:dd48:9b33 with SMTP id 14-20020a05600c25ce00b003a2dd489b33mr4202758wml.134.1657724711316; Wed, 13 Jul 2022 08:05:11 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-51-7.cust.vodafonedsl.it. [188.217.51.7]) by smtp.gmail.com with ESMTPSA id f17-20020a05600c4e9100b003a2d87aea57sm1465537wmq.10.2022.07.13.08.05.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 08:05:11 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Jacopo Mondi , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 1/6] media: ov5693: count num_supplies using array_size Date: Wed, 13 Jul 2022 17:05:01 +0200 Message-Id: <20220713150506.2085214-2-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220713150506.2085214-1-tommaso.merciai@amarulasolutions.com> References: <20220713150506.2085214-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: tommaso.merciai@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=gUbx5q33; spf=pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=tommaso.merciai@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Instead of hardcode OV5693_NUM_SUPPLIES in a define is better use ARRAY_SIZE function to count the number of supplies from ov5693_supply_names array Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi Reviewed-by: Daniel Scally --- Changes since v3: - Add reviewed-by tag, suggested by Jacopo, Krzysztof Changes since v4: - Add Daniel reviewed-by tag drivers/media/i2c/ov5693.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index 117ff5403312..f410333c4c67 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -127,11 +127,15 @@ #define OV5693_LINK_FREQ_419_2MHZ 419200000 #define OV5693_PIXEL_RATE 167680000 -/* Miscellaneous */ -#define OV5693_NUM_SUPPLIES 2 - #define to_ov5693_sensor(x) container_of(x, struct ov5693_device, sd) +static const char * const ov5693_supply_names[] = { + "avdd", /* Analog power */ + "dovdd", /* Digital I/O power */ +}; + +#define OV5693_NUM_SUPPLIES ARRAY_SIZE(ov5693_supply_names) + struct ov5693_reg { u32 reg; u8 val; @@ -352,11 +356,6 @@ static const s64 link_freq_menu_items[] = { OV5693_LINK_FREQ_419_2MHZ }; -static const char * const ov5693_supply_names[] = { - "avdd", - "dovdd", -}; - static const char * const ov5693_test_pattern_menu[] = { "Disabled", "Random Data",