From patchwork Wed Jul 13 15:05:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 2135 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 29E053F1F7 for ; Wed, 13 Jul 2022 17:05:16 +0200 (CEST) Received: by mail-wm1-f69.google.com with SMTP id q15-20020a05600c040f00b003a2e5c8fca3sf1182792wmb.7 for ; Wed, 13 Jul 2022 08:05:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1657724716; cv=pass; d=google.com; s=arc-20160816; b=rzl7Gat/WkFqHRXbvxbJtOr319tmK2MW0WEBhwb1UHeYbCIvz0CVnSZYtxojdAlHXt odA5Bayzl4DW+e25NMjHyd3nzW+uewkOPnaQ7LtOQka9hzc9iI5xgOE/m9/PC/L59UqD XXGLYwzzWMqtvr8hHzt5AM3Bsynw/u1mMUu2Z/V2Pdc9x82wRABhRNQ5fXWqPlxEjpXu I16voqqwYgicNEmGNbJKP97c/K/zeWLQQIuRjuEdjTd9iZ5facBmHdjuVnurf/zW+Avn F0WdzAONVFjhSir3TDCtQkqOdZnBGFTSIcnB0fKQ80lz/t0GHq4eoXkjJA70yVc3dCIa 75BQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=oqWkW2LxfD6S4ORUzeRpTsgvc5j2dAwD84ZMnuqbXNk=; b=u+aQwbd7FWb5ZG7QF0ex+F7S0ki3a3DxYfceSE5UHjPIr6Ri1bZH/1BEDfNKGgSpMv 60cUk58ZMTUm5zApK/Fay58fx/JK3fKPcON+DUIulc6VElNHE7QwB3tnj/Xh+XRB65G1 qCUrm9bNC/8MS43tMvQfcPNb5vyfKdeFsgnGIUMWcOwfL0QBm88wQCFCSasZqZW3c3rP WG0Ik2bCKSRd7aufaGn1efsw9ZVCpTkFp5bbjwzas9Yj9wqkznTnZmZIv/56kvsIC7b9 EfOE4ZOP29vWFh/GJh9ISs/yJ6Ngu5sLbrn/sYIu7Qlmza4KzI5/anG+DDz1K4AIhVJk /vtA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JVDAlTtD; spf=pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=tommaso.merciai@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=oqWkW2LxfD6S4ORUzeRpTsgvc5j2dAwD84ZMnuqbXNk=; b=D8tbww/ZZVc06aue5OFUJ56hUiOZKHjFDJvWvJV/f+rQo1NczeK9Bwt+KxyoyL02I2 Bnz1janyK8ksFw8oZ/c7yzKomGwsrfECfwfa2RR20ZhE2Je/irXwOKCK2tlSQPdGGEjP NXjc7lYN+fB2QyLuwSmsyThPQzcoCIV9uVX4c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=oqWkW2LxfD6S4ORUzeRpTsgvc5j2dAwD84ZMnuqbXNk=; b=rcOMx2hV4Z0nbrCd4MN8tdbL2J6fvn+ZVnJ6Ft0mNWfjUaYhVyYxt8wXBGY+De8gfy 94IAPgySLjrenzA0PQkR0y8Ejo29B+YsEJ/bg9KrB/smtMzC5NYbmUJDpV3uVaj78z8u Aw926nkqdhKr0t71pp4lzU386TF8u5zbkd0Im+V99qJc2ue6Fl//giRqvhFKBTsY/p5I mS45FBsG+cpBvw8A56IgyftrgY9SzTQoc1fSv4JJDp5beHJvKw//AmBzScm9WyeN3tL8 hImQvAN7fX93eGU9AWwCFhHXF0XmsfffAGVBN71ip52P/mIlCM5WwWGjEmWPZIK4S5QA yLGg== X-Gm-Message-State: AJIora9hbta0xYMB5fRbF0XfZO44WkPe9Sy9qbHpWQJVJ3hcfjv51/uE b76uUSDMl07giv3Lh/KHivLFMsoc X-Google-Smtp-Source: AGRyM1uWrTlco6Bd+u5XPmUTNaIsAUZTAj+DzKuJsyw5KZTjkiY4NxUErzHZ3YvUYhFc7853MsdLYQ== X-Received: by 2002:a5d:5263:0:b0:21d:7de7:956a with SMTP id l3-20020a5d5263000000b0021d7de7956amr3821376wrc.350.1657724715941; Wed, 13 Jul 2022 08:05:15 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:6000:1ac7:b0:21d:ab25:25ba with SMTP id i7-20020a0560001ac700b0021dab2525bals2915656wry.2.gmail; Wed, 13 Jul 2022 08:05:15 -0700 (PDT) X-Received: by 2002:a5d:4986:0:b0:21d:776c:2f11 with SMTP id r6-20020a5d4986000000b0021d776c2f11mr3682533wrq.119.1657724714795; Wed, 13 Jul 2022 08:05:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657724714; cv=none; d=google.com; s=arc-20160816; b=T8Bwlat//zHx2P9T2IPfevqWly2x3HU/TBV2u2HPRCwpmCUOXT4SWizSlUQs2UbLv8 H7L50kBUTEbU2EQbP7Lg7tOGkdlV3u87vjgOsUFvzXABCsySoZFF2RMvEkOGGGymvddu ZEoIFQPhCMHilEGNFoRFf5kGbviAyEECSDx3Oyt6u/GmmOPPFzIbokmrVAT0QlWlHVkJ +dLLUbmiP9J3naF6GctKtJE6DsczB9FyddVkDttPHvzXlPAR8mLqdQC+m3OIdnLIVpbX En2ewG5fg3X1VPXFSsNUq5iCXFgo4czzXrj5exFgQ+wSE9dkzoR6zK1O24JFsidFFy+m mN3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ctpa/T2vVk1WErHGmcuqVVZ1P5/ZM5PQkEWqW8vXr7A=; b=AIvEt9m3fr8LbAFp7idTy2ggxiCt8cPrFCdTM6qqwp6crd+8Bd6PHeT5AZytzXauw5 dacscseRY2jVjokmdYk70r8GiZphqHqZRA5nyaaAB+DffEuMTHVo8EVx+zetivOk9nCI L5yWCRw4GQrdHKZdT/uXsqr5HIslCC4PrEHdGi+AwVeh2/d0Z8ajsoZcqeP9pzt6+9qB iU+077RJFQwG+gZ0z2xLNi6aQCtTPMCjEzC8qKg+liEyrBr/9MhYAdH+tz/dq/u/JSia H/oUd2iPiNNCKz1RcHDcSxKz+Wt2osnmX9zrfUCnE1QzDGaffU8jN8Rm0B4yNI6+tZp4 Bkeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JVDAlTtD; spf=pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=tommaso.merciai@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id u6-20020adfc646000000b0021daa9bd767sor4098910wrg.77.2022.07.13.08.05.14 for (Google Transport Security); Wed, 13 Jul 2022 08:05:14 -0700 (PDT) Received-SPF: pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a5d:4d0b:0:b0:21d:819e:5765 with SMTP id z11-20020a5d4d0b000000b0021d819e5765mr3648022wrt.232.1657724714580; Wed, 13 Jul 2022 08:05:14 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-51-7.cust.vodafonedsl.it. [188.217.51.7]) by smtp.gmail.com with ESMTPSA id f17-20020a05600c4e9100b003a2d87aea57sm1465537wmq.10.2022.07.13.08.05.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 08:05:14 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Jacopo Mondi , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 3/6] media: ov5693: rename clk into xvclk Date: Wed, 13 Jul 2022 17:05:03 +0200 Message-Id: <20220713150506.2085214-4-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220713150506.2085214-1-tommaso.merciai@amarulasolutions.com> References: <20220713150506.2085214-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: tommaso.merciai@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JVDAlTtD; spf=pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=tommaso.merciai@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Rename clk pdata pointer into xvclk (system clock input). Same for clk_rate into xvclk_rate. This is more explicit Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi --- Changes since v3: - Add reviewed-by tag, suggested by Jacopo, Krzysztof drivers/media/i2c/ov5693.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index 9e84468d920e..d2adc5513a21 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -157,7 +157,7 @@ struct ov5693_device { struct gpio_desc *reset; struct gpio_desc *powerdown; struct regulator_bulk_data supplies[OV5693_NUM_SUPPLIES]; - struct clk *clk; + struct clk *xvclk; struct ov5693_mode { struct v4l2_rect crop; @@ -794,7 +794,7 @@ static void ov5693_sensor_powerdown(struct ov5693_device *ov5693) regulator_bulk_disable(OV5693_NUM_SUPPLIES, ov5693->supplies); - clk_disable_unprepare(ov5693->clk); + clk_disable_unprepare(ov5693->xvclk); } static int ov5693_sensor_powerup(struct ov5693_device *ov5693) @@ -804,7 +804,7 @@ static int ov5693_sensor_powerup(struct ov5693_device *ov5693) gpiod_set_value_cansleep(ov5693->reset, 1); gpiod_set_value_cansleep(ov5693->powerdown, 1); - ret = clk_prepare_enable(ov5693->clk); + ret = clk_prepare_enable(ov5693->xvclk); if (ret) { dev_err(ov5693->dev, "Failed to enable clk\n"); goto fail_power; @@ -1390,7 +1390,7 @@ static int ov5693_check_hwcfg(struct ov5693_device *ov5693) static int ov5693_probe(struct i2c_client *client) { struct ov5693_device *ov5693; - u32 clk_rate; + u32 xvclk_rate; int ret = 0; ov5693 = devm_kzalloc(&client->dev, sizeof(*ov5693), GFP_KERNEL); @@ -1408,16 +1408,16 @@ static int ov5693_probe(struct i2c_client *client) v4l2_i2c_subdev_init(&ov5693->sd, client, &ov5693_ops); - ov5693->clk = devm_clk_get(&client->dev, "xvclk"); - if (IS_ERR(ov5693->clk)) { + ov5693->xvclk = devm_clk_get(&client->dev, "xvclk"); + if (IS_ERR(ov5693->xvclk)) { dev_err(&client->dev, "Error getting clock\n"); - return PTR_ERR(ov5693->clk); + return PTR_ERR(ov5693->xvclk); } - clk_rate = clk_get_rate(ov5693->clk); - if (clk_rate != OV5693_XVCLK_FREQ) + xvclk_rate = clk_get_rate(ov5693->xvclk); + if (xvclk_rate != OV5693_XVCLK_FREQ) dev_warn(&client->dev, "Found clk freq %u, expected %u\n", - clk_rate, OV5693_XVCLK_FREQ); + xvclk_rate, OV5693_XVCLK_FREQ); ret = ov5693_configure_gpios(ov5693); if (ret)