From patchwork Wed Jul 13 15:05:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 2136 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 8D9B13F1F7 for ; Wed, 13 Jul 2022 17:05:17 +0200 (CEST) Received: by mail-wr1-f71.google.com with SMTP id v18-20020adf8b52000000b0021d641d2bb0sf2265932wra.11 for ; Wed, 13 Jul 2022 08:05:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1657724717; cv=pass; d=google.com; s=arc-20160816; b=XEhb8m/yoXgFM4XuxMYNFdf9qr0lS848Ed4zgzysdyaTP5RD+XkueZXDnRVuCNIwFj 65EAu81rLfeZDsVmTgoMqsLWbdeuAf2aYyV/c+3NVkHdICxVb3rL5Zw4DRKfHqmVG9VC OFi6/lY7M9ceKP5ME5Y60IheURBjqEZuqy5QyxvRA5O008c0GaPxbBhJWiJgAR26Hjep XlhakA1v6JAs5noJr13jvokzYDoeFWG5ZhBkNvSY2FLrxmGb2/aWqFzjB1iInO02yLgU SzcZyE27XHNDPydC7HQAffkmWrHt4xG1jG8p6xyqSwyJT9UFLVD0n7RsCcbbcuYfj8fk /uvQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=mxEH89PmKMnWEHW9AlxllWbUvhaOT14FMXhYQnwScZQ=; b=xyyVYmnkWiwrw6wGZbaxIW4QdcXc9D90XTMY6mupffOLG3LiRwP6DbPMzjxV+FoTvB Zl/eib4ViK58sKEo+88vnpIjAFuW4je18J/RJIo5Kt0WSTPjP3uTekB71VXvFIbJz3Rf iYwMh8NYfcChNA73aqd9JXRO08DPLvW8bYz7+NHCt5uFxH1mqBbINCC0UDrg/2TfSqr1 xELFe+fcckdA+n/jfvDDSgbFJW7CDlKNVBW1bh+vxdSPE0ymicPVWlpVWk9o8rar4tqG AMlkgoB8rd9exyoeEJ7ErXG+MzWKxdvdGiHXxRMcFvyQg39D7JM6Lc/AoayGHBU5OOTX jrqw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Pi5HkNDE; spf=pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=tommaso.merciai@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=mxEH89PmKMnWEHW9AlxllWbUvhaOT14FMXhYQnwScZQ=; b=KpjapRbRNDIL09obHkCDlVwefMhwgRFgXkTCuU1hl0dPfKlUHCGVzHRXGcLUK4yfsX XpgyFLyzk0PV7U8ANLtyoetl3UaHvF44KAMF2fJM5JYcRarXaVtPmKWdH6VAL78T6aIe r4eFk3sTz3alr64eu4AJzEo8UoYe3hc+1gBJk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=mxEH89PmKMnWEHW9AlxllWbUvhaOT14FMXhYQnwScZQ=; b=KSLou2ObI6VcitdtU62yXUKXJUtxc/Jb8l8iW1XJpMtG2xsSfKLSWBhl2cjqHbm0tb +MwjCpL58W8r8bVhe0n1vtklcr9DkEPRdArCvimlqrVRoQabmg1OVNH0JdoPZsXQYdVT YjjZ6Y0V9HfrWd9R4ZHRngCVPC/3wVgQW8EqIJqlaUxiHB+jCiGWWOK3/QXMCBVcoxDw LBmjaxf2W3yhEo5Edp1kT761APgrTPodggzgp9arprjIDgrLnHTRYaSIBGB52QxNQBep 0t0VuUq/Ym3yazsDvFkeJRTXb6g4wwzKrzdciNrjvWli8BGJ4GBG2Lim5+6DYcT1vN9y E9lw== X-Gm-Message-State: AJIora/30YSRuk/9fjbfCcrDo45KY9zOpw1Snz/DCgAYoJYgemZeJoAB iILkh4l+CvbM+is5n+HvO/iQpCaA X-Google-Smtp-Source: AGRyM1tvrHxuX/nt1m4v6EnlUGFxHcsiK6PCaSoxO8x4RGvpVExGT4cH+OF9SU5AmiRXv/Dv2Fvkng== X-Received: by 2002:a05:600c:2288:b0:3a2:ddbf:7b2f with SMTP id 8-20020a05600c228800b003a2ddbf7b2fmr10217908wmf.191.1657724717354; Wed, 13 Jul 2022 08:05:17 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a5d:64af:0:b0:21d:bf45:f904 with SMTP id m15-20020a5d64af000000b0021dbf45f904ls1243679wrp.3.gmail; Wed, 13 Jul 2022 08:05:16 -0700 (PDT) X-Received: by 2002:a5d:6d81:0:b0:21d:bb16:e6c8 with SMTP id l1-20020a5d6d81000000b0021dbb16e6c8mr3717505wrs.88.1657724716158; Wed, 13 Jul 2022 08:05:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657724716; cv=none; d=google.com; s=arc-20160816; b=hc8xMTSChgi1WqFZFY5+79WKiOXb7AaYtaMCBeR8bjTkiFgQ6q5DSyQfgVRoS8R2kN ukf0+BOzXZRapCLf+IqTiF6z2gKlNixxee4UkID9/tfKViWpyrg2KaaPD4GUQw518ayj +C+hPNOoX9nYq7QGpacHJUKfJP7MU0ekU82FYfN+x8uNzzcsRXQkvVSPJ/hs6UfwExUY GyIkjDCZ/9nTmhTCA4cAkw+sE0MqRIDZSl+KnMR0gOWu2PPY+tfrD7QnBLw26b2KkEOi YJWoGGJ4i/ky5NtgW9BTq2bhuCsYj1yuSdIsm8l8sQxmf9G9gw4IKu5/wgCIXu2nJ+tx K4hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ROC0BgtK/N+kzsuCvrmnTVmfs20tFROFRODZongU+to=; b=LtuMwXaefW9KcJcQ3QjJQdMPJvZJ0fHpnlFtG7VUoIlR859ePTL8A61u0I7us9Bnk9 T0OwacPDWOmijT1qiW/e0g5rL0OLVrKVDfwd3+xaglzv1HsRyDVBYbq3M77ikcvtrKMX 3HElPD19IxiwmGvXdikejzklq3A//cGkpaEfs4/o6YwCYP8XA09RpbZs/QQ3wunTTCZf iyx7v/R2oWfzfI0a7zk3R/bJ2YULKxNvwKBaNNgrfi2Bh4ffvKNSNsLkgzif9g8im2xP ghNnzMw9Jbxrm5PR5yJ8xRCDEmc4psYA/9na0CpqFB97tGVoHVBGx2psUxQWvAvnihWk W9sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Pi5HkNDE; spf=pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=tommaso.merciai@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id z25-20020a1c4c19000000b003a1a05c5669sor616628wmf.9.2022.07.13.08.05.16 for (Google Transport Security); Wed, 13 Jul 2022 08:05:16 -0700 (PDT) Received-SPF: pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:600c:a187:b0:3a2:eb3e:f1d4 with SMTP id id7-20020a05600ca18700b003a2eb3ef1d4mr10115330wmb.174.1657724715931; Wed, 13 Jul 2022 08:05:15 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-51-7.cust.vodafonedsl.it. [188.217.51.7]) by smtp.gmail.com with ESMTPSA id f17-20020a05600c4e9100b003a2d87aea57sm1465537wmq.10.2022.07.13.08.05.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 08:05:15 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Jacopo Mondi , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 4/6] media: ov5693: add support for acpi clock-frequency prop Date: Wed, 13 Jul 2022 17:05:04 +0200 Message-Id: <20220713150506.2085214-5-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220713150506.2085214-1-tommaso.merciai@amarulasolutions.com> References: <20220713150506.2085214-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: tommaso.merciai@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Pi5HkNDE; spf=pass (google.com: domain of tommaso.merciai@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=tommaso.merciai@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add support for ACPI-based platforms that specify the clock frequency by using the "clock-frequency" property instead of specifying a clock provider reference Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi --- Changes since v2: - Fix commit body as suggested by Sakari, Jacopo - Add details to commit body as suggested by Jacopo - Move ov5693_check_hwcfg into ov5693_hwcfg - Fix xvclk_rate position as suggested by Jacopo - Use devm_clk_get_optional instead of devm_clk_get as suggested Jacopo Changes since v3: - Fix commit body as suggested by Jacopo - Add reviewed-by tags, suggested by Jacopo, Krzysztof Changes since v4: - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari - Revert ov5693_check_hwcfg function changes. Keep clk init on probe function as suggested by Sakari - Fix commit body - Fix commit msg drivers/media/i2c/ov5693.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index d2adc5513a21..701468267f20 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -1408,13 +1408,25 @@ static int ov5693_probe(struct i2c_client *client) v4l2_i2c_subdev_init(&ov5693->sd, client, &ov5693_ops); - ov5693->xvclk = devm_clk_get(&client->dev, "xvclk"); - if (IS_ERR(ov5693->xvclk)) { - dev_err(&client->dev, "Error getting clock\n"); - return PTR_ERR(ov5693->xvclk); + ov5693->xvclk = devm_clk_get_optional(&client->dev, "xvclk"); + if (IS_ERR(ov5693->xvclk)) + return dev_err_probe(&client->dev, PTR_ERR(ov5693->xvclk), + "failed to get xvclk: %ld\n", + PTR_ERR(ov5693->xvclk)); + + if (ov5693->xvclk) { + xvclk_rate = clk_get_rate(ov5693->xvclk); + } else { + ret = fwnode_property_read_u32(dev_fwnode(&client->dev), + "clock-frequency", + &xvclk_rate); + + if (ret) { + dev_err(&client->dev, "can't get clock frequency"); + return ret; + } } - xvclk_rate = clk_get_rate(ov5693->xvclk); if (xvclk_rate != OV5693_XVCLK_FREQ) dev_warn(&client->dev, "Found clk freq %u, expected %u\n", xvclk_rate, OV5693_XVCLK_FREQ);