From patchwork Mon Jul 25 06:54:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2248 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 2D6723F046 for ; Mon, 25 Jul 2022 08:54:31 +0200 (CEST) Received: by mail-ej1-f70.google.com with SMTP id hq20-20020a1709073f1400b0072b9824f0a2sf2830915ejc.23 for ; Sun, 24 Jul 2022 23:54:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1658732071; cv=pass; d=google.com; s=arc-20160816; b=G08CnA3r24NZg2VXHogE5vxECKuXenVZiz6+VtSrQLX1fhrJK3bp6ggnSiG+UYFsoB cJWrFQvBJu9BvQbLRyIqSRkYWJFB4NMKzCJz/3HN6sMYovgvthAocpGjN8q61p2RmlJZ HlIR+beHtDxFsTDUelX62NEas9hsTlz+T5rvPyApkNgQcD/Eza/2Y6k78SYPAEmNw20y WLWhQ6F9DKjafpchz+fnJCPnV5RpznY42wiBSCzvxx7Nly4Nh4Z1nBtOlh5iA6sVs15b 5ENs4UOFw9yVKiIIaKQL78V3cBjQJ0KwAKHbZOVx9zP39t9E83FXANA+hvYo4v1USXlx RyMg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=b29gdo9J3N706r4dXtbubdUhtS6fbjqR/zgHmgX55qY=; b=nIRDzAU3/PfQ1hkiI4FJIbPIIGLV1RYxbXfDkSsoC1SoaS6vnDm1kX2DtfCz0lp7OM AeuT9/dCmGnMuw6ajTGq6FXnCMUsT5PzMBP9IrZIRgWNWZXCZC3IH76pgt01NKAB319X IgDgiomj0/eM9b+mx6VtXHV7jrNk/nX/bOaSuyLosgnhUHMjo1cPCIPQpODkorY/n3/N ivafYEsfZ5i3A50HSFQPhkKDdABWvXpt3CGfAzE2A6k3Rg55Qkugv/Mnwk5WRcD7B1fq 75J51ZKhzDbxi+ODJmZMk86bAERiGeADLvw6CQrrWnqzucsXTyszB9I0LcFQmCuwmvpH EzDw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=eMTP8obK; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=b29gdo9J3N706r4dXtbubdUhtS6fbjqR/zgHmgX55qY=; b=oU0YWz9GlTlxdaxOsNhDGTCUS2fZKdPG98TlG0RbfrTlyrmWnfNjNlWbomcn74YAa3 n2+6iqQGezzHeWyZVeu6Db6HwcA93d72XuwYAAqvL4rO5bUSvB+RJ3Gl85pmRUb6ewwD 3A6nwD+UcAkcuPUX0S/P+ngXH7ULf8Tq8vfeI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=b29gdo9J3N706r4dXtbubdUhtS6fbjqR/zgHmgX55qY=; b=0hRJpIpcNXRsWr45q8rTFSPpxGon+f6lc7mK299Un3Vx/GOKmFl5xa7yIH+NIZyhCp MWoSpkIZihiYnUwj4F4g57Bcb2UMhx1BLVzvsvaI43cdFfnPTnTrNxrjanJ/TnNns08J /RDx0FBsPym4TDGmXU5ggcQG4wim3P6/DwqRZylIzZncAIQIhQPZR3jT+UYOHfAN4kgw PvVsTzkdSRQdrulLIfRrOI5B14N/94k5wRIEbp7qB7EUu9eQ3r4WkLtIAWSWlMcDNt9a AIrp1vVPJUMY47WAYMBF3Tq80r1klWrzU50StYLFQKOvhTXcu83RDygR2Yxt2Peh7u3n 08fA== X-Gm-Message-State: AJIora8z2G9ITDuH2XRGngTXZ0s0Jlh0YwKMoXBPeIYZxwozpdCoroEW 0Mugxn62+vlYKV37BJv/Rp9yIgB3 X-Google-Smtp-Source: AGRyM1t3+l/grqd/9OXBGI6dGx4VNcp6q/ja7II1ypHrvB7DsjCdnQnXwvg+KYCpgWOEnLQKO9KyIQ== X-Received: by 2002:a17:907:761b:b0:72b:379e:39ea with SMTP id jx27-20020a170907761b00b0072b379e39eamr8990460ejc.591.1658732070867; Sun, 24 Jul 2022 23:54:30 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:906:3b47:b0:6fe:b664:4b5f with SMTP id h7-20020a1709063b4700b006feb6644b5fls1664482ejf.2.-pod-prod-gmail; Sun, 24 Jul 2022 23:54:30 -0700 (PDT) X-Received: by 2002:a17:907:b590:b0:72f:90ba:bef0 with SMTP id qx16-20020a170907b59000b0072f90babef0mr8855383ejc.333.1658732069824; Sun, 24 Jul 2022 23:54:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658732069; cv=none; d=google.com; s=arc-20160816; b=ttaWFyxGRkQGIqUgd0l1TKzSAAVlAhpumwYih2rzQ+J8L/dpOJSfCPawZaNqq41eVU oN7M4Z/E1Q348bXXRCY/Dh9KOlc/ng55M+lyCuJhz/ijlJFdkMlWoSze7eLWHB+7isxt 2DfMsrbOj1vRJDrVwD7wI0zTCumAl9wfpjQS7iw2g5RfsiQrAFJyO9rIxYGbYr7QRN3c Pzx6VMSMlUxKOXbsWibEv+ZzV3tcOrl3QVJeGJ12zUBbCXrjIaYtlsGWe7RjZzebq4pN 0okWUSz6hR4m2Hu5MIEqc9ePwSLE9GiFRGOlEf/wnHNj7ZJPOOYYlruI4H+5Psz9UKz/ 1HFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=WtIlfV0TRfMwcTJkeyhrUYfoxrMyuEr0LUCaeLfKOGs=; b=NbXscvBCftZjd560m+FRUAkxTZ6Nec4efUL3vUQ6FPSTaUNc/i2w4FuO24pO09/v02 fylDMXxPYckrJJVDb2mUmaeDdUIUEoPvkw0ZRjIsWJ6WAYb+BqtLW/hATNYNSs9xtrQY G6decBK0ta/Hq82MwDPmpOLHCsB0l2mNPluaZujNbWkyyLVWbsyQ253mURU3CSFVY7Hg tWfJx3RpYiCYHxMImXg75aHsT1pJy0usqFiqETc6FXdVnRzu28iGjqu7L4l6M29QOrYN pqMsGMywIflHKgH9LmH18uKOBGcUUDWVT/j+hy0RDqVRPkq5ayJoj/5DUIBOQ8CiEKmp Elyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=eMTP8obK; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id u14-20020a17090617ce00b0072b17278302sor3847359eje.78.2022.07.24.23.54.29 for (Google Transport Security); Sun, 24 Jul 2022 23:54:29 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:907:7638:b0:72d:f11b:5ebb with SMTP id jy24-20020a170907763800b0072df11b5ebbmr8846038ejc.647.1658732069630; Sun, 24 Jul 2022 23:54:29 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-87-14-98-67.retail.telecomitalia.it. [87.14.98.67]) by smtp.gmail.com with ESMTPSA id r2-20020a1709060d4200b00722e57fa051sm4967711ejh.90.2022.07.24.23.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Jul 2022 23:54:29 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: michael@amarulasolutions.com, Amarula patchwork , Jeroen Hofstee , Oliver Hartkopp , Dario Binacchi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Marc Kleine-Budde , Paolo Abeni , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2 4/6] can: slcan: use the generic can_change_mtu() Date: Mon, 25 Jul 2022 08:54:17 +0200 Message-Id: <20220725065419.3005015-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220725065419.3005015-1-dario.binacchi@amarulasolutions.com> References: <20220725065419.3005015-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=eMTP8obK; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , It is useless to define a custom function that does nothing but always return the same error code. Better to use the generic can_change_mtu() function. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/slcan/slcan-core.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c index 09d4abbbd9f4..919311890d2c 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -740,16 +740,11 @@ static int slcan_netdev_open(struct net_device *dev) return err; } -static int slcan_netdev_change_mtu(struct net_device *dev, int new_mtu) -{ - return -EINVAL; -} - static const struct net_device_ops slcan_netdev_ops = { .ndo_open = slcan_netdev_open, .ndo_stop = slcan_netdev_close, .ndo_start_xmit = slcan_netdev_xmit, - .ndo_change_mtu = slcan_netdev_change_mtu, + .ndo_change_mtu = can_change_mtu, }; /******************************************