From patchwork Thu Jul 28 06:18:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2270 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id A98643F013 for ; Thu, 28 Jul 2022 08:19:06 +0200 (CEST) Received: by mail-ej1-f69.google.com with SMTP id qw22-20020a1709066a1600b0072f43c1f59bsf280196ejc.6 for ; Wed, 27 Jul 2022 23:19:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1658989146; cv=pass; d=google.com; s=arc-20160816; b=ze1Tj6h7lgUoGyFjzhlnxBYM9YM4RxlJ+nbpN+w29WcwABezXC/Njg5yQ6CTTzu4zG cqHVraAr22rUeZ2M4En0faxCVQeT76XSLoNu2rq9dNi3GSCbhWdjUM2sapR7spzcsOHy VdhXTOj6iffLtYmR+eHr0v24It9cC1T5T2tJYHl0KSto2ytYXLEvrD58JNjpHLweAhYU Gfv6Ag904eVGEVlaaUv4S8bMcrf7ARvilzQqjNMZCt22KwF4tRQTyVrXrNg6BPojkf0k dp8019c8DMitE+4LEsgb8UvmkAL0ogGB7cjklUNv8mqpIT65gd0mYudptb5PyrkakxuI bIlQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=p9BUgPrxYEuAYSdCqWYHnH5Vkk9pA/5ExZ1MpE2zieY=; b=1FSeXjXYqEyxo+v37WKaiVXgJ+557i1xIqb+foTKndJV7eh5RMKxZof4WR3RDU9bU1 GofzbYU42EJRRiOnoTVsM0zbL5iNiCjvMTqmg8vYfvBpAPp+LpNwuQPdK/k0r8PQJppo QYAj977sW04OC4QpUJ6Cj3U8+IFWs3EAPUpQIHZHUIgsLNOFjvt6a2lkma+J5jc43in7 H5EOHw+TPmssivRr9MXlBOFsbMWEPC6L0W4HEGjH5QsDzETA09zpKPpl51G4VuUx1VD4 Zasu183ozGPP6RoUlQGL7mxm4WCeDOtMPT2slrjyYOIL7sK/SXALMKttW1X6YwVuusFW 0uiA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JbjP0JxI; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=p9BUgPrxYEuAYSdCqWYHnH5Vkk9pA/5ExZ1MpE2zieY=; b=D3KX92lZxcaKT2QLYpmFaZa/wB+wSUpElvEIzxVuRBolT5FeDfHQ1pfkFslphSoBo+ YF57oA0j9sAM3AkWqbUScsNXqkdcp1dOLmuOFjLoAnn7zh66nuxMCWdjaszeH6f83IW7 /jBwx6KE8jrRpeaTVAHK60dYn0jU+/aSNmaFE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:x-spam-checked-in-group:list-post:list-help :list-archive:list-unsubscribe; bh=p9BUgPrxYEuAYSdCqWYHnH5Vkk9pA/5ExZ1MpE2zieY=; b=ND3f2IWZtMRMYaU81LJ8ZxaaSwhx1Y1M4znf5lU/n9nQB5+nPLQ8emjoq2NhDgEVG6 AtL+qUSaaQc974O7RROTDJnGVmne8UnSGdCPxYRUfYp71jY9u/B+uthfxdBgkGtUXrvG pMovWfFjf+VTPQVUEqjaYt3eMZDFjyzzhDZutRDgcCvL6U7RVv2qxIxRVSz4IfI8SYV9 aCp5iA5Q6i4aoHybcXhXSifLl6g8DF60ieXzJRbR+sNCLgo9MVJy9fqCsRmhdhXiBT1W MUXPc+nUwMYSngaL4VqCx3lYhVMN1S2q+VPTD+DBIgJczlSMrnrAL0Vq7hPygL7B6nAc osDQ== X-Gm-Message-State: AJIora9w3+qem3mFJ4WVKihkSb+E6+H3a9+twytqDUUyA6yCTNxcUL8q 5/plhimW11P4HV/AQiW1zdEI3gk4 X-Google-Smtp-Source: AGRyM1sWdRRQvYlpFrIrkX5E280pZBNukBYieSs/QTyvzz88Nj1KQvU0De/H9LmM22rMF88Hwg1T7w== X-Received: by 2002:a17:907:1dca:b0:72b:3cb2:81f7 with SMTP id og10-20020a1709071dca00b0072b3cb281f7mr19273487ejc.567.1658989146183; Wed, 27 Jul 2022 23:19:06 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:906:1115:b0:726:d068:52af with SMTP id h21-20020a170906111500b00726d06852afls385209eja.1.-pod-prod-gmail; Wed, 27 Jul 2022 23:19:05 -0700 (PDT) X-Received: by 2002:a17:907:7349:b0:72d:a080:f8b0 with SMTP id dq9-20020a170907734900b0072da080f8b0mr19696129ejc.389.1658989145053; Wed, 27 Jul 2022 23:19:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658989145; cv=none; d=google.com; s=arc-20160816; b=VFA0iCoLy0gDtNZ2TcJgTFzi2TOEqC1J9xXRsVeuTZFoffdkpEje46erby4tijeXBA Zu+y3TGln+4MALZ5ip6EApHXzpTz7jey0JK/50KvcgqE4QpCI7080FR48iuFmLFleqTw VpFhSojU2XJuUl41X606bNJfnayDKAUUyydo0ANrFVHvgNHRhQYnpQU5Oyy+5/sgJTyS 7L3gWG3FiqnfGoO6TgNspiUjaGGAZF/LVtw4aNVFbMlPUJdgz/dwGt9o9KFZ3Rgxsckl kqgCGw1+roYrThOint3mVduu/xzp7lDWnJgl6TrIyIx+P+ytngjQbktpoJrboeUDlYxP P9mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=C3neU1AtxmqWdDSuYqkB7lF7A3shUmwSCsbgD00NRVo=; b=tmG9QRTMpGRf+JbXUKhiaNFUtcDboIhrXkBTjtY/9fvkVKgN1aPjXOL4ykiqfLVprp OpdQM3ZOzLGqXOsMKzRDEscSNUjVgt2WDHtEZYVDCYv2t6tMJe/1MAen8/xoAgblYWZt ndBc07lp2q7/KsxeBXZfh9e/WGAC0moRWj94CEufi1niHauTnwW8hrAmi3Rse9hY9Euq 2skn72XAIRq1TAv8noOrmZwAkc28/aSIqwxXkV9DKp96+2Xxnczm28B2mHC49amSIWEL yyKH+I5FziRPTPoP0t7wgd2s5zkvjAAcFZJiDK3zVBT1P+wfo6nlSikiMgfXMotR6QLH TCZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JbjP0JxI; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id y19-20020a1709060a9300b0072f643fc044sor28468ejf.37.2022.07.27.23.19.04 for (Google Transport Security); Wed, 27 Jul 2022 23:19:04 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:907:6818:b0:72b:5bac:c3a3 with SMTP id qz24-20020a170907681800b0072b5bacc3a3mr19390245ejc.139.1658989144713; Wed, 27 Jul 2022 23:19:04 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-31-31-9.retail.telecomitalia.it. [79.31.31.9]) by smtp.gmail.com with ESMTPSA id d6-20020aa7ce06000000b0043ba24a26casm105469edv.23.2022.07.27.23.19.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 23:19:04 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Michael Trimarchi , linux-amarula@amarulasolutions.com, Dario Binacchi , stable@vger.kernel.org, Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Vinod Koul , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [RESEND PATCH v5 1/2] dmaengine: mxs: use platform_driver_register Date: Thu, 28 Jul 2022 08:18:51 +0200 Message-Id: <20220728061852.209938-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JbjP0JxI; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Driver registration fails on SOC imx8mn as its supplier, the clock control module, is probed later than subsys initcall level. This driver uses platform_driver_probe which is not compatible with deferred probing and won't be probed again later if probe function fails due to clock not being available at that time. This patch replaces the use of platform_driver_probe with platform_driver_register which will allow probing the driver later again when the clock control module will be available. Fixes: a580b8c5429a ("dmaengine: mxs-dma: add dma support for i.MX23/28") Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Cc: stable@vger.kernel.org --- Changes in v5: - Update the commit message. - Add the patch "dmaengine: mxs: fix section mismatch" to remove the warning raised by this patch. Changes in v4: - Restore __init in front of mxs_dma_probe() definition. - Rename the mxs_dma_driver variable to mxs_dma_driver_probe. - Update the commit message. - Use builtin_platform_driver() instead of module_platform_driver(). Changes in v3: - Restore __init in front of mxs_dma_init() definition. Changes in v2: - Add the tag "Cc: stable@vger.kernel.org" in the sign-off area. drivers/dma/mxs-dma.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c index 994fc4d2aca4..18f8154b859b 100644 --- a/drivers/dma/mxs-dma.c +++ b/drivers/dma/mxs-dma.c @@ -839,10 +839,6 @@ static struct platform_driver mxs_dma_driver = { .name = "mxs-dma", .of_match_table = mxs_dma_dt_ids, }, + .probe = mxs_dma_probe, }; - -static int __init mxs_dma_module_init(void) -{ - return platform_driver_probe(&mxs_dma_driver, mxs_dma_probe); -} -subsys_initcall(mxs_dma_module_init); +builtin_platform_driver(mxs_dma_driver);