From patchwork Fri Sep 16 18:17:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2365 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 8270B3F032 for ; Fri, 16 Sep 2022 20:18:59 +0200 (CEST) Received: by mail-pf1-f197.google.com with SMTP id ay1-20020a056a00300100b0053e7e97696bsf13352958pfb.3 for ; Fri, 16 Sep 2022 11:18:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1663352338; cv=pass; d=google.com; s=arc-20160816; b=Eck8rTpAYCrsEX172+YkK3t0kottQOMUKIKfQyjbkI4+iKWkYED8RPGWc/dY78NJhK CmmQCR+Fct2ezOKutNxh0x4bWtbgf4Kczoi0q2MuwYgWo1BVfqzlxIoJt7awJyO96Qyy 8bmOca0IzV0AuhjeYWcVjcWB3hnmipqvg8TYfCsO8phNPCvL+4CH4EJ+IQj9BViwjYf1 J0DzEloAXkFjq0qnqdIV7SqXbJu29If5UR0dlLEV7oX5FSyH3FiAgUzr6O59XwUDIBra +GoYdvzK8l1TvHQlxUNKyISE11iYUcA25zrRgpk7bzqrxsCxqFcTlkGhPO24e0mfkNWC nKyA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=/C+G/Py6QDoVFuuVDqx6BOqpvVqdC1rrvR1B98CJl9c=; b=HPN3NQrihLl6StAbvZZeZaxfFto049Nly8EYlSdh8Fy4SbUpxMhNcktyuUmc1aqmNX grtj4xtpcpJ8qxHCOKrNOTs6BMUrDUd9uOFNpp2Aqqq5CFht8I2xHSP5KG8OikOTdgG/ GbUNge5eQfIO/BUdQE+9iBDv8AeR3r8dkuB/B4UwQgEH/BDvcE70I/eJuowDAGQ7vtzO w/MLH4giAYYX1TTScPqZAj7iupHkDT1KWq53LlFiZJGxPtDSRxBEPaX/ilDea5CI5J5C i2ZJgpVVzi91o2ACNpDn97x6FHf+6LrrDNagtKVTqPK9fYVukGzU8rSH6XZO22eMuYsz 1Q/Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=L9VBWsyO; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date; bh=/C+G/Py6QDoVFuuVDqx6BOqpvVqdC1rrvR1B98CJl9c=; b=h6H4LxhadMFeQ2NXciarhdl/DQzdrPnGh24ChD3jfUt6/RxnpK4oXH9CGfZYvsovq8 R0Ip17ip4gX8tigkTZSBVvsb5Kv/oTVLZXyuCOQLbbuzvV3fYYE/rbPFButQxbhVvJ3R SmbYgHjOdxx1Hr46G3UENlhfbOyrU6gYViJ7c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=/C+G/Py6QDoVFuuVDqx6BOqpvVqdC1rrvR1B98CJl9c=; b=yyUNI2XV/8+8ZQAUrY9bWPtXRhjk5MGnmYDpgptxf5rT8voA7GmaJWw4PHN1M0su4k wCW2/CrNNhJatWFazEVcYIbRIcvNOf8z47jnqaTbT3HccgE+gfsd07SLl0XBkAkChb+u wrWMot4UiXP4IMP9MzDfWo+Ucm520KI+zN4KuJ5cwKBksJakqak2P7AOAJMMgDhvVDW4 iz8q90IRelTRb2YuS8Vkv2PU25EALM8vHACGTcs+v0GCSE4qRnmdNOwcSpaYZhooWHi/ 4gAozWapvSAsVspFpZEWvv3hXXOtnhjL91A9UkiRy0MjkyzXjAk8FkPOBdVHCDxCW44P AefQ== X-Gm-Message-State: ACrzQf3DU0kavxxZNKB3cHMQqgCov2drmyhAIi132FjOpGIIV/RvzWnu AwfVatcjZXuJkx49DPkN7nL8gWnm X-Google-Smtp-Source: AMsMyM45wCndorJ1gO0Nx3Yyu0KGdmZdWTCn+Z7NgCJC5eA+IUSvVZTq4+yLSTfzLF5CB2VXdzrHhQ== X-Received: by 2002:a05:6a02:186:b0:439:49a3:479b with SMTP id bj6-20020a056a02018600b0043949a3479bmr5640576pgb.171.1663352338331; Fri, 16 Sep 2022 11:18:58 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:90a:12c3:b0:200:19ab:596d with SMTP id b3-20020a17090a12c300b0020019ab596dls15844112pjg.1.-pod-prod-gmail; Fri, 16 Sep 2022 11:18:57 -0700 (PDT) X-Received: by 2002:a17:902:dac4:b0:178:3037:680a with SMTP id q4-20020a170902dac400b001783037680amr1105256plx.37.1663352337471; Fri, 16 Sep 2022 11:18:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663352337; cv=none; d=google.com; s=arc-20160816; b=k2nNmT2+fMBft/XHcdqQ6pRrX47udecWO7TRhzuuG6PwSovxusNLTlBqgU/vKG5ZR9 pC3wl2eHBx/8o9UMer8vZ/2JjRhmmattnJDbjnkAbCHreVyPhfUirngDBsOP02zam3vL xAtqVVlhYN3MPaiPxSSk9zR9TN/sVNoCBNY3qsgE+Lxr4/qbmFB6lyo8Iu4Hmhg/4mED L0lX3Gm7VTgA5dAkXmEYN6hBOy1AzYgB91KnmrCEO0ZVEVGm24v1eWETFXo3s46yLuNk 8lppOIlNIxKqoZ+/duXFzJwb3nMZVroHcUaSo0aV/GmPkLRIRS/UGdXYSvqmL4VSRtho 6Vqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=TLVefyfl9f8OxBnZeywVyOFE3VwZP0fby31K9AwiC9o=; b=bnNt/8gUImqk9xvXSv4tX1DkCq7onaMWsGm1Rk/sCYIGNbYb3yzzOHK/R4as8WJ0nv 61cxEmMoF08fzSCysZBfkRADaMxUAg9gkm8Z1c3AoPQKDLqeRFguusT7e6rbvv+J7u37 7RkIFY9job9bJMItcsPNfRQmcZqSMEz5v9G4Aodum00rZYzqKYumKagfhXXiOsQQFfkR +suNI9djZQNcPiI9c41jNqrreWzIGTNpisv3+WKjfa5CkB5bGegMeR3dKLNU/dbi9WpH 8A5pTSqkix3rqijwt6MKOXSY9ht2yWMXT1akpGM6XsHniTCTYKTc5FLB3kKAi8TYxfS+ 7d7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=L9VBWsyO; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id j191-20020a6380c8000000b004393f4ef112sor5887873pgd.46.2022.09.16.11.18.57 for (Google Transport Security); Fri, 16 Sep 2022 11:18:57 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a63:2fc7:0:b0:42c:3683:7e50 with SMTP id v190-20020a632fc7000000b0042c36837e50mr5781542pgv.534.1663352337125; Fri, 16 Sep 2022 11:18:57 -0700 (PDT) Received: from localhost.localdomain ([2405:201:c00a:a073:ae5d:6ee4:5c2f:6733]) by smtp.gmail.com with ESMTPSA id d14-20020a17090a6a4e00b002007b60e288sm1770000pjm.23.2022.09.16.11.18.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 11:18:56 -0700 (PDT) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v5 05/11] drm: bridge: samsung-dsim: Handle proper DSI host initialization Date: Fri, 16 Sep 2022 23:47:25 +0530 Message-Id: <20220916181731.89764-6-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220916181731.89764-1-jagan@amarulasolutions.com> References: <20220916181731.89764-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=L9VBWsyO; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , DSI host initialization handling in previous exynos dsi driver has some pitfalls. It initializes the host during host transfer() hook that is indeed not the desired call flow for I2C and any other DSI configured downstream bridges. Host transfer() is usually triggered for downstream DSI panels or bridges and I2C-configured-DSI bridges miss these host initialization as these downstream bridges use bridge operations hooks like pre_enable, and enable in order to initialize or set up the host. This patch is trying to handle the host init handler to satisfy all downstream panels and bridges. Added the DSIM_STATE_REINITIALIZED state flag to ensure that host init is also done on first cmd transfer, this helps existing DSI panels work on exynos platform (form Marek Szyprowski). v5: * none v4: * update init handling to ensure host init done on first cmd transfer v3: * none v2: * check initialized state in samsung_dsim_init v1: * keep DSI init in host transfer Signed-off-by: Marek Szyprowski Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 25 +++++++++++++++++-------- include/drm/bridge/samsung-dsim.h | 5 +++-- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index eac2dc2f24ba..6d524338d4ff 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1234,12 +1234,17 @@ static void samsung_dsim_disable_irq(struct samsung_dsim *dsi) disable_irq(dsi->irq); } -static int samsung_dsim_init(struct samsung_dsim *dsi) +static int samsung_dsim_init(struct samsung_dsim *dsi, unsigned int flag) { const struct samsung_dsim_driver_data *driver_data = dsi->driver_data; + if (dsi->state & flag) + return 0; + samsung_dsim_reset(dsi); - samsung_dsim_enable_irq(dsi); + + if (!(dsi->state & DSIM_STATE_INITIALIZED)) + samsung_dsim_enable_irq(dsi); if (driver_data->reg_values[RESET_TYPE] == DSIM_FUNCRST) samsung_dsim_enable_lane(dsi, BIT(dsi->lanes) - 1); @@ -1250,6 +1255,8 @@ static int samsung_dsim_init(struct samsung_dsim *dsi) samsung_dsim_set_phy_ctrl(dsi); samsung_dsim_init_link(dsi); + dsi->state |= flag; + return 0; } @@ -1269,6 +1276,10 @@ static void samsung_dsim_atomic_pre_enable(struct drm_bridge *bridge, } dsi->state |= DSIM_STATE_ENABLED; + + ret = samsung_dsim_init(dsi, DSIM_STATE_INITIALIZED); + if (ret) + return; } static void samsung_dsim_atomic_enable(struct drm_bridge *bridge, @@ -1442,12 +1453,9 @@ static ssize_t samsung_dsim_host_transfer(struct mipi_dsi_host *host, if (!(dsi->state & DSIM_STATE_ENABLED)) return -EINVAL; - if (!(dsi->state & DSIM_STATE_INITIALIZED)) { - ret = samsung_dsim_init(dsi); - if (ret) - return ret; - dsi->state |= DSIM_STATE_INITIALIZED; - } + ret = samsung_dsim_init(dsi, DSIM_STATE_REINITIALIZED); + if (ret) + return ret; ret = mipi_dsi_create_packet(&xfer.packet, msg); if (ret < 0) @@ -1637,6 +1645,7 @@ static int __maybe_unused samsung_dsim_suspend(struct device *dev) if (dsi->state & DSIM_STATE_INITIALIZED) { dsi->state &= ~DSIM_STATE_INITIALIZED; + dsi->state &= ~DSIM_STATE_REINITIALIZED; samsung_dsim_disable_clock(dsi); diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h index 478f0291fb94..57b27d75369e 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -17,8 +17,9 @@ struct samsung_dsim; #define DSIM_STATE_ENABLED BIT(0) #define DSIM_STATE_INITIALIZED BIT(1) -#define DSIM_STATE_CMD_LPM BIT(2) -#define DSIM_STATE_VIDOUT_AVAILABLE BIT(3) +#define DSIM_STATE_REINITIALIZED BIT(2) +#define DSIM_STATE_CMD_LPM BIT(3) +#define DSIM_STATE_VIDOUT_AVAILABLE BIT(4) enum samsung_dsim_type { SAMSUNG_DSIM_TYPE_EXYNOS3250,