From patchwork Fri Sep 16 18:17:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2366 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 079D73F032 for ; Fri, 16 Sep 2022 20:19:07 +0200 (CEST) Received: by mail-pl1-f200.google.com with SMTP id p12-20020a170902e74c00b00177f3be2825sf15415343plf.17 for ; Fri, 16 Sep 2022 11:19:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1663352345; cv=pass; d=google.com; s=arc-20160816; b=PtcW9qOS0hYqQngMh//BtvF+OEf4kMjj+VjrJWQEGnV9Ryljb0U0HtBeLMBS03V+/L S2uywYUiYhvhloo8UQho+8/Gdx7DwvtdIeodMuqgfdKduycTS4W9URHJwWMrSYq/V/Oj EgfU8K7HddAZd+geeO0PEJbrjbdMDKOFC4J0KCmgaHST/uNPCK3TeV5JQFxumei+/Td/ hoM/4bfLQNwAIYkCyusx3Iz8CzNewQsntdywkS4ct2KCgHYV+k3VqNm/7tRMFIcVRaV4 +eGy3kxF/sBBlgvGBrvetaaf3iUYax5RXmPm3aexJN6OnzlJ+N+XJ6RG3QSgHbF0purQ iFHA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=OhUUbJDrWjMRO2kOeH011+iJwpwSmmmX6nGtqSOOnbQ=; b=L8djlxZp76YxWl+EBQYkvfFtIfTR3Jk9Dwdgl7X/4Y3512gdi0UBCwADbc/zWkyljT 9ctJSTv7VpqSusOSSFmUnR0lP6ea1uWm2670Tv/dh35gJKNQpqhdyk3BS86a9yhPLHfM V3LZmtkayI/lZ08v9JfSdVE4N8Uble1G9vMKmixvUpFnF9b3Z3x5uAg68+GcSeunxxyH fk7Te8z5LZ5AtDk4+719ZYll9nG4bfwvFH/3cyDyzR7bV5fZTu0oFQSO+R14n0GkBlJs D/tx3/KoXzpfWRsdlSDlyEYqu0WKFHMcm3bFNLbon1oSeku+SeoUTTKwb/PuIOnKOh+9 QpIQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=YdBKDmr3; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date; bh=OhUUbJDrWjMRO2kOeH011+iJwpwSmmmX6nGtqSOOnbQ=; b=AeItrLMud+zkfojVfXpea3W70J3IB5NgLW6nV4UlPrK0IpbZlhlNrXMVfRffIgaNJm 4SvGgEZLCho1o2rh9eGoU9O+fOhPD6T08ht4mMqs/A+NtKdD0AmNnVTxvDwylNlOFdpS L0hOfJV6N8bhzfX0A0SC7a0eww0JGdioD5Af0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=OhUUbJDrWjMRO2kOeH011+iJwpwSmmmX6nGtqSOOnbQ=; b=glRon1YCLzKUtTHEWqcbvwwsDRB5XYpVfWga6YLO4QlfnPWlV0ug98yPUl7U/w07f3 oMT4PtesaFKzw/waymfePCW/d7dx+0ex5QlTthZwO3q71eHrmMwWYvUAcaPlfg3Hyo4o adu3zKPb8Wqn2k+ozwc66zgTWnCTbTQnVqQQa0x5W1GRfbcBrC6zaRbNFEzYYpXZUnJd hzzHwMjMsUTnjfyVQLK704t3G4Q6YAE7eyaV0W8h1m9KAbSgvNkFLJjdkhR9kzeoYxah Kh1qg502oQ15OEjJqHgN14UpvJy0e+CxZNwIUYB+y7EJNGJ9vHtviFEXggQm5WSP7ugr h0Zw== X-Gm-Message-State: ACrzQf3+zaDRgeVarelOLY+c1Sl+D74s4oxVHBRXbwksaUjLd67pwCtO eX61epsNKzFYe7ilQYr/R+CDVBlO X-Google-Smtp-Source: AMsMyM4dZgtKqwqpV9iEuXvDyAB+v4Vs9NHJ3+uHQmLsJTn3lAo+EtSaysVBgkNdWYSS7j/POMk2Qg== X-Received: by 2002:a63:e153:0:b0:439:2fa3:74d1 with SMTP id h19-20020a63e153000000b004392fa374d1mr5590153pgk.85.1663352345780; Fri, 16 Sep 2022 11:19:05 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:903:260e:b0:178:35a3:84d9 with SMTP id jd14-20020a170903260e00b0017835a384d9ls10357235plb.10.-pod-prod-gmail; Fri, 16 Sep 2022 11:19:05 -0700 (PDT) X-Received: by 2002:a17:902:b206:b0:173:c58:dc74 with SMTP id t6-20020a170902b20600b001730c58dc74mr1039136plr.65.1663352344910; Fri, 16 Sep 2022 11:19:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663352344; cv=none; d=google.com; s=arc-20160816; b=Z4a4JrwUP0gg8a95Dl7czPpM96rTIj+Q9ioQJFqeMFNDZCX6rGN6zWY9CWgUgYbkuD bfveOceAa1cZ/am/lSQDJE/qFbNYzgamX25KWMDyaMJCJJv9DzLqIPIrr9q7giwN/vPT d69ga5UB3cFarTb6vZBmCTxzVAuFYbJWjGM72o2d2NIotZsMWBtRY1eWLKhbQY9PewWC Yk3yZG6ICrfbp3BUBoA0fnuf9KG+FUsnnUQ64aspynnaYmhza4biVhcUg3oOYdh2FtKJ 90HNji/2pmvyUVajmhPkKLEEbNBkUCP23RXtnipqRsEnEyqns07RNI9fYQZSrow7DHSB JuNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=btq8+UvEuEu4v/DMPqax3KQNrb7VRjirbnKm5H1X5d4=; b=E6w4I/XAwm64GW2urRoTwWammG1hi+avWtAPYi6rEBljjFOs9IP7MCJ6htGI8SRS9g lxTJ9RJSSwJcTFhBczFLsxS4p3R+/PaieH9FYa18+MT5yI5IPOMCCIZjIi0G3dTB9EtZ ilmY4EkJiXEfPcPmg1742f2ynZjI9zGfX8BScdpVNpmkspYbHeZIhm7mH3iB/7/KPQMj UGK4L2sMbcyfg/lOY4qAr9rr1p9HxDZ4qoecwSN22bk7Y+1N9PBWGnykrtrUuh9L8tpd gdDfYo2+dKDX8lb7Z7bKjpUX8tDwxEqo2illz/sKk/6sBkdaG/v6gUiWkqfkdmul8Dx8 O1tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=YdBKDmr3; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a8-20020a170902900800b00176d0c34129sor9163524plp.170.2022.09.16.11.19.04 for (Google Transport Security); Fri, 16 Sep 2022 11:19:04 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:90a:9295:b0:202:582b:1765 with SMTP id n21-20020a17090a929500b00202582b1765mr6666216pjo.99.1663352344609; Fri, 16 Sep 2022 11:19:04 -0700 (PDT) Received: from localhost.localdomain ([2405:201:c00a:a073:ae5d:6ee4:5c2f:6733]) by smtp.gmail.com with ESMTPSA id d14-20020a17090a6a4e00b002007b60e288sm1770000pjm.23.2022.09.16.11.18.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 11:19:03 -0700 (PDT) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v5 06/11] drm: bridge: samsung-dsim: Add atomic_check Date: Fri, 16 Sep 2022 23:47:26 +0530 Message-Id: <20220916181731.89764-7-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220916181731.89764-1-jagan@amarulasolutions.com> References: <20220916181731.89764-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=YdBKDmr3; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Look like an explicit fixing up of mode_flags is required for DSIM IP present in i.MX8M Mini/Nano SoCs. At least the LCDIF + DSIM needs active low sync polarities in order to correlate the correct sync flags of the surrounding components in the chain to make sure the whole pipeline can work properly. On the other hand the i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020 says. "13.6.3.5.2 RGB interface Vsync, Hsync, and VDEN are active high signals." No clear evidence about whether it can be documentation issues or something, so added a comment FIXME for this and updated the active low sync polarities using SAMSUNG_DSIM_TYPE_IMX8MM hw_type. v5: * rebase based new bridge changes [mszyprow] * remove DSIM_QUIRK_FIXUP_SYNC_POL * add hw_type check for sync polarities change. v4: * none v3: * add DSIM_QUIRK_FIXUP_SYNC_POL to handle mode_flasg fixup v2: * none v1: * fix mode flags in atomic_check instead of mode_fixup Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 26 ++++++++++++++++++++++++++ include/drm/bridge/samsung-dsim.h | 1 + 2 files changed, 27 insertions(+) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 6d524338d4ff..8abf89326424 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1315,6 +1315,31 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge, pm_runtime_put_sync(dsi->dev); } +static int samsung_dsim_atomic_check(struct drm_bridge *bridge, + struct drm_bridge_state *bridge_state, + struct drm_crtc_state *crtc_state, + struct drm_connector_state *conn_state) +{ + struct samsung_dsim *dsi = bridge_to_dsi(bridge); + struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode; + + if (dsi->plat_data->hw_type & SAMSUNG_DSIM_TYPE_IMX8MM) { + /** + * FIXME: + * At least LCDIF + DSIM needs active low sync, + * but i.MX 8M Mini Applications Processor Reference Manual, + * Rev. 3, 11/2020 says + * + * 13.6.3.5.2 RGB interface + * Vsync, Hsync, and VDEN are active high signals. + */ + adjusted_mode->flags |= (DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC); + adjusted_mode->flags &= ~(DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC); + } + + return 0; +} + static void samsung_dsim_mode_set(struct drm_bridge *bridge, const struct drm_display_mode *mode, const struct drm_display_mode *adjusted_mode) @@ -1337,6 +1362,7 @@ static const struct drm_bridge_funcs samsung_dsim_bridge_funcs = { .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, .atomic_reset = drm_atomic_helper_bridge_reset, + .atomic_check = samsung_dsim_atomic_check, .atomic_pre_enable = samsung_dsim_atomic_pre_enable, .atomic_enable = samsung_dsim_atomic_enable, .atomic_disable = samsung_dsim_atomic_disable, diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h index 57b27d75369e..0c5a905f3de7 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -27,6 +27,7 @@ enum samsung_dsim_type { SAMSUNG_DSIM_TYPE_EXYNOS5410, SAMSUNG_DSIM_TYPE_EXYNOS5422, SAMSUNG_DSIM_TYPE_EXYNOS5433, + SAMSUNG_DSIM_TYPE_IMX8MM, SAMSUNG_DSIM_TYPE_COUNT, };