From patchwork Fri Sep 16 18:17:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2371 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 9B7093F032 for ; Fri, 16 Sep 2022 20:19:44 +0200 (CEST) Received: by mail-pf1-f199.google.com with SMTP id 2-20020a621502000000b00541081df73esf12574490pfv.9 for ; Fri, 16 Sep 2022 11:19:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1663352383; cv=pass; d=google.com; s=arc-20160816; b=aw2nFgR17vVGzKFnw7Z9J578LAjkJjT33ErZXkouZAi1Vz4UZIjQ+UEG86KVhkBRb/ lT4nwQAP2ed57diGJT77iZMJtL46h6BnIQiMtPMKYVSwn9842h6zL8KCxx82kvChkcU8 qcpBy9XgaGZCLxZjXsV+TGzJiZPSwZnFNmXi9ObfkRdggX4CX9BibKl0B6k+Oo6IvuaM Kh31hp8QaQ8NDXt09jO3SpLsBLo/Nh3T5TAvjd2ME1GGJ5qsgN1oquvuiSUN0+IxCzES UQXu7B5KbgvFX9/ZBlc1RTQBgLAdwuxDpKRiB9uVMNgnpM6Om6AoTPN4ogGxMnga1CE/ wtWQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=9TkLeouOf6GiKN398pvG7ov1qx2bdPfBt1kJNLul12Q=; b=wMzMoQEJF7q6zcAMUJjGGiwPLEJgu4eFS/GRBA4YMQy2WUV5OO3Vpzv3lwQfBeKbHO k29WvSBO1j2WO70vpo+ks0QwwmbKWkHgOHoh/QpM5TqZrz5GZ4XldwOUiTv0qkptdZWd Y/LWf0Y//kIPLQBR50R9q2hAfzIqv3r5FypjacHX2HEq9hKtEvzVAfrt26iIgR16S1yA ZxXV9IPgj4Bp3x9gtuM7vAHrGsD3O/hauWMssCN/BT6R+Q8yf2klFdfrQPGM7mWhU7rM YPZFIfYJymQ0LIXmb7N+U3LHpHqVzw+rK7nRE9EJWL741zyQBJ0rPLQA9jnAtw24wuJz f7qw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=bGSRSiPn; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date; bh=9TkLeouOf6GiKN398pvG7ov1qx2bdPfBt1kJNLul12Q=; b=Cj7tOm2wfPEzh/1rI3Yvva/4E51Sagf+y/QM/fzQ1lw4skOGTmDehXpvpL4kkdyHe9 Y1mnVnQoTwXr/t4mn1QJUqqOcAmZY7gc0RkMYkoHjgxDkp07+MMelhnwEv4WZO0pIq7C c88ia7WnBoxo+a96rkeZBgWs93oM73bclrhUY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=9TkLeouOf6GiKN398pvG7ov1qx2bdPfBt1kJNLul12Q=; b=ZiNTLsghIiK/qfoYowbTgZ1E3V8gj2ywdKJGuDqy2neTyXmTv9xFkMwiTiV9sXyl4l 48+4OPHekcxI77Q0ca7h8nLs4MstZwKSCWHP6GI1y8k+3/VYi1+xBN/efORDAZE8bTTZ maSTXcyq2M9WbB1/VSDGdXiVXl8eMwdFm5fM6VTkM1uTQWbIfOy3sIo9dXeu2B/GPkop t2AsYigmsj4tnYi632ifE9RwGoty+8nksSclAld1/zRs7FIpowDEGhZoC23633QlC8lh NPh1MuirOWhP6J59gZw2iXbB95GMLhwgaHFIOwZIp2WuTyvNVbBZ/xr0Ap497FN2H4Ro hmeg== X-Gm-Message-State: ACrzQf16DgoPcfZgG/cPzwrdmI4ksmFikcjgu+IoGA3bMUnGSyeXLJkt uriii1CZs35FWZtpmJP3Cn6nZvMK X-Google-Smtp-Source: AMsMyM5oWB+Fn6/p2GbrOqtHDMIfnbLfjmqjhrlpRZkifqWhXpH80yvNfgM4QDWOOk2VaKzHIgzAfQ== X-Received: by 2002:a63:91ca:0:b0:436:64db:c902 with SMTP id l193-20020a6391ca000000b0043664dbc902mr5753027pge.87.1663352383460; Fri, 16 Sep 2022 11:19:43 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:ce84:b0:16d:4224:4877 with SMTP id f4-20020a170902ce8400b0016d42244877ls16369656plg.4.-pod-prod-gmail; Fri, 16 Sep 2022 11:19:42 -0700 (PDT) X-Received: by 2002:a17:90b:3504:b0:202:5d53:86c with SMTP id ls4-20020a17090b350400b002025d53086cmr6707986pjb.182.1663352382609; Fri, 16 Sep 2022 11:19:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663352382; cv=none; d=google.com; s=arc-20160816; b=TLgfBBpWVRVscJIG2ym77glHw5KbpFv3mcJi+UGL8Bh8TMTcGJSqpck+ELO4IMNjTN PN8EeasvCgCKYgD6mu3u/IhiZcpjVhPPz7vifA8gVV3I2UuxwW1qILKIT9nBM0dRQAg4 qn5vlQuPrJyBoSM3aQBOnjTTM2n2TKFMDI9ds77Y+zpH5GMZP7idc50sB+2aw7lQnn/a 7XajJyvD9OQYJBUenWBUIH1/JVe7kwzlG35Hs1SfZ/OLFG3W823v7mZIX4GzrSBP2D8K v7N2Veuf6f9UNZ8HR0UXvh/JOSsTqygxMW/Rczjppth33vbl7xcxuy5oc5W7ednMjJ0v XOpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=eJYfhIonTlyAez2s0SjetdYIgKeSNtmNA1kceRWxrAI=; b=T5DjpgF+YnkMnr9eXenYBFIhVYZ2Ls/q0aWYYKzYk+ArlFLJ0Ca4PKg6Xdalvc4DOK QOOLek1pwNdnJFNQufGhgsksXRD095+m4qwj5LyW4OEe/hCUZIKykYEzuHZtDFLT8Vlj xX7vHFxTGlJcmwHVtNO3hc8yVMXX2skO4t9nLviJjMEqmFdXAEIewxPY/DwKxX3yPGfy 682WmQi5wR13pkE9v1s7mrcyyFk8Cq1pVgvlZwi42oGluHMfX2LqBFlKjTknA7shQdpW f3xx3uukO6dfbmUbzjkTlDIvjm+O/xrVIuUfpXsFFAxOu7DEi/0d8+XxqYeEqDWrrxmO 0a3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=bGSRSiPn; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id f9-20020a170902f38900b0017293584a66sor9340619ple.72.2022.09.16.11.19.42 for (Google Transport Security); Fri, 16 Sep 2022 11:19:42 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:902:f650:b0:172:8ee1:7f40 with SMTP id m16-20020a170902f65000b001728ee17f40mr1082560plg.101.1663352382325; Fri, 16 Sep 2022 11:19:42 -0700 (PDT) Received: from localhost.localdomain ([2405:201:c00a:a073:ae5d:6ee4:5c2f:6733]) by smtp.gmail.com with ESMTPSA id d14-20020a17090a6a4e00b002007b60e288sm1770000pjm.23.2022.09.16.11.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 11:19:41 -0700 (PDT) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki , Laurent Pinchart Subject: [PATCH v5 11/11] drm: bridge: samsung-dsim: Add i.MX8MM support Date: Fri, 16 Sep 2022 23:47:31 +0530 Message-Id: <20220916181731.89764-12-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220916181731.89764-1-jagan@amarulasolutions.com> References: <20220916181731.89764-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=bGSRSiPn; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Samsung MIPI DSIM master can also be found in i.MX8MM SoC. Add compatible and associated driver_data for it. v5: * [mszyprow] rebased and adjusted to the new driver initialization * drop quirk v4: * none v3: * enable DSIM_QUIRK_FIXUP_SYNC_POL quirk v2: * collect Laurent r-b v1: * none Reviewed-by: Laurent Pinchart Signed-off-by: Marek Szyprowski Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 45 +++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index a0f5438b7921..62cb42087de3 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -360,6 +360,24 @@ static const unsigned int exynos5433_reg_values[] = { [PHYTIMING_HS_TRAIL] = DSIM_PHYTIMING2_HS_TRAIL(0x0c), }; +static const unsigned int imx8mm_dsim_reg_values[] = { + [RESET_TYPE] = DSIM_SWRST, + [PLL_TIMER] = 500, + [STOP_STATE_CNT] = 0xf, + [PHYCTRL_ULPS_EXIT] = 0, + [PHYCTRL_VREG_LP] = 0, + [PHYCTRL_SLEW_UP] = 0, + [PHYTIMING_LPX] = DSIM_PHYTIMING_LPX(0x06), + [PHYTIMING_HS_EXIT] = DSIM_PHYTIMING_HS_EXIT(0x0b), + [PHYTIMING_CLK_PREPARE] = DSIM_PHYTIMING1_CLK_PREPARE(0x07), + [PHYTIMING_CLK_ZERO] = DSIM_PHYTIMING1_CLK_ZERO(0x26), + [PHYTIMING_CLK_POST] = DSIM_PHYTIMING1_CLK_POST(0x0d), + [PHYTIMING_CLK_TRAIL] = DSIM_PHYTIMING1_CLK_TRAIL(0x08), + [PHYTIMING_HS_PREPARE] = DSIM_PHYTIMING2_HS_PREPARE(0x08), + [PHYTIMING_HS_ZERO] = DSIM_PHYTIMING2_HS_ZERO(0x0d), + [PHYTIMING_HS_TRAIL] = DSIM_PHYTIMING2_HS_TRAIL(0x0b), +}; + static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = { .reg_ofs = exynos_reg_ofs, .plltmr_reg = 0x50, @@ -421,6 +439,23 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = { .reg_values = exynos5422_reg_values, }; +static const struct samsung_dsim_driver_data imx8mm_dsi_driver_data = { + .reg_ofs = exynos5433_reg_ofs, + .plltmr_reg = 0xa0, + .has_clklane_stop = 1, + .num_clks = 2, + .max_freq = 2100, + .wait_for_reset = 0, + .num_bits_resol = 12, + /** + * FIXME: + * Offset value used from downstream drivers/gpu/drm/bridge/sec-dsim.c + * remove this comment if it is true else update the logic. + */ + .pll_p_offset = 14, + .reg_values = imx8mm_dsim_reg_values, +}; + static const struct samsung_dsim_driver_data * samsung_dsim_types[SAMSUNG_DSIM_TYPE_COUNT] = { [SAMSUNG_DSIM_TYPE_EXYNOS3250] = &exynos3_dsi_driver_data, @@ -428,6 +463,7 @@ samsung_dsim_types[SAMSUNG_DSIM_TYPE_COUNT] = { [SAMSUNG_DSIM_TYPE_EXYNOS5410] = &exynos5_dsi_driver_data, [SAMSUNG_DSIM_TYPE_EXYNOS5422] = &exynos5422_dsi_driver_data, [SAMSUNG_DSIM_TYPE_EXYNOS5433] = &exynos5433_dsi_driver_data, + [SAMSUNG_DSIM_TYPE_IMX8MM] = &imx8mm_dsi_driver_data, }; static inline struct samsung_dsim *host_to_dsi(struct mipi_dsi_host *h) @@ -1772,7 +1808,16 @@ const struct dev_pm_ops samsung_dsim_pm_ops = { }; EXPORT_SYMBOL_GPL(samsung_dsim_pm_ops); +static const struct samsung_dsim_plat_data samsung_dsim_imx8mm_pdata = { + .hw_type = SAMSUNG_DSIM_TYPE_IMX8MM, + .host_ops = &samsung_dsim_generic_host_ops, +}; + static const struct of_device_id samsung_dsim_of_match[] = { + { + .compatible = "fsl,imx8mm-mipi-dsim", + .data = &samsung_dsim_imx8mm_pdata, + }, { /* sentinel. */ } }; MODULE_DEVICE_TABLE(of, samsung_dsim_of_match);