From patchwork Sat Oct 1 08:06:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2405 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 1FCC93F06D for ; Sat, 1 Oct 2022 10:08:27 +0200 (CEST) Received: by mail-pf1-f198.google.com with SMTP id be18-20020a056a001f1200b00543d4bac885sf3995329pfb.13 for ; Sat, 01 Oct 2022 01:08:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1664611706; cv=pass; d=google.com; s=arc-20160816; b=KlTtIPaQJDRS64BggMpumPCJJVRpHP+/XBZhIfhjrmqtPHp4OgoNcvY2mxFSBcgb8z FYg1HWytRfF2D+2nGM6gLJHrWVo37FewVQw5r7AliF33qzmQ+jpE5ZoI9bgyXzyC5yU4 zxnZZCP2HquGvgFkWTlg7Lr9zpOARBljUglwDsmdR+Msaf3xLE6Tj5rNX2TF+5fvvGf5 uY+hY8f2DUcvXOkSrfuHkIdoI6ZzfAdmtKnIyfXpW3jSca2dpqQlwTifzG+CiImkddNV XpKVYNskxqSB+7UtsylZKLA88mwz5ddPU4r52LTyoMqd86ZHGbSAiKq6YeJmnAb9XPde E53g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=2t6AF/Ic5Kil4KVEXhJT08PkyPxtWGB+7p8bxKU+jZw=; b=ZyV7tQ3lrogO6ph6xNB0gMaeE4XNEkG9g2Dme6hyj0JlRi+E5tHraRgTayGxyElZNY 7/30l7d+HXx1+mW4827UwD4cO6Vnnx8s0A6aLrsyXujXlsDNhdrFZQeqfubRgfSAZs99 4HVAZDVdnUnoAGk9/V8/C2K/2sOqKDXIXvYw0jYFgagmfAP11qGelB9V9GusdMIjX0bg /58YLYx7+gHtUebeOnxPd5vKJbygp0gNxbJENCKLbjgul615fJ8eI0mH2+5ex3Qcs0mO zMLFU1FPL7f0qieCW371W4isxkc0ufqa2/KzQLWJj0V5T9ZX3LwLbx9rD0J0jpfvDnsK 6uJg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=YE7cv58N; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date; bh=2t6AF/Ic5Kil4KVEXhJT08PkyPxtWGB+7p8bxKU+jZw=; b=CoIYNZhVw8rs8nhZl0AT4NQEHAme3d1wgNkcxR/MIv2he81X4xfagVEexEFsCRxcm8 T6j/61Bk+39AhsHKDhs+/UarUlzn/HtnHqAg2akppHfudmA5649HohO9CzED6EnT0AAU SugAaXumW1b6RFDhH9frPP0Vn5V+D4nvFbfAw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=2t6AF/Ic5Kil4KVEXhJT08PkyPxtWGB+7p8bxKU+jZw=; b=NaKzB0rKx+GZn+3djUzm+2jF9RZ6K3Y6uixL8Ns7JN+FsAYU76VVCVF3VTtW0nIx0V GOemzFjMLmTkxdYTn8QirUpqD7NxPwgVEG3y+/62IFAYz63DYOhHkW38OTUaPiEmzQoF iDQN0jgp2sFTvyq5MFY+gLIwIzKPGIMp2VeNh9eFkk8pL1+GFpNjkFmQYJh3rub+y6JO hgVuKFrWsGxBGycNvI8MjwIr6MxgzqrjRcFqonJBCmEvLq8PBxjF/VAJeMtVw840KA1N VNT3OjUtB/uUObSwe4GWljKPS5OescbxaymmiLfwsoFkvalSRYyKX+Ajwt1IJoAwnPhE uQyg== X-Gm-Message-State: ACrzQf0ZWuErC7vZEHOP22UeoC25C+sp3C8dSbY/wiiXCqyGh23NPHW6 FvaCf82ua22u7DJdJfGRU7np2HdC X-Google-Smtp-Source: AMsMyM7hRJJI1NimPY2LelJPGsVgwjkdOC7hZkj/ktldD72hdYYO9BK3RZPx3CLoC5VK8VYY/OuaNQ== X-Received: by 2002:a63:da12:0:b0:43a:18ce:f959 with SMTP id c18-20020a63da12000000b0043a18cef959mr10686478pgh.386.1664611705913; Sat, 01 Oct 2022 01:08:25 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:ce0f:b0:176:9478:2315 with SMTP id k15-20020a170902ce0f00b0017694782315ls5716931plg.9.-pod-prod-gmail; Sat, 01 Oct 2022 01:08:25 -0700 (PDT) X-Received: by 2002:a17:90a:d181:b0:205:e100:3000 with SMTP id fu1-20020a17090ad18100b00205e1003000mr2269771pjb.184.1664611705051; Sat, 01 Oct 2022 01:08:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664611705; cv=none; d=google.com; s=arc-20160816; b=XSQnSB8VFiAxZ7EpFnvcmhy/bzbp5ACwVf79eDjRY88MLzFI5sCy0WCuAC0R+/UrWU VZHBC3x3OmZTvKD7wmc2AhCeBuyQDCnus0QKtpVZSs+KGX36DO2U4RgOrDdiJ3GRN5wk TpAxSCD4g6b9lOF+yxvc0zFOjewrICp/6ijqmTntv9I7pcsbvtBQJXHYO2hETUNlLceh dAZc9OYRPVBEIvt/Xvl2Sj/AaWNRmIr75yHkOTHLPfNj4VKiILfylLbfEZU10octdKsJ OzP3Ny81B4VeyCNGgTojte8DJcp+1F8cuP7jJdu/c2L9ranzAyhczCYQeCsdx/uP0bHO q9lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Ke/kHSIUtl4EAJQ/hjOQA71nefBPkPlcvo1GhHET9E8=; b=1DHPuxz3NWg5n4wfS6znez7pf+qoaw4rAzwGuPiEyh+SwBP+6xMmybjN+KO9/hRJHU Hzj/9ZNH+/sCdvyZwT4qFCz6KanO5amQeEnmHEzBUKWkX9YrsHqmXJtfOclqlqcb0bpW fAOXWe2x0Thfhwm/KhislQKBfohruB5TZUGZ5ogsDcMp/y8dJUQx7YxCyynJIYZJDtp3 efo/FbmnuZ+14M/dAEOwi+Ys6ZdUcYDsTcT2dDAqCHnNU3wijVVRgnEbqDxP+1pP11ej 5ZMGX8pLM5jmDmERpc/J3uFwRT/3agwXfxNBEBJY+9846x0b8ouX7uF1lrElT8gvUsAx 2Zgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=YE7cv58N; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id w8-20020a631608000000b0043c1908d34asor2298009pgl.67.2022.10.01.01.08.25 for (Google Transport Security); Sat, 01 Oct 2022 01:08:25 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a63:33cf:0:b0:439:f026:aab2 with SMTP id z198-20020a6333cf000000b00439f026aab2mr10713031pgz.86.1664611704758; Sat, 01 Oct 2022 01:08:24 -0700 (PDT) Received: from localhost.localdomain ([2405:201:c00a:a073:7254:4392:bc7c:c69]) by smtp.gmail.com with ESMTPSA id c194-20020a624ecb000000b005409c9d2d41sm3167041pfb.62.2022.10.01.01.08.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Oct 2022 01:08:24 -0700 (PDT) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v6 04/10] drm: bridge: samsung-dsim: Handle proper DSI host initialization Date: Sat, 1 Oct 2022 13:36:44 +0530 Message-Id: <20221001080650.1007043-5-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221001080650.1007043-1-jagan@amarulasolutions.com> References: <20221001080650.1007043-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=YE7cv58N; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , DSI host initialization handling in previous exynos dsi driver has some pitfalls. It initializes the host during host transfer() hook that is indeed not the desired call flow for I2C and any other DSI configured downstream bridges. Host transfer() is usually triggered for downstream DSI panels or bridges and I2C-configured-DSI bridges miss these host initialization as these downstream bridges use bridge operations hooks like pre_enable, and enable in order to initialize or set up the host. This patch is trying to handle the host init handler to satisfy all downstream panels and bridges. Added the DSIM_STATE_REINITIALIZED state flag to ensure that host init is also done on first cmd transfer, this helps existing DSI panels work on exynos platform (form Marek Szyprowski). v6, v5: * none v4: * update init handling to ensure host init done on first cmd transfer v3: * none v2: * check initialized state in samsung_dsim_init v1: * keep DSI init in host transfer Signed-off-by: Marek Szyprowski Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 25 +++++++++++++++++-------- include/drm/bridge/samsung-dsim.h | 5 +++-- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 2ba909ec5239..0636440e4420 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1234,12 +1234,17 @@ static void samsung_dsim_disable_irq(struct samsung_dsim *dsi) disable_irq(dsi->irq); } -static int samsung_dsim_init(struct samsung_dsim *dsi) +static int samsung_dsim_init(struct samsung_dsim *dsi, unsigned int flag) { const struct samsung_dsim_driver_data *driver_data = dsi->driver_data; + if (dsi->state & flag) + return 0; + samsung_dsim_reset(dsi); - samsung_dsim_enable_irq(dsi); + + if (!(dsi->state & DSIM_STATE_INITIALIZED)) + samsung_dsim_enable_irq(dsi); if (driver_data->reg_values[RESET_TYPE] == DSIM_FUNCRST) samsung_dsim_enable_lane(dsi, BIT(dsi->lanes) - 1); @@ -1250,6 +1255,8 @@ static int samsung_dsim_init(struct samsung_dsim *dsi) samsung_dsim_set_phy_ctrl(dsi); samsung_dsim_init_link(dsi); + dsi->state |= flag; + return 0; } @@ -1269,6 +1276,10 @@ static void samsung_dsim_atomic_pre_enable(struct drm_bridge *bridge, } dsi->state |= DSIM_STATE_ENABLED; + + ret = samsung_dsim_init(dsi, DSIM_STATE_INITIALIZED); + if (ret) + return; } static void samsung_dsim_atomic_enable(struct drm_bridge *bridge, @@ -1458,12 +1469,9 @@ static ssize_t samsung_dsim_host_transfer(struct mipi_dsi_host *host, if (!(dsi->state & DSIM_STATE_ENABLED)) return -EINVAL; - if (!(dsi->state & DSIM_STATE_INITIALIZED)) { - ret = samsung_dsim_init(dsi); - if (ret) - return ret; - dsi->state |= DSIM_STATE_INITIALIZED; - } + ret = samsung_dsim_init(dsi, DSIM_STATE_REINITIALIZED); + if (ret) + return ret; ret = mipi_dsi_create_packet(&xfer.packet, msg); if (ret < 0) @@ -1653,6 +1661,7 @@ static int __maybe_unused samsung_dsim_suspend(struct device *dev) if (dsi->state & DSIM_STATE_INITIALIZED) { dsi->state &= ~DSIM_STATE_INITIALIZED; + dsi->state &= ~DSIM_STATE_REINITIALIZED; samsung_dsim_disable_clock(dsi); diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h index b8132bf8e36f..0c5a905f3de7 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -17,8 +17,9 @@ struct samsung_dsim; #define DSIM_STATE_ENABLED BIT(0) #define DSIM_STATE_INITIALIZED BIT(1) -#define DSIM_STATE_CMD_LPM BIT(2) -#define DSIM_STATE_VIDOUT_AVAILABLE BIT(3) +#define DSIM_STATE_REINITIALIZED BIT(2) +#define DSIM_STATE_CMD_LPM BIT(3) +#define DSIM_STATE_VIDOUT_AVAILABLE BIT(4) enum samsung_dsim_type { SAMSUNG_DSIM_TYPE_EXYNOS3250,