From patchwork Sat Oct 1 08:06:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2406 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 9FAC23F06D for ; Sat, 1 Oct 2022 10:08:45 +0200 (CEST) Received: by mail-pf1-f200.google.com with SMTP id k11-20020aa792cb000000b00558674e8e7fsf3977825pfa.6 for ; Sat, 01 Oct 2022 01:08:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1664611724; cv=pass; d=google.com; s=arc-20160816; b=IGd74fGWJG1fJSpqisdI0xDJfjj8CC7FOob3U6laAdaydVF6aIcJZZebovmEl9v1pT qgxqd55idLx2WsB+M9SXzgzEKVySCmoOEpow09wmisi8VxdCGrPgcQzwRXSr5ozRx/QQ EmckcVGzie19vKXHBGtPc7fxOz6wWe9sVUMNN+SOraOnRNWo9hGYa1f3AqN16W5RwE9R S99jyjh2U6ikWX3lmSnp9ZqbDz9xkOrIJzQZVHT8xmvhNF8RCVlJ7zW+6eb5Tx+NuDE6 KaWtDUx97K4/f9IBQhjOqoQOQaCNW3m0hRMZkAKsmU0YSL3wRaphOyvCpYvSZXNho/Vd 99Lg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=VFuv5xLTtB2gx5Q+J6EMBdFh2DOnH1RCblcbvuGlaVA=; b=CQcWQEzD5p1b/FWk+jT35mDtw0seLQss1cF//X4dIseuenAU2cQGnj2fXM4fhHvWjt fh6Qq8Stqf41j8yDg7oiRvfnKzhuvKalpIOQ4HwvHiNDZpOMJ2i7XOp0h2YhY89lSvIn LVDQ5950cbLe4WOvorwzzegZNZ0giIiCfxMgQpKkXZzXjKISc8Wzr9O6RWoVlTPZyOFt x8SfBOzloVdwFW3c+GvbHO8kwMImcsGyWH1MFM/Oz8q3Lp9y9ttMlzqgUImY3vyAF2P2 n9qPQPEvJX6XfdjvCqefuALpE2ShEkbSqQtIz4kBvLGH7i2vX2wKFcOD+2szAIEZ2P11 uycQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=eou1vIfw; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date; bh=VFuv5xLTtB2gx5Q+J6EMBdFh2DOnH1RCblcbvuGlaVA=; b=NiMfaMszhKF5Nw9AHKrM+2P9Rw60QmIia8bFTI9piOV7pPeqaMtYtZ0Y8IwuL+5EEM 7fLnQ/UOIdJFRiCuiIOrbTIRARdo/0LrRANSTiDkLRE9VEDes3MPShlC8xFpifdQ4JpA /8cXRy9tnMxSldFXPIz1RtQBw6L5lZElg9hmk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=VFuv5xLTtB2gx5Q+J6EMBdFh2DOnH1RCblcbvuGlaVA=; b=wwIEag1nAj1HKwD1c3QWP7zR5qBVz2xrAQCvctFeuhYUh5WUwiDgGAeppW6pYVXsA8 vUZkAt20GYDIdDfsqVSqPAAeOKoOWYWXv/nSrNxGa5RxKS9lc+c7QYSKNFoLKMsdxk7h ref1pCJk+7sdoJkMypt7U+4srMLy/TJY2GNOn3d6R2Ocf3A1o1tvLx7cQgehLZAKZ1qQ 6nlybuQ/W+b91RhE2YwpQoV9Tzh2Y7IG5FTY5g2KqTJQTOkZIZpVT1/Ycq0yqJXgaf/4 +RsJrYvP1Rrbi8nOHlCDxeSUCGQCmLCui7RXpfyOfVbJZwrwZ01yu6ql7JMsRjHxKpaq ktWw== X-Gm-Message-State: ACrzQf2FtBZWRwGWNu+v9EmNtd42XCW608YeuKzSgJ+fDakki0U9XTdD Cho2c7vFzK1p4GttPkXFbymRkYwS X-Google-Smtp-Source: AMsMyM4JD2kSGlSJvpFRmb2a2Pq+XzjkoMzNBs3Lx6qObn1jdYCD7MlTBkauE+LJ1qap9n/OXYHTUA== X-Received: by 2002:a17:90b:1d0b:b0:203:c099:107c with SMTP id on11-20020a17090b1d0b00b00203c099107cmr2249166pjb.35.1664611724454; Sat, 01 Oct 2022 01:08:44 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:ce0f:b0:176:9478:2315 with SMTP id k15-20020a170902ce0f00b0017694782315ls5717244plg.9.-pod-prod-gmail; Sat, 01 Oct 2022 01:08:43 -0700 (PDT) X-Received: by 2002:a17:90b:4d0e:b0:1f7:ae99:4d7f with SMTP id mw14-20020a17090b4d0e00b001f7ae994d7fmr2242800pjb.200.1664611723691; Sat, 01 Oct 2022 01:08:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664611723; cv=none; d=google.com; s=arc-20160816; b=ccOWfXGawPAo7FA7i9Z5MV2Zqm1zPYS0PWJ15Zhwrwf70YtJFArPgC8DsOaYb1gxuI eNoDjCDRkig6y8UAcohR8PzRvJQ0Irf72ibhZCfEOtj7qwGkV7QrWCObckAA/0O6dnG+ opgIPCYm9/P6dKFJYKJZNejXLF/kAYYAnhVWcxmyIUiTf21X5qfdhSqewiIpprAvubwQ FmVakRwgHb8ucIy86i7HZRD2tajPbzWQnJr+nS5eCqM4Kw4h+nmDoddtcQtAy4rhdQnE GfIqB2WrHQTYx3+H4STewXMPIMRGN4KI61YIuKTvziJ/yF5cnwuLAj2V77v8l5DF/ooa /Qrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=exCDkdGNSGOnQuwt75tA06xXIS/Hfqspfp6d4Hi7GrE=; b=UXwpgP0+JFqc5SPq/gyulIOk6Uueil5bIG0wvmSkIcysOvAYaLHyvrB0UT3Ha7Kewd nWMZ1mMWqTtXF9/ozn8yHWAJKG/Wx39RAnA5Nyt7aPSLSVC1SYGJNxyIrkqPAsbJN1Bk jZxSM/vJlijyRkaph5caVHWqVmJokecLii7y8BU70FWcZgMTegjJr3OiZ+OMriU2/w0q 1Ip2PhLQ+01dhHTt1GVZoCf5xZAtxl+RWHOB9KYF5IDEZjmtfP50gHnejcfri6u9XupO qfYi5h/wgm9r/GGgaf7DPaz6QGvg6tKwt/2ApBcvK9voiuUEorDFJ+6J+UXJ3HZnkoS8 GrJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=eou1vIfw; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id h14-20020a170902f7ce00b00177ef4bc64asor2167813plw.65.2022.10.01.01.08.43 for (Google Transport Security); Sat, 01 Oct 2022 01:08:43 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:903:2288:b0:179:eb73:b9f5 with SMTP id b8-20020a170903228800b00179eb73b9f5mr12795552plh.163.1664611723397; Sat, 01 Oct 2022 01:08:43 -0700 (PDT) Received: from localhost.localdomain ([2405:201:c00a:a073:7254:4392:bc7c:c69]) by smtp.gmail.com with ESMTPSA id c194-20020a624ecb000000b005409c9d2d41sm3167041pfb.62.2022.10.01.01.08.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Oct 2022 01:08:42 -0700 (PDT) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v6 05/10] drm: bridge: samsung-dsim: Add atomic_check Date: Sat, 1 Oct 2022 13:36:45 +0530 Message-Id: <20221001080650.1007043-6-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221001080650.1007043-1-jagan@amarulasolutions.com> References: <20221001080650.1007043-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=eou1vIfw; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Look like an explicit fixing up of mode_flags is required for DSIM IP present in i.MX8M Mini/Nano SoCs. At least the LCDIF + DSIM needs active low sync polarities in order to correlate the correct sync flags of the surrounding components in the chain to make sure the whole pipeline can work properly. On the other hand the i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020 says. "13.6.3.5.2 RGB interface Vsync, Hsync, and VDEN are active high signals." No clear evidence about whether it can be documentation issues or something, so added a comment FIXME for this and updated the active low sync polarities using SAMSUNG_DSIM_TYPE_IMX8MM hw_type. v6: * none v5: * rebase based new bridge changes [mszyprow] * remove DSIM_QUIRK_FIXUP_SYNC_POL * add hw_type check for sync polarities change. v4: * none v3: * add DSIM_QUIRK_FIXUP_SYNC_POL to handle mode_flasg fixup v2: * none v1: * fix mode flags in atomic_check instead of mode_fixup Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 0636440e4420..90506be3f2dd 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1315,6 +1315,31 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge, pm_runtime_put_sync(dsi->dev); } +static int samsung_dsim_atomic_check(struct drm_bridge *bridge, + struct drm_bridge_state *bridge_state, + struct drm_crtc_state *crtc_state, + struct drm_connector_state *conn_state) +{ + struct samsung_dsim *dsi = bridge_to_dsi(bridge); + struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode; + + if (dsi->plat_data->hw_type & SAMSUNG_DSIM_TYPE_IMX8MM) { + /** + * FIXME: + * At least LCDIF + DSIM needs active low sync, + * but i.MX 8M Mini Applications Processor Reference Manual, + * Rev. 3, 11/2020 says + * + * 13.6.3.5.2 RGB interface + * Vsync, Hsync, and VDEN are active high signals. + */ + adjusted_mode->flags |= (DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC); + adjusted_mode->flags &= ~(DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC); + } + + return 0; +} + static void samsung_dsim_mode_set(struct drm_bridge *bridge, const struct drm_display_mode *mode, const struct drm_display_mode *adjusted_mode) @@ -1353,6 +1378,7 @@ static const struct drm_bridge_funcs samsung_dsim_bridge_funcs = { .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, .atomic_reset = drm_atomic_helper_bridge_reset, + .atomic_check = samsung_dsim_atomic_check, .atomic_pre_enable = samsung_dsim_atomic_pre_enable, .atomic_enable = samsung_dsim_atomic_enable, .atomic_disable = samsung_dsim_atomic_disable,