From patchwork Sat Oct 1 08:06:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2407 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 296383F02F for ; Sat, 1 Oct 2022 10:09:05 +0200 (CEST) Received: by mail-pf1-f199.google.com with SMTP id a3-20020aa795a3000000b0054b94ce7d12sf4014337pfk.17 for ; Sat, 01 Oct 2022 01:09:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1664611744; cv=pass; d=google.com; s=arc-20160816; b=nPMlN0lahHGqvMYb5/g759Idl9XgC1CWBT60XeLT75J1cKoFLWBx36fFQePC1MCBVX 48cbwFvEZpOBy3PADhfa9POE6MVmNBmgRNSGzHuUzHwSQ8QQTzzRFZ4KUnyoPopOJJgp oewLhzwOM1QZ/431OUDL9AVjjJl5MT7s4BfByxnERi2X6D+nBg+olrpnM95d+3dSlfHx 8kYSBGag8g4Z98e6hsboi3KL2/QERDv22knVfrdi+ZkyTSU7hHmnFd5vGm2VrPSeYyLj 58iDkbDoXcYDHLD89PRxGAX5weKqpPIqGUv3l/ksM8DI1wBUn+gpYFYaCzKxrKb9EDR5 1DHw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Z/+WgYB3lxuTl8r2fy0i8M/xFWf1jLrpdUInpIowehc=; b=y01YrgxPuS/oxFxMIEySyXevN/Phn2B/wQZWSn6nmrYbm2TfZ76jqQz1e+A/2uqDZG zj7YrUWPmV16suV8aOIG84i4x+QmCchbfJraGsEMcUyv5/j/LZ01x57POOq36ZwujhRk gDN4tke/Wx+7bnWw2suwGKM5S7Kz9wjp84QjZ45c5fyVaQf7k6YTPkRLg9xJVe6FewG5 KoM081NzPeqzdkqGTjx6IqxCse00A7X2hv58wG/qPC02RMeR4t4zogfipHxg9DNY4FQH 6bA1eFEb3jmOjQeZe5b6IgqWFY41iWWwOTOOBPOLgRKzQkd1VDwM8sTXlJbtrDyhInD2 qV6Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Ok5CPSQ6; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date; bh=Z/+WgYB3lxuTl8r2fy0i8M/xFWf1jLrpdUInpIowehc=; b=n7rgB1g5r0P9J39GelwRgIc5mF7RgDau3y2Nr9bEuP6cdyGzjl6Evk+SASVzMQdWVP JiPYISCwSUcpqEi44DjLhFmbCPtay8Oa6NoxSUKvmOxRRrBTpRcaStBLLfeP8TVveZkt SWWQUVXA+glyDSmty5NYGlye3BX3xY3AW6pzM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=Z/+WgYB3lxuTl8r2fy0i8M/xFWf1jLrpdUInpIowehc=; b=7WFbnhOcvs+Lc1aEbCrjD9m+TbWIHvwso8B+NEv/UjYbE6FIbnn9TOpqJ/SB7+LCq9 lwQUVziXvUTSfuXFh0JzFVDsqafHJBSjhHAICzw8mcFHvG+Vmw2CxDfe6Nb5ZI+jziwT AgNFKYxsVDZgPNBwvzfz5OJtizJRJYE9/g0s2xaMd87BXHqsYmrn4zXLyktogxiTZ9Ai IfveIPIG08jbsPl1CMmB+Qhd0KaxbX0EJWGSfdR/yHDBJWeySCHj4OyqFcbkJFyoQms/ 0Pb9YloItBDXl49dQYtWXB4GRvKQkgexu9lkxM7YoBlgcurxFBXnzmQGxK5gM3U022Z4 e83g== X-Gm-Message-State: ACrzQf1nipWOIl1WjzT3XKQxgeJ/N8t4zqokkI/4zbL7MTSSXTvF3B+X UmoAi0va/5Ms4KKa2PS0II4XqY4s X-Google-Smtp-Source: AMsMyM5Enp1lTdxT5/na3weS8sq8C+jjDaVnVLrzYVT2NYSVq3lY96PtQihColSMNXlB8sDPoz3Zvw== X-Received: by 2002:a17:90b:1e01:b0:202:ee2b:c856 with SMTP id pg1-20020a17090b1e0100b00202ee2bc856mr2245385pjb.29.1664611743915; Sat, 01 Oct 2022 01:09:03 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:903:41d2:b0:16c:2ae8:5b94 with SMTP id u18-20020a17090341d200b0016c2ae85b94ls5759228ple.0.-pod-prod-gmail; Sat, 01 Oct 2022 01:09:03 -0700 (PDT) X-Received: by 2002:a17:902:904c:b0:178:afa2:43f5 with SMTP id w12-20020a170902904c00b00178afa243f5mr13009168plz.78.1664611743071; Sat, 01 Oct 2022 01:09:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664611743; cv=none; d=google.com; s=arc-20160816; b=C870JBEKz7XtoH/CP7LfjNqxpFQSSleB9MCgpKSB4vGh5WGPdhGcfTuZXwJzf70z/e we3+lklRNQAkryfwIiQ3VOutvGNiW9wFnBBuUZem7RIf1tH4JAiolE2x5YAEZYzw2Nsa rbn06TeFj8cOq8RCce0lz5sbkNjXLXgYsV8xw+2fEaq24+MqCCjhS3hon9IhTrEVdOHM QDKrLSUtqF1vOW2Vpd7yhJMfMhzZYK1K8c6/mCF9Kn+zKl7JDJFWwahsZANX3v32MiOC eQ5+OAXxZBrPRZMR6V+fS7rPUnoh1LgAl7GLR1cwXIu8oecHg4vq63wD83pKW+nWTXx+ nPNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=UdRum/NOsNc+q0b9g1DppGoBok9aodOHrcP30aJbUSo=; b=K1JjkY/tLGySSrCNRBzPtBzM/94VbDkM6WL8GpECBIViVp7LIgErd5CZqWy0qLYGpD mljE83sdAcWJDkBIXSDy/aEUdZ1mZuD9SP87OMfSFCF6RF6B/o6JflV3ws3qh5Ndpj37 I+JeED6L2FlQphCYdKV5yxYv7JXTmq8VJY6zWLnJ3EDH+9DICBtIGJVfpGHYSjukrWeN 6voOao2Rgf2QCPY1mb1k6p+p5iop6dFMZ1L6GgZ0855YgUeYZEsgUv01wVmqfLY3OdSp 4Lxs6STJiypJ1ls7UJAwrQkDOIFSyNnW74FZbXQg3M08AeRaApOBkqe8aaSvpAN84qUS Zpcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Ok5CPSQ6; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id mv10-20020a17090b198a00b00202f88fd323sor1860330pjb.2.2022.10.01.01.09.03 for (Google Transport Security); Sat, 01 Oct 2022 01:09:03 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:90a:8044:b0:20a:6412:3b8c with SMTP id e4-20020a17090a804400b0020a64123b8cmr2235484pjw.139.1664611742805; Sat, 01 Oct 2022 01:09:02 -0700 (PDT) Received: from localhost.localdomain ([2405:201:c00a:a073:7254:4392:bc7c:c69]) by smtp.gmail.com with ESMTPSA id c194-20020a624ecb000000b005409c9d2d41sm3167041pfb.62.2022.10.01.01.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Oct 2022 01:09:02 -0700 (PDT) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v6 06/10] drm: bridge: samsung-dsim: Add platform PLL_P (PMS_P) offset Date: Sat, 1 Oct 2022 13:36:46 +0530 Message-Id: <20221001080650.1007043-7-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221001080650.1007043-1-jagan@amarulasolutions.com> References: <20221001080650.1007043-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Ok5CPSQ6; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Look like PLL PMS_P offset value varies between platforms that have Samsung DSIM IP. However, there is no clear evidence for it as both Exynos and i.MX 8M Mini Application Processor Reference Manual is still referring the PMS_P offset as 13. The offset 13 is not working for i.MX8M Mini SoCs but the downstream NXP sec-dsim.c driver is using offset 14 for i.MX8M Mini SoC platforms [1] [2]. PMS_P value set in sec_mipi_dsim_check_pll_out using PLLCTRL_SET_P() with offset 13 and then an additional offset of one bit added in sec_mipi_dsim_config_pll via PLLCTRL_SET_PMS(). Not sure whether it is reference manual documentation or something else but this patch trusts the downstream code and handle PLL_P offset via platform driver data so-that imx8mm driver data shall use pll_p_offset to 14. [1] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/gpu/drm/bridge/sec-dsim.c?h=imx_5.4.47_2.2.0#n210 [2] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/gpu/drm/bridge/sec-dsim.c?h=imx_5.4.47_2.2.0#n211 v6: * none v5: * updated clear commit message v4, v3, v2: * none v1: * updated commit message * add downstream driver link Signed-off-by: Frieder Schrempf Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 10 ++++++++-- include/drm/bridge/samsung-dsim.h | 1 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 90506be3f2dd..d0bb96a275fd 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -168,7 +168,7 @@ /* DSIM_PLLCTRL */ #define DSIM_FREQ_BAND(x) ((x) << 24) #define DSIM_PLL_EN (1 << 23) -#define DSIM_PLL_P(x) ((x) << 13) +#define DSIM_PLL_P(x, offset) ((x) << (offset)) #define DSIM_PLL_M(x) ((x) << 4) #define DSIM_PLL_S(x) ((x) << 1) @@ -368,6 +368,7 @@ static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = { .max_freq = 1000, .wait_for_reset = 1, .num_bits_resol = 11, + .pll_p_offset = 13, .reg_values = reg_values, }; @@ -380,6 +381,7 @@ static const struct samsung_dsim_driver_data exynos4_dsi_driver_data = { .max_freq = 1000, .wait_for_reset = 1, .num_bits_resol = 11, + .pll_p_offset = 13, .reg_values = reg_values, }; @@ -390,6 +392,7 @@ static const struct samsung_dsim_driver_data exynos5_dsi_driver_data = { .max_freq = 1000, .wait_for_reset = 1, .num_bits_resol = 11, + .pll_p_offset = 13, .reg_values = reg_values, }; @@ -401,6 +404,7 @@ static const struct samsung_dsim_driver_data exynos5433_dsi_driver_data = { .max_freq = 1500, .wait_for_reset = 0, .num_bits_resol = 12, + .pll_p_offset = 13, .reg_values = exynos5433_reg_values, }; @@ -412,6 +416,7 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = { .max_freq = 1500, .wait_for_reset = 1, .num_bits_resol = 12, + .pll_p_offset = 13, .reg_values = exynos5422_reg_values, }; @@ -543,7 +548,8 @@ static unsigned long samsung_dsim_set_pll(struct samsung_dsim *dsi, writel(driver_data->reg_values[PLL_TIMER], dsi->reg_base + driver_data->plltmr_reg); - reg = DSIM_PLL_EN | DSIM_PLL_P(p) | DSIM_PLL_M(m) | DSIM_PLL_S(s); + reg = DSIM_PLL_EN | DSIM_PLL_P(p, driver_data->pll_p_offset) | + DSIM_PLL_M(m) | DSIM_PLL_S(s); if (driver_data->has_freqband) { static const unsigned long freq_bands[] = { diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h index 0c5a905f3de7..df3d030daec6 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -53,6 +53,7 @@ struct samsung_dsim_driver_data { unsigned int max_freq; unsigned int wait_for_reset; unsigned int num_bits_resol; + unsigned int pll_p_offset; const unsigned int *reg_values; };