From patchwork Sat Oct 1 08:06:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2411 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id A539C3F02F for ; Sat, 1 Oct 2022 10:10:32 +0200 (CEST) Received: by mail-pf1-f199.google.com with SMTP id u131-20020a627989000000b0054d3cf50780sf4005432pfc.22 for ; Sat, 01 Oct 2022 01:10:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1664611831; cv=pass; d=google.com; s=arc-20160816; b=TgHqBVyxPKU6CIxtk3qimDFVKESPFlAQu478ThTZgGtOgBZjNA+1RKcinsFTplslw/ e1W0JD4Jf2em616UJLO2KNdeiS88iFLUia+QnDPcVtTUBMvPYprq6UKwUFXOAd+oMvh/ /OFbEB0Ru0HGuBjnW0Gp77QIJy7HP7MyyqFJOjqOEMFAdSILdt7CnSjOp+/lbJaOPhW1 pwtQb9P4SgGA0N8/NkHf2TSs6cB3FT53qxAPB4y2FZQbacYyH6Qw+JhzpPhfniBGbcl2 iPfBQwhcR8bzrXsN4xboFaohE52GTk+6x5PDok3kcdLm3tk2sP/JiHP10tB7XJ32wMzl M1lg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=i3eUPYiEyAirlLiJ8MasLk0YLut8uu1StPu0hRU5GSQ=; b=PVAl5c8XCBhTPuc7BUoyLJ+GzxT+7twI4apw/m4FiVnVRjf0BBcojtftJsL9pKLFGV Phd6DNd+Q1z62Egh11PAITkcjyGJatZHLc3Yl2c06BltvRnhxVF7OKE68qUveW2lClwB i/ujcwRZO44kYLWJnC32Aa6bbEmDTNmurvMhWHG7sqNxi1DHf4LmtdwNfHGxcYxB55qM wOv3YwcM32tBgQHGdRCc7FoHHvGx215A/WLvPxPQVVnV/2J6i7qfAHjam8OlCsN/Z+XI rUf/slZXb3Sk9VX0j9gOE/sXhrH/axxzK8YCJZeixinOKAx1u/95z7NzxYljnGnV2HTV iBvw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=rQNF8tS3; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date; bh=i3eUPYiEyAirlLiJ8MasLk0YLut8uu1StPu0hRU5GSQ=; b=ee9GVW3Q3BBT+iz5KiKFoP2Rh8sL+OJFkoGgI8BdKKmsgWFcHUjWFlRj+0RFEj8gbj d0ptxIZa9LX5pgTVyGP7fipYsYeG6nQBjCzvyPeZjKH7DTJeGWES5p9mZazxH7YqoZ5I TqLDeZ/5IAnOll4cc4M3kXzB5a/SLxTazW1bs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=i3eUPYiEyAirlLiJ8MasLk0YLut8uu1StPu0hRU5GSQ=; b=qyETHogfgMTxnaTmY9lr3yTvQ5T2/kKazMPdxMR8WYLLq595Cyu8/dUUPxqGyUAvne N9k4AjCPttdgmXdH2UmyEK47XYwQ0Bfgok8ElTv2ayir+DMKLPTLApKrozNTBeNFEgsk s5ygczbS9Yjmx7s6IXLPiBJmyHBVjuB7mCOOxW4NL8PiWRuA2W6jHarl4kAKRbU7ESRd qWZmIIHJZcH9wdp/l9DJIQV/miY6TDuRY+zxpE34SHDW43bohyMqe96ifnFYn++m2KBZ fuRQ5phr7SGhFHdAdPqZhI/jcrnFaSpryQtwACeC1OGo39Em4uvKQuSnkFG+cBPusYa0 vIRg== X-Gm-Message-State: ACrzQf0i1g3EdQFUC+Pn+KEUbvGoHp7+vw3T3Hvop35IvxW1HDKjjrJK 1pW6gKF1YtNjYYDiN+4b7v/BaSET X-Google-Smtp-Source: AMsMyM7zDIG/YFTyNGn/wShWaISzxVS6KK/IFURVCEvGUjphrbXU35jURdrLs9I7VOvTc1GW+xftZw== X-Received: by 2002:aa7:8687:0:b0:560:3299:a6c0 with SMTP id d7-20020aa78687000000b005603299a6c0mr87945pfo.81.1664611831506; Sat, 01 Oct 2022 01:10:31 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:f081:b0:178:3881:c7e3 with SMTP id p1-20020a170902f08100b001783881c7e3ls5711107pla.11.-pod-prod-gmail; Sat, 01 Oct 2022 01:10:30 -0700 (PDT) X-Received: by 2002:a17:902:76c7:b0:178:ab0a:19af with SMTP id j7-20020a17090276c700b00178ab0a19afmr12584008plt.164.1664611830657; Sat, 01 Oct 2022 01:10:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664611830; cv=none; d=google.com; s=arc-20160816; b=Ix8vBUVG0cAS1pLNNdd1Hp9OFoxjOEGNamSPRXssWShnKAXZLpYEV9fFQ31M6pylk2 Jbh1V5FQh34nkbs5v1pP8wfTLWo+GwHZB0hEDErCXCr0uIGmlSAkgzrb/wPqHNryS3pa jDH2EHDL2iODYSamZeLIkEc1811E32P//BvyGYGUA07imHwzfZWGl75awQZq2YKefxJ9 Mt7VADyZ6OhMsXwoSG4GWq4+Rt1aT2SW5c+7KEbPIjTaNL145MfnmLCZJXeDn4+KHbBY 6bQGD1zbVBMtvs/MHbhe3rf3mZ/Xt2j+ukb++t6ElQAGoD2nxTndcroLmUojvSTwTLum 3cOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=kNa+Zfrt6fq++pnj2gbp7R05J06qVtRoBZLGkH8PcDw=; b=PjOXGqjccN2reD2AlHy7dgjaf+B7TV94acyPC+Slua6rLuJ9g3kaPK70CjRbxsQFgB 52UmpVvSW+7dpUyowyzjRzAfccHq3og0IsHMFNTd2UiQGeQNhRBeS/Tx5392QBFRSMD0 0/RyYAwqBeNo1F8TXYPdIEwg8Lv878E8KBtMm598yIjGgjkT9XHdc0kEL5Lam8tdmRS5 RhB2aK4/iDgIjMphg1lbDG6dEN4hRFnCMryX0rp/BcDfsrQwCiXUGBSaEvTJLMPm2bUc Bp5IoYeUQqShO6FPaQijuWYTjedQLPdzmyh2hVVGdKo/J/8VKPtS6JV8Gk3znri6PZpF 4ViA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=rQNF8tS3; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id g129-20020a625287000000b0053b9ec925efsor2374168pfb.50.2022.10.01.01.10.30 for (Google Transport Security); Sat, 01 Oct 2022 01:10:30 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6a00:cd6:b0:546:d03:3dd7 with SMTP id b22-20020a056a000cd600b005460d033dd7mr12926362pfv.19.1664611830363; Sat, 01 Oct 2022 01:10:30 -0700 (PDT) Received: from localhost.localdomain ([2405:201:c00a:a073:7254:4392:bc7c:c69]) by smtp.gmail.com with ESMTPSA id c194-20020a624ecb000000b005409c9d2d41sm3167041pfb.62.2022.10.01.01.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Oct 2022 01:10:29 -0700 (PDT) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki , Laurent Pinchart Subject: [PATCH v6 10/10] drm: bridge: samsung-dsim: Add i.MX8MM support Date: Sat, 1 Oct 2022 13:36:50 +0530 Message-Id: <20221001080650.1007043-11-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221001080650.1007043-1-jagan@amarulasolutions.com> References: <20221001080650.1007043-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=rQNF8tS3; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Samsung MIPI DSIM master can also be found in i.MX8MM SoC. Add compatible and associated driver_data for it. v6: * none v3: * enable DSIM_QUIRK_FIXUP_SYNC_POL quirk v5: * [mszyprow] rebased and adjusted to the new driver initialization * drop quirk v4: * none v3: * enable DSIM_QUIRK_FIXUP_SYNC_POL quirk v2: * collect Laurent r-b v1: * none Reviewed-by: Laurent Pinchart Signed-off-by: Marek Szyprowski Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 45 +++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 49406a07d655..5f2c51428cdd 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -360,6 +360,24 @@ static const unsigned int exynos5433_reg_values[] = { [PHYTIMING_HS_TRAIL] = DSIM_PHYTIMING2_HS_TRAIL(0x0c), }; +static const unsigned int imx8mm_dsim_reg_values[] = { + [RESET_TYPE] = DSIM_SWRST, + [PLL_TIMER] = 500, + [STOP_STATE_CNT] = 0xf, + [PHYCTRL_ULPS_EXIT] = 0, + [PHYCTRL_VREG_LP] = 0, + [PHYCTRL_SLEW_UP] = 0, + [PHYTIMING_LPX] = DSIM_PHYTIMING_LPX(0x06), + [PHYTIMING_HS_EXIT] = DSIM_PHYTIMING_HS_EXIT(0x0b), + [PHYTIMING_CLK_PREPARE] = DSIM_PHYTIMING1_CLK_PREPARE(0x07), + [PHYTIMING_CLK_ZERO] = DSIM_PHYTIMING1_CLK_ZERO(0x26), + [PHYTIMING_CLK_POST] = DSIM_PHYTIMING1_CLK_POST(0x0d), + [PHYTIMING_CLK_TRAIL] = DSIM_PHYTIMING1_CLK_TRAIL(0x08), + [PHYTIMING_HS_PREPARE] = DSIM_PHYTIMING2_HS_PREPARE(0x08), + [PHYTIMING_HS_ZERO] = DSIM_PHYTIMING2_HS_ZERO(0x0d), + [PHYTIMING_HS_TRAIL] = DSIM_PHYTIMING2_HS_TRAIL(0x0b), +}; + static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = { .reg_ofs = exynos_reg_ofs, .plltmr_reg = 0x50, @@ -421,6 +439,23 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = { .reg_values = exynos5422_reg_values, }; +static const struct samsung_dsim_driver_data imx8mm_dsi_driver_data = { + .reg_ofs = exynos5433_reg_ofs, + .plltmr_reg = 0xa0, + .has_clklane_stop = 1, + .num_clks = 2, + .max_freq = 2100, + .wait_for_reset = 0, + .num_bits_resol = 12, + /** + * FIXME: + * Offset value used from downstream drivers/gpu/drm/bridge/sec-dsim.c + * remove this comment if it is true else update the logic. + */ + .pll_p_offset = 14, + .reg_values = imx8mm_dsim_reg_values, +}; + static const struct samsung_dsim_driver_data * samsung_dsim_types[SAMSUNG_DSIM_TYPE_COUNT] = { [SAMSUNG_DSIM_TYPE_EXYNOS3250] = &exynos3_dsi_driver_data, @@ -428,6 +463,7 @@ samsung_dsim_types[SAMSUNG_DSIM_TYPE_COUNT] = { [SAMSUNG_DSIM_TYPE_EXYNOS5410] = &exynos5_dsi_driver_data, [SAMSUNG_DSIM_TYPE_EXYNOS5422] = &exynos5422_dsi_driver_data, [SAMSUNG_DSIM_TYPE_EXYNOS5433] = &exynos5433_dsi_driver_data, + [SAMSUNG_DSIM_TYPE_IMX8MM] = &imx8mm_dsi_driver_data, }; static inline struct samsung_dsim *host_to_dsi(struct mipi_dsi_host *h) @@ -1788,7 +1824,16 @@ const struct dev_pm_ops samsung_dsim_pm_ops = { }; EXPORT_SYMBOL_GPL(samsung_dsim_pm_ops); +static const struct samsung_dsim_plat_data samsung_dsim_imx8mm_pdata = { + .hw_type = SAMSUNG_DSIM_TYPE_IMX8MM, + .host_ops = &samsung_dsim_generic_host_ops, +}; + static const struct of_device_id samsung_dsim_of_match[] = { + { + .compatible = "fsl,imx8mm-mipi-dsim", + .data = &samsung_dsim_imx8mm_pdata, + }, { /* sentinel. */ } }; MODULE_DEVICE_TABLE(of, samsung_dsim_of_match);