From patchwork Wed Oct 5 15:13:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2421 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id B84D63F1F7 for ; Wed, 5 Oct 2022 17:13:28 +0200 (CEST) Received: by mail-il1-f198.google.com with SMTP id d6-20020a056e02214600b002fa23a188ebsf3877534ilv.6 for ; Wed, 05 Oct 2022 08:13:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1664982807; cv=pass; d=google.com; s=arc-20160816; b=cKzvEMBBSuLgiNIkZgzm8s/W0f1q2JwYKJLrYfrAHEk+JgNoy7uK5YVG4GCcUFhk8W +oRIov2Nz92hBEa61On1ZqQ2GqK8Uij3/j4RXFW07rJlUwCC4IyrUVGzRCF/C1l3s3nY Bk5CYdLH/oD+7G+coUuCkB84+Nw/OEw8D7WxcDSYccFYcrmTG3ilK9lbSLmy8MgneyI2 1WHNHKibuL3YzrCaPI1y53hYWm1DmeaZBdpQOGABSfHH89cjlWqWfbqRyn8CYCR+e3Eh IeBw7LOoy2TSfCEhoNARo3UoV8cgyvx7uwtLtqkbv5gwAenjbTdZT6d7ZlDVuAx4cOhI vmLA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=rnql3Ho8i4p50ktjYswiRtcau6PSPdBiGiWD3A0gWQ4=; b=B+yChvCNldg6d8BpD8GYOSqxoXLTFUktQ/E5kx9/uA5h8M9pgf8YBpo+n3N10R0SRp BfMtjGm5qKJavWKksXwJ+sbe5fzswL14s42C1GzsF9E0mBmJMyh3qYVkvmZl+hsmWNsF eUJGOKMSsVJvUQwkc0Z9ckaFSrgt2CXxZzHtpBq29jp2Jxg+F5grUixe18Hu5jEmzjNI xlw0LyyRnjeZKBqUt4nzMkY+7LoEDu4wkQ09M0x6DGpESbbIW+8Zj1FrrdCLPCwhH4ew vIrvIlGIHSdgR2va8MiPy3ps/y/x+uofCXE3qAspPX6PcF6x1J5gxtKXaUahmrhTYMEP /YGw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="c5/d6Kr0"; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date; bh=rnql3Ho8i4p50ktjYswiRtcau6PSPdBiGiWD3A0gWQ4=; b=n8Sy3cVSI1+zdrZ14M8gjUpo8c8VkqWhUgC6oD1cTfW6K43wAG0nnkdS9yrsff+9pr +pW0oWvOCgutxmJL6JAHTaTN14EXXmbyT7xxaUykCkl6Ut/SBke3KOWQR/i6mGDVrHHX HpmReT3zN3KmNyqLnoW7Ef8g4unUB/Qoc4k5M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=rnql3Ho8i4p50ktjYswiRtcau6PSPdBiGiWD3A0gWQ4=; b=jaTKI0fCeRbI9Z9FOLtCGBwqOHuTJOcLEiJNY7YJudGLz3K7N8r24b6cwt2asU8OeR yu1YjNjINv1WelamSiRLeyiUXG72WKZeLcEHBTcf1QkGk8PBC3cRSx5Z+Hn5OsGyU4hw U1Wf3m9TND4LwdlMft3IsU60fMbQZTtpRfVIOe0WZnNwybeiZDz0tR7ys6FJvo1roNGC wBCc8/iXKO7cgPJCQqtUkUSEgdlxtEA4AHvsnXe4KDfPotk3SSay/iM16a4t6L87z/jm bffxYlcFX5fzaOtLpA6D01s4aUumtU+a76ccQrwgiVxW3YEFAgVnqtTO/MbviPVh2a0T wFnA== X-Gm-Message-State: ACrzQf2/uFx/iW6JhQlnhGVYi8anUueTHfCYSKCQRf/y0+xZEcjkvI5R Wkvd1U3zaow5IXiW2WL+OvYK6DNa X-Google-Smtp-Source: AMsMyM6Us/a6t4iqpsUBxJd6yBnbLNFbYgJcK3vWh4BVE3a7M5wMiCUnHhdshi1LoaHpkPVUoWQckA== X-Received: by 2002:a05:6638:419f:b0:35a:286e:6bdb with SMTP id az31-20020a056638419f00b0035a286e6bdbmr38234jab.295.1664982807673; Wed, 05 Oct 2022 08:13:27 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a02:2a82:0:b0:35a:328c:6cc0 with SMTP id w124-20020a022a82000000b0035a328c6cc0ls4051232jaw.2.-pod-prod-gmail; Wed, 05 Oct 2022 08:13:27 -0700 (PDT) X-Received: by 2002:a05:6638:205:b0:35a:31e:c020 with SMTP id e5-20020a056638020500b0035a031ec020mr50184jaq.111.1664982807091; Wed, 05 Oct 2022 08:13:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664982807; cv=none; d=google.com; s=arc-20160816; b=Nz9IuDtEctZgWBCSFrgoi9NACVO3+DkZztXNTEFvITlZGKy+smh/Ir31SlN//A/BGM s3/tCMUzYW2BrIExnaXv3g0Xoo+VpYWRJNxeF+yYtAxMJLvhTZJrzhnmd01HheMMctCt Xq6m7JgT9wnCEQGbgEMqCVy4UQu3QqRZkQY5wReFCZluMQC3YSFEui33MhagcgjsYhHW B5xek3TtzzHUwewbyKY8u37nHYxGWjtJaGqYrRAHnQVE8SUUCLvUzjGrGHWqtX0bAIzr kTHcfXSzgegyfwrR8JeaKSCYjeAHFgO8RIlEhz+wu5b9RjYhn/dOrSeT9kA9KpO/i3// vBiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=CTE4OyoAPPvHX4/voYrSXggdSk25Ceo5ZBjV7AJSfnQ=; b=gav4MOrMjYmK8K3FdVck7hA00lzZcD48fFXz/UJelij1+WNbe4rVc8Nax+7QITfDHO UaYmPn5pLSMhxG+JThmOa/tIY1fF48yzGFymp0yFfBcSAaQvyX96vo3IBSuhHr7PmMSk P69yNUNS/AYTY3XVCtJw0UsabtXqK92OaO+ol793/92cJQnE2mrBM7sjJNdjEWBPFD7T woe3R8m5Gyv1lYE7zz5jpoPwKjPJVoq5PLAFnyzDRPxhG8BBNuDcBtr9i0HKYTgZHOF/ iBPbKlc9G+ouTAodV3jnbGboJT55KvjNJ3OO5A76L8knJt0uo/JYxZdgvWhaMP01kZc9 IGbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="c5/d6Kr0"; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id o5-20020a02b805000000b0035b3122c3aasor4642530jam.4.2022.10.05.08.13.27 for (Google Transport Security); Wed, 05 Oct 2022 08:13:27 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a02:ccf9:0:b0:356:71fc:26a5 with SMTP id l25-20020a02ccf9000000b0035671fc26a5mr49162jaq.165.1664982806826; Wed, 05 Oct 2022 08:13:26 -0700 (PDT) Received: from j-ThinkPad-E14-Gen-2.stthomas.edu ([140.209.96.21]) by smtp.gmail.com with ESMTPSA id w15-20020a056602034f00b0068a235db030sm7089276iou.27.2022.10.05.08.13.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 08:13:26 -0700 (PDT) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v7 04/10] drm: bridge: samsung-dsim: Handle proper DSI host initialization Date: Wed, 5 Oct 2022 20:43:03 +0530 Message-Id: <20221005151309.7278-5-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221005151309.7278-1-jagan@amarulasolutions.com> References: <20221005151309.7278-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="c5/d6Kr0"; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , DSI host initialization handling in previous exynos dsi driver has some pitfalls. It initializes the host during host transfer() hook that is indeed not the desired call flow for I2C and any other DSI configured downstream bridges. Host transfer() is usually triggered for downstream DSI panels or bridges and I2C-configured-DSI bridges miss these host initialization as these downstream bridges use bridge operations hooks like pre_enable, and enable in order to initialize or set up the host. This patch is trying to handle the host init handler to satisfy all downstream panels and bridges. Added the DSIM_STATE_REINITIALIZED state flag to ensure that host init is also done on first cmd transfer, this helps existing DSI panels work on exynos platform (form Marek Szyprowski). v7, v6, v5: * none v4: * update init handling to ensure host init done on first cmd transfer v3: * none v2: * check initialized state in samsung_dsim_init v1: * keep DSI init in host transfer Signed-off-by: Marek Szyprowski Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 25 +++++++++++++++++-------- include/drm/bridge/samsung-dsim.h | 5 +++-- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 1bae3673151b..563781bb27c4 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1234,12 +1234,17 @@ static void samsung_dsim_disable_irq(struct samsung_dsim *dsi) disable_irq(dsi->irq); } -static int samsung_dsim_init(struct samsung_dsim *dsi) +static int samsung_dsim_init(struct samsung_dsim *dsi, unsigned int flag) { const struct samsung_dsim_driver_data *driver_data = dsi->driver_data; + if (dsi->state & flag) + return 0; + samsung_dsim_reset(dsi); - samsung_dsim_enable_irq(dsi); + + if (!(dsi->state & DSIM_STATE_INITIALIZED)) + samsung_dsim_enable_irq(dsi); if (driver_data->reg_values[RESET_TYPE] == DSIM_FUNCRST) samsung_dsim_enable_lane(dsi, BIT(dsi->lanes) - 1); @@ -1250,6 +1255,8 @@ static int samsung_dsim_init(struct samsung_dsim *dsi) samsung_dsim_set_phy_ctrl(dsi); samsung_dsim_init_link(dsi); + dsi->state |= flag; + return 0; } @@ -1269,6 +1276,10 @@ static void samsung_dsim_atomic_pre_enable(struct drm_bridge *bridge, } dsi->state |= DSIM_STATE_ENABLED; + + ret = samsung_dsim_init(dsi, DSIM_STATE_INITIALIZED); + if (ret) + return; } static void samsung_dsim_atomic_enable(struct drm_bridge *bridge, @@ -1458,12 +1469,9 @@ static ssize_t samsung_dsim_host_transfer(struct mipi_dsi_host *host, if (!(dsi->state & DSIM_STATE_ENABLED)) return -EINVAL; - if (!(dsi->state & DSIM_STATE_INITIALIZED)) { - ret = samsung_dsim_init(dsi); - if (ret) - return ret; - dsi->state |= DSIM_STATE_INITIALIZED; - } + ret = samsung_dsim_init(dsi, DSIM_STATE_REINITIALIZED); + if (ret) + return ret; ret = mipi_dsi_create_packet(&xfer.packet, msg); if (ret < 0) @@ -1653,6 +1661,7 @@ static int __maybe_unused samsung_dsim_suspend(struct device *dev) if (dsi->state & DSIM_STATE_INITIALIZED) { dsi->state &= ~DSIM_STATE_INITIALIZED; + dsi->state &= ~DSIM_STATE_REINITIALIZED; samsung_dsim_disable_clock(dsi); diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h index b8132bf8e36f..0c5a905f3de7 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -17,8 +17,9 @@ struct samsung_dsim; #define DSIM_STATE_ENABLED BIT(0) #define DSIM_STATE_INITIALIZED BIT(1) -#define DSIM_STATE_CMD_LPM BIT(2) -#define DSIM_STATE_VIDOUT_AVAILABLE BIT(3) +#define DSIM_STATE_REINITIALIZED BIT(2) +#define DSIM_STATE_CMD_LPM BIT(3) +#define DSIM_STATE_VIDOUT_AVAILABLE BIT(4) enum samsung_dsim_type { SAMSUNG_DSIM_TYPE_EXYNOS3250,