From patchwork Wed Oct 5 15:13:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2423 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 4AF543F1F7 for ; Wed, 5 Oct 2022 17:13:32 +0200 (CEST) Received: by mail-il1-f198.google.com with SMTP id g10-20020a056e021e0a00b002f9db676704sf6844821ila.14 for ; Wed, 05 Oct 2022 08:13:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1664982811; cv=pass; d=google.com; s=arc-20160816; b=T0lqHwaClc6uh2Sk3u00HmAhsMN6osXfdyfDYiUIYKfxqKD5NaaaqmA4QpDDTWIofu u5nB9Wlmn4JwYuQH59b/g1Fd1P3BlJf9qXjILu4nD/Q2wXZGOBKaVvjwrN8IJOGCDJnK Y3YdKoqoH+ijfI8OEPMfEDP+PwMt+SHAXF34XCC3TJn5WYEKonO7fs8ZSaFN/l7w6sKB RM77v3WbLEHzdBACDPkP2WjEWxth634qo0k3beRWCrFUXi0oL3STpemBdaUCLU/DSlgz HS1FUt2ckMyqX6TTc52lSmXhdK2cODv9QjPZ+ZgBldFaiqO0D6YNPeuCXlwlefTVsDS0 g8sQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=E2LDYUqHNdFCRhNtZukUk23TLFrDyFVSYDjd1eOQ0sk=; b=a+14xg6IA2Pkz0NWP6WiiuHHBV+n4TvdaqkGrt6RK7c+qSjS8/keTSy61jtKlUlgeh 3IbeTvC037JLkbEZEDsxvRel4+xbolYkTHJhA+PyafvR0flPc/D2poTEobDFAS2v4a+W qjRXb+NMqnERGYrIWf8J+G8CRwGQ8ofpc28hAHZY5SYxNld+kWdDdBdUbHv5X9Kt0uww rhQNXfbahIMuYE2RIEVLy1f5YrkrPGO1qNCn55MScZqEgxTH/r7j7ItHlK1dKRWbhvUs Xa+Dquz83E60qFGF9eBO2WP7F83ndhxeSlLxXxZ/ecwHLSvcyJHRY4+TYBWW3ryUTSzA 6h/w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=B3IfNLsv; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date; bh=E2LDYUqHNdFCRhNtZukUk23TLFrDyFVSYDjd1eOQ0sk=; b=ryo8bIZgPR/b3MDcTDU/+NFRUvWFiu7V3z1gm76cp/91hciP/BhIPR08Su+U3gWH3i YjNeLkbHvoyGF3b/i5kr4f3XXxrTjewEffhk6fzToW2rifmix4/87ns2r2gwxbWAAf8/ rNvRDkiz2iQSK3qzOckSbq5iphPcDFjwZQNb0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=E2LDYUqHNdFCRhNtZukUk23TLFrDyFVSYDjd1eOQ0sk=; b=yIUNkJKzAc9mr898umXcFIogs3l8OiQpGpbvMqZSPsdHupA3nuV5DM7UIGRyY3bDzj QznnEYOnlSoTIvwj6dczjm88oC94lLF60VIP0t9e/GufYZQVBLkBDES5LYtlDc2Db1Nh ZKwsCWihO/Q6+i2wDjuISdok84H51Z1/WYrEv/H7ZPDHgA5Lc62fkQGKEGXkWoyofDuW 3V0ced0CkL+5x8vgQZ8RAUu3CO1mu7VSevfW/OmDlAxRcbVpMTef1WY6XMQBoQTkD3UF /46bfSSJjDMkp9EF8UtLm/Q6zf822bL2lu2z33hvlPqwIV2XzTeHJ5qjdpNwujvq6Mu2 yXMQ== X-Gm-Message-State: ACrzQf347ydKuYcvvQbygxGozcsgpfOe+jWdG3Cl1c0kNueFTrDpTi3k wvnDoPn3oypR02JINBnT88b6D6ea X-Google-Smtp-Source: AMsMyM7J0egcRmBDscVjzOuXBVngbdmG1RVMr7JA6lg4fphZTubZOaxOfMT2Q1S5E3rkcC/7JHPyWw== X-Received: by 2002:a05:6e02:20c9:b0:2f8:13b3:9dc with SMTP id 9-20020a056e0220c900b002f813b309dcmr49803ilq.303.1664982811302; Wed, 05 Oct 2022 08:13:31 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a02:7a5d:0:b0:363:3846:dfb9 with SMTP id z29-20020a027a5d000000b003633846dfb9ls1962905jad.11.-pod-prod-gmail; Wed, 05 Oct 2022 08:13:30 -0700 (PDT) X-Received: by 2002:a02:8804:0:b0:35b:7425:82af with SMTP id r4-20020a028804000000b0035b742582afmr52502jai.21.1664982810714; Wed, 05 Oct 2022 08:13:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664982810; cv=none; d=google.com; s=arc-20160816; b=IgHSwXg5+Hi12xEe/Zp3cLU5DeB5h0/CrCEtD9rrGAHu7pbSLuRXTGv7mMIUrnmMXM vc2isurahXl4z44PQKSWSGne0DDYrakdZCsA6Fd4ohXlzfpSvm6dZrxWd4OrvomwyUfx Vo+j6PpvxgZIgxyQ5PmGQFY3AGbASuG0lRvPt49NVq/NzoEoAEY1HojuNQr8csue2Adp NsjLZZtp2KA2gZD7HgCE4JyxAQAl/+M+7TTIKBME/dbmLDCypWvcN5dqdixKVC0mgDuN b4i13jRuN0ilWyJTbjqBrMYHdB7/aRblEYkvH+1mxhvpjgjXL7SqP20nK5Ucca20xdd/ aPZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=YFWE05cUP5gYPfL1GvHSDjJECfaamqkGSDdNhylsilI=; b=LodM54x/qpsNNlneI5H5yFhkFK+e+O1vrymsz1UKF7QkeJfslnvsFnfrDVef2S9uuT c5p1tK/e2lH7N8i6YvaCTv8mowxB4emjUsN9CO3vT4qwsSJbz1GPl+qNHOFXMEQRvclT G8vd33PN98tuoI5Cq9Hx7Jlix4T9kHmu6kjfWrJB2O1rOa1EMBrXs7b2l6z/HQTT+qFf apmxUrbtUeE+gXKHKYcFw4+N6MtJcAk7FUar3ECo8g3Uz+5ICnD/Dy4GmEhbbnwtQlvb ly2hmm+BIsEytF7qBwx42wPtFAOqFesGnsCIE4TcmiDkV/DJIv+8ktnfKzuPC/IACLET QiTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=B3IfNLsv; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id w6-20020a5d8446000000b0066938348797sor3594573ior.40.2022.10.05.08.13.30 for (Google Transport Security); Wed, 05 Oct 2022 08:13:30 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6602:121c:b0:6a5:1f4:4ab with SMTP id y28-20020a056602121c00b006a501f404abmr147259iot.187.1664982810375; Wed, 05 Oct 2022 08:13:30 -0700 (PDT) Received: from j-ThinkPad-E14-Gen-2.stthomas.edu ([140.209.96.21]) by smtp.gmail.com with ESMTPSA id w15-20020a056602034f00b0068a235db030sm7089276iou.27.2022.10.05.08.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 08:13:29 -0700 (PDT) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v7 06/10] drm: bridge: samsung-dsim: Add platform PLL_P (PMS_P) offset Date: Wed, 5 Oct 2022 20:43:05 +0530 Message-Id: <20221005151309.7278-7-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221005151309.7278-1-jagan@amarulasolutions.com> References: <20221005151309.7278-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=B3IfNLsv; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Look like PLL PMS_P offset value varies between platforms that have Samsung DSIM IP. However, there is no clear evidence for it as both Exynos and i.MX 8M Mini Application Processor Reference Manual is still referring the PMS_P offset as 13. The offset 13 is not working for i.MX8M Mini SoCs but the downstream NXP sec-dsim.c driver is using offset 14 for i.MX8M Mini SoC platforms [1] [2]. PMS_P value set in sec_mipi_dsim_check_pll_out using PLLCTRL_SET_P() with offset 13 and then an additional offset of one bit added in sec_mipi_dsim_config_pll via PLLCTRL_SET_PMS(). Not sure whether it is reference manual documentation or something else but this patch trusts the downstream code and handle PLL_P offset via platform driver data so-that imx8mm driver data shall use pll_p_offset to 14. [1] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/gpu/drm/bridge/sec-dsim.c?h=imx_5.4.47_2.2.0#n210 [2] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/gpu/drm/bridge/sec-dsim.c?h=imx_5.4.47_2.2.0#n211 v7, v6: * none v5: * updated clear commit message v4, v3, v2: * none v1: * updated commit message * add downstream driver link Signed-off-by: Frieder Schrempf Signed-off-by: Jagan Teki Reviewed-by: Marek Vasut --- drivers/gpu/drm/bridge/samsung-dsim.c | 10 ++++++++-- include/drm/bridge/samsung-dsim.h | 1 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index b46346232c52..41970e794a7c 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -168,7 +168,7 @@ /* DSIM_PLLCTRL */ #define DSIM_FREQ_BAND(x) ((x) << 24) #define DSIM_PLL_EN (1 << 23) -#define DSIM_PLL_P(x) ((x) << 13) +#define DSIM_PLL_P(x, offset) ((x) << (offset)) #define DSIM_PLL_M(x) ((x) << 4) #define DSIM_PLL_S(x) ((x) << 1) @@ -368,6 +368,7 @@ static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = { .max_freq = 1000, .wait_for_reset = 1, .num_bits_resol = 11, + .pll_p_offset = 13, .reg_values = reg_values, }; @@ -380,6 +381,7 @@ static const struct samsung_dsim_driver_data exynos4_dsi_driver_data = { .max_freq = 1000, .wait_for_reset = 1, .num_bits_resol = 11, + .pll_p_offset = 13, .reg_values = reg_values, }; @@ -390,6 +392,7 @@ static const struct samsung_dsim_driver_data exynos5_dsi_driver_data = { .max_freq = 1000, .wait_for_reset = 1, .num_bits_resol = 11, + .pll_p_offset = 13, .reg_values = reg_values, }; @@ -401,6 +404,7 @@ static const struct samsung_dsim_driver_data exynos5433_dsi_driver_data = { .max_freq = 1500, .wait_for_reset = 0, .num_bits_resol = 12, + .pll_p_offset = 13, .reg_values = exynos5433_reg_values, }; @@ -412,6 +416,7 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = { .max_freq = 1500, .wait_for_reset = 1, .num_bits_resol = 12, + .pll_p_offset = 13, .reg_values = exynos5422_reg_values, }; @@ -543,7 +548,8 @@ static unsigned long samsung_dsim_set_pll(struct samsung_dsim *dsi, writel(driver_data->reg_values[PLL_TIMER], dsi->reg_base + driver_data->plltmr_reg); - reg = DSIM_PLL_EN | DSIM_PLL_P(p) | DSIM_PLL_M(m) | DSIM_PLL_S(s); + reg = DSIM_PLL_EN | DSIM_PLL_P(p, driver_data->pll_p_offset) | + DSIM_PLL_M(m) | DSIM_PLL_S(s); if (driver_data->has_freqband) { static const unsigned long freq_bands[] = { diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h index 0c5a905f3de7..df3d030daec6 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -53,6 +53,7 @@ struct samsung_dsim_driver_data { unsigned int max_freq; unsigned int wait_for_reset; unsigned int num_bits_resol; + unsigned int pll_p_offset; const unsigned int *reg_values; };