From patchwork Wed Oct 5 15:13:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2427 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id F3C533F1F7 for ; Wed, 5 Oct 2022 17:13:39 +0200 (CEST) Received: by mail-io1-f71.google.com with SMTP id e19-20020a6b5013000000b006b3d18586c7sf2568406iob.12 for ; Wed, 05 Oct 2022 08:13:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1664982819; cv=pass; d=google.com; s=arc-20160816; b=A0ndr4wnBD5NtH2Fv4o1hrkuapnrHx2OCPrM4RBt++btOK2UHLYjkjU6+rxNGOiOrJ ncqlp8jD+rLaUgahsv7FITVCMJivhjTr0OyAALugd5m01pOzOhqiLUP5YJZhLn4gl6MR xrLNuJT8AI7HCiPpGsbPNP/tmDyMAS0U0PJFCaSd1dVBhiJeZSvTbp6Uu1VyMF93FK0w sHNvKNpxic7D8DVbhb3IquldVrxdluVo9VtHbjSmQdnscyClBt1iaF/XVZpFTzfJsQ/O NpzNT/b9C7yuZnm4gnAnse22lA183DUIQhog7JpPDYJtezmOOMDPsMFTTf2GEuPU4LTX kC5Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Yw+xBEm6aTAu75gbVUvw2PoVxqffaErP+31PjMjJajw=; b=0SMdjO5ITdr3NSF1lQpWx+CjjhwVS0EApTDkx2Cx2KY+TWMGt6plCN8QnLbEsNEZzq p/2pz9dO6FSdmSaZn9pjCNF7C3N+kIJfr3hi/r/Qjxx0TULmUXw58I6XqM8bPgZ5rREh a85QDdl7mFHCNThsp02KF6E11z/fPciqPFpZM0iFCQ/XWZlcqY0M52aTd59GfTAjOH8/ An4BE0NLFga9SjW76cwg7fx1qmIDqVZ1l3ZInsPtj6vycKVG73lILWGhogHN+kc3EhkV XhR1OJ8n3O6cFxIQbE04q9CTXe1SO/22hzMorgZtzrmhfPhkBSINFr1IgbrD/ALuMGsj NTDg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=lxNqiUpW; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date; bh=Yw+xBEm6aTAu75gbVUvw2PoVxqffaErP+31PjMjJajw=; b=Gmyyg3MaWd9DjXx1AXz9AOD3rAmJyWKebTf59Quufr57eupZc3EK+1B0wZcb8R9prn T8LOiqiA9UopiivgQLT/xUob4pCNf/fL9ME4iNeWdZI9WcWI14ka1s6j6SBBdGH700yM tv7b2/Qmrv8alMvcbSpUC8iGCBOf1o6Y+Acfg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=Yw+xBEm6aTAu75gbVUvw2PoVxqffaErP+31PjMjJajw=; b=2QQ6dmUGnuETSD1gCdQ7u64y6yELbSbwG5xIpfmovqj9dPSC3L5dj3TT7SqhGDfGX/ k6lPNdL0fIHj6XU90FaGqwt+wMOTn7v9Agu01TftYXeb53+YkT6poa5ZOHvaTO0+fAXZ zYAuQvBdi7zteu9OF4bk28YsN1BQY34hdZohZXI7n9oJuATPOHuIC7etarzgyIWNeq4G UihirXnCSS3ehFzhIwJi1l9YSgSNgD/WpwPSM2ls7Nh80TFMxC0IZ3PQgdPd5tfEn2DC FnnTrry8H4Lrd2sy/yTeijdYMEzWUeieGh3vq0esTdveUGtZJuSD5/MzIZxOXNOuVjHf g7kw== X-Gm-Message-State: ACrzQf00vE2DXFLa6vyIlz8JjLdRQ6GohvpDtLlXrgxx2ik6b2TOlFV3 hLf2jZGLygd/AoBYWnV4KE3E2u7j X-Google-Smtp-Source: AMsMyM6zuP1ujKuSoXtDL3B55yU3JKjQOaA6nLv0aOYyEgbw+uWxfsQiUXiLsBluYr32zxPmTvdn0g== X-Received: by 2002:a05:6e02:2145:b0:2f4:8c94:dcbc with SMTP id d5-20020a056e02214500b002f48c94dcbcmr54860ilv.161.1664982818952; Wed, 05 Oct 2022 08:13:38 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a02:7a5d:0:b0:363:3846:dfb9 with SMTP id z29-20020a027a5d000000b003633846dfb9ls1962964jad.11.-pod-prod-gmail; Wed, 05 Oct 2022 08:13:38 -0700 (PDT) X-Received: by 2002:a05:6638:258e:b0:35a:28cb:773b with SMTP id s14-20020a056638258e00b0035a28cb773bmr60387jat.260.1664982818413; Wed, 05 Oct 2022 08:13:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664982818; cv=none; d=google.com; s=arc-20160816; b=0FRvSpW0XEl4g1lPqiZMj3MzYles0z7AeuIm2jPxxp93NiBDRJWTImxQyV1ChvSOp7 lHifoeB6FvEE+BeuBxkIIa8HpTOmM/7yfbV7tzAlqHYh3mpmKqDa2DZYVCF4zAMOhIja VmJI7ZPKdptc0KQ3neGOZZNXWdLzS6JgAeoymH3FFU+G0fQHCsgBvv4t/CkJLgovTsCG bapjL8xlwozPIf4YIIgE7iSyVVzqLGU1FD184AS0rl7mrU4+YV+n1fVyWXAkb7LbMUlx crfN2tdlOZk26Cx89uVSpSWpGlSn0VppVHMU6ubCYRc316Zc052jDxjd5SqNSBGTNm8O 10Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=preYEoQg0LX6lD/WAOwpnKfSNDR1YFRVxD4DlRUGkd4=; b=H2nLNjj9B+F8uo8026abjhqc13D4I/Uw2pM8p6PcKtzV5kqOsx7BzKNPOKnMQ56lz1 /sQI4e3pSQr1kVvnc0cpPEpk+TCIZmtlnLObbK/QLMLkzjlpIxR/Sq32p6jwJxTxpMnv 2gCwnJ8T/xfsFbGkPArIS4lxWSV6ym/Nx10pFqLgKYabHHqIT0cL8KPkiAdCXn5/MEhE UpeGWu0+delvGG9Yx5R+1uPATJJB78m4UHEgotlRQ0VMQep2/PlpM+nJi8z47mbZmLnr w5DAEdhQ5fVrKJnld0ANcktA8bljzFMw1NG9y6wGPW2QdqqcS65JmF87zWzh19R5Fad+ BzxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=lxNqiUpW; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id z6-20020a926506000000b002fa7d712c70sor15201ilb.58.2022.10.05.08.13.38 for (Google Transport Security); Wed, 05 Oct 2022 08:13:38 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6e02:1c86:b0:2f9:7dc5:4037 with SMTP id w6-20020a056e021c8600b002f97dc54037mr72663ill.2.1664982818128; Wed, 05 Oct 2022 08:13:38 -0700 (PDT) Received: from j-ThinkPad-E14-Gen-2.stthomas.edu ([140.209.96.21]) by smtp.gmail.com with ESMTPSA id w15-20020a056602034f00b0068a235db030sm7089276iou.27.2022.10.05.08.13.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 08:13:37 -0700 (PDT) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki , Laurent Pinchart Subject: [PATCH v7 10/10] drm: bridge: samsung-dsim: Add i.MX8MM support Date: Wed, 5 Oct 2022 20:43:09 +0530 Message-Id: <20221005151309.7278-11-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221005151309.7278-1-jagan@amarulasolutions.com> References: <20221005151309.7278-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=lxNqiUpW; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Samsung MIPI DSIM master can also be found in i.MX8MM SoC. Add compatible and associated driver_data for it. v7, v6: * none v3: * enable DSIM_QUIRK_FIXUP_SYNC_POL quirk v5: * [mszyprow] rebased and adjusted to the new driver initialization * drop quirk v4: * none v3: * enable DSIM_QUIRK_FIXUP_SYNC_POL quirk v2: * collect Laurent r-b v1: * none Reviewed-by: Laurent Pinchart Signed-off-by: Marek Szyprowski Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 45 +++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index f5cd80641cea..1b5ba33dc635 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -360,6 +360,24 @@ static const unsigned int exynos5433_reg_values[] = { [PHYTIMING_HS_TRAIL] = DSIM_PHYTIMING2_HS_TRAIL(0x0c), }; +static const unsigned int imx8mm_dsim_reg_values[] = { + [RESET_TYPE] = DSIM_SWRST, + [PLL_TIMER] = 500, + [STOP_STATE_CNT] = 0xf, + [PHYCTRL_ULPS_EXIT] = 0, + [PHYCTRL_VREG_LP] = 0, + [PHYCTRL_SLEW_UP] = 0, + [PHYTIMING_LPX] = DSIM_PHYTIMING_LPX(0x06), + [PHYTIMING_HS_EXIT] = DSIM_PHYTIMING_HS_EXIT(0x0b), + [PHYTIMING_CLK_PREPARE] = DSIM_PHYTIMING1_CLK_PREPARE(0x07), + [PHYTIMING_CLK_ZERO] = DSIM_PHYTIMING1_CLK_ZERO(0x26), + [PHYTIMING_CLK_POST] = DSIM_PHYTIMING1_CLK_POST(0x0d), + [PHYTIMING_CLK_TRAIL] = DSIM_PHYTIMING1_CLK_TRAIL(0x08), + [PHYTIMING_HS_PREPARE] = DSIM_PHYTIMING2_HS_PREPARE(0x08), + [PHYTIMING_HS_ZERO] = DSIM_PHYTIMING2_HS_ZERO(0x0d), + [PHYTIMING_HS_TRAIL] = DSIM_PHYTIMING2_HS_TRAIL(0x0b), +}; + static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = { .reg_ofs = exynos_reg_ofs, .plltmr_reg = 0x50, @@ -421,6 +439,23 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = { .reg_values = exynos5422_reg_values, }; +static const struct samsung_dsim_driver_data imx8mm_dsi_driver_data = { + .reg_ofs = exynos5433_reg_ofs, + .plltmr_reg = 0xa0, + .has_clklane_stop = 1, + .num_clks = 2, + .max_freq = 2100, + .wait_for_reset = 0, + .num_bits_resol = 12, + /** + * FIXME: + * Offset value used from downstream drivers/gpu/drm/bridge/sec-dsim.c + * remove this comment if it is true else update the logic. + */ + .pll_p_offset = 14, + .reg_values = imx8mm_dsim_reg_values, +}; + static const struct samsung_dsim_driver_data * samsung_dsim_types[SAMSUNG_DSIM_TYPE_COUNT] = { [SAMSUNG_DSIM_TYPE_EXYNOS3250] = &exynos3_dsi_driver_data, @@ -428,6 +463,7 @@ samsung_dsim_types[SAMSUNG_DSIM_TYPE_COUNT] = { [SAMSUNG_DSIM_TYPE_EXYNOS5410] = &exynos5_dsi_driver_data, [SAMSUNG_DSIM_TYPE_EXYNOS5422] = &exynos5422_dsi_driver_data, [SAMSUNG_DSIM_TYPE_EXYNOS5433] = &exynos5433_dsi_driver_data, + [SAMSUNG_DSIM_TYPE_IMX8MM] = &imx8mm_dsi_driver_data, }; static inline struct samsung_dsim *host_to_dsi(struct mipi_dsi_host *h) @@ -1788,7 +1824,16 @@ const struct dev_pm_ops samsung_dsim_pm_ops = { }; EXPORT_SYMBOL_GPL(samsung_dsim_pm_ops); +static const struct samsung_dsim_plat_data samsung_dsim_imx8mm_pdata = { + .hw_type = SAMSUNG_DSIM_TYPE_IMX8MM, + .host_ops = &samsung_dsim_generic_host_ops, +}; + static const struct of_device_id samsung_dsim_of_match[] = { + { + .compatible = "fsl,imx8mm-mipi-dsim", + .data = &samsung_dsim_imx8mm_pdata, + }, { /* sentinel. */ } }; MODULE_DEVICE_TABLE(of, samsung_dsim_of_match);